)]}'
{"id":"openstack%2Fpython-openstackclient~901022","triplet_id":"openstack%2Fpython-openstackclient~master~I9e78b35ad9d016d7a33655141ec579397c5344c0","project":"openstack/python-openstackclient","branch":"master","topic":"argumenterror","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-12-05 17:21:08.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"I9e78b35ad9d016d7a33655141ec579397c5344c0","subject":"parseactions: Use ArgumentError, not ArgumentTypeError","status":"MERGED","created":"2023-11-15 11:33:49.000000000","updated":"2023-12-05 18:44:12.000000000","submitted":"2023-12-05 18:42:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"901022-argumenterror","meta_rev_id":"171c58eb45ebea2de7a364f09745517d1bc90767","_number":901022,"virtual_id_number":901022,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-12-05 18:42:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2023-11-15 14:58:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2023-12-05 17:21:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-15 12:35:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-15 14:58:40.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"}],"messages":[{"id":"ade77024e4a0b48ff4fb667f290a02ea9e3a8213","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-11-15 11:33:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c41cf36dd5939a6106fdcc72ee33b985b6010bc4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-15 12:35:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dc54f049466d49ac9c4890fa18bdb5c4\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/5d54f82dce34457b8dad2109def99723 : SUCCESS in 4m 49s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/44d2e6b071414c4090f280660dde99de : SUCCESS in 4m 46s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/c7dff93cf1404443a85138e73f34f46d : SUCCESS in 4m 37s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ef9ee36e77304471ae8c8e40e931a2a2 : SUCCESS in 5m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/23573bb3bceb43f9b5b907e127452508 : SUCCESS in 3m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3324ad3c54124807ad6006e27731ea26 : SUCCESS in 3m 40s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2ae751c5d4a143b889b40b2b49f130b9 : SUCCESS in 3m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c779a3f36d24e8c9fed276e21b8cb0d : SUCCESS in 6m 39s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/2f300d84b67e46858c8085f10deffe08 : SUCCESS in 8m 58s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/575c481ecc944756a8f26efdc4b66ddf : SUCCESS in 59m 27s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/814733f3727e4b178f5a1d91cb3c46cc : SUCCESS in 53m 36s","accounts_in_message":[],"_revision_number":1},{"id":"dd235d064e0eb21a0fc017dd4707cc0909b1e6c0","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2023-11-15 14:58:40.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"21afa4558f68cc6a36c30df9fd03128a7e5f4102","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-12-05 17:21:08.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4dbf47230dc2c42cdc84e381eaf488da05c81151","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 17:21:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"97fcd7cd951e56bed7212144f35e9ec48ca5df3b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 18:42:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c07ca0285f2641f1aecc9b349f0de08d\n\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/00974bbf1d204eca98645e328f53fc1c : SUCCESS in 4m 40s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/1a6536357a8e4195885dd45804454491 : SUCCESS in 5m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e279b3f45a71478a8dd7e2b45f98d3fa : SUCCESS in 4m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/83268ae9447d4de99abd7dff2eec08b2 : SUCCESS in 4m 30s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8dc2beae38a74e4aa8fe58df5ae1b78b : SUCCESS in 3m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/438aa63ea06b4663bb336c218ac942be : SUCCESS in 6m 44s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/abe14b8571164fddaa04a2773f240736 : SUCCESS in 6m 35s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/a7339dad8dcc41608ae867561a5bd477 : SUCCESS in 1h 15m 44s","accounts_in_message":[],"_revision_number":1},{"id":"bb517e682db77aba3da785e9f6246ac78f500e51","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 18:42:59.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"171c58eb45ebea2de7a364f09745517d1bc90767","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-05 18:44:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/38706f10159e4c91b7ef7dba39eb6996\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39e7dddb0c20429bad7160fa2b4c58f4 : SUCCESS in 47s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/2e4bb7be9f1f43f78765a6bb5e2e8ca7 : SUCCESS in 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c08d6e0391c2e435f2e98918116b968104846327","revisions":{"c08d6e0391c2e435f2e98918116b968104846327":{"kind":"REWORK","_number":1,"created":"2023-11-15 11:33:49.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/22/901022/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/901022/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/901022/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/901022/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/901022/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/901022/1"}}},"commit":{"parents":[{"commit":"3057997cae65261b513a2d59aaf6eb4e87afc8c9","subject":"Remove unnecessary file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3057997cae65261b513a2d59aaf6eb4e87afc8c9"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-11-15 10:21:36.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2023-11-15 11:33:19.000000000","tz":0},"subject":"parseactions: Use ArgumentError, not ArgumentTypeError","message":"parseactions: Use ArgumentError, not ArgumentTypeError\n\nIf you use the former, you get a pretty error message when there\u0027s a\nfailure. If you use the latter, you get an ugly traceback when used with\nthe \u0027--debug\u0027 flag.\n\nWithout this change:\n\n  $ openstack flavor create ... --property \u0027\u0027 foo\n  ...\n  Traceback (most recent call last):\n    File \"/tmp/venv/lib/python3.11/site-packages/cliff/app.py\", line 402, in run_subcommand\n      parsed_args \u003d cmd_parser.parse_args(sub_argv)\n                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n    File \"/usr/lib64/python3.11/argparse.py\", line 1862, in parse_args\n      args, argv \u003d self.parse_known_args(args, namespace)\n                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n    File \"/usr/lib64/python3.11/argparse.py\", line 1895, in parse_known_args\n      namespace, args \u003d self._parse_known_args(args, namespace)\n                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n    File \"/usr/lib64/python3.11/argparse.py\", line 2107, in _parse_known_args\n      start_index \u003d consume_optional(start_index)\n                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n    File \"/usr/lib64/python3.11/argparse.py\", line 2047, in consume_optional\n      take_action(action, args, option_string)\n    File \"/usr/lib64/python3.11/argparse.py\", line 1971, in take_action\n      action(self, namespace, argument_values, option_string)\n    File \"/tmp/venv/lib/python3.11/site-packages/osc_lib/cli/parseractions.py\", line 45, in __call__\n      raise argparse.ArgumentTypeError(msg % str(values))\n  argparse.ArgumentTypeError: Expected \u0027key\u003dvalue\u0027 type, but got:\n  clean_up CreateFlavor: Expected \u0027key\u003dvalue\u0027 type, but got:\n\nWith this change:\n\n  $ openstack flavor create ... --property \u0027\u0027 foo\n  ...\n  usage: openstack flavor create [-h] [-f {json,shell,table,value,yaml}] [-c COLUMN]\n                                 [--noindent] [--prefix PREFIX] [--max-width \u003cinteger\u003e]\n                                 [--fit-width] [--print-empty] [--id \u003cid\u003e]\n                                 [--ram \u003csize-mb\u003e] [--disk \u003csize-gb\u003e]\n                                 [--ephemeral \u003csize-gb\u003e] [--swap \u003csize-mb\u003e]\n                                 [--vcpus \u003cvcpus\u003e] [--rxtx-factor \u003cfactor\u003e]\n                                 [--public | --private] [--property \u003ckey\u003dvalue\u003e]\n                                 [--project \u003cproject\u003e] [--description \u003cdescription\u003e]\n                                 [--project-domain \u003cproject-domain\u003e]\n                                 \u003cflavor-name\u003e\n  openstack flavor create: error: argument --property: Expected \u0027key\u003dvalue\u0027 type, but got:\n  clean_up CreateFlavor:\n\nChange-Id: I9e78b35ad9d016d7a33655141ec579397c5344c0\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c08d6e0391c2e435f2e98918116b968104846327"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c08d6e0391c2e435f2e98918116b968104846327"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}