)]}'
{"id":"openstack%2Fpython-openstackclient~901765","triplet_id":"openstack%2Fpython-openstackclient~master~Ia7b9738205002b028c19e4f397411c86469cba1a","project":"openstack/python-openstackclient","branch":"master","topic":"dns_domain_clearing","attention_set":{},"removed_from_attention_set":{"36266":{"account":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"last_update":"2024-01-10 18:31:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia7b9738205002b028c19e4f397411c86469cba1a","subject":"Fix clearing of dns_domain and description on a network by setting to empty strings","status":"MERGED","created":"2023-11-23 15:11:08.000000000","updated":"2024-01-10 18:33:26.000000000","submitted":"2024-01-10 18:31:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"901765-dns_domain_clearing","meta_rev_id":"94c0c6b0cd71a092415c93753d5667057da1a533","_number":901765,"virtual_id_number":901765,"owner":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-01-10 18:31:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2024-01-10 15:04:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2023-11-24 12:26:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":2,"date":"2023-11-27 16:30:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-11-28 02:50:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2024-01-10 15:04:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-23 16:55:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-24 07:41:21.000000000","updated_by":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"reviewer":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"state":"CC"},{"updated":"2023-11-24 12:26:39.000000000","updated_by":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"reviewer":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"state":"REVIEWER"},{"updated":"2023-11-27 16:30:37.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2023-11-28 02:50:09.000000000","updated_by":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"reviewer":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"state":"REVIEWER"},{"updated":"2024-01-10 15:04:12.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"f52f401436cfac4df23af23da61b7e5e6cd797e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"date":"2023-11-23 15:11:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e3716bf1920a270387a81672b20f8096ecfb597a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"date":"2023-11-23 15:43:14.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"f21bf93ded50c8d972c46fda096e32e250d978db","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-23 16:55:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/703f5a279c9244d686d98ed21d8207fb\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/caee35c1ea4b4d919cd5e47fc8b33135 : SUCCESS in 4m 07s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/23ae021a81ec4e96a006a5af21dd3c7b : SUCCESS in 4m 41s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/0200512862e24e96a1b170bb32e0de8a : SUCCESS in 4m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3406643d07f54daa9e1dff817e06cdb0 : SUCCESS in 4m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/faa8c9a5e2484b058e388d624c892895 : SUCCESS in 3m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/88cf8357856d47d28c6fdd7ae49e21d7 : SUCCESS in 4m 14s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8027c2660d7a490b91ad49819229695a : SUCCESS in 3m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e708dc22c1ea4da0a2b89a6da2e577f1 : SUCCESS in 6m 19s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/23af538a3fc5420ca106c4951c29e175 : SUCCESS in 5m 54s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/7f52d42b94e844818bd64f8c6249cd87 : SUCCESS in 1h 05m 57s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/e2f33aa85e5543beb32ebf338f93198a : SUCCESS in 56m 22s","accounts_in_message":[],"_revision_number":2},{"id":"3b59c4f7c99c8294633fb496a627a75f8a7f0cb9","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2023-11-24 07:41:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7b3337cea0801ab09484dd2b9ca8a4c2121945c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"date":"2023-11-24 11:40:51.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"1417c20fff3b8e2649232eed02e60b44f3510b93","author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"date":"2023-11-24 12:26:39.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"85f49eb4720719ca632cc7ee3b5026f120995a54","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-24 13:00:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/04ecd38946db4c368c21fe90f2ca7f32\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/2cd46089b5f64cf883bcdb869ae7f3ba : SUCCESS in 4m 00s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/94c5cf6f7ef2478ba5bea2534251c609 : SUCCESS in 4m 02s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/20fa0efe5d114489a5d1510c1e2641dc : SUCCESS in 5m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2df66aed25c142f7940e24e39db21159 : SUCCESS in 4m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44e486aad3e446acb645e47124928c5a : SUCCESS in 4m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2d7fc58f83904629b1d461913d2e5282 : SUCCESS in 3m 10s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/0ce79e3df096407f89c781c70bd6c6e0 : SUCCESS in 3m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c8842a59b66f48e9997e7bb0e897fe79 : SUCCESS in 6m 08s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/d8a5f246fef24308bd6fb373aaa48445 : SUCCESS in 5m 49s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/ff5805be103d457ab923ccb883f577b6 : SUCCESS in 1h 08m 23s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/90b669c9861046529afddddeabee6072 : SUCCESS in 1h 11m 31s","accounts_in_message":[],"_revision_number":3},{"id":"b53175946405872fe5b6d15f0a5a2b54d726dea0","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2023-11-27 16:30:37.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"6c64e126d4aee52a8c1f543a5acd9ada6cad4ed2","author":{"_account_id":32238,"name":"wdd","email":"wangzihao@yovole.com","username":"wangzihao"},"date":"2023-11-28 02:50:09.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e8101534034b8101973d55ff80a2ee8e0ee67ffb","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-01-10 15:04:12.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"b7c3ff1320cd4f0f604f284de28e8afde514aab5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 15:04:56.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"298dd13bf17b8f6df0789e9e4448e5f28ed3b0b2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 18:31:42.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ee733918e3c140fa8a5bb62458da7690\n\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/b60f795f579947ec932863f5ad9d6fe9 : SUCCESS in 5m 17s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/16743bbbbfff4d96aedb5dbe0d72011d : SUCCESS in 6m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/624e963372654df988057f9704071786 : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c85a4b09259846b1aa48cb7f379ec481 : SUCCESS in 5m 01s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/6648309a65ec4b8eb993443b53b958dd : SUCCESS in 5m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3cd797951af84453a113f0bac78247b6 : SUCCESS in 7m 31s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/852dc747088b4853a47bb8c3d91f0bf3 : SUCCESS in 5m 56s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/9af8eecbdfb24164889ad67fe91a9553 : SUCCESS in 1h 11m 02s","accounts_in_message":[],"_revision_number":3},{"id":"07bcdf0c8e5d6aed06a095d2152d8742b20d4186","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 18:31:42.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"94c0c6b0cd71a092415c93753d5667057da1a533","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-10 18:33:26.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7b2ec56a9c0444919ef247a86335eca1\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eab56936a7ac4f1eb65d2da6dfc5b1ea : SUCCESS in 1m 25s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/90845f80d30740aa9b736486bf9f33ce : SUCCESS in 32s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ce0765facba9c25fcc1fca662d23cc9c28345559","revisions":{"171f2676e60311892d1469514cff0dcc2ad3b856":{"kind":"REWORK","_number":1,"created":"2023-11-23 15:11:08.000000000","uploader":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"ref":"refs/changes/65/901765/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/901765/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/1"}}},"commit":{"parents":[{"commit":"127b49d45ef30e8980c00f36dda96f3a686f12b2","subject":"Merge \"tests: Check for DHCP agents first in DHCP test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/127b49d45ef30e8980c00f36dda96f3a686f12b2"}]}],"author":{"name":"Florian Streibelt","email":"florian.streibelt@sap.com","date":"2023-11-23 15:04:47.000000000","tz":60},"committer":{"name":"Florian Streibelt","email":"florian.streibelt@sap.com","date":"2023-11-23 15:04:47.000000000","tz":60},"subject":"enable clearing of dns_domain on a network by setting to empty string","message":"enable clearing of dns_domain on a network by setting to empty string\n\nAfter setting a default dns_domain on a network\n\n openstack net set --dns-domain \u0027example.com.\u0027 \u003cNETWORKID\u003e\n\nthe setting could not be reverted back to an empty string using\n\n openstack net set --dns-domain \u0027\u0027 \u003cNETWORKID\u003e\n\nand the call also does not emit any error.\n\nReason was using the parsed argument directly as a condition instead of\ncomparing against None -- dropping the empty string as valid value.\n\nChange-Id: Ia7b9738205002b028c19e4f397411c86469cba1a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/171f2676e60311892d1469514cff0dcc2ad3b856"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/171f2676e60311892d1469514cff0dcc2ad3b856"}]},"branch":"refs/heads/master"},"a6788be315c847eaf22163d2645897d6a066949e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-11-23 15:43:14.000000000","uploader":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"ref":"refs/changes/65/901765/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/901765/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/2"}}},"commit":{"parents":[{"commit":"127b49d45ef30e8980c00f36dda96f3a686f12b2","subject":"Merge \"tests: Check for DHCP agents first in DHCP test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/127b49d45ef30e8980c00f36dda96f3a686f12b2"}]}],"author":{"name":"Florian Streibelt","email":"florian.streibelt@sap.com","date":"2023-11-23 15:04:47.000000000","tz":60},"committer":{"name":"Florian Streibelt","email":"florian.streibelt@sap.com","date":"2023-11-23 15:43:14.000000000","tz":0},"subject":"Fix clearing of dns_domain on a network by setting to empty string","message":"Fix clearing of dns_domain on a network by setting to empty string\n\nAfter setting a default dns_domain on a network\n\n openstack net set --dns-domain \u0027example.com.\u0027 \u003cNETWORKID\u003e\n\nthe setting could not be reverted back to an empty string using\n\n openstack net set --dns-domain \u0027\u0027 \u003cNETWORKID\u003e\n\nand the call also does not emit any error.\n\nReason was using the parsed argument directly as a condition instead of\ncomparing against None -- dropping the empty string as valid value.\n\nChange-Id: Ia7b9738205002b028c19e4f397411c86469cba1a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a6788be315c847eaf22163d2645897d6a066949e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a6788be315c847eaf22163d2645897d6a066949e"}]},"branch":"refs/heads/master","description":"Edit commit message"},"ce0765facba9c25fcc1fca662d23cc9c28345559":{"kind":"REWORK","_number":3,"created":"2023-11-24 11:40:51.000000000","uploader":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"ref":"refs/changes/65/901765/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/901765/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/901765/3"}}},"commit":{"parents":[{"commit":"127b49d45ef30e8980c00f36dda96f3a686f12b2","subject":"Merge \"tests: Check for DHCP agents first in DHCP test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/127b49d45ef30e8980c00f36dda96f3a686f12b2"}]}],"author":{"name":"Florian Streibelt","email":"florian.streibelt@sap.com","date":"2023-11-23 15:04:47.000000000","tz":60},"committer":{"name":"Florian Streibelt","email":"florian.streibelt@sap.com","date":"2023-11-24 11:36:07.000000000","tz":60},"subject":"Fix clearing of dns_domain and description on a network by setting to empty strings","message":"Fix clearing of dns_domain and description on a network by setting to empty strings\n\nAfter setting a default dns_domain on a network\n\n openstack net set --dns-domain \u0027example.com.\u0027 \u003cNETWORKID\u003e\n\nthe setting could not be reverted back to an empty string using\n\n openstack net set --dns-domain \u0027\u0027 \u003cNETWORKID\u003e\n\nand the call also does not emit any error.\n\nThe same is true for the description of a network.\n\nReason was using the parsed argument directly as a condition instead of\ncomparing against None -- dropping the empty string as valid value.\n\nThe name parameter already accepted an empty string.\n\nThis change also adds a testcase for dns_domain, description and the\nnetwork name parameter, checking if the empty string is forwarded.\n\nChange-Id: Ia7b9738205002b028c19e4f397411c86469cba1a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ce0765facba9c25fcc1fca662d23cc9c28345559"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ce0765facba9c25fcc1fca662d23cc9c28345559"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}