)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e767ab88853ce5e6f8351b0a6f415c6512b55d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31f4f15f_f7e9cb61","updated":"2023-12-04 17:30:55.000000000","message":"Soft -1","commit_id":"39dfccd49d109f42734e8aad3c37fa1ab4bfab1d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"142e97e5ca7903dffeeef1601c9082fca2ce01e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f251aca1_e982f448","updated":"2024-07-19 15:06:43.000000000","message":"@rajatdhasmana@gmail.com I\u0027ve added a new option, `--default`, to replace `--class` entirely. You can find it [here](https://review.opendev.org/c/openstack/python-openstackclient/+/923949). Does this change still make sense, given this? If it does, we probably need to rebase this.","commit_id":"23f0b59e02d2c6079747e17b55fad88e072794a7"}],"openstackclient/common/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e767ab88853ce5e6f8351b0a6f415c6512b55d0f","unresolved":true,"context_lines":[{"line_number":732,"context_line":"                    \"Network quotas are ignored since quota classes are not \""},{"line_number":733,"context_line":"                    \"supported.\""},{"line_number":734,"context_line":"                )"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            project \u003d utils.find_resource("},{"line_number":737,"context_line":"                identity_client.projects,"},{"line_number":738,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0402c6bb_cadb1add","line":735,"updated":"2023-12-04 17:30:55.000000000","message":"Rather than changing the message, could we just invert the logic here and start checking for `parsed_args.project` instead of `parsed_args.quota_class`, e.g.\n\n```\nif parsed_args.project:\n    # project-specific configuration\nelse:\n    # deployment-wide configuration (not supported by Networking)\n```\n\nThat seems better than passing an effectively useless option?","commit_id":"39dfccd49d109f42734e8aad3c37fa1ab4bfab1d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8149bf0744cfd4e167c122c870a3bb31b14c01f1","unresolved":true,"context_lines":[{"line_number":732,"context_line":"                    \"Network quotas are ignored since quota classes are not \""},{"line_number":733,"context_line":"                    \"supported.\""},{"line_number":734,"context_line":"                )"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            project \u003d utils.find_resource("},{"line_number":737,"context_line":"                identity_client.projects,"},{"line_number":738,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":1,"id":"defe205b_d15cde93","line":735,"in_reply_to":"0402c6bb_cadb1add","updated":"2023-12-05 13:55:46.000000000","message":"I\u0027m not sure about the change you are suggesting. How can that act as an alternative to the warning message?\nThe purpose of my change is, during a quota set command, the warning suggests to use \u0027quota show\u0027 which isn\u0027t correct.\nAlso we need to pass either a \u003cproject\u003e or --class argument else the command will error out before this part executes so we can\u0027t run the command without --class option even though it\u0027s redundant.","commit_id":"39dfccd49d109f42734e8aad3c37fa1ab4bfab1d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"be4f78dbe2391a0692cb74b7b04e8c2d561511c9","unresolved":false,"context_lines":[{"line_number":732,"context_line":"                    \"Network quotas are ignored since quota classes are not \""},{"line_number":733,"context_line":"                    \"supported.\""},{"line_number":734,"context_line":"                )"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            project \u003d utils.find_resource("},{"line_number":737,"context_line":"                identity_client.projects,"},{"line_number":738,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a730191a_6f71acf7","line":735,"in_reply_to":"255b4dcc_99702784","updated":"2023-12-06 11:56:07.000000000","message":"I see. that was my initial thought but doing rework for something that is eventually going to be removed didn\u0027t look like a good idea to me.\nBut i can see the option will be removed in 8.0.0 and we are currently at 6.3.0 so it is still a long way to go. will update in next PS.","commit_id":"39dfccd49d109f42734e8aad3c37fa1ab4bfab1d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d0aef8d42f1a700cf6971fdbb200ff128382f2b5","unresolved":true,"context_lines":[{"line_number":732,"context_line":"                    \"Network quotas are ignored since quota classes are not \""},{"line_number":733,"context_line":"                    \"supported.\""},{"line_number":734,"context_line":"                )"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            project \u003d utils.find_resource("},{"line_number":737,"context_line":"                identity_client.projects,"},{"line_number":738,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":1,"id":"255b4dcc_99702784","line":735,"in_reply_to":"defe205b_d15cde93","updated":"2023-12-05 17:28:07.000000000","message":"\u003e Also we need to pass either a \u003cproject\u003e or --class argument else the command will error out before this part executes so we can\u0027t run the command without --class option even though it\u0027s redundant.\n\nExactly, it\u0027s redundant. I\u0027m replace this\n\n    Please use \u0027openstack quota show --default\u0027 instead.\n\nwith e.g. this:\n\n    You can omit this argument.\n    \nAnd instead of doing:\n\n    if user passed \u0027--quota\u0027\n        get default quotas\n    else\n        get project-specific quotas\n\nwe do:\n\n    if user passed \u0027--project PROJECT\u0027\n        get project-specific quotas\n    else\n        get default quotas\n\nHopefully that makes more sense?","commit_id":"39dfccd49d109f42734e8aad3c37fa1ab4bfab1d"}]}