)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00411af65e61a38ad4e815305f8d7e71f1274a64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24b86dc7_48655acd","updated":"2023-12-06 11:16:21.000000000","message":"No issues with the idea but I\u0027d like the opt updated, please 🙏","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"46e3cb2baf55f61ee621a059d038a6806d909fab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b43f580_bd4ae440","in_reply_to":"24b86dc7_48655acd","updated":"2024-02-21 16:28:39.000000000","message":"Sorry I forgot this, one, and thought that I did the update ....","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"853f78bcb50ac5445e525376af3f22fd65e08019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0affbba3_b5853212","updated":"2024-05-03 15:27:31.000000000","message":"-1 to bring attention to my comment inline","commit_id":"e208b344a9d3c66851898a534d1c2bcd3cd2547d"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1a08e1ecbc7b3968347c8a94c20cf11cef3149ab","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        attrs[\u0027project_id\u0027] \u003d project_id"},{"line_number":116,"context_line":"    if parsed_args.external_gateway:"},{"line_number":117,"context_line":"        gateway_info \u003d {}"},{"line_number":118,"context_line":"        n_client \u003d client_manager.network"},{"line_number":119,"context_line":"        network \u003d n_client.find_network("},{"line_number":120,"context_line":"            parsed_args.external_gateway, ignore_missing\u003dFalse"},{"line_number":121,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"53df3a0c_7ece14b3","line":118,"updated":"2023-12-05 15:25:31.000000000","message":"Guess this should move from under this if:","commit_id":"c0d0f4096a62225440c5c336e92de57c0662fba3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9771874657566f9210ae157995c281234702826d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        attrs[\u0027project_id\u0027] \u003d project_id"},{"line_number":116,"context_line":"    if parsed_args.external_gateway:"},{"line_number":117,"context_line":"        gateway_info \u003d {}"},{"line_number":118,"context_line":"        n_client \u003d client_manager.network"},{"line_number":119,"context_line":"        network \u003d n_client.find_network("},{"line_number":120,"context_line":"            parsed_args.external_gateway, ignore_missing\u003dFalse"},{"line_number":121,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b098f5d_28695327","line":118,"in_reply_to":"2ad39a7d_26c6fa83","updated":"2024-04-09 17:05:51.000000000","message":"Done","commit_id":"c0d0f4096a62225440c5c336e92de57c0662fba3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b60a5838ce6d7d1a07c028086fba0525886b6ffc","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        attrs[\u0027project_id\u0027] \u003d project_id"},{"line_number":116,"context_line":"    if parsed_args.external_gateway:"},{"line_number":117,"context_line":"        gateway_info \u003d {}"},{"line_number":118,"context_line":"        n_client \u003d client_manager.network"},{"line_number":119,"context_line":"        network \u003d n_client.find_network("},{"line_number":120,"context_line":"            parsed_args.external_gateway, ignore_missing\u003dFalse"},{"line_number":121,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ad39a7d_26c6fa83","line":118,"in_reply_to":"53df3a0c_7ece14b3","updated":"2023-12-06 10:30:55.000000000","message":"yes, strange that having a client is conditional.","commit_id":"c0d0f4096a62225440c5c336e92de57c0662fba3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00411af65e61a38ad4e815305f8d7e71f1274a64","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            parsed_args.project_domain,"},{"line_number":114,"context_line":"        ).id"},{"line_number":115,"context_line":"        attrs[\u0027project_id\u0027] \u003d project_id"},{"line_number":116,"context_line":"    n_client \u003d client_manager.network"},{"line_number":117,"context_line":"    if parsed_args.external_gateway:"},{"line_number":118,"context_line":"        gateway_info \u003d {}"},{"line_number":119,"context_line":"        network \u003d n_client.find_network("}],"source_content_type":"text/x-python","patch_set":2,"id":"5c3b0875_1f18bb4b","line":116,"updated":"2023-12-06 11:16:21.000000000","message":"nit: can you move this to the top of the function now that it\u0027s no longer conditional? That\u0027s the general location of these things.","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"46e3cb2baf55f61ee621a059d038a6806d909fab","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            parsed_args.project_domain,"},{"line_number":114,"context_line":"        ).id"},{"line_number":115,"context_line":"        attrs[\u0027project_id\u0027] \u003d project_id"},{"line_number":116,"context_line":"    n_client \u003d client_manager.network"},{"line_number":117,"context_line":"    if parsed_args.external_gateway:"},{"line_number":118,"context_line":"        gateway_info \u003d {}"},{"line_number":119,"context_line":"        network \u003d n_client.find_network("}],"source_content_type":"text/x-python","patch_set":2,"id":"2c6e7e10_74d0e816","line":116,"in_reply_to":"5c3b0875_1f18bb4b","updated":"2024-02-21 16:28:39.000000000","message":"Done","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00411af65e61a38ad4e815305f8d7e71f1274a64","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        parser.add_argument("},{"line_number":407,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":408,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":409,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":410,"context_line":"        )"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"29de152e_b716f680","line":409,"updated":"2023-12-06 11:16:21.000000000","message":"Could you rename this to \u0027--flavor\u0027 and update the help text? You should probably create a legacy (hidden, via `argparse.SUPPRESS`) alias too. Don\u0027t forget the release note!","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"46e3cb2baf55f61ee621a059d038a6806d909fab","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        parser.add_argument("},{"line_number":407,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":408,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":409,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":410,"context_line":"        )"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"d49c3b8f_172b8b31","line":409,"in_reply_to":"29de152e_b716f680","updated":"2024-02-21 16:28:39.000000000","message":"Something new today, hope I understand well how you meant the legacy option","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9771874657566f9210ae157995c281234702826d","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        parser.add_argument("},{"line_number":407,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":408,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":409,"context_line":"            help\u003d_(\"Associate the router to a flavor by ID\"),"},{"line_number":410,"context_line":"        )"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"18994378_aa3a606d","line":409,"in_reply_to":"d49c3b8f_172b8b31","updated":"2024-04-09 17:05:51.000000000","message":"Done","commit_id":"be4fc4155c4e9d101cf08ef538faa0c1d3cdcff1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9771874657566f9210ae157995c281234702826d","unresolved":true,"context_lines":[{"line_number":571,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":572,"context_line":"            help\u003d_(\"Associate the router to a flavor (by name or ID\"),"},{"line_number":573,"context_line":"        )"},{"line_number":574,"context_line":"        if not self.is_docs_build:"},{"line_number":575,"context_line":"            parser.add_argument("},{"line_number":576,"context_line":"                \u0027--flavor-id\u0027,"},{"line_number":577,"context_line":"                metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8483a723_7c58558e","line":574,"updated":"2024-04-09 17:05:51.000000000","message":"Oh, is this necessary? It should be ignored by docs builds (or at least minimally obtrusive)","commit_id":"c02fdb546e8552cda6084a7c13b4f739bbc38941"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"688fc3da308915e289c6da4eacb2a260ec74c9b8","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"},{"line_number":572,"context_line":"            help\u003d_(\"Associate the router to a flavor (by name or ID\"),"},{"line_number":573,"context_line":"        )"},{"line_number":574,"context_line":"        if not self.is_docs_build:"},{"line_number":575,"context_line":"            parser.add_argument("},{"line_number":576,"context_line":"                \u0027--flavor-id\u0027,"},{"line_number":577,"context_line":"                metavar\u003d\u0027\u003cflavor-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff72845a_f5f91bb7","line":574,"in_reply_to":"8483a723_7c58558e","updated":"2024-04-10 07:57:24.000000000","message":"yeah, to tell the truth I don\u0027t remember why I added that check, it seems unnecessary really.","commit_id":"c02fdb546e8552cda6084a7c13b4f739bbc38941"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d2aa47a69bf43e78af6a4996aee2f8bd12d0013","unresolved":true,"context_lines":[{"line_number":454,"context_line":"# TODO(yanxing\u0027an): Use the SDK resource mapped attribute names once the"},{"line_number":455,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":456,"context_line":"class CreateRouter("},{"line_number":457,"context_line":"    common.NetworkAndComputeShowOne, common.NeutronCommandWithExtraArgs"},{"line_number":458,"context_line":"):"},{"line_number":459,"context_line":"    _description \u003d _(\"Create a new router\")"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"37e415e0_bce31bbe","line":457,"range":{"start_line":457,"start_character":4,"end_line":457,"end_character":36},"updated":"2024-04-11 17:58:32.000000000","message":"Is this necessary? This seems to be for commands that provide implementations for both compute and networking, which `CreateRouter` does not?","commit_id":"a35f07ac5953df1c76810394c182c81a2e1e2669"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"15fefe5bc54445064ce77a64225a9e0eefe4000b","unresolved":true,"context_lines":[{"line_number":454,"context_line":"# TODO(yanxing\u0027an): Use the SDK resource mapped attribute names once the"},{"line_number":455,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":456,"context_line":"class CreateRouter("},{"line_number":457,"context_line":"    common.NetworkAndComputeShowOne, common.NeutronCommandWithExtraArgs"},{"line_number":458,"context_line":"):"},{"line_number":459,"context_line":"    _description \u003d _(\"Create a new router\")"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"efdb4158_3e8a9c7c","line":457,"range":{"start_line":457,"start_character":4,"end_line":457,"end_character":36},"in_reply_to":"37e415e0_bce31bbe","updated":"2024-05-06 11:53:07.000000000","message":"You are right, for routers command.ShowOne works perfectly","commit_id":"a35f07ac5953df1c76810394c182c81a2e1e2669"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08d99086cc0159335b8ba789ea7547ad6cc5569a","unresolved":false,"context_lines":[{"line_number":454,"context_line":"# TODO(yanxing\u0027an): Use the SDK resource mapped attribute names once the"},{"line_number":455,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":456,"context_line":"class CreateRouter("},{"line_number":457,"context_line":"    common.NetworkAndComputeShowOne, common.NeutronCommandWithExtraArgs"},{"line_number":458,"context_line":"):"},{"line_number":459,"context_line":"    _description \u003d _(\"Create a new router\")"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a20b1428_bfe4a844","line":457,"range":{"start_line":457,"start_character":4,"end_line":457,"end_character":36},"in_reply_to":"efdb4158_3e8a9c7c","updated":"2024-05-08 17:39:04.000000000","message":"Done","commit_id":"a35f07ac5953df1c76810394c182c81a2e1e2669"}],"openstackclient/tests/unit/network/v2/test_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"593d18f7a05c75b2851351e3e8183232eb217968","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        self.network_client.find_flavor \u003d mock.Mock(return_value\u003d_flavor)"},{"line_number":387,"context_line":"        arglist \u003d ["},{"line_number":388,"context_line":"            self.new_router.name,"},{"line_number":389,"context_line":"            \u0027--flavor-id\u0027,"},{"line_number":390,"context_line":"            _flavor.id,"},{"line_number":391,"context_line":"        ]"},{"line_number":392,"context_line":"        arglist_with_name \u003d [self.new_router.name, \u0027--flavor-id\u0027, _flavor.name]"}],"source_content_type":"text/x-python","patch_set":4,"id":"15145e6f_454b8a09","line":389,"updated":"2024-02-22 16:52:43.000000000","message":"nit: do you need to test both --flavor and --flavor-id ?","commit_id":"db51902e788912731065ea4627503404f0d72c26"}],"releasenotes/notes/Router-flavor-accepts-name-or-id-e9cecafcddf81cb2.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9771874657566f9210ae157995c281234702826d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Instead of the ``router create`` command ``flavor-id`` the"},{"line_number":5,"context_line":"    ``flavor`` option can be used and it accepts both name or Id."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"13016e46_6ed00ac9","line":5,"updated":"2024-04-09 17:05:51.000000000","message":"How about\n\n```\nThe ``router create --flavor-id`` parameter has been deprecated\nin favour of the ``--flavor`` parameter, which accepts both\nflavor names and flavor IDs.\n```\n\n?","commit_id":"c02fdb546e8552cda6084a7c13b4f739bbc38941"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"688fc3da308915e289c6da4eacb2a260ec74c9b8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Instead of the ``router create`` command ``flavor-id`` the"},{"line_number":5,"context_line":"    ``flavor`` option can be used and it accepts both name or Id."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f2ac2836_6c31e629","line":5,"in_reply_to":"13016e46_6ed00ac9","updated":"2024-04-10 07:57:24.000000000","message":"sounds better","commit_id":"c02fdb546e8552cda6084a7c13b4f739bbc38941"}]}