)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6fe5104e051baa2261921f90712d257b3c80f91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4b3539c0_394a5d24","updated":"2024-02-16 14:08:47.000000000","message":"I fixed the style issues (by checking out the patch and running `pre-commit run -a`: you can install `pre-commit` to have this happen automatically when committing). There\u0027s one outstanding issue here though. Fix that and I\u0027m +2.","commit_id":"4f927e884e4728eb09d066350ea5490039124c22"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"add0501f53d70bedcb87d837957f562ad5fea015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c0431780_ffeed286","updated":"2024-02-21 17:06:40.000000000","message":"Let\u0027s wait for code freeze to lift","commit_id":"cdab1977b73838ffce8617b2bef192f40e165b0a"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"baba2222924fc0dfb93e1493cfa6a36b8f619fb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8c942d45_65b8156b","updated":"2024-02-20 18:22:04.000000000","message":"Whoops, somehow thought I uploaded this patch yesterday... no wonder Zuul didn\u0027t respond :)","commit_id":"cdab1977b73838ffce8617b2bef192f40e165b0a"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"7a7421e142d09fce1058be0d48244cd8f2b9ece5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4857e57d_f5eed894","updated":"2024-03-13 15:35:36.000000000","message":"recheck","commit_id":"fc6b1530dc39e7f5b2c19436c291a7e3c737ae7b"}],"openstackclient/tests/unit/identity/v3/test_user.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"195bf02bfbe7fd242dc7abbcabdcbbb8767eeddf","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super().setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.app.client_manager.sdk_connection.identity \u003d mock.Mock()"},{"line_number":39,"context_line":"        self.identity_sdk_client \u003d (self.app.client_manager.sdk_connection.identity)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"58355667_440cf3a5","line":38,"updated":"2024-02-14 18:27:06.000000000","message":"When doing this, you should spec the mock so that you get an error if you call an invalid method. Alternatively, rebase your change on top of https://review.opendev.org/c/openstack/python-openstackclient/+/909035 where I just added this to the `TestIdentityv3` base test class)","commit_id":"08b5ad14eb6e61aba1a5b0cbb98662326b086ac2"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"df0a15294709bfdd5c8770e2f87d29930c888185","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super().setUp()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.app.client_manager.sdk_connection.identity \u003d mock.Mock()"},{"line_number":39,"context_line":"        self.identity_sdk_client \u003d (self.app.client_manager.sdk_connection.identity)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e2e9973b_ee0d2575","line":38,"in_reply_to":"58355667_440cf3a5","updated":"2024-02-14 19:27:40.000000000","message":"Done","commit_id":"08b5ad14eb6e61aba1a5b0cbb98662326b086ac2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"195bf02bfbe7fd242dc7abbcabdcbbb8767eeddf","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                \u0027domain_id\u0027: self.domain.id,"},{"line_number":64,"context_line":"                \u0027default_project_id\u0027: self.project.id,"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":"        self.datalist \u003d ("},{"line_number":68,"context_line":"            self.project.id,"},{"line_number":69,"context_line":"            self.domain.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"933f6c18_744b9ca7","line":66,"updated":"2024-02-14 18:27:06.000000000","message":"Are those attributes getting propagated to the created `User` object? What happens if you do e.g.\n\n```\nprint(self.domain.id)\nprint(self.user.domain_id)\n```\n\nThey should be same, right? If not, why? Hint: If a method looks like this:\n\n```\ndef foo(**kwargs):\n    print(kwargs)\n```\n\nthen you call it like this:\n\n```\nfoo(bar\u003d123, baz\u003d\u0027abc\u0027)\n```\n\n*not* like this:\n\n```\nfoo(kwargs\u003d{\u0027bar\u0027: 123, \u0027baz\u0027: \u0027abc\u0027})\n```\n\n`**kwargs` allows you to accept arbitrary keyword arguments. Similarly `*args` lets you accept arbitrary positional arguments.","commit_id":"08b5ad14eb6e61aba1a5b0cbb98662326b086ac2"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"df0a15294709bfdd5c8770e2f87d29930c888185","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                \u0027domain_id\u0027: self.domain.id,"},{"line_number":64,"context_line":"                \u0027default_project_id\u0027: self.project.id,"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":"        self.datalist \u003d ("},{"line_number":68,"context_line":"            self.project.id,"},{"line_number":69,"context_line":"            self.domain.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bccdd05c_2ecc2d6a","line":66,"in_reply_to":"933f6c18_744b9ca7","updated":"2024-02-14 19:27:40.000000000","message":"Ohh haha, I see what you mean! That fixed it, thank you!","commit_id":"08b5ad14eb6e61aba1a5b0cbb98662326b086ac2"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"66113e8f0056cae7e9ea6da099911e1ac56bdc75","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from openstack import exceptions as sdk_exc"},{"line_number":22,"context_line":"from openstack.identity.v3 import domain as _domain"},{"line_number":23,"context_line":"from openstack.identity.v3 import project as _project"},{"line_number":24,"context_line":"from openstack.identity.v3 import group as _group"},{"line_number":25,"context_line":"from openstack.identity.v3 import role_assignment as _role_assignment"},{"line_number":26,"context_line":"from openstack.identity.v3 import user as _user"},{"line_number":27,"context_line":"from openstack.test import fakes as sdk_fakes"}],"source_content_type":"text/x-python","patch_set":6,"id":"d56e8cc1_a70401fa","line":24,"in_reply_to":"011584eb_e8f8f211","updated":"2024-02-15 21:06:37.000000000","message":"Oops, I thought that did something special... I\u0027ll fix it myself :)","commit_id":"32d4abaaeec48d8f58dafd5cfcbc1f47695a9a0d"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"ebee43655ba64f23079bb076ca6ba3930bc6aff3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from openstack import exceptions as sdk_exc"},{"line_number":22,"context_line":"from openstack.identity.v3 import domain as _domain"},{"line_number":23,"context_line":"from openstack.identity.v3 import project as _project"},{"line_number":24,"context_line":"from openstack.identity.v3 import group as _group"},{"line_number":25,"context_line":"from openstack.identity.v3 import role_assignment as _role_assignment"},{"line_number":26,"context_line":"from openstack.identity.v3 import user as _user"},{"line_number":27,"context_line":"from openstack.test import fakes as sdk_fakes"}],"source_content_type":"text/x-python","patch_set":6,"id":"86eb5144_d6364835","line":24,"in_reply_to":"d56e8cc1_a70401fa","updated":"2024-02-15 21:08:44.000000000","message":"Done","commit_id":"32d4abaaeec48d8f58dafd5cfcbc1f47695a9a0d"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"b9423a69cccc6cb55acbe41bc4c95590b4caefb7","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from openstack import exceptions as sdk_exc"},{"line_number":22,"context_line":"from openstack.identity.v3 import domain as _domain"},{"line_number":23,"context_line":"from openstack.identity.v3 import project as _project"},{"line_number":24,"context_line":"from openstack.identity.v3 import group as _group"},{"line_number":25,"context_line":"from openstack.identity.v3 import role_assignment as _role_assignment"},{"line_number":26,"context_line":"from openstack.identity.v3 import user as _user"},{"line_number":27,"context_line":"from openstack.test import fakes as sdk_fakes"}],"source_content_type":"text/x-python","patch_set":6,"id":"011584eb_e8f8f211","line":24,"in_reply_to":"ef1e7da0_a155c5e9","updated":"2024-02-15 21:03:02.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (openstack.identity.v3.project, openstack.identity.v3.group)\n\nPlease fix.","commit_id":"32d4abaaeec48d8f58dafd5cfcbc1f47695a9a0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6fe5104e051baa2261921f90712d257b3c80f91f","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.app.client_manager.sdk_connection.identity \u003d mock.Mock()"},{"line_number":39,"context_line":"        self.identity_sdk_client \u003d ("},{"line_number":40,"context_line":"            self.app.client_manager.sdk_connection.identity"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3d315bb6_75d6a5ed","line":40,"updated":"2024-02-16 14:08:47.000000000","message":"You shouldn\u0027t need to do this since it\u0027s already defined on the base `TestIdentityv3` class (which actually does a better job since it\u0027s specced against the `openstack.identity._proxy.Proxy` class, meaning you\u0027ll get errors if you try to use methods that don\u0027t exist on that class).\n\nIn fact, I don\u0027t think you need this base `TestUser` class at all now and could replace uses of it with `identity_fakes.TestIdentityv3` below?","commit_id":"4f927e884e4728eb09d066350ea5490039124c22"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"df1a1f6c5118c15dd815b513bd1f6a082989fe7e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.app.client_manager.sdk_connection.identity \u003d mock.Mock()"},{"line_number":39,"context_line":"        self.identity_sdk_client \u003d ("},{"line_number":40,"context_line":"            self.app.client_manager.sdk_connection.identity"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"90e9f379_a7168127","line":40,"in_reply_to":"3d315bb6_75d6a5ed","updated":"2024-02-19 19:03:08.000000000","message":"Done","commit_id":"4f927e884e4728eb09d066350ea5490039124c22"}]}