)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7a19d2589859d7399b824c0de3131f3ee0c62fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84f301ca_b443e0dd","updated":"2024-07-23 14:15:38.000000000","message":"I did this [here](https://review.opendev.org/c/openstack/python-openstackclient/+/923868).","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"}],"openstackclient/common/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dcb83069e4978670f8a3efb70738a0a3fca33962","unresolved":true,"context_lines":[{"line_number":627,"context_line":"            \u0027--force\u0027,"},{"line_number":628,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":629,"context_line":"            dest\u003d\u0027force\u0027,"},{"line_number":630,"context_line":"            default\u003dNone,"},{"line_number":631,"context_line":"            help\u003d_("},{"line_number":632,"context_line":"                \u0027Force quota update (only supported by compute and network) \u0027"},{"line_number":633,"context_line":"                \u0027(default for network)\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2a34a40f_f897e9df","line":630,"updated":"2024-05-08 15:21:33.000000000","message":"I never figured out how to do this when you\u0027ve a shared `dest`. I assume they stack, i.e. only the `default` of the last option is considered? In any case, we normally ensure `default` is the same across all options with a common `dest` to avoid confusion. Could we do the same here?\n\nLater: actually, if it works like I expect then you\u0027re changed the wrong option. See below.","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dcb83069e4978670f8a3efb70738a0a3fca33962","unresolved":true,"context_lines":[{"line_number":648,"context_line":"        force_group.add_argument("},{"line_number":649,"context_line":"            \u0027--check-limit\u0027,"},{"line_number":650,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":651,"context_line":"            dest\u003d\u0027force\u0027,"},{"line_number":652,"context_line":"            default\u003dNone,"},{"line_number":653,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":654,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2ff092f_b6e386a7","line":651,"updated":"2024-05-08 15:21:33.000000000","message":"This uses the same `dest` as the previous two options so we want to change the default here instead (or - better - for all)","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"11d3b4e9504c3ecc7b5445ef1678f13966d010b5","unresolved":true,"context_lines":[{"line_number":692,"context_line":"            # (a.k.a. \u0027not force\u0027)"},{"line_number":693,"context_line":"            network_kwargs[\u0027force\u0027] \u003d True"},{"line_number":694,"context_line":"        elif parsed_args.force is False:"},{"line_number":695,"context_line":"            network_kwargs[\u0027check_limit\u0027] \u003d True"},{"line_number":696,"context_line":"        else:"},{"line_number":697,"context_line":"            msg \u003d _("},{"line_number":698,"context_line":"                \"This command currently defaults to \u0027--no-force\u0027 when modifying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"f36e8c85_b880959d","line":695,"updated":"2024-05-07 08:08:32.000000000","message":"if we are changing default behaviour to be like \u0027check_limit\u0027 is now, and force to be optional, I think we don\u0027t need 2 parameters anymore and we can just rely on the \u0027force\u0027 - this will require some changes in the neutron also but that\u0027s IMO the way how this should be done.","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"63c8831bb8a76df48681b42e43e29aa65964d9bf","unresolved":true,"context_lines":[{"line_number":692,"context_line":"            # (a.k.a. \u0027not force\u0027)"},{"line_number":693,"context_line":"            network_kwargs[\u0027force\u0027] \u003d True"},{"line_number":694,"context_line":"        elif parsed_args.force is False:"},{"line_number":695,"context_line":"            network_kwargs[\u0027check_limit\u0027] \u003d True"},{"line_number":696,"context_line":"        else:"},{"line_number":697,"context_line":"            msg \u003d _("},{"line_number":698,"context_line":"                \"This command currently defaults to \u0027--no-force\u0027 when modifying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"e6ceb79b_5f0d7af5","line":695,"in_reply_to":"dbfba267_4c8171f3","updated":"2024-05-08 19:28:05.000000000","message":"Do we need \u0027force\u0027 option too?\nIt is nice for backward compatibility, but iiuc quotas act as limits, and set per project, given that, is there any legit case in which setting lower quota than existing needed?\nAllowing that seems to me like a bug in quotas as a feature.","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b473a2eb1c606b88ca369a1c7e33daf5ff543ffa","unresolved":true,"context_lines":[{"line_number":692,"context_line":"            # (a.k.a. \u0027not force\u0027)"},{"line_number":693,"context_line":"            network_kwargs[\u0027force\u0027] \u003d True"},{"line_number":694,"context_line":"        elif parsed_args.force is False:"},{"line_number":695,"context_line":"            network_kwargs[\u0027check_limit\u0027] \u003d True"},{"line_number":696,"context_line":"        else:"},{"line_number":697,"context_line":"            msg \u003d _("},{"line_number":698,"context_line":"                \"This command currently defaults to \u0027--no-force\u0027 when modifying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"6717622c_2a61b604","line":695,"in_reply_to":"e6ceb79b_5f0d7af5","updated":"2024-05-09 07:23:35.000000000","message":"I don\u0027t agree that this is \"bug\" as some operators may want to lower quota for the project and then let project owner to slowly remove too many used resources but from the other side don\u0027t allow to create any new resource there.\n\nLet\u0027s imagine for example cloud storage service like Dropbox or something similar - if will exceed quota because for example your paid plan just expired and you are on the free one again, your existing files will be still there but You will be not allowed to add there anything else before you will go below new quota limit set for You there.\n\nSo, we will need \u0027force\u0027 option to be still there.\n\n@stephenfin: that is very good point about older releases, I totally forgot that OSC needs to be able to talk to older releases too. So yes, we need to keep that option there for those who use it with older Neutron versions.","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dcb83069e4978670f8a3efb70738a0a3fca33962","unresolved":true,"context_lines":[{"line_number":692,"context_line":"            # (a.k.a. \u0027not force\u0027)"},{"line_number":693,"context_line":"            network_kwargs[\u0027force\u0027] \u003d True"},{"line_number":694,"context_line":"        elif parsed_args.force is False:"},{"line_number":695,"context_line":"            network_kwargs[\u0027check_limit\u0027] \u003d True"},{"line_number":696,"context_line":"        else:"},{"line_number":697,"context_line":"            msg \u003d _("},{"line_number":698,"context_line":"                \"This command currently defaults to \u0027--no-force\u0027 when modifying \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dbfba267_4c8171f3","line":695,"in_reply_to":"f36e8c85_b880959d","updated":"2024-05-08 15:21:33.000000000","message":"Agreed. However, won\u0027t we need to care about this forever to support older configuration?","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"11d3b4e9504c3ecc7b5445ef1678f13966d010b5","unresolved":true,"context_lines":[{"line_number":697,"context_line":"            msg \u003d _("},{"line_number":698,"context_line":"                \"This command currently defaults to \u0027--no-force\u0027 when modifying \""},{"line_number":699,"context_line":"                \"network quotas, amount set when bigger than resource count. \""},{"line_number":700,"context_line":"                \"Consider explicitly providing \u0027--force\u0027 when needed.\""},{"line_number":701,"context_line":"            )"},{"line_number":702,"context_line":"            self.log.warning(msg)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a9c62394_03a3df0d","line":700,"updated":"2024-05-07 08:08:32.000000000","message":"do we really need this message still?","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dcb83069e4978670f8a3efb70738a0a3fca33962","unresolved":true,"context_lines":[{"line_number":697,"context_line":"            msg \u003d _("},{"line_number":698,"context_line":"                \"This command currently defaults to \u0027--no-force\u0027 when modifying \""},{"line_number":699,"context_line":"                \"network quotas, amount set when bigger than resource count. \""},{"line_number":700,"context_line":"                \"Consider explicitly providing \u0027--force\u0027 when needed.\""},{"line_number":701,"context_line":"            )"},{"line_number":702,"context_line":"            self.log.warning(msg)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"06178e0f_fce1b153","line":700,"in_reply_to":"a9c62394_03a3df0d","updated":"2024-05-08 15:21:33.000000000","message":"No, we should drop it if we change this default.","commit_id":"b837a36bd7f217e48d014080b9f4f3dd6bd8cab6"}]}