)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"feeb59cf60526f04cecaaab58f6438bcc7c24520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ed4170c_a2544411","updated":"2024-06-24 16:58:48.000000000","message":"Actually, can we get unit tests for this, even if they\u0027re copy-pastes again?","commit_id":"acac6e52ef20bcee4c8bf77105ad9cdc5a684d56"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ee7220b20e93b6df746cb30465dd4c55918d238","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f68f4810_a116f16e","in_reply_to":"3ed4170c_a2544411","updated":"2024-06-24 20:22:19.000000000","message":"Done","commit_id":"acac6e52ef20bcee4c8bf77105ad9cdc5a684d56"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ee7220b20e93b6df746cb30465dd4c55918d238","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0ce7010_5cf998f6","updated":"2024-06-24 20:22:19.000000000","message":"Thanks Stephen","commit_id":"49c42c73a29f6381e6dbf94fb1a0f96329c6a1f4"}],"openstackclient/volume/v3/volume_snapshot.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f9ebca6e3c7b4e3d695cfcef089db903a2d2000","unresolved":true,"context_lines":[{"line_number":57,"context_line":"                ).id"},{"line_number":58,"context_line":"                volume_client.volume_snapshots.delete("},{"line_number":59,"context_line":"                    snapshot_id, parsed_args.force"},{"line_number":60,"context_line":"                )"},{"line_number":61,"context_line":"            except Exception as e:"},{"line_number":62,"context_line":"                result +\u003d 1"},{"line_number":63,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"ce6eee55_70cd4048","line":60,"updated":"2024-06-24 17:00:18.000000000","message":"Any reason we can\u0027t migrate these to SDK in a follow-up? Looks like the `delete_snapshot` proxy method takes a `force` argument so it should work?","commit_id":"acac6e52ef20bcee4c8bf77105ad9cdc5a684d56"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ee7220b20e93b6df746cb30465dd4c55918d238","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                ).id"},{"line_number":58,"context_line":"                volume_client.volume_snapshots.delete("},{"line_number":59,"context_line":"                    snapshot_id, parsed_args.force"},{"line_number":60,"context_line":"                )"},{"line_number":61,"context_line":"            except Exception as e:"},{"line_number":62,"context_line":"                result +\u003d 1"},{"line_number":63,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"3bc705ca_50b18b92","line":60,"in_reply_to":"ce6eee55_70cd4048","updated":"2024-06-24 20:22:19.000000000","message":"I\u0027m migrating all volume snapshot commands to SDK here https://review.opendev.org/c/openstack/python-openstackclient/+/894824\n\nWill include this change in that patch","commit_id":"acac6e52ef20bcee4c8bf77105ad9cdc5a684d56"}]}