)]}'
{"id":"openstack%2Fpython-openstackclient~922565","triplet_id":"openstack%2Fpython-openstackclient~master~Id74552346cfa975e3dd5eb45b8f621b365e88463","project":"openstack/python-openstackclient","branch":"master","topic":"bug/2054629","attention_set":{},"removed_from_attention_set":{"1131":{"account":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"last_update":"2024-07-23 15:25:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id74552346cfa975e3dd5eb45b8f621b365e88463","subject":"Add tests for \u0027default security group rule create\u0027","status":"MERGED","created":"2024-06-22 23:25:24.000000000","updated":"2024-07-23 15:26:59.000000000","submitted":"2024-07-23 15:25:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"922565-bug/2054629","meta_rev_id":"bb55ef001250743bd27aa7f64bc3c94e2770f69a","_number":922565,"virtual_id_number":922565,"owner":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-07-23 15:25:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-07-23 14:21:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-07-23 14:21:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-23 01:06:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-07-23 14:21:09.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"d131d6e814abbcc71acdfbacb2cf58dfd3b69f8d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2024-06-22 23:25:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aea1a7b19744c6efa0c5daed935221062ae69a45","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-06-23 01:06:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/3a3e95cc209741c4878798d5eef1425c\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/916ab9bd13504214965a4ce676083dda : SUCCESS in 4m 15s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/21d40b45ea844df2be6ce757dc26a0ea : SUCCESS in 3m 33s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/473c068d6bfc46caade6576b7503451f : SUCCESS in 3m 54s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0b5dce97b2864d0f8bab6a26ccf79739 : SUCCESS in 3m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a7a6639f6174da0bc6bb92c8a6e7003 : FAILURE in 4m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0f025d6dbef844a095eaa5e9d58921cb : SUCCESS in 2m 51s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/54c8a6d5814d4b0bbf92540090c2d45d : SUCCESS in 2m 55s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/da7d75da571b410f86d6456b6600dcad : SUCCESS in 6m 31s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/183366cab769416c979dd7a5994c2337 : SUCCESS in 5m 00s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/221ba23265c249968f333801a242f228 : SUCCESS in 5m 31s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/54ab7d049dc847fab9713dff185d07c9 : SUCCESS in 1h 05m 47s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/03a5e5e1590b4eb39cdc5da71655575d : FAILURE in 49m 44s","accounts_in_message":[],"_revision_number":1},{"id":"41f60851f0cf0564b59ecf79de2557ddabd8dae9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2024-06-26 20:37:04.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"ffee52eba32e454efc3d8e020fe567ceb5a158d8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-06-26 21:53:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6bdd09675d4f45989cc49832926e42fa\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/d63a29e9d46349c5b69dbcc4f54da1da : SUCCESS in 4m 27s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/072646a6d7e4482ab58ee0af0ae05ff7 : SUCCESS in 3m 51s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/c9e806e915a14c80b56399f339ee80fb : SUCCESS in 5m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3c9529d34a334041b705dac5cb4f800d : SUCCESS in 5m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/68de798c196943c2a2fb6ca57b80ee27 : SUCCESS in 3m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/250855d9fec44cffad49cf7ef221fe44 : SUCCESS in 3m 19s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/e8f25961e32947a983f976930bf1f305 : SUCCESS in 5m 37s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/1e7d3e826fe248ee9178dd1ae8012b93 : SUCCESS in 5m 42s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/862c801c4b224ef28d978702e499ea11 : SUCCESS in 5m 11s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/894ad67db7b24de58338ec4d628b0f4f : SUCCESS in 8m 22s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/611a01adfced414aa1c37d634c3fea92 : SUCCESS in 1h 07m 05s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/df132a705f4d4b0797dd3efed77f26b8 : SUCCESS in 1h 10m 43s","accounts_in_message":[],"_revision_number":2},{"id":"eafbb498143fe1dd00fae4b7db09a3ad36623669","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-07-23 14:21:09.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"371b0d32452da30e511c40246d5d6371a59c99da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-23 14:21:44.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ea7b8e19ef9a5ec3035bf5e0e8e5653707d1d1cb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-23 15:25:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/35ef28dcd76944808854179ee6f2ed7d\n\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/5e751bbb4c9c4e55b29b57ee50814f16 : SUCCESS in 4m 46s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/6d1dcc84d3b740dbae9e03765ce2fb1e : SUCCESS in 4m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32f7c88bb27143619a3a3f21496b9596 : SUCCESS in 4m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0a147906fd294c538a2bfa633f1f2837 : SUCCESS in 5m 18s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/9e5d35f71dbc4fdb976bccf27b3e36ee : SUCCESS in 3m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2ed1de904fc942bc8bdecb55605db6d4 : SUCCESS in 6m 06s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/92bed75c26244a619e9ca68ea8acefa0 : SUCCESS in 6m 22s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/422561d73dde422493db12cb5f3e404c : SUCCESS in 1h 03m 59s","accounts_in_message":[],"_revision_number":2},{"id":"e4ee9c237738d83ab5a5032d666ff09b4f5ce249","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-23 15:25:51.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"bb55ef001250743bd27aa7f64bc3c94e2770f69a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-07-23 15:26:59.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f58cdea57ee24eb99941964419687264\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/74d28969d57e480ab5c6bdc509ea7897 : SUCCESS in 45s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/ccc747a34f2c4ac2b2975cafc02dd8ca : SUCCESS in 32s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"75696f8f3f3524f7e804b82e63280387215a23ec","revisions":{"06ddaf5cf0362261e3e1f94d3ef050d0c9fe8537":{"kind":"REWORK","_number":1,"created":"2024-06-22 23:25:24.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/65/922565/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/922565/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/1"}}},"commit":{"parents":[{"commit":"dd6ac285d5b35f87947f9c00f5558b55e9787747","subject":"Merge \"Identity: Migrate \u0027role assignment\u0027 commands to SDK\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dd6ac285d5b35f87947f9c00f5558b55e9787747"}]}],"author":{"name":"Brian Haley","email":"haleyb.dev@gmail.com","date":"2024-06-22 23:20:08.000000000","tz":-240},"committer":{"name":"Brian Haley","email":"haleyb.dev@gmail.com","date":"2024-06-22 23:20:08.000000000","tz":-240},"subject":"Add tests for \u0027default security group rule create\u0027","message":"Add tests for \u0027default security group rule create\u0027\n\nA previous change fixed a bug with the custom SG rule\nflag, but did not add any tests to verify all the\ncombinations of default and custom SG flags. Let\u0027s\nadd them now.\n\nChange-Id: Id74552346cfa975e3dd5eb45b8f621b365e88463\nRelated-bug: #2054629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/06ddaf5cf0362261e3e1f94d3ef050d0c9fe8537"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/06ddaf5cf0362261e3e1f94d3ef050d0c9fe8537"}]},"branch":"refs/heads/master"},"75696f8f3f3524f7e804b82e63280387215a23ec":{"kind":"REWORK","_number":2,"created":"2024-06-26 20:37:04.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/65/922565/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/922565/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/922565/2"}}},"commit":{"parents":[{"commit":"dd6ac285d5b35f87947f9c00f5558b55e9787747","subject":"Merge \"Identity: Migrate \u0027role assignment\u0027 commands to SDK\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dd6ac285d5b35f87947f9c00f5558b55e9787747"}]}],"author":{"name":"Brian Haley","email":"haleyb.dev@gmail.com","date":"2024-06-22 23:20:08.000000000","tz":-240},"committer":{"name":"Brian Haley","email":"haleyb.dev@gmail.com","date":"2024-06-26 20:36:32.000000000","tz":-240},"subject":"Add tests for \u0027default security group rule create\u0027","message":"Add tests for \u0027default security group rule create\u0027\n\nA previous change fixed a bug with the custom SG rule\nflag, but did not add any tests to verify all the\ncombinations of default and custom SG flags. Let\u0027s\nadd them now.\n\nChange-Id: Id74552346cfa975e3dd5eb45b8f621b365e88463\nRelated-bug: #2054629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/75696f8f3f3524f7e804b82e63280387215a23ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/75696f8f3f3524f7e804b82e63280387215a23ec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}