)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"30a524ad81542d86ba49ee6a1a7659feea3da72a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fb716cd_cafdd2a0","updated":"2024-06-27 13:41:05.000000000","message":"Looks good, I just have one question, as I don\u0027t see why some code change is necessary.","commit_id":"42b194749e1cdf5945c0205a11251a11acdc5819"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b1af7b91d4223ad1f21318f408437c77c85d7f8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fb55a26_3737e77a","updated":"2024-06-28 11:23:42.000000000","message":"Another one that would be easier if it was split into two parts: one to copy code from v2 and another to make changes. In this case though, the change is small enough to be okay.","commit_id":"ca81b1acf05d87871ae2c672d7900dfb67d52ec0"}],"openstackclient/volume/v2/service.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"30a524ad81542d86ba49ee6a1a7659feea3da72a","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    _description \u003d _(\"List service command\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_parser(self, prog_name):"},{"line_number":28,"context_line":"        parser \u003d self._get_parser(prog_name)"},{"line_number":29,"context_line":"        return parser"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"--host\","}],"source_content_type":"text/x-python","patch_set":1,"id":"42dd4884_cb7a1112","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":37},"updated":"2024-06-27 13:41:05.000000000","message":"?: What am I missing? This looks unnecessary.","commit_id":"42b194749e1cdf5945c0205a11251a11acdc5819"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2f811744c2d87642f6a4fcb3ced983dc88fe6e38","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    _description \u003d _(\"List service command\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_parser(self, prog_name):"},{"line_number":28,"context_line":"        parser \u003d self._get_parser(prog_name)"},{"line_number":29,"context_line":"        return parser"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"--host\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9d30a344_d7e050fe","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":37},"in_reply_to":"42dd4884_cb7a1112","updated":"2024-06-27 14:07:36.000000000","message":"Ah, i made this change thinking we needed an additional --cluster argument but later realized we didn\u0027t, will revert this","commit_id":"42b194749e1cdf5945c0205a11251a11acdc5819"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d4611a77cca97925c039468332e910db64f2aa1b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _description \u003d _(\"List service command\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def get_parser(self, prog_name):"},{"line_number":28,"context_line":"        parser \u003d self._get_parser(prog_name)"},{"line_number":29,"context_line":"        return parser"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super().get_parser(prog_name)"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \"--host\","}],"source_content_type":"text/x-python","patch_set":1,"id":"d09aba7e_06649653","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":37},"in_reply_to":"9d30a344_d7e050fe","updated":"2024-06-27 14:08:27.000000000","message":"Done","commit_id":"42b194749e1cdf5945c0205a11251a11acdc5819"}],"openstackclient/volume/v3/service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b1af7b91d4223ad1f21318f408437c77c85d7f8f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    def take_action(self, parsed_args):"},{"line_number":26,"context_line":"        service_client \u003d self.app.client_manager.volume"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        if parsed_args.long:"},{"line_number":29,"context_line":"            columns \u003d ["},{"line_number":30,"context_line":"                \"Binary\","},{"line_number":31,"context_line":"                \"Host\","},{"line_number":32,"context_line":"                \"Zone\","},{"line_number":33,"context_line":"                \"Status\","},{"line_number":34,"context_line":"                \"State\","},{"line_number":35,"context_line":"                \"Updated At\","},{"line_number":36,"context_line":"                \"Disabled Reason\","},{"line_number":37,"context_line":"            ]"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            columns \u003d ["},{"line_number":40,"context_line":"                \"Binary\","},{"line_number":41,"context_line":"                \"Host\","},{"line_number":42,"context_line":"                \"Zone\","},{"line_number":43,"context_line":"                \"Status\","},{"line_number":44,"context_line":"                \"State\","},{"line_number":45,"context_line":"                \"Updated At\","},{"line_number":46,"context_line":"            ]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if service_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.7\u0027):"},{"line_number":49,"context_line":"            columns.append(\"Cluster\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1d5e9067_11dde285","line":46,"range":{"start_line":28,"start_character":0,"end_line":46,"end_character":13},"updated":"2024-06-28 11:23:42.000000000","message":"nit:\n\n```\n            columns \u003d [\n                \"Binary\",\n                \"Host\",\n                \"Zone\",\n                \"Status\",\n                \"State\",\n                \"Updated At\",\n            ]\n            if parsed_args.long:\n                columns +\u003d [\"Disabled Reason\"]\n```\n\nThe `if parsed_args.long` bit should probably also go _after_ the microversion-specific checks below?","commit_id":"ca81b1acf05d87871ae2c672d7900dfb67d52ec0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1fa552f463a71476309c2ae70a3cb217d343bbaf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def take_action(self, parsed_args):"},{"line_number":26,"context_line":"        service_client \u003d self.app.client_manager.volume"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        if parsed_args.long:"},{"line_number":29,"context_line":"            columns \u003d ["},{"line_number":30,"context_line":"                \"Binary\","},{"line_number":31,"context_line":"                \"Host\","},{"line_number":32,"context_line":"                \"Zone\","},{"line_number":33,"context_line":"                \"Status\","},{"line_number":34,"context_line":"                \"State\","},{"line_number":35,"context_line":"                \"Updated At\","},{"line_number":36,"context_line":"                \"Disabled Reason\","},{"line_number":37,"context_line":"            ]"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            columns \u003d ["},{"line_number":40,"context_line":"                \"Binary\","},{"line_number":41,"context_line":"                \"Host\","},{"line_number":42,"context_line":"                \"Zone\","},{"line_number":43,"context_line":"                \"Status\","},{"line_number":44,"context_line":"                \"State\","},{"line_number":45,"context_line":"                \"Updated At\","},{"line_number":46,"context_line":"            ]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if service_client.api_version \u003e\u003d api_versions.APIVersion(\u00273.7\u0027):"},{"line_number":49,"context_line":"            columns.append(\"Cluster\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb477579_8a91cde4","line":46,"range":{"start_line":28,"start_character":0,"end_line":46,"end_character":13},"in_reply_to":"1d5e9067_11dde285","updated":"2024-06-28 15:06:18.000000000","message":"Done here https://review.opendev.org/c/openstack/python-openstackclient/+/923056","commit_id":"ca81b1acf05d87871ae2c672d7900dfb67d52ec0"}]}