)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a99b34f0d65c5befb57cd0fd2a06467ac3017b3c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-07 15:27:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the trunk subports informatrion to the port list command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added the subports information to the port list command, when the"},{"line_number":10,"context_line":"\"--long\" qualifier is specified."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"251bc111_001b58b5","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":35},"updated":"2024-08-22 14:35:13.000000000","message":"nit: information","commit_id":"bee8ab98fe730d334fbf5ae9c608d1f620b6f012"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a7207a3d0af5610989c10740d8e0c0787d6142c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-07 15:27:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the trunk subports informatrion to the port list command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added the subports information to the port list command, when the"},{"line_number":10,"context_line":"\"--long\" qualifier is specified."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"58a8ef6d_fecaf713","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":35},"in_reply_to":"251bc111_001b58b5","updated":"2024-09-20 08:14:55.000000000","message":"Done","commit_id":"bee8ab98fe730d334fbf5ae9c608d1f620b6f012"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a99b34f0d65c5befb57cd0fd2a06467ac3017b3c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Added the subports information to the port list command, when the"},{"line_number":10,"context_line":"\"--long\" qualifier is specified."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/926609"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2074187"},{"line_number":15,"context_line":"Change-Id: I8ef66c3415279caf0ebea4ba6232ca3696188de9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"27ebfaac_276bdbda","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":72},"updated":"2024-08-22 14:35:13.000000000","message":"strange that the sdk patch is necessary, but good idea otherwise, I check in details tomorrow","commit_id":"bee8ab98fe730d334fbf5ae9c608d1f620b6f012"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a7207a3d0af5610989c10740d8e0c0787d6142c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added the subports information to the port list command, when the"},{"line_number":10,"context_line":"\"--long\" qualifier is specified."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/926609"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2074187"},{"line_number":15,"context_line":"Change-Id: I8ef66c3415279caf0ebea4ba6232ca3696188de9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"87424e32_a56c80cc","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":72},"in_reply_to":"27ebfaac_276bdbda","updated":"2024-09-20 08:14:55.000000000","message":"Yes, we need this because the SDK resource \"port\" requires this new field to be printed. This field \"subports\" is a calculated field. Please check https://review.opendev.org/c/openstack/python-openstackclient/+/926611/comment/63f5000e_fac323c6/","commit_id":"bee8ab98fe730d334fbf5ae9c608d1f620b6f012"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c29bb836e4c959739ad1fdde009b718f0b3cd716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7c2ae590_5b3ca4d6","updated":"2024-12-17 12:20:33.000000000","message":"hi folks, any review is welcome, thanks!","commit_id":"98e45febf79d9d79bcfcbf54e709600cc17a9fd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dcbcc154b5ca41db6fdee357c5b2ab10a0e59d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8967ce99_bcc50fde","updated":"2025-01-17 11:36:41.000000000","message":"Thanks for addressing my concerns 🙏","commit_id":"2a0431e8255671824b9f938de94715f36bed48ba"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"738e9ae4d4b69c028d68b0c1f618e1f25face9ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e1e7f6c4_b1c71bbd","updated":"2025-01-13 16:37:47.000000000","message":"The SDK patch is already released","commit_id":"2a0431e8255671824b9f938de94715f36bed48ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"feaf642daee83aec28a0c5f4c6fd6e762d1683a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"abc0f7d9_361be7b2","updated":"2025-01-10 15:14:03.000000000","message":"ping fellow reviewers","commit_id":"2a0431e8255671824b9f938de94715f36bed48ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"575423a485c7953e88b02c2b4706c3c8205720b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2d2c42d0_41af391b","updated":"2025-01-18 10:02:22.000000000","message":"recheck osc-functional-devstack-tips","commit_id":"2a0431e8255671824b9f938de94715f36bed48ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e44922b21daba839028cdcfecd21e8a59f3146b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b2d79a08_9a82a98c","updated":"2025-01-17 14:04:45.000000000","message":"recheck osc-upload-image","commit_id":"2a0431e8255671824b9f938de94715f36bed48ba"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4ae93dbb8cd0559930181f87f135f8f7bcab85a3","unresolved":true,"context_lines":[{"line_number":842,"context_line":"            column_headers +\u003d (\u0027Security Groups\u0027,"},{"line_number":843,"context_line":"                               \u0027Device Owner\u0027,"},{"line_number":844,"context_line":"                               \u0027Tags\u0027,"},{"line_number":845,"context_line":"                               \u0027Subports\u0027,"},{"line_number":846,"context_line":"                               )"},{"line_number":847,"context_line":"        if parsed_args.device_owner is not None:"},{"line_number":848,"context_line":"            filters[\u0027device_owner\u0027] \u003d parsed_args.device_owner"}],"source_content_type":"text/x-python","patch_set":1,"id":"63f5000e_fac323c6","line":845,"updated":"2024-08-20 22:34:33.000000000","message":"Is there one missing? Or I\u0027m mis-understanding how things are displayed.","commit_id":"bee8ab98fe730d334fbf5ae9c608d1f620b6f012"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a7207a3d0af5610989c10740d8e0c0787d6142c6","unresolved":false,"context_lines":[{"line_number":842,"context_line":"            column_headers +\u003d (\u0027Security Groups\u0027,"},{"line_number":843,"context_line":"                               \u0027Device Owner\u0027,"},{"line_number":844,"context_line":"                               \u0027Tags\u0027,"},{"line_number":845,"context_line":"                               \u0027Subports\u0027,"},{"line_number":846,"context_line":"                               )"},{"line_number":847,"context_line":"        if parsed_args.device_owner is not None:"},{"line_number":848,"context_line":"            filters[\u0027device_owner\u0027] \u003d parsed_args.device_owner"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3b7d358_c588776f","line":845,"in_reply_to":"63f5000e_fac323c6","updated":"2024-09-20 08:14:55.000000000","message":"Yes. We use the \"columns\" field to retrieve the port information. \u0027trunk_details\u0027 is part of the port API information and is returned (\u0027subports\u0027 it isn\u0027t).\n\nThe \u0027subports\u0027 field is only part of the SDK \"port\" resource [1]. With the Neutron API call returned information (Neutron resource \"port.trunk_details\") we build the SDK resource \"port.subports\".\n\n[1]https://review.opendev.org/c/openstack/openstacksdk/+/926609","commit_id":"bee8ab98fe730d334fbf5ae9c608d1f620b6f012"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b0ecebd7b22d5d4be64b5efbbc51fd5047dc3e0","unresolved":true,"context_lines":[{"line_number":955,"context_line":"                utils.get_item_properties("},{"line_number":956,"context_line":"                    s,"},{"line_number":957,"context_line":"                    attrs,"},{"line_number":958,"context_line":"                    formatters\u003d_formatters,"},{"line_number":959,"context_line":"                )"},{"line_number":960,"context_line":"                for s in data"},{"line_number":961,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":7,"id":"8ca7cfd1_b22f4286","line":958,"updated":"2024-12-17 17:41:11.000000000","message":"I\u0027m not a massive fan of what you\u0027ve done with the custom resource class, `_Port`. Is there any reason we couldn\u0027t just have another formatter for the `trunk_details` field that simply extracted the `sub_ports` field from the object and wrapped it in a `ListDictColumn`? Heck, you could subclass `ListDictColumn` and just override `human_readable` and `machine_readable` to extract the value first.","commit_id":"98e45febf79d9d79bcfcbf54e709600cc17a9fd1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f4f9b24c8937fe4107ea4bc25d08ff7209becfdd","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                utils.get_item_properties("},{"line_number":956,"context_line":"                    s,"},{"line_number":957,"context_line":"                    attrs,"},{"line_number":958,"context_line":"                    formatters\u003d_formatters,"},{"line_number":959,"context_line":"                )"},{"line_number":960,"context_line":"                for s in data"},{"line_number":961,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfaefe1b_e0a7d5d9","line":958,"in_reply_to":"8ca7cfd1_b22f4286","updated":"2024-12-18 06:52:58.000000000","message":"So basically what I\u0027ve done here but in a \"container\" (a formatter class), right?","commit_id":"98e45febf79d9d79bcfcbf54e709600cc17a9fd1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"acd5369901480716aa34f24e267644300c585910","unresolved":true,"context_lines":[{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cliff import columns as cliff_columns"},{"line_number":22,"context_line":"from openstack.network.v2 import port as port_sdk"},{"line_number":23,"context_line":"from openstack import resource as resource_sdk"},{"line_number":24,"context_line":"from osc_lib.cli import format_columns"},{"line_number":25,"context_line":"from osc_lib.cli import parseractions"},{"line_number":26,"context_line":"from osc_lib.command import command"}],"source_content_type":"text/x-python","patch_set":9,"id":"c8ced722_6463f97b","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":46},"updated":"2024-12-18 11:08:00.000000000","message":"I think you want to drop these now?","commit_id":"60303329496eaf29c4d61fdfb7d0c45acae46348"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"23ab6686d56a233e4b254db41ac090436d8d47fa","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cliff import columns as cliff_columns"},{"line_number":22,"context_line":"from openstack.network.v2 import port as port_sdk"},{"line_number":23,"context_line":"from openstack import resource as resource_sdk"},{"line_number":24,"context_line":"from osc_lib.cli import format_columns"},{"line_number":25,"context_line":"from osc_lib.cli import parseractions"},{"line_number":26,"context_line":"from osc_lib.command import command"}],"source_content_type":"text/x-python","patch_set":9,"id":"255e251f_f1e55d5e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":46},"in_reply_to":"c8ced722_6463f97b","updated":"2024-12-18 14:04:43.000000000","message":"Right!","commit_id":"60303329496eaf29c4d61fdfb7d0c45acae46348"}]}