)]}'
{"id":"openstack%2Fpython-openstackclient~927490","triplet_id":"openstack%2Fpython-openstackclient~master~If81c7055e9ef692425da2789bae18a96d04b104f","project":"openstack/python-openstackclient","branch":"master","topic":"ruff","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2024-09-11 19:36:21.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"If81c7055e9ef692425da2789bae18a96d04b104f","subject":"pre-commit: Migrate from flake8 to ruff","status":"MERGED","created":"2024-08-29 09:59:58.000000000","updated":"2024-09-11 21:16:44.000000000","submitted":"2024-09-11 21:16:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"927490-ruff","meta_rev_id":"bea026407d1a6aebbbf21744d5b4f508156de244","_number":927490,"virtual_id_number":927490,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-09-11 21:16:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-09-11 19:36:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-09-11 19:36:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-29 11:19:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3e6042611c4a01c4c14fef0538818f14863d5865","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-08-29 09:59:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de10b8431ee6f8479a435361bee198be26370a03","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-29 11:19:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/2e05310db4fc453580d10ef663476043\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/843f0cc132b74beb9dbdeb930262e85f : FAILURE in 5m 24s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/99850bd41d5345c5b188d5a1deec740c : FAILURE in 4m 56s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/ce4988f138e246e59c790f7667914960 : FAILURE in 5m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d3697abc57c94839b0835021c3361ab3 : FAILURE in 3m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8f486554edfa488788c07c5694fd7876 : SUCCESS in 3m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e93ed6977bd8444ea054a38ea51c0f2c : FAILURE in 3m 29s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8f8c45b726274bf39b5906cdeffa7ca0 : FAILURE in 3m 22s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/145c2192e6264484b28fbf7ed030bb1d : FAILURE in 3m 30s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/faa8bc6881e4429da5ce7a4c366fb426 : SUCCESS in 5m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7a2a85d986bb486abfa7960bf3770590 : SUCCESS in 3m 51s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/f8ee7638625c411f8216bc2408c9db1f : SUCCESS in 7m 31s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/320357cf5e8a4095ae742f22ac0a81c4 : SUCCESS in 1h 00m 16s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/6b52f6d6a1b1496e8340abe44875e5b7 : SUCCESS in 1h 11m 53s","accounts_in_message":[],"_revision_number":1},{"id":"a6a577db864e076e783365f8b7bf03e04524e12a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-08-29 14:56:15.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"b2062ca4b9498a7c24561a560cd5881c7e6b3a6f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-29 16:13:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/014bdb922339494ea2ff158827ee4a34\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/fb1ffd8e419e446fb5c1aa7cc20b7345 : FAILURE in 9m 54s (non-voting)\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/18c0bf96a6734d639af5a388150299d6 : SUCCESS in 6m 16s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/be25185c92ed4b09b1b99ac904b2c3da : SUCCESS in 5m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cbfb5c9865c84f22a024107f5032c5c1 : SUCCESS in 4m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6b97dcb536984f2ca4f2f2bc25705093 : SUCCESS in 3m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/465cde95c3954d4b9971d6d4ed973b3a : SUCCESS in 3m 57s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/7ec3d971bf9d4b89a4e95d46f51c8594 : SUCCESS in 3m 45s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/5db1a74284e340af9c2c9ecb460371a9 : SUCCESS in 3m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/07af3ca124b44d778c33666f823af19b : SUCCESS in 4m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a3a45960b1204a7daed952117a3e179d : SUCCESS in 3m 42s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/73044ad05a60414a8ab9f644f6c6e175 : SUCCESS in 5m 56s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/9ef2f78a4a90427eabb35b4efac30e28 : SUCCESS in 1h 10m 50s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/5b8cbe05013b40df86e4f30928f4fa86 : SUCCESS in 1h 08m 44s","accounts_in_message":[],"_revision_number":2},{"id":"f9e745d4a414b41b47047a02cb89a4c6abc54a87","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-09-11 19:36:21.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"1ebd4d969fb66a62fae4ea7d6e13d841ac8b1375","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-11 19:37:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"883f7a312cb0679a0ca67fedbb8780a4a3e16cc8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-11 21:16:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2bc0ead3e58f4835be2ca8af33542c18\n\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/11153e9a33b940e49b40aceb15905e81 : SUCCESS in 5m 40s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/296dffd516ec4b8bae48e381f0640aec : SUCCESS in 7m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3a2c610e337d4f8f95b1cd1acbbf5247 : SUCCESS in 4m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1bf6281f61294056ac95116fa6a3a066 : SUCCESS in 4m 18s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/11b7032c77ca4a43a5c2c644d7b753cb : SUCCESS in 5m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5c391cf2013408f8302da2702c3d5cb : SUCCESS in 8m 38s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/004db5fbebf34a01b888df7493feb29c : SUCCESS in 4m 11s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/cc8e5e4b9c6b4bf18511398997b9ef38 : SUCCESS in 7m 56s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/f0048f6ff77c43c5a3732e435b5831cf : SUCCESS in 53m 28s","accounts_in_message":[],"_revision_number":2},{"id":"bea026407d1a6aebbbf21744d5b4f508156de244","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-11 21:16:44.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2ba90581d5d68c565347b6c3aa16faf4b6478f2d","revisions":{"d43ade7aaafe5f4ed2dae30c8f650e3b92449f2b":{"kind":"REWORK","_number":1,"created":"2024-08-29 09:59:58.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/90/927490/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/927490/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/1"}}},"commit":{"parents":[{"commit":"869b07ededc5b8bee5669ebd877c3fd3c543a464","subject":"pre-commit: Bump versions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/869b07ededc5b8bee5669ebd877c3fd3c543a464"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-08-29 09:53:30.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-08-29 09:59:04.000000000","tz":60},"subject":"pre-commit: Migrate from flake8 to ruff","message":"pre-commit: Migrate from flake8 to ruff\n\nWell, mostly. We still keep our own flake8 hooks and the hacking hooks\nenabled. Everything else can be handled by ruff.\n\nDoing this enables a couple of hacking checks that were previously\nunaddressed. It also highlights a few cases that flake8 missed. Both are\naddressed.\n\nChange-Id: If81c7055e9ef692425da2789bae18a96d04b104f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d43ade7aaafe5f4ed2dae30c8f650e3b92449f2b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d43ade7aaafe5f4ed2dae30c8f650e3b92449f2b"}]},"branch":"refs/heads/master"},"2ba90581d5d68c565347b6c3aa16faf4b6478f2d":{"kind":"REWORK","_number":2,"created":"2024-08-29 14:56:15.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/90/927490/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/927490/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/927490/2"}}},"commit":{"parents":[{"commit":"869b07ededc5b8bee5669ebd877c3fd3c543a464","subject":"pre-commit: Bump versions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/869b07ededc5b8bee5669ebd877c3fd3c543a464"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-08-29 09:53:30.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-08-29 14:55:13.000000000","tz":60},"subject":"pre-commit: Migrate from flake8 to ruff","message":"pre-commit: Migrate from flake8 to ruff\n\nWell, mostly. We still keep our own flake8 hooks and the hacking hooks\nenabled. Everything else can be handled by ruff.\n\nDoing this enables a couple of hacking checks that were previously\nunaddressed. It also highlights a few cases that flake8 missed. Both are\naddressed.\n\nChange-Id: If81c7055e9ef692425da2789bae18a96d04b104f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2ba90581d5d68c565347b6c3aa16faf4b6478f2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2ba90581d5d68c565347b6c3aa16faf4b6478f2d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}