)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"71658c2fec054a9fe436290d31d4c042df2d2663","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawek Kaplonski \u003cskaplons@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-10 19:49:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"trusted\" attribut to the \"port\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/927723"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6e36a2d0_feed4d87","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":22},"updated":"2024-09-11 10:54:32.000000000","message":"nit: attribute","commit_id":"4f5cb3d0714f426ab5c6485f760e25b50a856dbc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"036a97a07b14550163ad9021c59304e5ee7c8642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5be33cf_1e95eec0","updated":"2024-09-10 18:25:45.000000000","message":"recheck - new PS in the depends on patch","commit_id":"4f5cb3d0714f426ab5c6485f760e25b50a856dbc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"da5dda0e3993c11f0d8617964158bb5b4f90a42e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"27272e93_55590b0d","updated":"2024-11-04 13:58:10.000000000","message":"recheck\nfunctional job failure is not related (quota check compute test)","commit_id":"47144103cabf11edb108ae80f700ea936bf50b30"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7ecc390552301117bdeaeef8b25bd06ca336bb72","unresolved":true,"context_lines":[{"line_number":594,"context_line":"                \u0027attached to the network backend\u0027"},{"line_number":595,"context_line":"            ),"},{"line_number":596,"context_line":"        )"},{"line_number":597,"context_line":"        port_trusted \u003d parser.add_mutually_exclusive_group()"},{"line_number":598,"context_line":"        port_trusted.add_argument("},{"line_number":599,"context_line":"            \u0027--trusted\u0027,"},{"line_number":600,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":601,"context_line":"            help\u003d_("},{"line_number":602,"context_line":"                \"Set port to be trusted. This will be populated into the \""},{"line_number":603,"context_line":"                \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":604,"context_line":"                \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":605,"context_line":"            ),"},{"line_number":606,"context_line":"        )"},{"line_number":607,"context_line":"        port_trusted.add_argument("},{"line_number":608,"context_line":"            \u0027--no-trusted\u0027,"},{"line_number":609,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":610,"context_line":"            help\u003d_("},{"line_number":611,"context_line":"                \"Set port to be not trusted. This will be populated into the \""},{"line_number":612,"context_line":"                \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":613,"context_line":"                \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":614,"context_line":"            ),"},{"line_number":615,"context_line":"        )"},{"line_number":616,"context_line":"        _tag.add_tag_option_to_parser_for_create(parser, _(\u0027port\u0027))"},{"line_number":617,"context_line":"        return parser"},{"line_number":618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1beec875_4c2af75f","line":615,"range":{"start_line":597,"start_character":8,"end_line":615,"end_character":9},"updated":"2024-09-04 08:50:57.000000000","message":"Instead of adding twice --trusted/--no-trusted, you can define it once in ``_add_updatable_args``","commit_id":"d9b8207b31e4bb49917027f308c3494a4ab26bf3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f45766261c9eec52a066ff114387f5692cad44b8","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                \u0027attached to the network backend\u0027"},{"line_number":595,"context_line":"            ),"},{"line_number":596,"context_line":"        )"},{"line_number":597,"context_line":"        port_trusted \u003d parser.add_mutually_exclusive_group()"},{"line_number":598,"context_line":"        port_trusted.add_argument("},{"line_number":599,"context_line":"            \u0027--trusted\u0027,"},{"line_number":600,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":601,"context_line":"            help\u003d_("},{"line_number":602,"context_line":"                \"Set port to be trusted. This will be populated into the \""},{"line_number":603,"context_line":"                \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":604,"context_line":"                \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":605,"context_line":"            ),"},{"line_number":606,"context_line":"        )"},{"line_number":607,"context_line":"        port_trusted.add_argument("},{"line_number":608,"context_line":"            \u0027--no-trusted\u0027,"},{"line_number":609,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":610,"context_line":"            help\u003d_("},{"line_number":611,"context_line":"                \"Set port to be not trusted. This will be populated into the \""},{"line_number":612,"context_line":"                \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":613,"context_line":"                \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":614,"context_line":"            ),"},{"line_number":615,"context_line":"        )"},{"line_number":616,"context_line":"        _tag.add_tag_option_to_parser_for_create(parser, _(\u0027port\u0027))"},{"line_number":617,"context_line":"        return parser"},{"line_number":618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f1662601_9c1cb0da","line":615,"range":{"start_line":597,"start_character":8,"end_line":615,"end_character":9},"in_reply_to":"1beec875_4c2af75f","updated":"2024-09-08 16:57:41.000000000","message":"Done","commit_id":"d9b8207b31e4bb49917027f308c3494a4ab26bf3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ec34781837cbdaf336be2e30f3a19bb5c1e8d80","unresolved":true,"context_lines":[{"line_number":393,"context_line":"            \u0027(repeat option to set multiple hints)\u0027"},{"line_number":394,"context_line":"        ),"},{"line_number":395,"context_line":"    )"},{"line_number":396,"context_line":"    port_trusted \u003d parser.add_mutually_exclusive_group()"},{"line_number":397,"context_line":"    port_trusted.add_argument("},{"line_number":398,"context_line":"        \u0027--trusted\u0027,"},{"line_number":399,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4769efcf_0bf192c7","line":396,"updated":"2024-09-09 18:25:46.000000000","message":"Why are we using two items below - trusted and no_trusted, and instead just using a single value with store_true/store_false ? Is it just because we don\u0027t want to pass anything for the field if not specified? Basing my comment on looking at Nova server.py code.","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"022056d705d4dec1580718910908f7f859387f60","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            \u0027(repeat option to set multiple hints)\u0027"},{"line_number":394,"context_line":"        ),"},{"line_number":395,"context_line":"    )"},{"line_number":396,"context_line":"    port_trusted \u003d parser.add_mutually_exclusive_group()"},{"line_number":397,"context_line":"    port_trusted.add_argument("},{"line_number":398,"context_line":"        \u0027--trusted\u0027,"},{"line_number":399,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f5a5fc1_fbbfc04d","line":396,"in_reply_to":"4769efcf_0bf192c7","updated":"2024-09-10 17:49:15.000000000","message":"yes, I don\u0027t want to send anything if it is not specifiec. That\u0027s why I did it that way.","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ec34781837cbdaf336be2e30f3a19bb5c1e8d80","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        help\u003d_("},{"line_number":401,"context_line":"            \"Set port to be trusted. This will be populated into the \""},{"line_number":402,"context_line":"            \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":403,"context_line":"            \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":404,"context_line":"        ),"},{"line_number":405,"context_line":"    )"},{"line_number":406,"context_line":"    port_trusted.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"574e8a8a_3ed1a9e2","line":403,"range":{"start_line":403,"start_character":19,"end_line":403,"end_character":26},"updated":"2024-09-09 18:25:46.000000000","message":"super nit: expect\n\nsame below","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ec34781837cbdaf336be2e30f3a19bb5c1e8d80","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        help\u003d_("},{"line_number":401,"context_line":"            \"Set port to be trusted. This will be populated into the \""},{"line_number":402,"context_line":"            \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":403,"context_line":"            \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":404,"context_line":"        ),"},{"line_number":405,"context_line":"    )"},{"line_number":406,"context_line":"    port_trusted.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"509eda3a_4929b4ae","line":403,"range":{"start_line":403,"start_character":50,"end_line":403,"end_character":64},"updated":"2024-09-09 18:25:46.000000000","message":"super nit: we use both \u0027e.g.\u0027 and \u0027for example\u0027 in files here, typically the former, but in this file on L315 we use the latter. So since I\u0027m nit picking once might as well do both :) so I\u0027d do this:\n\n... dictionary (for example, Nova).\n\nsame below","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"022056d705d4dec1580718910908f7f859387f60","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        help\u003d_("},{"line_number":401,"context_line":"            \"Set port to be trusted. This will be populated into the \""},{"line_number":402,"context_line":"            \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":403,"context_line":"            \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":404,"context_line":"        ),"},{"line_number":405,"context_line":"    )"},{"line_number":406,"context_line":"    port_trusted.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"bbe4d733_0eef4634","line":403,"range":{"start_line":403,"start_character":50,"end_line":403,"end_character":64},"in_reply_to":"509eda3a_4929b4ae","updated":"2024-09-10 17:49:15.000000000","message":"Done","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"022056d705d4dec1580718910908f7f859387f60","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        help\u003d_("},{"line_number":401,"context_line":"            \"Set port to be trusted. This will be populated into the \""},{"line_number":402,"context_line":"            \"\u0027binding:profile\u0027 dictionary and passed to the services \""},{"line_number":403,"context_line":"            \"which expects it in this dictionary, like e.g. Nova\""},{"line_number":404,"context_line":"        ),"},{"line_number":405,"context_line":"    )"},{"line_number":406,"context_line":"    port_trusted.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"f04c4a4b_cc517e35","line":403,"range":{"start_line":403,"start_character":19,"end_line":403,"end_character":26},"in_reply_to":"574e8a8a_3ed1a9e2","updated":"2024-09-10 17:49:15.000000000","message":"Done","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3ec34781837cbdaf336be2e30f3a19bb5c1e8d80","unresolved":true,"context_lines":[{"line_number":404,"context_line":"        ),"},{"line_number":405,"context_line":"    )"},{"line_number":406,"context_line":"    port_trusted.add_argument("},{"line_number":407,"context_line":"        \u0027--no-trusted\u0027,"},{"line_number":408,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":409,"context_line":"        help\u003d_("},{"line_number":410,"context_line":"            \"Set port to be not trusted. This will be populated into the \""}],"source_content_type":"text/x-python","patch_set":2,"id":"d0496ff3_ba28cd1e","line":407,"range":{"start_line":407,"start_character":9,"end_line":407,"end_character":21},"updated":"2024-09-09 18:25:46.000000000","message":"I think this should be \u0027--not-trusted\u0027","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"022056d705d4dec1580718910908f7f859387f60","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        ),"},{"line_number":405,"context_line":"    )"},{"line_number":406,"context_line":"    port_trusted.add_argument("},{"line_number":407,"context_line":"        \u0027--no-trusted\u0027,"},{"line_number":408,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":409,"context_line":"        help\u003d_("},{"line_number":410,"context_line":"            \"Set port to be not trusted. This will be populated into the \""}],"source_content_type":"text/x-python","patch_set":2,"id":"2c011eec_2f7a32e1","line":407,"range":{"start_line":407,"start_character":9,"end_line":407,"end_character":21},"in_reply_to":"d0496ff3_ba28cd1e","updated":"2024-09-10 17:49:15.000000000","message":"you\u0027re right, changed","commit_id":"e803a5539c8e450b2396c5509ea84f7eec13fd2f"}],"releasenotes/notes/Add-trusted-vif-to-the-port-0a0c76d9da8f3da0.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f723bff39de4477d516c4c145ba40c914f45ebe6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``trusted`` attribute to the ``port create`` and ``port set`` commands."},{"line_number":5,"context_line":"    It can be set to ``true`` with ``--trusted`` and to ``false`` with"},{"line_number":6,"context_line":"    ``--no-trusted`` CLI arguments passed to the ``port create`` and ``port"},{"line_number":7,"context_line":"    set`` commands``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"30d6021e_88d3dad6","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":18},"updated":"2024-10-02 14:51:59.000000000","message":"s/--not-trusted","commit_id":"dcf75d067b4f214502eebf4c2e9e2699142dcb7f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"246300a28e49a80fa2d0ec4ca860c2fdeea0e83e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``trusted`` attribute to the ``port create`` and ``port set`` commands."},{"line_number":5,"context_line":"    It can be set to ``true`` with ``--trusted`` and to ``false`` with"},{"line_number":6,"context_line":"    ``--no-trusted`` CLI arguments passed to the ``port create`` and ``port"},{"line_number":7,"context_line":"    set`` commands``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e2aa397f_ba9f76fc","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":18},"in_reply_to":"30d6021e_88d3dad6","updated":"2024-11-04 09:13:09.000000000","message":"Done","commit_id":"dcf75d067b4f214502eebf4c2e9e2699142dcb7f"}]}