)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"07df5dbf320cc59eedcdc7dd8045f64a7fe312f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10118ef7_a638c7bf","updated":"2024-09-17 15:17:55.000000000","message":"Giving +2 to getting the fix merged, we can discuss consistency later if needed.","commit_id":"033793aa0e96e3b8c8e729ff8fa67a9a37029e55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4578427e62f26f85cf0442031b6ca19ec787de70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b17eb181_b9014932","updated":"2024-09-25 05:11:13.000000000","message":"recheck not sure about the quota failure, might be unstable?","commit_id":"033793aa0e96e3b8c8e729ff8fa67a9a37029e55"}],"openstackclient/identity/v3/user.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3723108521a0db5a154e7c72f742d50ac85b7a55","unresolved":true,"context_lines":[{"line_number":267,"context_line":"            kwargs[\u0027default_project_id\u0027] \u003d identity_client.find_project("},{"line_number":268,"context_line":"                name_or_id\u003dparsed_args.project,"},{"line_number":269,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":270,"context_line":"                domain_id\u003dproject_domain_id,"},{"line_number":271,"context_line":"            ).id"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if parsed_args.description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1610cb29_fcb23bd8","line":270,"updated":"2024-09-16 15:03:44.000000000","message":"So it looks to me like there was another bug in the old code that is getting fixed here, namely that domain_id was being used to find the project instead of project_domain? Does is make sense to mention this in the commit message? Also maybe add a test case to cover this?","commit_id":"6dd4779a8c6612f8673b69e5772a8604a12cccf8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4318dbee168d4c07fb0b4eb35178a15bc0b5e132","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            kwargs[\u0027default_project_id\u0027] \u003d identity_client.find_project("},{"line_number":268,"context_line":"                name_or_id\u003dparsed_args.project,"},{"line_number":269,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":270,"context_line":"                domain_id\u003dproject_domain_id,"},{"line_number":271,"context_line":"            ).id"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if parsed_args.description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"32b31792_9cbe0098","line":270,"in_reply_to":"1610cb29_fcb23bd8","updated":"2024-09-16 16:32:26.000000000","message":"Good point. Added a note to the commit message and expanded a test case to ensure we\u0027re calling `find_domain` with the correct argument.","commit_id":"6dd4779a8c6612f8673b69e5772a8604a12cccf8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3723108521a0db5a154e7c72f742d50ac85b7a55","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        except sdk_exc.ConflictException:"},{"line_number":308,"context_line":"            if parsed_args.or_show:"},{"line_number":309,"context_line":"                if domain_id:"},{"line_number":310,"context_line":"                    kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"                user \u003d identity_client.find_user("},{"line_number":313,"context_line":"                    name_or_id\u003dparsed_args.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd54172d_d004dd14","line":310,"updated":"2024-09-16 15:03:44.000000000","message":"This doesn\u0027t make sense to me, kwargs isn\u0027t used anymore below? This also just repeats what was set above?","commit_id":"6dd4779a8c6612f8673b69e5772a8604a12cccf8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4318dbee168d4c07fb0b4eb35178a15bc0b5e132","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        except sdk_exc.ConflictException:"},{"line_number":308,"context_line":"            if parsed_args.or_show:"},{"line_number":309,"context_line":"                if domain_id:"},{"line_number":310,"context_line":"                    kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"                user \u003d identity_client.find_user("},{"line_number":313,"context_line":"                    name_or_id\u003dparsed_args.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"78796f06_0af03e84","line":310,"in_reply_to":"6b91c556_862c9396","updated":"2024-09-16 16:32:26.000000000","message":"Done","commit_id":"6dd4779a8c6612f8673b69e5772a8604a12cccf8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"07df5dbf320cc59eedcdc7dd8045f64a7fe312f6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        except sdk_exc.ConflictException:"},{"line_number":308,"context_line":"            if parsed_args.or_show:"},{"line_number":309,"context_line":"                if domain_id:"},{"line_number":310,"context_line":"                    kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"                user \u003d identity_client.find_user("},{"line_number":313,"context_line":"                    name_or_id\u003dparsed_args.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"76fa3d32_bbdaf6e4","line":310,"in_reply_to":"78796f06_0af03e84","updated":"2024-09-17 15:17:55.000000000","message":"ah, that\u0027s more reasonable now, thx","commit_id":"6dd4779a8c6612f8673b69e5772a8604a12cccf8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"594b5d8ba2b09e227e28b887968881ee24fd3665","unresolved":true,"context_lines":[{"line_number":307,"context_line":"        except sdk_exc.ConflictException:"},{"line_number":308,"context_line":"            if parsed_args.or_show:"},{"line_number":309,"context_line":"                if domain_id:"},{"line_number":310,"context_line":"                    kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"                user \u003d identity_client.find_user("},{"line_number":313,"context_line":"                    name_or_id\u003dparsed_args.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b91c556_862c9396","line":310,"in_reply_to":"cd54172d_d004dd14","updated":"2024-09-16 16:07:31.000000000","message":"whoops, I did not complete this","commit_id":"6dd4779a8c6612f8673b69e5772a8604a12cccf8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"5083cf26b3552d74056c3ed684c0906453c918a5","unresolved":true,"context_lines":[{"line_number":260,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if parsed_args.project:"},{"line_number":263,"context_line":"            project_domain_id \u003d identity_client.find_domain("},{"line_number":264,"context_line":"                parsed_args.project_domain,"},{"line_number":265,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":266,"context_line":"            ).id"}],"source_content_type":"text/x-python","patch_set":2,"id":"c6a50d45_296ba730","line":263,"updated":"2024-09-17 12:11:01.000000000","message":"I just foresee how many people will start again complaining they are now broken. project_domain is an optional parameter and may be absent. Current code would use the passed domain (an to be honest chances somebody is going to use project from a different domain here is terribly low). I suggest making it backwards compatible and use project_domain with a fallback at domain if not set.\n\nIt would have been so much easier for everybody if users would be explicit in what they mean and sdk/cli just require being absolutely explicit to avoid this sort of guessing (always missing for some group of users).","commit_id":"ed894472fda080cde82fa30d46384dd0ed2d8236"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"105b7e3cecd04f8fef3127195f4f0765a9dbbc77","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if parsed_args.project:"},{"line_number":263,"context_line":"            project_domain_id \u003d identity_client.find_domain("},{"line_number":264,"context_line":"                parsed_args.project_domain,"},{"line_number":265,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":266,"context_line":"            ).id"}],"source_content_type":"text/x-python","patch_set":2,"id":"993f3b5e_6e6d3be0","line":263,"in_reply_to":"696673c5_21b097e5","updated":"2024-09-17 12:30:49.000000000","message":"fwiw, we previously used the `--project-domain` option but regressed that in the same change so I\u0027m actually fixing two bugs from the same patch here.","commit_id":"ed894472fda080cde82fa30d46384dd0ed2d8236"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"07df5dbf320cc59eedcdc7dd8045f64a7fe312f6","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if parsed_args.project:"},{"line_number":263,"context_line":"            project_domain_id \u003d identity_client.find_domain("},{"line_number":264,"context_line":"                parsed_args.project_domain,"},{"line_number":265,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":266,"context_line":"            ).id"}],"source_content_type":"text/x-python","patch_set":2,"id":"80117224_4be308da","line":263,"in_reply_to":"993f3b5e_6e6d3be0","updated":"2024-09-17 15:17:55.000000000","message":"Looking at https://docs.openstack.org/api-ref/identity/v3/index.html#users , this option should really be called --default-project I think, to make clearer that this doesn\u0027t do anything in the way of actually associating the user with a role in that project. But that\u0027s likely a topic for another patch.","commit_id":"ed894472fda080cde82fa30d46384dd0ed2d8236"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eca3f490f7a245338729e9ef53414fa16083b499","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            kwargs[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if parsed_args.project:"},{"line_number":263,"context_line":"            project_domain_id \u003d identity_client.find_domain("},{"line_number":264,"context_line":"                parsed_args.project_domain,"},{"line_number":265,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":266,"context_line":"            ).id"}],"source_content_type":"text/x-python","patch_set":2,"id":"696673c5_21b097e5","line":263,"in_reply_to":"c6a50d45_296ba730","updated":"2024-09-17 12:30:01.000000000","message":"You\u0027re right, this should be optional.","commit_id":"ed894472fda080cde82fa30d46384dd0ed2d8236"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"07df5dbf320cc59eedcdc7dd8045f64a7fe312f6","unresolved":true,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        domain_id \u003d None"},{"line_number":255,"context_line":"        if parsed_args.domain:"},{"line_number":256,"context_line":"            domain_id \u003d identity_client.find_domain("},{"line_number":257,"context_line":"                parsed_args.domain,"},{"line_number":258,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":259,"context_line":"            ).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"62b059e6_560958af","line":256,"updated":"2024-09-17 15:17:55.000000000","message":"I just stumpled upon this when comparing calls, other identity code uses\n\n```\ncommon.find_domain(identity_client, ...)\n```\n\nnot sure which one is better, but maybe do the same thing everywhere for consistency?","commit_id":"033793aa0e96e3b8c8e729ff8fa67a9a37029e55"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e0c7aece2a6a30e59dd1ce6e9726b2cab75e0bd","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        domain_id \u003d None"},{"line_number":255,"context_line":"        if parsed_args.domain:"},{"line_number":256,"context_line":"            domain_id \u003d identity_client.find_domain("},{"line_number":257,"context_line":"                parsed_args.domain,"},{"line_number":258,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":259,"context_line":"            ).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b4c8ea6_7655fbe9","line":256,"in_reply_to":"62b059e6_560958af","updated":"2024-09-18 12:38:53.000000000","message":"That only works with `keystoneclient`, not `openstacksdk`, so we can\u0027t use that here. Eventually all those helpers methods will go away.","commit_id":"033793aa0e96e3b8c8e729ff8fa67a9a37029e55"}]}