)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fe108513_8ace6d9a","updated":"2024-11-12 12:14:34.000000000","message":"bit of work still needed here","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3dac9d7f708417c569572cdc3dab08580deafe2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7e49cb4f_ff949f96","updated":"2024-12-10 15:43:02.000000000","message":"recheck quota failure in functional test\n\nGood work here","commit_id":"cda857da6e940139fc175475412ae4a80fc60d14"}],"openstackclient/identity/v3/service_provider.py":[{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"8fd392f835e1df29e6597b7b5b075ab0aa84927c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"            \u0027Enabled\u0027,"},{"line_number":92,"context_line":"            \u0027Description\u0027,"},{"line_number":93,"context_line":"            \u0027Auth URL\u0027,"},{"line_number":94,"context_line":"            \u0027Service Provider URL\u0027,"},{"line_number":95,"context_line":"        )"},{"line_number":96,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":97,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"14d1bf6a_38533ee6","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":33},"updated":"2024-09-19 17:57:54.000000000","message":"Should we be sending the sp url as well? It\u0027s in some tests but not in any of these resource definitions. I added them for now to have consistency.","commit_id":"8483ea7bc5ef1d8e0242ded1484401db3da72178"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"c36f22ee300e87637faa8c2cae06196c91c91148","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \u0027Enabled\u0027,"},{"line_number":92,"context_line":"            \u0027Description\u0027,"},{"line_number":93,"context_line":"            \u0027Auth URL\u0027,"},{"line_number":94,"context_line":"            \u0027Service Provider URL\u0027,"},{"line_number":95,"context_line":"        )"},{"line_number":96,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":97,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":1,"id":"e09ee1e0_17d690f5","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":33},"in_reply_to":"14d1bf6a_38533ee6","updated":"2024-10-01 16:42:40.000000000","message":"Done","commit_id":"8483ea7bc5ef1d8e0242ded1484401db3da72178"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        )"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        enable_service_provider \u003d parser.add_mutually_exclusive_group()"},{"line_number":63,"context_line":"        enable_service_provider.add_argument("},{"line_number":64,"context_line":"            \u0027--enable\u0027,"},{"line_number":65,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":66,"context_line":"            default\u003dTrue,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Enable the service provider (default)\u0027),"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":"        enable_service_provider.add_argument("},{"line_number":70,"context_line":"            \u0027--disable\u0027,"},{"line_number":71,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":72,"context_line":"            help\u003d_(\u0027Disable the service provider\u0027),"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return parser"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fe0bf0e_862f74c6","line":73,"range":{"start_line":63,"start_character":0,"end_line":73,"end_character":9},"updated":"2024-11-12 12:14:34.000000000","message":"You actually want to keep the common `dest` since it\u0027ll make your life easier below.\n\n```suggestion\n        enable_service_provider.add_argument(\n            \u0027--enable\u0027,\n            dest\u003d\u0027is_enabled\u0027,\n            action\u003d\u0027store_true\u0027,\n            default\u003dNone,\n            help\u003d_(\u0027Enable the service provider (default)\u0027),\n        )\n        enable_service_provider.add_argument(\n            \u0027--disable\u0027,\n            dest\u003d\u0027is_enabled\u0027,\n            action\u003d\u0027store_false\u0027,\n            default\u003dNone,\n            help\u003d_(\u0027Disable the service provider\u0027),\n        )\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        )"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        enable_service_provider \u003d parser.add_mutually_exclusive_group()"},{"line_number":63,"context_line":"        enable_service_provider.add_argument("},{"line_number":64,"context_line":"            \u0027--enable\u0027,"},{"line_number":65,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":66,"context_line":"            default\u003dTrue,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Enable the service provider (default)\u0027),"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":"        enable_service_provider.add_argument("},{"line_number":70,"context_line":"            \u0027--disable\u0027,"},{"line_number":71,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":72,"context_line":"            help\u003d_(\u0027Disable the service provider\u0027),"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return parser"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"32eb4b2a_071acded","line":73,"range":{"start_line":63,"start_character":0,"end_line":73,"end_character":9},"in_reply_to":"9fe0bf0e_862f74c6","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    def take_action(self, parsed_args):"},{"line_number":78,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        kwargs \u003d {}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if parsed_args.service_provider_id:"},{"line_number":83,"context_line":"            kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        enabled \u003d True"},{"line_number":86,"context_line":"        if parsed_args.disable is True:"}],"source_content_type":"text/x-python","patch_set":4,"id":"0f920791_0b1f3f12","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":58},"updated":"2024-11-12 12:14:34.000000000","message":"This is a mandatory parameter so the `if` shouldn\u0027t be necessary?\n\n\n```suggestion\n        kwargs \u003d {\n            \u0027id\u0027: parsed_args.service_provider_id,\n        }\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def take_action(self, parsed_args):"},{"line_number":78,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        kwargs \u003d {}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if parsed_args.service_provider_id:"},{"line_number":83,"context_line":"            kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        enabled \u003d True"},{"line_number":86,"context_line":"        if parsed_args.disable is True:"}],"source_content_type":"text/x-python","patch_set":4,"id":"62f862f7_69c43408","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":58},"in_reply_to":"0f920791_0b1f3f12","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        if parsed_args.service_provider_id:"},{"line_number":83,"context_line":"            kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        enabled \u003d True"},{"line_number":86,"context_line":"        if parsed_args.disable is True:"},{"line_number":87,"context_line":"            enabled \u003d False"},{"line_number":88,"context_line":"        kwargs[\u0027is_enabled\u0027] \u003d enabled"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if parsed_args.description:"},{"line_number":91,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"}],"source_content_type":"text/x-python","patch_set":4,"id":"326ac8a9_2aa65622","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":38},"updated":"2024-11-12 12:14:34.000000000","message":"```suggestion\n        if parsed_args.is_enabled is not None:\n            kwargs[\u0027is_enabled\u0027] \u003d parsed_args.is_enabled\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if parsed_args.service_provider_id:"},{"line_number":83,"context_line":"            kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        enabled \u003d True"},{"line_number":86,"context_line":"        if parsed_args.disable is True:"},{"line_number":87,"context_line":"            enabled \u003d False"},{"line_number":88,"context_line":"        kwargs[\u0027is_enabled\u0027] \u003d enabled"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if parsed_args.description:"},{"line_number":91,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"}],"source_content_type":"text/x-python","patch_set":4,"id":"1b0b16e0_54a4c816","line":88,"range":{"start_line":85,"start_character":0,"end_line":88,"end_character":38},"in_reply_to":"326ac8a9_2aa65622","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":109,"context_line":"        return ("},{"line_number":110,"context_line":"            column_headers,"},{"line_number":111,"context_line":"            ("},{"line_number":112,"context_line":"                utils.get_item_properties("},{"line_number":113,"context_line":"                    sp,"},{"line_number":114,"context_line":"                    columns,"},{"line_number":115,"context_line":"                    formatters\u003d{},"},{"line_number":116,"context_line":"                )"},{"line_number":117,"context_line":"            ),"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7951c731_f0d338dd","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":14},"updated":"2024-11-12 12:14:34.000000000","message":"```suggestion\n            utils.get_item_properties(sp, columns),\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":109,"context_line":"        return ("},{"line_number":110,"context_line":"            column_headers,"},{"line_number":111,"context_line":"            ("},{"line_number":112,"context_line":"                utils.get_item_properties("},{"line_number":113,"context_line":"                    sp,"},{"line_number":114,"context_line":"                    columns,"},{"line_number":115,"context_line":"                    formatters\u003d{},"},{"line_number":116,"context_line":"                )"},{"line_number":117,"context_line":"            ),"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c5d56580_1a7dab90","line":117,"range":{"start_line":111,"start_character":0,"end_line":117,"end_character":14},"in_reply_to":"7951c731_f0d338dd","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":174,"context_line":"        return ("},{"line_number":175,"context_line":"            column_headers,"},{"line_number":176,"context_line":"            ("},{"line_number":177,"context_line":"                utils.get_item_properties("},{"line_number":178,"context_line":"                    s,"},{"line_number":179,"context_line":"                    columns,"},{"line_number":180,"context_line":"                    formatters\u003d{},"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"                for s in data"},{"line_number":183,"context_line":"            ),"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f5a77033_58a97d81","line":183,"range":{"start_line":176,"start_character":0,"end_line":183,"end_character":14},"updated":"2024-11-12 12:14:34.000000000","message":"```suggestion\n            (utils.get_item_properties(s, columns) for s in data),\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":174,"context_line":"        return ("},{"line_number":175,"context_line":"            column_headers,"},{"line_number":176,"context_line":"            ("},{"line_number":177,"context_line":"                utils.get_item_properties("},{"line_number":178,"context_line":"                    s,"},{"line_number":179,"context_line":"                    columns,"},{"line_number":180,"context_line":"                    formatters\u003d{},"},{"line_number":181,"context_line":"                )"},{"line_number":182,"context_line":"                for s in data"},{"line_number":183,"context_line":"            ),"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ae6f437b_9795e6c9","line":183,"range":{"start_line":176,"start_character":0,"end_line":183,"end_character":14},"in_reply_to":"f5a77033_58a97d81","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            help\u003d_(\u0027New service provider URL, where SAML assertions are sent\u0027),"},{"line_number":215,"context_line":"        )"},{"line_number":216,"context_line":"        enable_service_provider \u003d parser.add_mutually_exclusive_group()"},{"line_number":217,"context_line":"        enable_service_provider.add_argument("},{"line_number":218,"context_line":"            \u0027--enable\u0027,"},{"line_number":219,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":220,"context_line":"            help\u003d_(\u0027Enable the service provider\u0027),"},{"line_number":221,"context_line":"        )"},{"line_number":222,"context_line":"        enable_service_provider.add_argument("},{"line_number":223,"context_line":"            \u0027--disable\u0027,"},{"line_number":224,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":225,"context_line":"            help\u003d_(\u0027Disable the service provider\u0027),"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        return parser"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7973dae_07301eb0","line":226,"range":{"start_line":217,"start_character":0,"end_line":226,"end_character":9},"updated":"2024-11-12 12:14:34.000000000","message":"```suggestion\n        enable_service_provider.add_argument(\n            \u0027--enable\u0027,\n            dest\u003d\u0027is_enabled\u0027,\n            action\u003d\u0027store_true\u0027,\n            default\u003dNone,\n            help\u003d_(\u0027Enable the service provider\u0027),\n        )\n        enable_service_provider.add_argument(\n            \u0027--disable\u0027,\n            dest\u003d\u0027is_enabled\u0027,\n            action\u003d\u0027store_false\u0027,\n            default\u003dNone,\n            help\u003d_(\u0027Disable the service provider\u0027),\n        )\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            help\u003d_(\u0027New service provider URL, where SAML assertions are sent\u0027),"},{"line_number":215,"context_line":"        )"},{"line_number":216,"context_line":"        enable_service_provider \u003d parser.add_mutually_exclusive_group()"},{"line_number":217,"context_line":"        enable_service_provider.add_argument("},{"line_number":218,"context_line":"            \u0027--enable\u0027,"},{"line_number":219,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":220,"context_line":"            help\u003d_(\u0027Enable the service provider\u0027),"},{"line_number":221,"context_line":"        )"},{"line_number":222,"context_line":"        enable_service_provider.add_argument("},{"line_number":223,"context_line":"            \u0027--disable\u0027,"},{"line_number":224,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":225,"context_line":"            help\u003d_(\u0027Disable the service provider\u0027),"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        return parser"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ad0523f_c50e25e2","line":226,"range":{"start_line":217,"start_character":0,"end_line":226,"end_character":9},"in_reply_to":"a7973dae_07301eb0","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        if parsed_args.disable is True:"},{"line_number":236,"context_line":"            enabled \u003d False"},{"line_number":237,"context_line":"        kwargs[\u0027is_enabled\u0027] \u003d enabled"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if parsed_args.description:"},{"line_number":240,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b1ffd706_72b4235a","line":238,"updated":"2024-11-12 12:14:34.000000000","message":"```suggestion\n        if parsed_args.is_enabled is not None:\n            kwargs[\u0027is_enabled\u0027] \u003d parsed_args.is_enabled\n```\n\nThis one is a bug btw. As this is currently written, we will *always* set enabled to `true` unless `--disable` is passed. That\u0027s because `enabled` defaults to `True` and not `None` like before.","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        if parsed_args.disable is True:"},{"line_number":236,"context_line":"            enabled \u003d False"},{"line_number":237,"context_line":"        kwargs[\u0027is_enabled\u0027] \u003d enabled"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if parsed_args.description:"},{"line_number":240,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfc27f06_53bf556b","line":238,"in_reply_to":"b1ffd706_72b4235a","updated":"2024-11-12 18:34:36.000000000","message":"But didn\u0027t we set default\u003dNone above? So if enabled isn\u0027t set, it will remain None as it won\u0027t go into this if statement.","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"338e5f6fd00889238ee07af59fe285fe19e29207","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        if parsed_args.disable is True:"},{"line_number":236,"context_line":"            enabled \u003d False"},{"line_number":237,"context_line":"        kwargs[\u0027is_enabled\u0027] \u003d enabled"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if parsed_args.description:"},{"line_number":240,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d7260a6f_9dab9de9","line":238,"in_reply_to":"bfc27f06_53bf556b","updated":"2024-11-13 13:03:08.000000000","message":"I\u0027m talking about the code as it existed in patchset 4. In that, while we wouldn\u0027t go into the if statement unless `parsed_args.disable` was `True`, we were setting `enabled \u003d True` so we\u0027d always pass *a* value. You\u0027ve corrected this in PS5 so it\u0027s all good now.","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def take_action(self, parsed_args):"},{"line_number":267,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":268,"context_line":"        service_provider \u003d service_client.find_service_provider("},{"line_number":269,"context_line":"            parsed_args.service_provider"},{"line_number":270,"context_line":"        )"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        column_headers \u003d ("},{"line_number":273,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ea61a74_24290160","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":9},"updated":"2024-11-12 12:14:34.000000000","message":"Don\u0027t forget `ignore_missing\u003dFalse`","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def take_action(self, parsed_args):"},{"line_number":267,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":268,"context_line":"        service_provider \u003d service_client.find_service_provider("},{"line_number":269,"context_line":"            parsed_args.service_provider"},{"line_number":270,"context_line":"        )"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        column_headers \u003d ("},{"line_number":273,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"10e05c02_354233f7","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":9},"in_reply_to":"7ea61a74_24290160","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":279,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":280,"context_line":"        return ("},{"line_number":281,"context_line":"            column_headers,"},{"line_number":282,"context_line":"            ("},{"line_number":283,"context_line":"                utils.get_item_properties("},{"line_number":284,"context_line":"                    service_provider,"},{"line_number":285,"context_line":"                    columns,"},{"line_number":286,"context_line":"                    formatters\u003d{},"},{"line_number":287,"context_line":"                )"},{"line_number":288,"context_line":"            ),"},{"line_number":289,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"f9806c22_c532208d","line":288,"range":{"start_line":282,"start_character":0,"end_line":288,"end_character":14},"updated":"2024-11-12 12:14:34.000000000","message":"```suggestion\n            utils.get_item_properties(service_provider, columns),\n```","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":280,"context_line":"        return ("},{"line_number":281,"context_line":"            column_headers,"},{"line_number":282,"context_line":"            ("},{"line_number":283,"context_line":"                utils.get_item_properties("},{"line_number":284,"context_line":"                    service_provider,"},{"line_number":285,"context_line":"                    columns,"},{"line_number":286,"context_line":"                    formatters\u003d{},"},{"line_number":287,"context_line":"                )"},{"line_number":288,"context_line":"            ),"},{"line_number":289,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"03e3b96b_ba0fde83","line":288,"range":{"start_line":282,"start_character":0,"end_line":288,"end_character":14},"in_reply_to":"f9806c22_c532208d","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"338e5f6fd00889238ee07af59fe285fe19e29207","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    def take_action(self, parsed_args):"},{"line_number":80,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        kwargs \u003d {}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if parsed_args.is_enabled is not None:"},{"line_number":87,"context_line":"            kwargs[\u0027is_enabled\u0027] \u003d parsed_args.is_enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"d42a51f1_ac4bfb7f","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":54},"updated":"2024-11-13 13:03:08.000000000","message":"```suggestion\n        kwargs \u003d {\u0027id\u0027: parsed_args.service_provider_id}\n```","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"ae662d2f72cdc3b6df1a4155a37b6ed0336b0085","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def take_action(self, parsed_args):"},{"line_number":80,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        kwargs \u003d {}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if parsed_args.is_enabled is not None:"},{"line_number":87,"context_line":"            kwargs[\u0027is_enabled\u0027] \u003d parsed_args.is_enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"6266dd88_90b0ab48","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":54},"in_reply_to":"d42a51f1_ac4bfb7f","updated":"2024-11-20 23:38:57.000000000","message":"Done","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"ae662d2f72cdc3b6df1a4155a37b6ed0336b0085","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def take_action(self, parsed_args):"},{"line_number":80,"context_line":"        service_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        kwargs \u003d {}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        kwargs[\u0027id\u0027] \u003d parsed_args.service_provider_id"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if parsed_args.is_enabled is not None:"},{"line_number":87,"context_line":"            kwargs[\u0027is_enabled\u0027] \u003d parsed_args.is_enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee6e363e_d3d04a3d","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":54},"in_reply_to":"d42a51f1_ac4bfb7f","updated":"2024-11-20 23:38:57.000000000","message":"Done","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"338e5f6fd00889238ee07af59fe285fe19e29207","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        sp \u003d service_client.create_service_provider(**kwargs)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        column_headers \u003d ("},{"line_number":101,"context_line":"            \u0027ID\u0027,"},{"line_number":102,"context_line":"            \u0027Enabled\u0027,"},{"line_number":103,"context_line":"            \u0027Description\u0027,"},{"line_number":104,"context_line":"            \u0027Auth URL\u0027,"},{"line_number":105,"context_line":"            \u0027Service Provider URL\u0027,"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":108,"context_line":"        return ("},{"line_number":109,"context_line":"            column_headers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"e00e6530_999280b8","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":9},"updated":"2024-11-13 13:03:08.000000000","message":"Were these capitalized previously?","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"ae662d2f72cdc3b6df1a4155a37b6ed0336b0085","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        sp \u003d service_client.create_service_provider(**kwargs)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        column_headers \u003d ("},{"line_number":101,"context_line":"            \u0027ID\u0027,"},{"line_number":102,"context_line":"            \u0027Enabled\u0027,"},{"line_number":103,"context_line":"            \u0027Description\u0027,"},{"line_number":104,"context_line":"            \u0027Auth URL\u0027,"},{"line_number":105,"context_line":"            \u0027Service Provider URL\u0027,"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":108,"context_line":"        return ("},{"line_number":109,"context_line":"            column_headers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ab46c931_728e5bf4","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":9},"in_reply_to":"e00e6530_999280b8","updated":"2024-11-20 23:38:57.000000000","message":"Done","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"338e5f6fd00889238ee07af59fe285fe19e29207","unresolved":true,"context_lines":[{"line_number":258,"context_line":"            ignore_missing\u003dFalse,"},{"line_number":259,"context_line":"        )"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        column_headers \u003d ("},{"line_number":262,"context_line":"            \u0027ID\u0027,"},{"line_number":263,"context_line":"            \u0027Enabled\u0027,"},{"line_number":264,"context_line":"            \u0027Description\u0027,"},{"line_number":265,"context_line":"            \u0027Auth URL\u0027,"},{"line_number":266,"context_line":"            \u0027Service Provider URL\u0027,"},{"line_number":267,"context_line":"        )"},{"line_number":268,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":269,"context_line":"        return ("},{"line_number":270,"context_line":"            column_headers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"910edfb8_1a0fab7a","line":267,"range":{"start_line":261,"start_character":0,"end_line":267,"end_character":9},"updated":"2024-11-13 13:03:08.000000000","message":"Ditto. Was this capitalized previously?","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"ae662d2f72cdc3b6df1a4155a37b6ed0336b0085","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            ignore_missing\u003dFalse,"},{"line_number":259,"context_line":"        )"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        column_headers \u003d ("},{"line_number":262,"context_line":"            \u0027ID\u0027,"},{"line_number":263,"context_line":"            \u0027Enabled\u0027,"},{"line_number":264,"context_line":"            \u0027Description\u0027,"},{"line_number":265,"context_line":"            \u0027Auth URL\u0027,"},{"line_number":266,"context_line":"            \u0027Service Provider URL\u0027,"},{"line_number":267,"context_line":"        )"},{"line_number":268,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027description\u0027, \u0027auth_url\u0027, \u0027sp_url\u0027)"},{"line_number":269,"context_line":"        return ("},{"line_number":270,"context_line":"            column_headers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"06d8931f_6593c38e","line":267,"range":{"start_line":261,"start_character":0,"end_line":267,"end_character":9},"in_reply_to":"910edfb8_1a0fab7a","updated":"2024-11-20 23:38:57.000000000","message":"Done","commit_id":"a1e8ddfb88dfaec14c292cdd488d93b43c602de0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3dac9d7f708417c569572cdc3dab08580deafe2a","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        service_client.update_service_provider("},{"line_number":257,"context_line":"            parsed_args.service_provider,"},{"line_number":258,"context_line":"            **kwargs,"},{"line_number":259,"context_line":"        )"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class ShowServiceProvider(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1eef47f0_7dba3b8a","line":259,"updated":"2024-12-10 15:43:02.000000000","message":"As a follow-up, any reason not to return the result to the user? You\u0027ll need to return the value from `update_service_provider` above and change the superclass from `Command` to `ShowOne`.","commit_id":"cda857da6e940139fc175475412ae4a80fc60d14"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4f07c35247678bc7ef545356b635bfb73053ecc7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        service_client.update_service_provider("},{"line_number":257,"context_line":"            parsed_args.service_provider,"},{"line_number":258,"context_line":"            **kwargs,"},{"line_number":259,"context_line":"        )"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class ShowServiceProvider(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f71792a9_ab7148c7","line":259,"in_reply_to":"1eef47f0_7dba3b8a","updated":"2024-12-10 20:16:36.000000000","message":"Done","commit_id":"cda857da6e940139fc175475412ae4a80fc60d14"}],"releasenotes/notes/migrate-service-provider-to-sdk-74dc48b227f21a05.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"500b2483dd21bbfa0d6c2fe83edee5e6a00401c8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following commands have been migrated to SDK:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2889e301_be07b258","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-11-12 12:14:34.000000000","message":"Can you change this to `upgrade`? It\u0027s not really a \"feature\" so much as a slight change in the inner workings that might (but shouldn\u0027t) have some impact for end-users.","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"421e1054d5ae6cbeb462a69a938199a01b821e78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following commands have been migrated to SDK:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3c9ea4c4_64814c0d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"2889e301_be07b258","updated":"2024-11-12 18:34:36.000000000","message":"Done","commit_id":"09c31eb94e4d61c4c80ee8abb8f5860d471b23ab"}]}