)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5da4c2d_9367fd12","updated":"2024-11-12 12:22:39.000000000","message":"This is pretty much done, but I think I\u0027ve enough nits here to warrant the -1 (sorry 😊)","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ab864afaf2e14550fd3287ea152d35089800dc22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"73c523bc_9c7839d7","updated":"2024-11-13 13:05:05.000000000","message":"recheck timeout\n\nA potential follow-up inline but this is good enough as-is","commit_id":"550871ad93801a08fe18adbe67cb8ea45df24aa0"}],"openstackclient/identity/v3/region.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"},{"line_number":63,"context_line":"        return ("},{"line_number":64,"context_line":"            column_headers,"},{"line_number":65,"context_line":"            ("},{"line_number":66,"context_line":"                utils.get_item_properties("},{"line_number":67,"context_line":"                    region,"},{"line_number":68,"context_line":"                    columns,"},{"line_number":69,"context_line":"                )"},{"line_number":70,"context_line":"            ),"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"83612874_e123ef4d","line":70,"range":{"start_line":65,"start_character":0,"end_line":70,"end_character":14},"updated":"2024-11-12 12:22:39.000000000","message":"nit: should fit on one line","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"eda227e35072730964393d805d29128d3c34cf01","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"},{"line_number":63,"context_line":"        return ("},{"line_number":64,"context_line":"            column_headers,"},{"line_number":65,"context_line":"            ("},{"line_number":66,"context_line":"                utils.get_item_properties("},{"line_number":67,"context_line":"                    region,"},{"line_number":68,"context_line":"                    columns,"},{"line_number":69,"context_line":"                )"},{"line_number":70,"context_line":"            ),"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9175261f_d7709269","line":70,"range":{"start_line":65,"start_character":0,"end_line":70,"end_character":14},"in_reply_to":"83612874_e123ef4d","updated":"2024-11-12 18:58:20.000000000","message":"Done","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        result \u003d 0"},{"line_number":90,"context_line":"        for i in parsed_args.region:"},{"line_number":91,"context_line":"            try:"},{"line_number":92,"context_line":"                identity_client.delete_region(i)"},{"line_number":93,"context_line":"            except Exception as e:"},{"line_number":94,"context_line":"                result +\u003d 1"},{"line_number":95,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":5,"id":"815d6f6d_00c0e178","line":92,"updated":"2024-11-12 12:22:39.000000000","message":"regions can only be looked up by ID so no need for a `find_region` call here ✅","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        kwargs \u003d {}"},{"line_number":128,"context_line":"        if parsed_args.parent_region:"},{"line_number":129,"context_line":"            kwargs[\u0027parent_region_id\u0027] \u003d parsed_args.parent_region"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        columns_headers \u003d (\u0027Region\u0027, \u0027Parent Region\u0027, \u0027Description\u0027)"},{"line_number":132,"context_line":"        columns \u003d (\u0027ID\u0027, \u0027Parent Region Id\u0027, \u0027Description\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b21d82d5_0673170d","line":129,"updated":"2024-11-12 12:22:39.000000000","message":"`parent_region_id` is a valid filter option in SDK ✅","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":true,"context_lines":[{"line_number":194,"context_line":"    def take_action(self, parsed_args):"},{"line_number":195,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        region \u003d identity_client.find_region(parsed_args.region)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        columns \u003d (\u0027description\u0027, \u0027parent_region_id\u0027, \u0027id\u0027)"},{"line_number":200,"context_line":"        column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"043b2ff9_35885833","line":197,"updated":"2024-11-12 12:22:39.000000000","message":"You want `get_region` here. `find_region` shouldn\u0027t exist since there\u0027s no `name` attribute to lookup by","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"eda227e35072730964393d805d29128d3c34cf01","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def take_action(self, parsed_args):"},{"line_number":195,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        region \u003d identity_client.find_region(parsed_args.region)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        columns \u003d (\u0027description\u0027, \u0027parent_region_id\u0027, \u0027id\u0027)"},{"line_number":200,"context_line":"        column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e50dfff7_7ffadcd2","line":197,"in_reply_to":"043b2ff9_35885833","updated":"2024-11-12 18:58:20.000000000","message":"Done","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"},{"line_number":201,"context_line":"        return ("},{"line_number":202,"context_line":"            column_headers,"},{"line_number":203,"context_line":"            ("},{"line_number":204,"context_line":"                utils.get_item_properties("},{"line_number":205,"context_line":"                    region,"},{"line_number":206,"context_line":"                    columns,"},{"line_number":207,"context_line":"                )"},{"line_number":208,"context_line":"            ),"},{"line_number":209,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b84854b_db84fc6d","line":208,"range":{"start_line":203,"start_character":0,"end_line":208,"end_character":14},"updated":"2024-11-12 12:22:39.000000000","message":"nit: should fit on one line?\n\nAlso, do you want a `_format_region` helper like you\u0027ve done elsewhere?","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"eda227e35072730964393d805d29128d3c34cf01","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"},{"line_number":201,"context_line":"        return ("},{"line_number":202,"context_line":"            column_headers,"},{"line_number":203,"context_line":"            ("},{"line_number":204,"context_line":"                utils.get_item_properties("},{"line_number":205,"context_line":"                    region,"},{"line_number":206,"context_line":"                    columns,"},{"line_number":207,"context_line":"                )"},{"line_number":208,"context_line":"            ),"},{"line_number":209,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"d3ffcd45_4833a472","line":208,"range":{"start_line":203,"start_character":0,"end_line":208,"end_character":14},"in_reply_to":"4b84854b_db84fc6d","updated":"2024-11-12 18:58:20.000000000","message":"Done","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ab864afaf2e14550fd3287ea152d35089800dc22","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _format_region(region):"},{"line_number":29,"context_line":"    columns \u003d (\u0027description\u0027, \u0027parent_region_id\u0027, \u0027id\u0027)"},{"line_number":30,"context_line":"    column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"},{"line_number":31,"context_line":"    return ("},{"line_number":32,"context_line":"        column_headers,"},{"line_number":33,"context_line":"        utils.get_item_properties(region, columns),"}],"source_content_type":"text/x-python","patch_set":6,"id":"398d4fff_692c16e8","line":30,"range":{"start_line":29,"start_character":55,"end_line":30,"end_character":63},"updated":"2024-11-13 13:05:05.000000000","message":"nit: it probably makes sense to have `region` / `id` first?\n\n\n```suggestion\n    columns \u003d (\u0027id\u0027, \u0027parent_region_id\u0027, \u0027description\u0027)\n    column_headers \u003d (\u0027region\u0027, \u0027parent_region\u0027, \u0027description\u0027)\n```","commit_id":"550871ad93801a08fe18adbe67cb8ea45df24aa0"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"eb6e6b21c55ba5c67e417afc400adf612b5c8314","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _format_region(region):"},{"line_number":29,"context_line":"    columns \u003d (\u0027description\u0027, \u0027parent_region_id\u0027, \u0027id\u0027)"},{"line_number":30,"context_line":"    column_headers \u003d (\u0027description\u0027, \u0027parent_region\u0027, \u0027region\u0027)"},{"line_number":31,"context_line":"    return ("},{"line_number":32,"context_line":"        column_headers,"},{"line_number":33,"context_line":"        utils.get_item_properties(region, columns),"}],"source_content_type":"text/x-python","patch_set":6,"id":"119ddffe_d7aa5a65","line":30,"range":{"start_line":29,"start_character":55,"end_line":30,"end_character":63},"in_reply_to":"398d4fff_692c16e8","updated":"2024-11-20 23:29:23.000000000","message":"Done","commit_id":"550871ad93801a08fe18adbe67cb8ea45df24aa0"}],"releasenotes/notes/migrate-region-to-sdk-fbd27bceaa1db9dc.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"14cba2d5e45a740f500085dc024868c1364fc9d6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following commands have been migrated to SDK:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4cb1ac6e_2d95dbaf","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-11-12 12:22:39.000000000","message":"`upgrade`","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"eda227e35072730964393d805d29128d3c34cf01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following commands have been migrated to SDK:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0d191bc1_31e748d7","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"4cb1ac6e_2d95dbaf","updated":"2024-11-12 18:58:20.000000000","message":"Done","commit_id":"1b28cee63eb82b4891fcb21199099a5217244c15"}]}