)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"691fc304d8504d4262e65b743a9a38ac009c920a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"99ca1530_28040a5a","updated":"2024-11-20 22:56:51.000000000","message":"recheck","commit_id":"894fc0771f3234606d4ec3aa1b93cd22d1251803"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c69866f74d801627f4ddb492cbee27b13f4f6f5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f1a3c36_4ab83e24","updated":"2024-12-10 15:39:09.000000000","message":"Fixed the failing unit test","commit_id":"764b4437b8ef527e45b5a20a5399ffb0aaceb18b"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"30455bca65a285d5d4b78ec18d6ce4eeb635236d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ecade6e_6273a158","updated":"2024-12-10 20:10:32.000000000","message":"The changes @stephenfin@redhat.com made are passing for me locally but not on Zuul, which is the same issue I was having with the previous version of the code. How could I approach debugging this?","commit_id":"764b4437b8ef527e45b5a20a5399ffb0aaceb18b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d697b7a0beecc9c16bdec762e3f56bc18671961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7bf1c034_4d11b6bb","in_reply_to":"6ecade6e_6273a158","updated":"2024-12-16 18:25:34.000000000","message":"Looks like you uncovered a race. That should be fixed in the patch [below this](https://review.opendev.org/c/openstack/python-openstackclient/+/937803) now.","commit_id":"764b4437b8ef527e45b5a20a5399ffb0aaceb18b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd40de272cfa155c40d6a3fc3849f8742e985e4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bba226e2_d307af02","updated":"2024-12-19 19:12:40.000000000","message":"recheck","commit_id":"769bf87d0a2a305d9ce53c91931f1c7016848053"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1e68f0740f0cdc956f90130c3542db5df9226022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"00fa844f_56f1c694","updated":"2024-12-17 17:42:05.000000000","message":"recheck apparently unrelated timeout","commit_id":"769bf87d0a2a305d9ce53c91931f1c7016848053"}],"openstackclient/identity/v3/trust.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        ).id"},{"line_number":110,"context_line":"        kwargs[\u0027trustor_id\u0027] \u003d trustor_id"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        trustee_id \u003d identity_client.find_user("},{"line_number":113,"context_line":"            parsed_args.trustee, parsed_args.trustee_domain"},{"line_number":114,"context_line":"        ).id"},{"line_number":115,"context_line":"        kwargs[\u0027trustee_id\u0027] \u003d trustee_id"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        project_id \u003d identity_client.find_project("}],"source_content_type":"text/x-python","patch_set":5,"id":"b64f0960_f5a06992","line":114,"range":{"start_line":112,"start_character":0,"end_line":114,"end_character":12},"updated":"2024-11-12 12:28:20.000000000","message":"I think you want to surround all three of these `find_*` calls in `try - except sdk_exceptions.ForbiddenException` blocks since that appears to be what `common.find_user` (via `_find_identity_resource`) was doing?","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ).id"},{"line_number":110,"context_line":"        kwargs[\u0027trustor_id\u0027] \u003d trustor_id"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        trustee_id \u003d identity_client.find_user("},{"line_number":113,"context_line":"            parsed_args.trustee, parsed_args.trustee_domain"},{"line_number":114,"context_line":"        ).id"},{"line_number":115,"context_line":"        kwargs[\u0027trustee_id\u0027] \u003d trustee_id"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        project_id \u003d identity_client.find_project("}],"source_content_type":"text/x-python","patch_set":5,"id":"0005b970_1f7cedfe","line":114,"range":{"start_line":112,"start_character":0,"end_line":114,"end_character":12},"in_reply_to":"b64f0960_f5a06992","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":"        return ("},{"line_number":155,"context_line":"            columns,"},{"line_number":156,"context_line":"            ("},{"line_number":157,"context_line":"                utils.get_item_properties("},{"line_number":158,"context_line":"                    trust,"},{"line_number":159,"context_line":"                    columns,"},{"line_number":160,"context_line":"                )"},{"line_number":161,"context_line":"            ),"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f9bdda5_6a5dc3eb","line":161,"range":{"start_line":156,"start_character":0,"end_line":161,"end_character":14},"updated":"2024-11-12 12:28:20.000000000","message":"nit: should fit on one line? Also, do you want a `_format_trust` helper here?","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        )"},{"line_number":154,"context_line":"        return ("},{"line_number":155,"context_line":"            columns,"},{"line_number":156,"context_line":"            ("},{"line_number":157,"context_line":"                utils.get_item_properties("},{"line_number":158,"context_line":"                    trust,"},{"line_number":159,"context_line":"                    columns,"},{"line_number":160,"context_line":"                )"},{"line_number":161,"context_line":"            ),"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4e9c157d_3f038723","line":161,"range":{"start_line":156,"start_character":0,"end_line":161,"end_character":14},"in_reply_to":"3f9bdda5_6a5dc3eb","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        errors \u003d 0"},{"line_number":182,"context_line":"        for trust in parsed_args.trust:"},{"line_number":183,"context_line":"            try:"},{"line_number":184,"context_line":"                trust_obj \u003d identity_client.find_trust(trust)"},{"line_number":185,"context_line":"                identity_client.delete_trust(trust_obj.id)"},{"line_number":186,"context_line":"            except Exception as e:"},{"line_number":187,"context_line":"                errors +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"f14cee29_eb67ccc8","line":184,"updated":"2024-11-12 12:28:20.000000000","message":"`ignore_missing\u003dFalse`","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        errors \u003d 0"},{"line_number":182,"context_line":"        for trust in parsed_args.trust:"},{"line_number":183,"context_line":"            try:"},{"line_number":184,"context_line":"                trust_obj \u003d identity_client.find_trust(trust)"},{"line_number":185,"context_line":"                identity_client.delete_trust(trust_obj.id)"},{"line_number":186,"context_line":"            except Exception as e:"},{"line_number":187,"context_line":"                errors +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"a719955d_25efb7d3","line":184,"in_reply_to":"f14cee29_eb67ccc8","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":265,"context_line":"                # either the trustor or the trustee set to current user"},{"line_number":266,"context_line":"                # using a single call would give us trusts with both"},{"line_number":267,"context_line":"                # trustee and trustor set to current user"},{"line_number":268,"context_line":"                identity_client.trusts(trustor_user\u003duser)"},{"line_number":269,"context_line":"                identity_client.trusts(trustee_user\u003duser)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                data \u003d list("},{"line_number":272,"context_line":"                    {"},{"line_number":273,"context_line":"                        x.id: x"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d30d988_b394ecec","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":1},"updated":"2024-11-12 12:28:20.000000000","message":"These calls are not being saved. Do you want/need them still?","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                # either the trustor or the trustee set to current user"},{"line_number":266,"context_line":"                # using a single call would give us trusts with both"},{"line_number":267,"context_line":"                # trustee and trustor set to current user"},{"line_number":268,"context_line":"                identity_client.trusts(trustor_user\u003duser)"},{"line_number":269,"context_line":"                identity_client.trusts(trustee_user\u003duser)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                data \u003d list("},{"line_number":272,"context_line":"                    {"},{"line_number":273,"context_line":"                        x.id: x"}],"source_content_type":"text/x-python","patch_set":5,"id":"8b0d0954_2bec2c7c","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":1},"in_reply_to":"1d30d988_b394ecec","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":279,"context_line":"                )"},{"line_number":280,"context_line":"        else:"},{"line_number":281,"context_line":"            trustor \u003d None"},{"line_number":282,"context_line":"            if parsed_args.trustor:"},{"line_number":283,"context_line":"                trustor \u003d identity_client.find_user("},{"line_number":284,"context_line":"                    parsed_args.trustor,"},{"line_number":285,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":286,"context_line":"                )"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            trustee \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustee:"},{"line_number":290,"context_line":"                trustee \u003d identity_client.find_user("}],"source_content_type":"text/x-python","patch_set":5,"id":"3d101fdc_30582275","line":287,"range":{"start_line":282,"start_character":35,"end_line":287,"end_character":1},"updated":"2024-11-12 12:28:20.000000000","message":"Same comment as above about catching `ForbiddenException` here and just using what the user gave if so.","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5dff63e2e5280ff0f140ad733c3b6d60a3329686","unresolved":true,"context_lines":[{"line_number":279,"context_line":"                )"},{"line_number":280,"context_line":"        else:"},{"line_number":281,"context_line":"            trustor \u003d None"},{"line_number":282,"context_line":"            if parsed_args.trustor:"},{"line_number":283,"context_line":"                trustor \u003d identity_client.find_user("},{"line_number":284,"context_line":"                    parsed_args.trustor,"},{"line_number":285,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":286,"context_line":"                )"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            trustee \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustee:"},{"line_number":290,"context_line":"                trustee \u003d identity_client.find_user("}],"source_content_type":"text/x-python","patch_set":5,"id":"d87482ba_8089c189","line":287,"range":{"start_line":282,"start_character":35,"end_line":287,"end_character":1},"in_reply_to":"3d101fdc_30582275","updated":"2024-11-13 10:59:43.000000000","message":"Just to expand on this, what I mean is:\n\n```\ntry:\n    trustor \u003d identity_client.find_user(\n        parsed_args.trustor,\n        parsed_args.trustor_domain,\n    ).id\nexcept sdk_exceptions.ForbiddenException:\n    # assume we were given an ID and use that as-is\n    trustor \u003d parsed_args.trustor\n```","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                )"},{"line_number":280,"context_line":"        else:"},{"line_number":281,"context_line":"            trustor \u003d None"},{"line_number":282,"context_line":"            if parsed_args.trustor:"},{"line_number":283,"context_line":"                trustor \u003d identity_client.find_user("},{"line_number":284,"context_line":"                    parsed_args.trustor,"},{"line_number":285,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":286,"context_line":"                )"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            trustee \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustee:"},{"line_number":290,"context_line":"                trustee \u003d identity_client.find_user("}],"source_content_type":"text/x-python","patch_set":5,"id":"74e8f1dc_17d03b63","line":287,"range":{"start_line":282,"start_character":35,"end_line":287,"end_character":1},"in_reply_to":"d87482ba_8089c189","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":288,"context_line":"            trustee \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustee:"},{"line_number":290,"context_line":"                trustee \u003d identity_client.find_user("},{"line_number":291,"context_line":"                    parsed_args.trustor,"},{"line_number":292,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":293,"context_line":"                )"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            data \u003d identity_client.trusts("}],"source_content_type":"text/x-python","patch_set":5,"id":"345456b7_41605300","line":292,"range":{"start_line":291,"start_character":1,"end_line":292,"end_character":47},"updated":"2024-11-12 12:28:20.000000000","message":"not you but...\n\n```suggestion\n                    parsed_args.trustee,\n                    parsed_args.trustee_domain,\n```","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            trustee \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustee:"},{"line_number":290,"context_line":"                trustee \u003d identity_client.find_user("},{"line_number":291,"context_line":"                    parsed_args.trustor,"},{"line_number":292,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":293,"context_line":"                )"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            data \u003d identity_client.trusts("}],"source_content_type":"text/x-python","patch_set":5,"id":"c4ee8cf7_c07fc365","line":292,"range":{"start_line":291,"start_character":1,"end_line":292,"end_character":47},"in_reply_to":"345456b7_41605300","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def take_action(self, parsed_args):"},{"line_number":343,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":344,"context_line":"        trust \u003d identity_client.find_trust(parsed_args.trust)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        columns \u003d ("},{"line_number":347,"context_line":"            \u0027expires_at\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a3f9b96b_845e9a70","line":344,"updated":"2024-11-12 12:28:20.000000000","message":"`ignore_missing\u003dFalse`","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def take_action(self, parsed_args):"},{"line_number":343,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":344,"context_line":"        trust \u003d identity_client.find_trust(parsed_args.trust)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        columns \u003d ("},{"line_number":347,"context_line":"            \u0027expires_at\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"264cf9dd_160c3251","line":344,"in_reply_to":"a3f9b96b_845e9a70","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41f46faa2b4cb6bfd070205773f35379ec18dc26","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if parsed_args.authuser:"},{"line_number":272,"context_line":"            if auth_ref:"},{"line_number":273,"context_line":"                user \u003d identity_client.find_user(auth_ref.user_id)"},{"line_number":274,"context_line":"                # We need two calls here as we want trusts with"},{"line_number":275,"context_line":"                # either the trustor or the trustee set to current user"}],"source_content_type":"text/x-python","patch_set":6,"id":"e086a954_04b8460a","line":272,"updated":"2024-11-14 17:30:37.000000000","message":"Not entirely related to this, but is there any way for this to be unset? What happens e.g. if you run the command without any authentication information being set (i.e. with `OS_CLOUD` unset and no `--os-cloud` CLI parameter)?\n\nAs this stands, we have a bug here where if this is falsey then `data` will never get set and we\u0027ll get an `NameError`. If this is always set to something (i.e. it\u0027s truthy) then we can simply remove this check.","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"a875e695fe23c7853d99d199271bb30d4c0d7899","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if parsed_args.authuser:"},{"line_number":272,"context_line":"            if auth_ref:"},{"line_number":273,"context_line":"                user \u003d identity_client.find_user(auth_ref.user_id)"},{"line_number":274,"context_line":"                # We need two calls here as we want trusts with"},{"line_number":275,"context_line":"                # either the trustor or the trustee set to current user"}],"source_content_type":"text/x-python","patch_set":6,"id":"da2a8c15_95d8f87d","line":272,"in_reply_to":"2d91c2fe_9a465b98","updated":"2024-11-19 18:20:43.000000000","message":"Tried again with `openstack trust list --auth-user` and the command fails due to the same error. Removing the if statement.","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"559a74521d4c75efd4d072b6b885a549657baddc","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if parsed_args.authuser:"},{"line_number":272,"context_line":"            if auth_ref:"},{"line_number":273,"context_line":"                user \u003d identity_client.find_user(auth_ref.user_id)"},{"line_number":274,"context_line":"                # We need two calls here as we want trusts with"},{"line_number":275,"context_line":"                # either the trustor or the trustee set to current user"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d91c2fe_9a465b98","line":272,"in_reply_to":"e086a954_04b8460a","updated":"2024-11-19 16:29:11.000000000","message":"You\u0027re right, I don\u0027t think the command can be run without auth information:\n`$ openstack trust list` outputs `Missing value auth-url required for auth plugin password`. Should I keep the code as is then? The if statement would be useless in this case so I can remove it.","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41f46faa2b4cb6bfd070205773f35379ec18dc26","unresolved":true,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if parsed_args.authuser:"},{"line_number":272,"context_line":"            if auth_ref:"},{"line_number":273,"context_line":"                user \u003d identity_client.find_user(auth_ref.user_id)"},{"line_number":274,"context_line":"                # We need two calls here as we want trusts with"},{"line_number":275,"context_line":"                # either the trustor or the trustee set to current user"},{"line_number":276,"context_line":"                # using a single call would give us trusts with both"}],"source_content_type":"text/x-python","patch_set":6,"id":"d53400b9_ddf8c8cc","line":273,"updated":"2024-11-14 17:30:37.000000000","message":"Do we need to do this, actually? We already have a `user_id` that we know to be good. Maybe we can just use that?","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"a875e695fe23c7853d99d199271bb30d4c0d7899","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if parsed_args.authuser:"},{"line_number":272,"context_line":"            if auth_ref:"},{"line_number":273,"context_line":"                user \u003d identity_client.find_user(auth_ref.user_id)"},{"line_number":274,"context_line":"                # We need two calls here as we want trusts with"},{"line_number":275,"context_line":"                # either the trustor or the trustee set to current user"},{"line_number":276,"context_line":"                # using a single call would give us trusts with both"}],"source_content_type":"text/x-python","patch_set":6,"id":"2ed404f4_a8aec78f","line":273,"in_reply_to":"d53400b9_ddf8c8cc","updated":"2024-11-19 18:20:43.000000000","message":"Done","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41f46faa2b4cb6bfd070205773f35379ec18dc26","unresolved":true,"context_lines":[{"line_number":279,"context_line":"                    {"},{"line_number":280,"context_line":"                        x.id: x"},{"line_number":281,"context_line":"                        for x in itertools.chain("},{"line_number":282,"context_line":"                            identity_client.trusts(trustor_user\u003duser),"},{"line_number":283,"context_line":"                            identity_client.trusts(trustee_user\u003duser),"},{"line_number":284,"context_line":"                        )"},{"line_number":285,"context_line":"                    }.values()"},{"line_number":286,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":6,"id":"047aab2b_d751e087","line":283,"range":{"start_line":282,"start_character":0,"end_line":283,"end_character":70},"updated":"2024-11-14 17:30:37.000000000","message":"I don\u0027t see the `trustor_user` or `trustee_user` fields in the `Proxy.trusts` method in `openstack/identity/v3/_proxy.py` command (they\u0027re called `trustor_user_id` and `trustee_user_id` instead). Have you tested this?","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"559a74521d4c75efd4d072b6b885a549657baddc","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    {"},{"line_number":280,"context_line":"                        x.id: x"},{"line_number":281,"context_line":"                        for x in itertools.chain("},{"line_number":282,"context_line":"                            identity_client.trusts(trustor_user\u003duser),"},{"line_number":283,"context_line":"                            identity_client.trusts(trustee_user\u003duser),"},{"line_number":284,"context_line":"                        )"},{"line_number":285,"context_line":"                    }.values()"},{"line_number":286,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":6,"id":"7155ebae_47ab3ca8","line":283,"range":{"start_line":282,"start_character":0,"end_line":283,"end_character":70},"in_reply_to":"047aab2b_d751e087","updated":"2024-11-19 16:29:11.000000000","message":"You\u0027re right, sorry about that. Tests were still passing so it slipped through. Fixed!","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41f46faa2b4cb6bfd070205773f35379ec18dc26","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                    }.values()"},{"line_number":286,"context_line":"                )"},{"line_number":287,"context_line":"        else:"},{"line_number":288,"context_line":"            trustor \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustor:"},{"line_number":290,"context_line":"                trustor \u003d identity_client.find_user("},{"line_number":291,"context_line":"                    parsed_args.trustor,"},{"line_number":292,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":293,"context_line":"                )"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            trustee \u003d None"},{"line_number":296,"context_line":"            if parsed_args.trustee:"}],"source_content_type":"text/x-python","patch_set":6,"id":"54fc7d6b_3c0456f5","line":293,"range":{"start_line":288,"start_character":0,"end_line":293,"end_character":17},"updated":"2024-11-14 17:30:37.000000000","message":"Can we do the same thing as above RE: checking for `ForbiddenException` and using the value as-is if we get that?","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"559a74521d4c75efd4d072b6b885a549657baddc","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                    }.values()"},{"line_number":286,"context_line":"                )"},{"line_number":287,"context_line":"        else:"},{"line_number":288,"context_line":"            trustor \u003d None"},{"line_number":289,"context_line":"            if parsed_args.trustor:"},{"line_number":290,"context_line":"                trustor \u003d identity_client.find_user("},{"line_number":291,"context_line":"                    parsed_args.trustor,"},{"line_number":292,"context_line":"                    parsed_args.trustor_domain,"},{"line_number":293,"context_line":"                )"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            trustee \u003d None"},{"line_number":296,"context_line":"            if parsed_args.trustee:"}],"source_content_type":"text/x-python","patch_set":6,"id":"d15a38c3_7e959de7","line":293,"range":{"start_line":288,"start_character":0,"end_line":293,"end_character":17},"in_reply_to":"54fc7d6b_3c0456f5","updated":"2024-11-19 16:29:11.000000000","message":"Done","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41f46faa2b4cb6bfd070205773f35379ec18dc26","unresolved":true,"context_lines":[{"line_number":300,"context_line":"                )"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            data \u003d identity_client.trusts("},{"line_number":303,"context_line":"                trustor_user\u003dtrustor,"},{"line_number":304,"context_line":"                trustee_user\u003dtrustee,"},{"line_number":305,"context_line":"            )"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        column_headers \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"6135351e_9b2f2018","line":304,"range":{"start_line":303,"start_character":0,"end_line":304,"end_character":37},"updated":"2024-11-14 17:30:37.000000000","message":"Same comment as above: shouldn\u0027t these be `trustor_user_id` / `trustee_user_id`?","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"559a74521d4c75efd4d072b6b885a549657baddc","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                )"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            data \u003d identity_client.trusts("},{"line_number":303,"context_line":"                trustor_user\u003dtrustor,"},{"line_number":304,"context_line":"                trustee_user\u003dtrustee,"},{"line_number":305,"context_line":"            )"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        column_headers \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"c12b87d4_7a12a1be","line":304,"range":{"start_line":303,"start_character":0,"end_line":304,"end_character":37},"in_reply_to":"6135351e_9b2f2018","updated":"2024-11-19 16:29:11.000000000","message":"Done","commit_id":"7522d216fd55853a881eac9ae23727e6e808623d"}],"releasenotes/notes/migrate-trust-to-sdk-9397c9cfddcb636a.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a19e764397a1ad2b883bb60a0e439176213eea3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following commands have been migrated to SDK:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"68f5a10b_d253c0cc","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2024-11-12 12:28:20.000000000","message":"`upgrade`","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"4c555b7aaa4f087dcad1e80a50d739de1558c6c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following commands have been migrated to SDK:"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"565db65f_1f763de2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"68f5a10b_d253c0cc","updated":"2024-11-13 18:12:26.000000000","message":"Done","commit_id":"03dbe6420d957a7119d120b5cd63baf0b616f2a6"}]}