)]}'
{"id":"openstack%2Fpython-openstackclient~932435","triplet_id":"openstack%2Fpython-openstackclient~master~Ibbeef52225e18757cd28d0fbfb14c1ca06975b60","project":"openstack/python-openstackclient","branch":"master","topic":"bug/2084580","hashtags":[],"change_id":"Ibbeef52225e18757cd28d0fbfb14c1ca06975b60","subject":"clientmanager: Check for \u0027block-storage\u0027 service type","status":"MERGED","created":"2024-10-15 17:08:56.000000000","updated":"2024-10-15 19:46:47.000000000","submitted":"2024-10-15 19:45:22.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"932435-bug/2084580","meta_rev_id":"8980df949721870e18f0c3d52eca10ef47088b16","_number":932435,"virtual_id_number":932435,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-10-15 19:45:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2024-10-15 17:10:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2024-10-15 17:10:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-15 18:27:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27e2b463162c9a0e4f2486e6bf5ae737c7f62a27","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-10-15 17:08:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"53627e7e48c40fe768e71eef16082dc35a51466c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-10-15 17:10:15.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"668b8dbec9c039d8316d6ff49f3658fddb7f08c5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-15 18:27:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/96907b46f7d04024b8b991096f78d4c2\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/2ad1605c8ae24c439a751d740d337cfd : SUCCESS in 4m 24s (non-voting)\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/455bb4deec5a463e951917ef53162edc : SUCCESS in 4m 22s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/dc9e31260f8246068f31357789263604 : SUCCESS in 4m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/20bd33b697454dd69827615aa97451d9 : SUCCESS in 3m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bceb14b077514d5a81b8f3f468ee5556 : SUCCESS in 2m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fa60fd39950340c7a0a95be9fe5a64dc : SUCCESS in 5m 39s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/d100902755f5490caf9e256900f91eb6 : SUCCESS in 3m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/05878591392f4851954c6e22a10a8078 : SUCCESS in 4m 23s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/14a799b5fba746889ca1842495c84772 : SUCCESS in 5m 23s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/a07150a4fa7d47ffae86150d10b50f5e : SUCCESS in 4m 55s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c58235d1e6964b25a7b8fddf3f397fd6 : SUCCESS in 1h 03m 36s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ca7e09fe43c84c05aeefc5870d8d3c82 : SUCCESS in 1h 17m 55s","accounts_in_message":[],"_revision_number":1},{"id":"349b4bbcfb99ce1b2320d8a2a2ddf65443d7be6f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-15 18:28:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dcf46a9db731a005fa625b8ea9f7ef904406a648","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-15 19:45:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6e5fd7d8132d4b54bdbd77065ddad4d3\n\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/4130402ac30a4bfea28880d64b195788 : SUCCESS in 3m 26s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/6c5e0e34813b4376b73f8d0b8bb2d329 : SUCCESS in 3m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a5162ee4a8154eac9edad1f5f67ff024 : SUCCESS in 2m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d47590bf55fa42ea910c18f9dbfc0feb : SUCCESS in 3m 28s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/3478c784068046d58cb1bdccb9d194e3 : SUCCESS in 2m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2021c5281f1848d693f8b68787636c2f : SUCCESS in 5m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/87f598a9492941b9a73b39e23f7f6cf4 : SUCCESS in 3m 24s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/3ddd272630344045bc47b45e0eb10e62 : SUCCESS in 6m 40s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/d0c27a026f62437aa2e503f32d17d64c : SUCCESS in 50m 12s","accounts_in_message":[],"_revision_number":1},{"id":"978e9b258d2ac7ffd4230b60ec5b8d4da8bf8707","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-15 19:45:22.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"8980df949721870e18f0c3d52eca10ef47088b16","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-15 19:46:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3ece6782852a4616b2a575068ee299ab\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3d5144377424c69851df3b9a8a57f20 : SUCCESS in 43s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1d44af16ecdc41f58aa52d4395163e03 : SUCCESS in 49s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/3fec33c266434f468b12cb0eeafb1c41 : SUCCESS in 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7c6b47b451f30d1d3965358c515baae87955d7dc","revisions":{"7c6b47b451f30d1d3965358c515baae87955d7dc":{"kind":"REWORK","_number":1,"created":"2024-10-15 17:08:56.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/35/932435/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/35/932435/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/932435/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/932435/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/932435/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/35/932435/1"}}},"commit":{"parents":[{"commit":"8979c00150cd1d318364024ba45d734f6b26dc67","subject":"Merge \"Always resolve domain id\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8979c00150cd1d318364024ba45d734f6b26dc67"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-10-15 16:41:50.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-10-15 17:07:26.000000000","tz":60},"subject":"clientmanager: Check for \u0027block-storage\u0027 service type","message":"clientmanager: Check for \u0027block-storage\u0027 service type\n\nThis is a fun one driven by two separate changes. We recently started\nchecking whether the volume service was available before setting quotas\nin order to allow us to use quota set for other services [1]. This\nmerged a number of weeks ago and was included in 7.1.0. More recently,\nwe modified DevStack to stop publishing a service catalog entry with a\nservice type of \u0027volumev3\u0027, preferring instead to use the correct\n\u0027block-storage\u0027 service type. Taken separately, neither of these changes\nwould have caused issues. Together, they mean our lookups for the volume\nservice now fail and we can\u0027t set volume quotas.\n\nFix things by checking for the block-storage service type also. A future\nchange will raise a warning (later an error) if the volume service is\nnot found and you\u0027re attempting to set a quota since this is clearly a\nmistake.\n\nChange-Id: Ibbeef52225e18757cd28d0fbfb14c1ca06975b60\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-bug: #2084580\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7c6b47b451f30d1d3965358c515baae87955d7dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7c6b47b451f30d1d3965358c515baae87955d7dc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}