)]}'
{"id":"openstack%2Fpython-openstackclient~934155","triplet_id":"openstack%2Fpython-openstackclient~master~Iaf9596aea02f683c280ae68504a14d43dbd6134a","project":"openstack/python-openstackclient","branch":"master","topic":"bug/2077634","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2024-11-05 20:38:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iaf9596aea02f683c280ae68504a14d43dbd6134a","subject":"common: Use correct argument for volume limits","status":"MERGED","created":"2024-11-05 17:15:18.000000000","updated":"2024-11-05 20:39:27.000000000","submitted":"2024-11-05 20:38:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"934155-bug/2077634","meta_rev_id":"1da066ad30e825d9be46fccfbc4c55b11fd6c21b","_number":934155,"virtual_id_number":934155,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-11-05 20:38:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":2,"date":"2024-11-05 17:17:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":1,"date":"2024-11-05 19:02:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-05 17:17:34.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2024-11-05 18:26:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cc69ae9f44c1b44582ecebc23f9e5830df16d853","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-11-05 17:15:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"340ca78c8b88db0e11a01964c142efe642bd3acb","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2024-11-05 17:17:34.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"438035f0d2726c677a0767f910ea8119dd5ba6b8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-05 18:26:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a6c0dd791ea940b08d65bf223d5e8345\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/7c3fd4e26d8c4aa68840613d115db8dc : FAILURE in 5m 32s (non-voting)\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/a91b567412134ed59ed56ade74a64ac5 : SUCCESS in 4m 35s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/e884703d038b410383b8e895e9c80276 : SUCCESS in 5m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2080e8773b4b4e5b919a2ec3c058f3b7 : SUCCESS in 4m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0c86886b485242f68ff760b548355f5e : SUCCESS in 2m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d9c43604c8254f279a47ca0593824045 : SUCCESS in 3m 18s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/1c3a83f457274733b277b9b9412779d1 : SUCCESS in 3m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a4af00535fd482e8943116a0942d91b : SUCCESS in 3m 30s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/00a71ec741e64bad83e1401417521004 : SUCCESS in 6m 06s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/07274ecf52504e7cba74d454dee170bd : SUCCESS in 1h 05m 04s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/40b4b8e6dcdf423cb7eff5a395873a50 : SUCCESS in 44m 13s","accounts_in_message":[],"_revision_number":1},{"id":"2ae26243738d4e6d34327254cb453653980afff1","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2024-11-05 19:02:06.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6577cd4f6b3c7c56031be4647d5a8774069001e4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-05 19:02:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f3aabaabb4e3bd43a225bc2733f087efbb0fef1e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-05 20:38:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c8d089f968d64b8f92529e9fed594780\n\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/dde9f61982d14bcaa224653a9a27b3a8 : SUCCESS in 6m 52s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/13ad56228fc441cb8db5de75cfa8ed5a : SUCCESS in 6m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc043c2f57a747e89bb2eefd94fb4918 : SUCCESS in 2m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7b845db7a3e14a5c803f5d2feed0e100 : SUCCESS in 3m 31s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/ab17b01595154e508100e690209bff5a : SUCCESS in 2m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4348ebed1bef4681b6eac85730c283da : SUCCESS in 4m 10s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/3a76ee55393e40a097fcad6c043f3bc9 : SUCCESS in 10m 15s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/907fe2bffc7e417e8353cfeecbd39c70 : SUCCESS in 1h 07m 19s","accounts_in_message":[],"_revision_number":1},{"id":"33af95f2c6a1e15a82a888cc7157a913b7814902","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-05 20:38:15.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"1da066ad30e825d9be46fccfbc4c55b11fd6c21b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-05 20:39:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/69dffb52551a4992ac45e14e225fd980\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5cf1839765a14441887d679ae17b1e5f : SUCCESS in 45s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/c3c7a4b99be349c3bb88defe3630f2ee : SUCCESS in 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e5ccf1eb1ca4c2efe946f6dc8967041ee82d4ec5","revisions":{"e5ccf1eb1ca4c2efe946f6dc8967041ee82d4ec5":{"kind":"REWORK","_number":1,"created":"2024-11-05 17:15:18.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/55/934155/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/55/934155/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/934155/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/934155/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/55/934155/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/55/934155/1"}}},"commit":{"parents":[{"commit":"7c6b47b451f30d1d3965358c515baae87955d7dc","subject":"clientmanager: Check for \u0027block-storage\u0027 service type","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7c6b47b451f30d1d3965358c515baae87955d7dc"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-11-05 17:07:49.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-11-05 17:07:49.000000000","tz":0},"subject":"common: Use correct argument for volume limits","message":"common: Use correct argument for volume limits\n\nThe sooner we have type hints in SDK, the better /o\\\n\nChange-Id: Iaf9596aea02f683c280ae68504a14d43dbd6134a\nCloses-bug: #2077634\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e5ccf1eb1ca4c2efe946f6dc8967041ee82d4ec5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e5ccf1eb1ca4c2efe946f6dc8967041ee82d4ec5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}