)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"5a4a6bde822b57b8cb9bbbbeb14af9772abac437","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7fde6475_b71caec8","updated":"2024-12-04 19:26:47.000000000","message":"For some reason none of the tests pass due to a 500 internal server error, but I\u0027m seeing above that the Zuul tests passed. What could be different about my environment that is causing this?","commit_id":"d3dc079dd3296a85bed8d3025d4936bb14654bd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d235b03aa1503affc5f8388ebedcdbce1a5564d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1ba24fe_576ae71b","updated":"2024-12-05 12:43:34.000000000","message":"Funnily enough, this same test appears to have failed again 😅 I guess that\u0027s a good thing though since it shows us this issue is not *the* issue.\n\nI\u0027ve looked into *the* more this morning and I think we\u0027ve misunderstood the issue. Firstly, it\u0027s the `quota list` command that is failing, not the `quota show` command. The way that works is that we list all projects and then attempt to retrieve quotas for each of them one-by-one. It appears that a project is getting deleted between these two steps (a classic TOCTOU bug) but the code we have to handle this error isn\u0027t working because compute\u0027s `os-quota-sets` API, unlike every other compute API, return a HTTP 400 (Bad Request) rather than a HTTP 404 (Not Found) if the resource (i.e. a project) doesn\u0027t exist.\n\nI\u0027ve proposed changing this in Nova [here](https://review.opendev.org/c/openstack/nova/+/937125) but whether or not that gets that merged, we still need to support older releases where this is an issue. That means catching also catching the Bad Request exception in the `ListQuota` command.\n\n@antoniagaete@osuosl.org Would you like to rework this/propose a new patch to do that instead? This might be an issue for other services also. You can test that by trying to retrieve quotas for an invalid project ID locally and see what the error response code is.","commit_id":"d3dc079dd3296a85bed8d3025d4936bb14654bd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"253994d500c1fdabbca9c4a39dbc406b296c8cb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70980670_4eda186d","in_reply_to":"7fde6475_b71caec8","updated":"2024-12-10 16:39:35.000000000","message":"You mean it\u0027s failing locally? That would suggest an error with Keystone or Nova. I would suggest looking at the logs for both to see if you can identify the issue. For example, on your devstack host run:\n\n```\njournalctl -a --unit devstack@keystone -f\njournalctl -a --unit devstack@n-api -f\n```","commit_id":"d3dc079dd3296a85bed8d3025d4936bb14654bd7"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"ffa963b4864efb64043446c00cd63cd7959edb88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1e856d5_3c05e51d","in_reply_to":"d1ba24fe_576ae71b","updated":"2024-12-09 18:53:01.000000000","message":"Sorry for not getting to this sooner. Will get on that right now!","commit_id":"d3dc079dd3296a85bed8d3025d4936bb14654bd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"947fb52dd9b5af782bfddaf9ce4de5e0dd0ee05c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eec21f11_26efe265","updated":"2024-12-16 18:29:20.000000000","message":"Looks like we stepped on each other\u0027s toes here. Sorry! I did this in https://review.opendev.org/c/openstack/python-openstackclient/+/937363 as I didn\u0027t know if you\u0027d have time to resolve it. I\u0027m going to abandon this since it\u0027s resolving to a reshuffle of lines and nothing more now, but thank you for looking into this and fixing it 😊","commit_id":"23eb8321b92c6e12f168d3c37331690bb9f51d11"}],"openstackclient/tests/functional/common/test_quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"096171fa89cb06d488b16a18515a2fdfedb65b94","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_quota_list_compute_option(self):"},{"line_number":58,"context_line":"        wait_time \u003d 0"},{"line_number":59,"context_line":"        while wait_time \u003c 60:"},{"line_number":60,"context_line":"            cmd_output \u003d self.openstack(\u0027project list\u0027, parse_output\u003dTrue)"},{"line_number":61,"context_line":"            if self.PROJECT_NAME not in [x[\u0027Name\u0027] for x in cmd_output]:"},{"line_number":62,"context_line":"                print(\u0027retrying project list check\u0027)"},{"line_number":63,"context_line":"                wait_time +\u003d 10"},{"line_number":64,"context_line":"                time.sleep(10)"},{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                break"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.openstack(\u0027quota set --instances 30 \u0027 + self.PROJECT_NAME)"},{"line_number":69,"context_line":"        cmd_output \u003d self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"845b5d34_61e88fc0","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":21},"updated":"2024-12-04 10:49:07.000000000","message":"Can you place this up under the call to create the project (in `setupClass`) rather than here?","commit_id":"207108f87365731451b8a7f84240f38116aa7253"},{"author":{"_account_id":35548,"name":"Antonia Gaete","email":"antoniagaete@osuosl.org","username":"antoniagaete"},"change_message_id":"5a4a6bde822b57b8cb9bbbbeb14af9772abac437","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_quota_list_compute_option(self):"},{"line_number":58,"context_line":"        wait_time \u003d 0"},{"line_number":59,"context_line":"        while wait_time \u003c 60:"},{"line_number":60,"context_line":"            cmd_output \u003d self.openstack(\u0027project list\u0027, parse_output\u003dTrue)"},{"line_number":61,"context_line":"            if self.PROJECT_NAME not in [x[\u0027Name\u0027] for x in cmd_output]:"},{"line_number":62,"context_line":"                print(\u0027retrying project list check\u0027)"},{"line_number":63,"context_line":"                wait_time +\u003d 10"},{"line_number":64,"context_line":"                time.sleep(10)"},{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                break"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.openstack(\u0027quota set --instances 30 \u0027 + self.PROJECT_NAME)"},{"line_number":69,"context_line":"        cmd_output \u003d self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"7da4a960_29091008","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":21},"in_reply_to":"845b5d34_61e88fc0","updated":"2024-12-04 19:26:47.000000000","message":"Done","commit_id":"207108f87365731451b8a7f84240f38116aa7253"}]}