)]}'
{"id":"openstack%2Fpython-openstackclient~937365","triplet_id":"openstack%2Fpython-openstackclient~master~I45ab9af953f7d060379f48ca429eaea7cfe857cc","project":"openstack/python-openstackclient","branch":"master","attention_set":{},"removed_from_attention_set":{"4523":{"account":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"last_update":"2025-04-03 16:40:17.000000000","reason":"Change was submitted"},"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2025-04-03 16:40:17.000000000","reason":"Change was submitted"},"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2025-04-03 16:40:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I45ab9af953f7d060379f48ca429eaea7cfe857cc","subject":"Fix: extend in-use volumes check","status":"MERGED","created":"2024-12-09 13:31:26.000000000","updated":"2025-04-03 16:41:45.000000000","submitted":"2025-04-03 16:40:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"937365","meta_rev_id":"90249b3e9c3477e36db764963448e6cd060deede","_number":937365,"virtual_id_number":937365,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-04-03 16:40:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2025-03-24 16:31:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2025-04-03 15:43:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"reviewers":{"CC":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-09 16:06:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-12-09 16:08:29.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"CC"},{"updated":"2025-03-24 16:31:59.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2025-03-24 16:31:59.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"014a5642a25e6404c16eddb6aec32882b91e86e4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2024-12-09 13:31:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35fccaf2cc0167c57b76bddd626f8788c8406c84","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-09 16:06:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1f04006409324413a7c89c13ae4b63a7\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/09195ad7cab946409aacde32e87ec244 : SUCCESS in 3m 36s (non-voting)\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/e8b6e2a82d8a44e9a75412ca7b38f691 : SUCCESS in 6m 28s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/ead8c8c4d1cc408c8e57cce870266c73 : SUCCESS in 6m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bcf0ecc5522c4ca28a7b2327e8302d00 : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd6d188e44524fa2b7743f29d496ff92 : SUCCESS in 3m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/af1e30139b124a878377a4e176ebd527 : SUCCESS in 3m 17s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/8e3f7fb69059497da1cf722ff0739c52 : SUCCESS in 4m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58be22eafd5e4926937b289a174876e4 : SUCCESS in 5m 25s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/a16942bb763540569394bd40ef1d7a05 : SUCCESS in 6m 18s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/8e6578bb3b84409f975fd59c608e0234 : SUCCESS in 52m 47s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/cce14084d6b0421586ab36190bbe2334 : SUCCESS in 1h 06m 07s","accounts_in_message":[],"_revision_number":1},{"id":"5c7127bc7f7c8ec1a1e7e97e19f56e93f3c9cf7a","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2024-12-09 16:08:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7650853b254c4a2821bfc5c981823bb0bdc8985a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-03-24 16:31:59.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ecb2296b7a5b216cb12cb623d88fbd9b73bf2f34","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-04-03 15:43:25.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"4c54a8259e0bcdcc0a74b79e383cfec3b7550b9c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-03 15:43:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2eb93dac625b59a7c02202f145e8d7bef23e19c6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-03 16:40:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/28109de7e0e54095a25f0a7300131cc4\n\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/af3103b21af94231a4516291252a97ce : SUCCESS in 4m 49s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/c734f61400cc478ea0434b243dde455e : SUCCESS in 4m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/806c4ca5de35403bb77e9846f8e9a9b8 : SUCCESS in 3m 55s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/7f90ff1aaffc44e09efeaae2a9ba16a3 : SUCCESS in 3m 42s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c38af85617074a1eb8a7914c598e3300 : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/04d30bc0f4e64e6181f535806ff7b908 : SUCCESS in 6m 17s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/9eafe08886ba4162928881b6b780b95a : SUCCESS in 6m 05s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/763e698a4d604b27acaa71b62305fedd : SUCCESS in 55m 35s","accounts_in_message":[],"_revision_number":1},{"id":"120f78b4f55b596e7adc6422eac48a01469a8b62","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-03 16:40:17.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"90249b3e9c3477e36db764963448e6cd060deede","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-03 16:41:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d3cef93c6e854b33915771ae314b8d9d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0eda54a0b246433e844f25bb54d00852 : SUCCESS in 46s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/7062e4d271f94329b67bc7c1ddcaa7a5 : SUCCESS in 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"03933e9a736daa3531e46d851fc7ecdc817a3944","revisions":{"03933e9a736daa3531e46d851fc7ecdc817a3944":{"kind":"REWORK","_number":1,"created":"2024-12-09 13:31:26.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/65/937365/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/937365/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/937365/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/937365/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/937365/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/937365/1"}}},"commit":{"parents":[{"commit":"ecc744a4fdf58c37ba05bcf72a8ae22f9aea4173","subject":"Remove ceilometer service overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ecc744a4fdf58c37ba05bcf72a8ae22f9aea4173"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2024-12-09 13:28:27.000000000","tz":330},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2024-12-09 13:31:22.000000000","tz":330},"subject":"Fix: extend in-use volumes check","message":"Fix: extend in-use volumes check\n\nCurrently we have 2 issues with extending volumes checks:\n\n1. We don\u0027t specify explicitly that MV 3.42 needs to be passed for\nin-use volumes\n2. Any state of volume (error, attaching, detaching etc) can pass\nthis check by specifying MV 3.42\n\nThe fundamentally correct approach to these checks should be:\n\n1. Only allow \u0027available\u0027 and \u0027in-use\u0027 volumes to be extended\n2. Check MV 3.42 or greater is specified in case of \u0027in-use\u0027 volumes\notherwise fail\n\nThis approach is implemented in the patch.\n\nChange-Id: I45ab9af953f7d060379f48ca429eaea7cfe857cc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/03933e9a736daa3531e46d851fc7ecdc817a3944"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/03933e9a736daa3531e46d851fc7ecdc817a3944"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
