)]}'
{"id":"openstack%2Fpython-openstackclient~937803","triplet_id":"openstack%2Fpython-openstackclient~master~I8bf9055e3f5b885dd5a7a6d751b774934da4a7d7","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"I8bf9055e3f5b885dd5a7a6d751b774934da4a7d7","subject":"tests: Stop setting attributes on class","status":"MERGED","created":"2024-12-16 18:24:30.000000000","updated":"2024-12-17 18:48:11.000000000","submitted":"2024-12-17 18:47:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"937803","meta_rev_id":"a6017fffcb643ac2394e36825baae12b46815ea9","_number":937803,"virtual_id_number":937803,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-12-17 18:46:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-12-17 17:42:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-12-17 17:42:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-16 19:36:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a095b6256cd12306f246f9d8364b61653f9e326f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-12-16 18:24:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9b3057d8e984fcc1151094ebd2ac85ef4481a382","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-16 19:36:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/94efb37738d3491a8ad0fca7d91a4117\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/0c1f4576044b44e0a948f7939e85ff7d : SUCCESS in 4m 27s (non-voting)\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/6815300bdfe74d508cc1f114b4fcd58c : SUCCESS in 4m 20s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/9405f97be0cb41f382e9c5fa9fedac2f : SUCCESS in 4m 46s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/07f9e4d9ae4e4ae9b718ab1957a36d9d : SUCCESS in 4m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c8ffe3f9e1b9424694ef8a5d1f45c42b : SUCCESS in 2m 42s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5e79602706f849cfbc199863007d0770 : SUCCESS in 3m 15s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/3e4dc5865d13446ab8f67621919373f4 : SUCCESS in 3m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af033aa275e6440b8344876f6e3afa4e : SUCCESS in 4m 58s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/82309c6ae8bf4a32b2d59c61ae3ecb29 : SUCCESS in 5m 29s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/c0c6a4f0afe542c598ece5efc6209777 : SUCCESS in 59m 55s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/25cf8920875d4d3894e6024f6b455c9a : SUCCESS in 56m 37s","accounts_in_message":[],"_revision_number":1},{"id":"d533ce4c66367bfc40d5a4ab225023688375055a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-12-17 17:42:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"98e6ae2045def44df84a6b2421a87f428356e674","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 17:43:26.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a257b7fcb7b593fc61836efc67726833eb120f50","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 18:46:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e86b3d383d1e467a9f8a3997273941cf\n\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/95ab7b31d4d6442584b9d9f20882a1ff : SUCCESS in 4m 52s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/76bbdebefcf746f19782eabaee16181b : SUCCESS in 4m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4cb4f7fd06544ed7a7d3fb57514a7dfe : SUCCESS in 4m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/38ed68223b4a4f67a439da29019d22c2 : SUCCESS in 6m 44s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/93b1559fba144462930174ae366e9ee4 : SUCCESS in 4m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0955351a90034be6a30d185a8c06a3ca : SUCCESS in 5m 56s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/4d6b00b3a2954808bfda76200d3b3d6b : SUCCESS in 8m 34s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/88a9938e4b284f9897f8b41b7a16fcf7 : SUCCESS in 1h 01m 10s","accounts_in_message":[],"_revision_number":1},{"id":"624353191079f54db9699cea0321612d95afe1e3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 18:47:00.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"a6017fffcb643ac2394e36825baae12b46815ea9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-12-17 18:48:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a1e99e9836f1409d87b9d50a4364d3c8\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7d8181b23ce74f1a9d05ae6fea122c1c : SUCCESS in 53s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/199976ffa51a4fa39176484579ab552c : SUCCESS in 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"38407c6a78b6676ade148bbf9760d33152af7133","revisions":{"38407c6a78b6676ade148bbf9760d33152af7133":{"kind":"REWORK","_number":1,"created":"2024-12-16 18:24:30.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/03/937803/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/03/937803/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/03/937803/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/03/937803/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/03/937803/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/03/937803/1"}}},"commit":{"parents":[{"commit":"4cef5f5549299258cf2285b087529ad98fe5cf24","subject":"Adopt sdk_fakes for compute.test_server_group","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4cef5f5549299258cf2285b087529ad98fe5cf24"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-12-16 18:16:48.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2024-12-16 18:23:09.000000000","tz":0},"subject":"tests: Stop setting attributes on class","message":"tests: Stop setting attributes on class\n\nFor some reason we were setting a property mock on the FakeClientManager\nclass. In multiple places, no less. This has a nasty habit of causing\nside-effects in other tests, depending on the order that tests run in.\nResolve this simply setting the attribute as we\u0027d expect.\n\nChange-Id: I8bf9055e3f5b885dd5a7a6d751b774934da4a7d7\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/38407c6a78b6676ade148bbf9760d33152af7133"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/38407c6a78b6676ade148bbf9760d33152af7133"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}