)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8731567f5218ac499e524943856cfb8fe92766b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for spice-direct console types."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for Nova microversion 2.98 which exposes the new"},{"line_number":10,"context_line":"spice-direct console type and the pre-existing /os-console-auth-token/ API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"+----------+----------------------------------------------------------+"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6b306fbb_2c583d27","line":9,"range":{"start_line":9,"start_character":48,"end_line":9,"end_character":50},"updated":"2025-02-25 16:31:39.000000000","message":"99","commit_id":"2b6460b486b9c9e0f9ec8acda0997b58ab6c3f5c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d9bc8886a8a67c570edd5c9bb156300049bc8698","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for spice-direct console types."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for Nova microversion 2.98 which exposes the new"},{"line_number":10,"context_line":"spice-direct console type and the pre-existing /os-console-auth-token/ API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"+----------+----------------------------------------------------------+"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"81a0aff0_a150b6aa","line":9,"range":{"start_line":9,"start_character":48,"end_line":9,"end_character":50},"in_reply_to":"6b306fbb_2c583d27","updated":"2025-03-13 10:54:57.000000000","message":"Done","commit_id":"2b6460b486b9c9e0f9ec8acda0997b58ab6c3f5c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8202f1c990e61858530d4f61fa60c67cd422c571","unresolved":true,"context_lines":[{"line_number":28,"context_line":"+----------------------+--------------------------------------+"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I2d33646d6ac9b25076d69be76dcef8f5c465cd1b"},{"line_number":31,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/940479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0cba2bdd_54251cb9","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":72},"updated":"2025-05-06 09:34:30.000000000","message":"looks like this is inclueded in in 4.5.0\n\nit looks like the lower constrait in requirements.txt is 4.4.0\n\nhttps://github.com/openstack/python-openstackclient/blob/master/requirements.txt#L10\n\nso we should be bumping that in this patch no?","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"349780e9174e550cbd838e3e4d7cbf5505bb37ac","unresolved":false,"context_lines":[{"line_number":28,"context_line":"+----------------------+--------------------------------------+"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I2d33646d6ac9b25076d69be76dcef8f5c465cd1b"},{"line_number":31,"context_line":"Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/940479"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4b29043e_807fc893","line":31,"range":{"start_line":31,"start_character":12,"end_line":31,"end_character":72},"in_reply_to":"0cba2bdd_54251cb9","updated":"2025-05-07 09:37:08.000000000","message":"Done","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8731567f5218ac499e524943856cfb8fe92766b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e631427f_f78b0007","updated":"2025-02-25 16:31:39.000000000","message":"the code chage looks ok but i suspsect we need test coverate as well.\n\nalso we need a new min version of the sdk to supprot this so i expect you will need to bump the min version in requirements.txt","commit_id":"2b6460b486b9c9e0f9ec8acda0997b58ab6c3f5c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7cae4685fec05dcbf0aef161eb411210623f075d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f0e01da_e78cb7e0","updated":"2025-03-13 10:54:46.000000000","message":"Also, you probably want tests for the new command too. They\u0027ll fail the `pyXX` CI jobs until the SDK patch merges, but they should pass the `pyXX-tips` jobs. You can work on it locally by installing your local SDK changes into the tox .venv (e.g. `tox -e py310 --notest; source .tox/py310/bin/activate; pip install ../openstacksdk; deactivate; tox -e py310`)","commit_id":"dded4814e36465cfc279211cbe728450bff18468"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63f589a101def25713559ec12c8aeaa0816d14aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3065935b_d0a1a283","updated":"2025-03-13 10:52:54.000000000","message":"Looking good. We\u0027ll need to cut a release of SDK before we can merge this but that\u0027s not a big deal.\n\nAny chance of a release note, though? And if there was ever a novaclient equivalent of `console connection show`, we probably want to add the mapping to `doc/source/cli/data/nova.csv`.","commit_id":"dded4814e36465cfc279211cbe728450bff18468"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"e6f71b14b8064021f36b80b769865f94e7ba9733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10c6f6c5_53821ac8","in_reply_to":"3065935b_d0a1a283","updated":"2025-03-18 08:54:10.000000000","message":"Happy to do a release note. I can find no evidence of support for `os-console-auth-tokens` in python-novaclient, so I think we can skip the CSV file thing.","commit_id":"dded4814e36465cfc279211cbe728450bff18468"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"e6f71b14b8064021f36b80b769865f94e7ba9733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75f6ed64_f3a7cd84","in_reply_to":"5f0e01da_e78cb7e0","updated":"2025-03-18 08:54:10.000000000","message":"Thanks for this tox pointer, that\u0027s super helpful.\n\nI\u0027ve had a swing at the unit test, but ran out of time for today and got stuck on this:\n\n```\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFailed 1 tests - output below:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nopenstackclient.tests.unit.compute.v2.test_console.TestConsoleTokens.test_console_connection_show\n-------------------------------------------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n\n      File \"/Users/mikal/src/shakenfist/kerbside-patches/src/python-openstackclient/openstackclient/tests/unit/compute/v2/test_console.py\", line 274, in test_console_connection_show\n    parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)\n                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n      File \"/Users/mikal/src/shakenfist/kerbside-patches/src/python-openstackclient/openstackclient/tests/unit/utils.py\", line 98, in check_parser\n    actual_value \u003d getattr(parsed_args, attr)\n                   ^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n    AttributeError: \u0027Namespace\u0027 object has no attribute \u0027host\u0027\n```\n\nI will take another swing at it as soon as I get a chance.","commit_id":"dded4814e36465cfc279211cbe728450bff18468"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4546089a6ad33e60e5f63a37e25f48c24fd1b8c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"517d236f_5405989f","in_reply_to":"75f6ed64_f3a7cd84","updated":"2025-03-18 13:03:51.000000000","message":"Left a comment on the test.","commit_id":"dded4814e36465cfc279211cbe728450bff18468"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2f603629981c0bdc51ad139c5f5892c6b50dbad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56738552_bdf61790","updated":"2025-03-18 13:00:38.000000000","message":"Fix needed to the test inline. Also, if you run either `pre-commit run -a` or `tox -e pep8` (which installs `pre-commit` in a venv and then runs it), you\u0027ll get most of the formatting issues auto-fixed and warnings issued about the ones you need to address yourself.","commit_id":"8fda23583ac404cf63dde2318f2b1bd3da411226"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84b52a1368e6d1f73c2983bfe47fa8b3bc827654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de5d4d89_c6a448a0","updated":"2025-03-18 13:21:44.000000000","message":"Fixed the issues. Please check that you\u0027re happy with it before we proceed, @mikal@stillhq.com","commit_id":"d52a9b67a50d731c5c62a84d346c722a89993c3b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ace1fca7c8497ee795649b08cc874bb2a12b9977","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89581d9e_d674b584","updated":"2025-03-19 12:03:09.000000000","message":"PS: I expect test failures on the non-tips jobs until the SDK changes merge and are released.","commit_id":"d52a9b67a50d731c5c62a84d346c722a89993c3b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8202f1c990e61858530d4f61fa60c67cd422c571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3a87e5de_20370fa5","updated":"2025-05-06 09:34:30.000000000","message":"+1 because i think the patch is mostly correct but holdign +2 because i think we need to update requirements.txt. see my comments inline","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"b4aa65fb01e3d1a161326e4e03e43724c495caea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c9fe3b21_e33184b6","updated":"2025-04-07 09:16:35.000000000","message":"I was seeing test failures with openstacksdk manually dragged in, but this update resolves those. Thanks for the help along the way @stephenfin.","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"b4a0534ada2bfbf67108f00bdb208c01042111d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4537d40f_138869e8","updated":"2025-04-28 08:22:38.000000000","message":"Time for a re-review here I think @stephenfin@redhat.com.","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d25d0a8be3fe3d8bb2e90bd62d777fa603ec9a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ca4155d4_3beed34c","updated":"2025-04-07 10:47:29.000000000","message":"Will come back to this once the new release of SDK is out. Please poke me if I forget.","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"20e99bc5b15c6421d89a8bd676ca6dea261b0a25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7bbe7632_862df7a6","updated":"2025-04-23 21:56:23.000000000","message":"recheck dependencies now merged","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"349780e9174e550cbd838e3e4d7cbf5505bb37ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"63a1503f_f2a4f83a","updated":"2025-05-07 09:37:08.000000000","message":"Thanks Sean. Updated.","commit_id":"5d730f374b63bbc2121a025638b7abe79f156f53"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9363e9f92dcb74458d90014c17a6be7da2658d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f40f1e85_90945376","updated":"2025-05-07 10:52:25.000000000","message":"this looks good to me now","commit_id":"5d730f374b63bbc2121a025638b7abe79f156f53"}],"openstackclient/compute/v2/console_connection.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8202f1c990e61858530d4f61fa60c67cd422c571","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def take_action(self, parsed_args):"},{"line_number":43,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":44,"context_line":"        data \u003d compute_client.validate_console_auth_token(parsed_args.token)"},{"line_number":45,"context_line":"        display_columns, columns \u003d _get_console_connection_columns(data)"},{"line_number":46,"context_line":"        data \u003d utils.get_dict_properties(data, columns)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"eedabfbf_722c823f","line":44,"updated":"2025-05-06 09:34:30.000000000","message":"currently i belive this will raise an error without using 4.5.0 of the sdk.\nto provide https://review.opendev.org/c/openstack/openstacksdk/+/940479/9/openstack/compute/v2/_proxy.py#2389","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"349780e9174e550cbd838e3e4d7cbf5505bb37ac","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def take_action(self, parsed_args):"},{"line_number":43,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":44,"context_line":"        data \u003d compute_client.validate_console_auth_token(parsed_args.token)"},{"line_number":45,"context_line":"        display_columns, columns \u003d _get_console_connection_columns(data)"},{"line_number":46,"context_line":"        data \u003d utils.get_dict_properties(data, columns)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"24fd710c_525c8d09","line":44,"in_reply_to":"eedabfbf_722c823f","updated":"2025-05-07 09:37:08.000000000","message":"Acknowledged","commit_id":"83f81320bab137793ae7fe7c8e7d17d1c0e9690b"}],"openstackclient/tests/unit/compute/v2/test_console.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2f603629981c0bdc51ad139c5f5892c6b50dbad","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        arglist \u003d ["},{"line_number":266,"context_line":"            \u0027token\u0027,"},{"line_number":267,"context_line":"        ]"},{"line_number":268,"context_line":"        verifylist \u003d ["},{"line_number":269,"context_line":"            (\u0027host\u0027, \u0027127.0.0.1\u0027),"},{"line_number":270,"context_line":"            (\u0027internal_access_path\u0027, None),"},{"line_number":271,"context_line":"            (\u0027port\u0027, 5900),"},{"line_number":272,"context_line":"            (\u0027tls_port\u0027, 5901)"},{"line_number":273,"context_line":"        ]"},{"line_number":274,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":275,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"65e6bdb5_50e507cc","line":272,"range":{"start_line":268,"start_character":22,"end_line":272,"end_character":30},"updated":"2025-03-18 13:00:38.000000000","message":"`arglist` is the list of string arguments you\u0027re passing to the command. That looks correct.\n\n`verifylist` is a list of tuples of the argparse dest and value. This looks wrong. Since the command only accepts a single positional argument - and positional argument\u0027s `dest` value is the same as the argument itself - I\u0027d expect this to be:\n\n\n```suggestion\n        verifylist \u003d [\n            (\u0027token\u0027, \u0027token\u0027),\n```","commit_id":"8fda23583ac404cf63dde2318f2b1bd3da411226"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84b52a1368e6d1f73c2983bfe47fa8b3bc827654","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        arglist \u003d ["},{"line_number":266,"context_line":"            \u0027token\u0027,"},{"line_number":267,"context_line":"        ]"},{"line_number":268,"context_line":"        verifylist \u003d ["},{"line_number":269,"context_line":"            (\u0027host\u0027, \u0027127.0.0.1\u0027),"},{"line_number":270,"context_line":"            (\u0027internal_access_path\u0027, None),"},{"line_number":271,"context_line":"            (\u0027port\u0027, 5900),"},{"line_number":272,"context_line":"            (\u0027tls_port\u0027, 5901)"},{"line_number":273,"context_line":"        ]"},{"line_number":274,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":275,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0a583ef4_5ca13fcf","line":272,"range":{"start_line":268,"start_character":22,"end_line":272,"end_character":30},"in_reply_to":"65e6bdb5_50e507cc","updated":"2025-03-18 13:21:44.000000000","message":"Done","commit_id":"8fda23583ac404cf63dde2318f2b1bd3da411226"}],"releasenotes/notes/compute-add-validate-console-auth-token-1eda2bd62060ccfa.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4546089a6ad33e60e5f63a37e25f48c24fd1b8c2","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the new ``spice-direct`` console type, as well as the"},{"line_number":5,"context_line":"    exposing the ability for admins to lookup console connection information"},{"line_number":6,"context_line":"    via the new ``console connection show`` sub-command."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"63821274_b1aa2579","line":6,"updated":"2025-03-18 13:03:51.000000000","message":"I suspect whatever editor you\u0027re using (a) is not adding newlines to the end of the file and (b) likely isn\u0027t Vim. Could you fix at least fix the former here? `ruff` should handle it for the Python files.","commit_id":"8fda23583ac404cf63dde2318f2b1bd3da411226"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84b52a1368e6d1f73c2983bfe47fa8b3bc827654","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the new ``spice-direct`` console type, as well as the"},{"line_number":5,"context_line":"    exposing the ability for admins to lookup console connection information"},{"line_number":6,"context_line":"    via the new ``console connection show`` sub-command."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0fadd982_7a32c29e","line":6,"in_reply_to":"63821274_b1aa2579","updated":"2025-03-18 13:21:44.000000000","message":"Done","commit_id":"8fda23583ac404cf63dde2318f2b1bd3da411226"}]}