)]}'
{"openstackclient/network/v2/port.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"45b1e92355100820b40e32949507f694436845cf","unresolved":true,"context_lines":[{"line_number":1321,"context_line":"            \u0027--device\u0027,"},{"line_number":1322,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1323,"context_line":"            default\u003dFalse,"},{"line_number":1324,"context_line":"            help\u003d_(\"Clear device ID for the port.\"),"},{"line_number":1325,"context_line":"        )"},{"line_number":1326,"context_line":"        parser.add_argument("},{"line_number":1327,"context_line":"            \u0027--device-owner\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb409f4e_841f891c","line":1324,"range":{"start_line":1324,"start_character":20,"end_line":1324,"end_character":48},"updated":"2025-03-14 12:13:40.000000000","message":"perhaps some extra warning for the admin here that this is really a two edged sword","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f75dc31a110f4018a171f5547322ef05bc7e90d2","unresolved":true,"context_lines":[{"line_number":1321,"context_line":"            \u0027--device\u0027,"},{"line_number":1322,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1323,"context_line":"            default\u003dFalse,"},{"line_number":1324,"context_line":"            help\u003d_(\"Clear device ID for the port.\"),"},{"line_number":1325,"context_line":"        )"},{"line_number":1326,"context_line":"        parser.add_argument("},{"line_number":1327,"context_line":"            \u0027--device-owner\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f6ca9e79_4b3f72a3","line":1324,"range":{"start_line":1324,"start_character":20,"end_line":1324,"end_character":48},"in_reply_to":"68771d82_4e8fa3c3","updated":"2025-03-17 09:47:18.000000000","message":"you are right perhaps, this is an admin field, so removing the device-id is something they should know what it means.","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ed6608e5baa9edf71b3c2d5bc40fbefce0e2d816","unresolved":true,"context_lines":[{"line_number":1321,"context_line":"            \u0027--device\u0027,"},{"line_number":1322,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1323,"context_line":"            default\u003dFalse,"},{"line_number":1324,"context_line":"            help\u003d_(\"Clear device ID for the port.\"),"},{"line_number":1325,"context_line":"        )"},{"line_number":1326,"context_line":"        parser.add_argument("},{"line_number":1327,"context_line":"            \u0027--device-owner\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f18d579d_a9c1ce74","line":1324,"range":{"start_line":1324,"start_character":20,"end_line":1324,"end_character":48},"in_reply_to":"eb409f4e_841f891c","updated":"2025-03-14 14:33:45.000000000","message":"I could add more of warning to the help text there, what would you like to have there?\n\nI actually needed this while testing device_id logic and I think [1] is really the best way forward (cloud users should not be able to hack a field used internally by Neutron and Nova).\n\n[1] https://review.opendev.org/c/openstack/neutron/+/861169","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"407a7d276eed61bdcac0edcb384b1dcffe982ed9","unresolved":true,"context_lines":[{"line_number":1321,"context_line":"            \u0027--device\u0027,"},{"line_number":1322,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1323,"context_line":"            default\u003dFalse,"},{"line_number":1324,"context_line":"            help\u003d_(\"Clear device ID for the port.\"),"},{"line_number":1325,"context_line":"        )"},{"line_number":1326,"context_line":"        parser.add_argument("},{"line_number":1327,"context_line":"            \u0027--device-owner\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"68771d82_4e8fa3c3","line":1324,"range":{"start_line":1324,"start_character":20,"end_line":1324,"end_character":48},"in_reply_to":"f18d579d_a9c1ce74","updated":"2025-03-14 14:34:28.000000000","message":"s/hack/hack on/g","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5482253241e4fef8c91d5b2af6a68f4613ce6f1f","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"        if parsed_args.hints:"},{"line_number":1397,"context_line":"            attrs[\u0027hints\u0027] \u003d None"},{"line_number":1398,"context_line":"        if parsed_args.device:"},{"line_number":1399,"context_line":"            attrs[\u0027device_id\u0027] \u003d \u0027\u0027"},{"line_number":1400,"context_line":"        if parsed_args.device_owner:"},{"line_number":1401,"context_line":"            attrs[\u0027device_owner\u0027] \u003d \u0027\u0027"},{"line_number":1402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f696dfe_4ce11d87","line":1399,"range":{"start_line":1399,"start_character":33,"end_line":1399,"end_character":35},"updated":"2025-03-14 12:12:28.000000000","message":"the empty string is good for these ones and not None like the previous values?","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f75dc31a110f4018a171f5547322ef05bc7e90d2","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"        if parsed_args.hints:"},{"line_number":1397,"context_line":"            attrs[\u0027hints\u0027] \u003d None"},{"line_number":1398,"context_line":"        if parsed_args.device:"},{"line_number":1399,"context_line":"            attrs[\u0027device_id\u0027] \u003d \u0027\u0027"},{"line_number":1400,"context_line":"        if parsed_args.device_owner:"},{"line_number":1401,"context_line":"            attrs[\u0027device_owner\u0027] \u003d \u0027\u0027"},{"line_number":1402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b9d97845_4867433c","line":1399,"range":{"start_line":1399,"start_character":33,"end_line":1399,"end_character":35},"in_reply_to":"505d306d_fca9993f","updated":"2025-03-17 09:47:18.000000000","message":"thanks","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ed6608e5baa9edf71b3c2d5bc40fbefce0e2d816","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"        if parsed_args.hints:"},{"line_number":1397,"context_line":"            attrs[\u0027hints\u0027] \u003d None"},{"line_number":1398,"context_line":"        if parsed_args.device:"},{"line_number":1399,"context_line":"            attrs[\u0027device_id\u0027] \u003d \u0027\u0027"},{"line_number":1400,"context_line":"        if parsed_args.device_owner:"},{"line_number":1401,"context_line":"            attrs[\u0027device_owner\u0027] \u003d \u0027\u0027"},{"line_number":1402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"505d306d_fca9993f","line":1399,"range":{"start_line":1399,"start_character":33,"end_line":1399,"end_character":35},"in_reply_to":"9f696dfe_4ce11d87","updated":"2025-03-14 14:33:45.000000000","message":"I tried with None intially but gives a Neutron HTTP 400 bad request back","commit_id":"f1bd417861aaa584c85db1c97818d81c1309c6af"}]}
