)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"814be020c8ff02b8de127bb38693a463426b9a8f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Specifying project-domain for project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The fix ensures that if a user wants to set a default project, "},{"line_number":10,"context_line":"they must also provide the project domain. If it\u0027s missing, "},{"line_number":11,"context_line":"an explicit error message is shown, making it clear that the "},{"line_number":12,"context_line":"project domain is required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b372f0ac_83427424","line":9,"updated":"2025-03-21 19:20:55.000000000","message":"nit: trailing spaces","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"82a4075e272fa326e30b5d31866c012dd0de67d0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Specifying project-domain for project"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The fix ensures that if a user wants to set a default project, "},{"line_number":10,"context_line":"they must also provide the project domain. If it\u0027s missing, "},{"line_number":11,"context_line":"an explicit error message is shown, making it clear that the "},{"line_number":12,"context_line":"project domain is required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eac184d0_3e2ac15c","line":9,"in_reply_to":"b372f0ac_83427424","updated":"2025-03-22 13:34:29.000000000","message":"Done","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d661dceff002e0c53b96cbca131994b77a5e730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"218d2450_4c836418","updated":"2025-03-21 14:55:58.000000000","message":"Comment inline. I also thing we want to add a unit tests for this to prevent regressions. Can you please modify the calls in the `test_user_set_project_domain` and `test_user_set_project` tests in `openstackclient/tests/unit/identity/v3/test_user.py` to check that `self.identity_sdk_client.find_domain` is/is not called, respectively. It would also be good to add a check that `self.identity_sdk_client.find_project` is always called 🙏","commit_id":"14204711e1709995e83397cef4f60c4e19f6b232"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"66ea544a7f68863e6986c307807c57ff4ca8c2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6951554_ae6ae54c","updated":"2025-03-21 14:20:48.000000000","message":"Hmm, I think this little strange...\n\nWe must be able to change primary project via:\n\nopenstack user set --project new_project user\n\nAfter this case we need use construction:\n\nopenstack user set --project-domain default --project new_project user","commit_id":"14204711e1709995e83397cef4f60c4e19f6b232"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"f43c34570dc3ae670b1fdd18e59acb0179ab22ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c25e6b7_05dcc8a8","in_reply_to":"218d2450_4c836418","updated":"2025-03-21 17:08:10.000000000","message":"@stephenfin@redhat.com\nThanks for reply, modified some checks in test, could you try to lookup if I\u0027ve missed something.","commit_id":"14204711e1709995e83397cef4f60c4e19f6b232"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"814be020c8ff02b8de127bb38693a463426b9a8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"edb2cd3f_7ed4845d","updated":"2025-03-21 19:20:55.000000000","message":"you\u0027ll need to fix those linter failures before we can merge this. I have some other small comments left too","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"53ff16fa0a4a8fb9721a4823224fc21b0458a627","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"930b7756_76cbd5e7","updated":"2025-03-23 07:06:36.000000000","message":"@stephenfin@redhat.com\n\nCould you lookup one more time, if there is something we\u0027re may be missing.\nThanks.","commit_id":"647909348db0a278c82d8df95d101710e82aac78"}],"openstackclient/identity/v3/user.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8d661dceff002e0c53b96cbca131994b77a5e730","unresolved":true,"context_lines":[{"line_number":612,"context_line":"        if parsed_args.description:"},{"line_number":613,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":614,"context_line":"        if parsed_args.project:"},{"line_number":615,"context_line":"            if not parsed_args.project_domain:"},{"line_number":616,"context_line":"                raise ValueError(\"Error: --project-domain must be provided when specifying --project.\")"},{"line_number":617,"context_line":"            project_domain_id \u003d identity_client.find_domain("},{"line_number":618,"context_line":"                name_or_id\u003dparsed_args.project_domain,"},{"line_number":619,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":620,"context_line":"            ).id"},{"line_number":621,"context_line":"            project_id \u003d identity_client.find_project("},{"line_number":622,"context_line":"                name_or_id\u003dparsed_args.project,"},{"line_number":623,"context_line":"                ignore_missing\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"354d675b_49dee448","line":620,"range":{"start_line":615,"start_character":0,"end_line":620,"end_character":16},"updated":"2025-03-21 14:55:58.000000000","message":"This looks like a bug introduced in I06f3848812bce60c65909f1311f36b70eba427d4. This didn\u0027t happen before.\n\nRather than doing this, we should check if `parsed_args.project_domain` and only do the lookup if so:\n\n```suggestion\n            project_domain_id \u003d None\n            if parsed_args.project_domain:\n                project_domain_id \u003d identity_client.find_domain(\n                    name_or_id\u003dparsed_args.project_domain,\n                    ignore_missing\u003dFalse,\n                ).id\n```","commit_id":"14204711e1709995e83397cef4f60c4e19f6b232"},{"author":{"_account_id":37632,"name":"Dmitriy Chubinidze","email":"dcu995@gmail.com","username":"chubinidzedr"},"change_message_id":"7010d96ef04c413a6745b1aa2868bd3912af2195","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        if parsed_args.description:"},{"line_number":613,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":614,"context_line":"        if parsed_args.project:"},{"line_number":615,"context_line":"            if not parsed_args.project_domain:"},{"line_number":616,"context_line":"                raise ValueError(\"Error: --project-domain must be provided when specifying --project.\")"},{"line_number":617,"context_line":"            project_domain_id \u003d identity_client.find_domain("},{"line_number":618,"context_line":"                name_or_id\u003dparsed_args.project_domain,"},{"line_number":619,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":620,"context_line":"            ).id"},{"line_number":621,"context_line":"            project_id \u003d identity_client.find_project("},{"line_number":622,"context_line":"                name_or_id\u003dparsed_args.project,"},{"line_number":623,"context_line":"                ignore_missing\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"260f374c_a2149b37","line":620,"range":{"start_line":615,"start_character":0,"end_line":620,"end_character":16},"in_reply_to":"354d675b_49dee448","updated":"2025-03-21 16:12:27.000000000","message":"Thanks for assistance, now it\u0027s working properly.\nFix applied.","commit_id":"14204711e1709995e83397cef4f60c4e19f6b232"}],"openstackclient/tests/unit/identity/v3/test_user.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"814be020c8ff02b8de127bb38693a463426b9a8f","unresolved":true,"context_lines":[{"line_number":1206,"context_line":"        self.identity_sdk_client.update_user.assert_called_with("},{"line_number":1207,"context_line":"            user\u003dself.user, **kwargs"},{"line_number":1208,"context_line":"        )"},{"line_number":1209,"context_line":"        # Ensure find_domain is NOT called"},{"line_number":1210,"context_line":"        self.identity_sdk_client.find_domain.assert_not_called()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        # Ensure find_project is called"}],"source_content_type":"text/x-python","patch_set":4,"id":"e220b064_619f19fd","line":1209,"updated":"2025-03-21 19:20:55.000000000","message":"nit: you don\u0027t need these comments: the code says as much","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"605be6f6662b98a797922a377d89f13c7ce98145","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"        self.identity_sdk_client.update_user.assert_called_with("},{"line_number":1207,"context_line":"            user\u003dself.user, **kwargs"},{"line_number":1208,"context_line":"        )"},{"line_number":1209,"context_line":"        # Ensure find_domain is NOT called"},{"line_number":1210,"context_line":"        self.identity_sdk_client.find_domain.assert_not_called()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        # Ensure find_project is called"}],"source_content_type":"text/x-python","patch_set":4,"id":"3d00eade_8fa04b0a","line":1209,"in_reply_to":"e220b064_619f19fd","updated":"2025-03-22 13:36:32.000000000","message":"Done","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"814be020c8ff02b8de127bb38693a463426b9a8f","unresolved":true,"context_lines":[{"line_number":1209,"context_line":"        # Ensure find_domain is NOT called"},{"line_number":1210,"context_line":"        self.identity_sdk_client.find_domain.assert_not_called()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        # Ensure find_project is called"},{"line_number":1213,"context_line":"        self.identity_sdk_client.find_project.assert_called_once_with("},{"line_number":1214,"context_line":"        self.project.id, ignore_missing\u003dFalse"},{"line_number":1215,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"f5b1e423_03504035","line":1212,"updated":"2025-03-21 19:20:55.000000000","message":"ditto","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"605be6f6662b98a797922a377d89f13c7ce98145","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        # Ensure find_domain is NOT called"},{"line_number":1210,"context_line":"        self.identity_sdk_client.find_domain.assert_not_called()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        # Ensure find_project is called"},{"line_number":1213,"context_line":"        self.identity_sdk_client.find_project.assert_called_once_with("},{"line_number":1214,"context_line":"        self.project.id, ignore_missing\u003dFalse"},{"line_number":1215,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"69344460_3bac58a3","line":1212,"in_reply_to":"f5b1e423_03504035","updated":"2025-03-22 13:36:32.000000000","message":"Done","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"814be020c8ff02b8de127bb38693a463426b9a8f","unresolved":true,"context_lines":[{"line_number":1210,"context_line":"        self.identity_sdk_client.find_domain.assert_not_called()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        # Ensure find_project is called"},{"line_number":1213,"context_line":"        self.identity_sdk_client.find_project.assert_called_once_with("},{"line_number":1214,"context_line":"        self.project.id, ignore_missing\u003dFalse"},{"line_number":1215,"context_line":"        )"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        self.assertIsNone(result)"},{"line_number":1218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9e96b197_6dc2c6b5","line":1215,"range":{"start_line":1213,"start_character":0,"end_line":1215,"end_character":9},"updated":"2025-03-21 19:20:55.000000000","message":"This formatting is off. Did you install and configure `pre-commit`? If not, you\u0027ll to run `tox -e pep8` and push again.","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"605be6f6662b98a797922a377d89f13c7ce98145","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"        self.identity_sdk_client.find_domain.assert_not_called()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        # Ensure find_project is called"},{"line_number":1213,"context_line":"        self.identity_sdk_client.find_project.assert_called_once_with("},{"line_number":1214,"context_line":"        self.project.id, ignore_missing\u003dFalse"},{"line_number":1215,"context_line":"        )"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        self.assertIsNone(result)"},{"line_number":1218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c880646a_08ec9363","line":1215,"range":{"start_line":1213,"start_character":0,"end_line":1215,"end_character":9},"in_reply_to":"9e96b197_6dc2c6b5","updated":"2025-03-22 13:36:32.000000000","message":"Done","commit_id":"26aec0e9e0dfb02c9648c101e6228044c1ef5b79"}]}