)]}'
{"id":"openstack%2Fpython-openstackclient~946135","triplet_id":"openstack%2Fpython-openstackclient~master~Ib98348cab613b7139f0faa0b5df90ff44353974f","project":"openstack/python-openstackclient","branch":"master","topic":"typing","hashtags":[],"change_id":"Ib98348cab613b7139f0faa0b5df90ff44353974f","subject":"Remove use of formatter function","status":"MERGED","created":"2025-04-02 11:41:35.000000000","updated":"2025-04-02 14:41:24.000000000","submitted":"2025-04-02 14:40:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"946135-typing","meta_rev_id":"3016fa71d81911a70e2cad810fdca7d62e4bf44d","_number":946135,"virtual_id_number":946135,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-04-02 14:40:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2025-04-02 13:34:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2025-04-02 13:34:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-02 13:18:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"750050a389b6bbb6f1b5ac57060cad27ad81601d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-04-02 11:41:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c90f2f5c0cf7b04d939dbd2736e273ecb67e481","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-02 13:18:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9e07cef14cd84f42b02b2af45f38b81c\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/883e9627d9a9441db60c6ef5bdebde4e : SUCCESS in 5m 55s (non-voting)\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/d8534b87c59842ff8dd8b5d3541089bd : SUCCESS in 5m 04s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/0f496bf4d8e34989ad1cb7fca02c74b1 : SUCCESS in 5m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0d804f24516843febd713d75927af302 : SUCCESS in 5m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/15da5ed6523440468c4d6fb2094350f1 : SUCCESS in 3m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/db7ed095982f43688ef514fd4990e53f : SUCCESS in 3m 08s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/629941e2fb9840aaa11accd03aed0416 : SUCCESS in 3m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a3226968ffd4c65b08dc01e9bbcc333 : SUCCESS in 5m 53s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/79a2455a1e354806a6b285585a5296e4 : SUCCESS in 5m 25s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/2bfeb0e0ab5747a0b4ed6b82d7453f85 : SUCCESS in 1h 09m 26s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/783eaa25a4c04e1ba43e2cbbb5d1c771 : SUCCESS in 1h 09m 05s","accounts_in_message":[],"_revision_number":1},{"id":"6b46d5caa4c7297cad9671eeef5413a56b1b6025","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-04-02 13:34:56.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8b0d04c6a0c9913d9752d4dd6b43b3b0b5d648bd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-02 13:35:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"70100ba8dc53afeac638e3e0f845b1735291f650","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-02 14:40:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/947680b9333f431188dcf4993c843c36\n\n- osc-tox-py39-tips https://zuul.opendev.org/t/openstack/build/6b3600a98f734bc5aeb94ba72a74134b : SUCCESS in 6m 51s\n- osc-tox-py312-tips https://zuul.opendev.org/t/openstack/build/cb294425b07d42809928f44a580d6870 : SUCCESS in 6m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/71837695cdd94b17900a622972698ca9 : SUCCESS in 4m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/acb6306e288c4eddb4f7269e41f81080 : SUCCESS in 4m 37s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/9ea32dfe65ae46dab8b830e91a1b36aa : SUCCESS in 4m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7274a062172e4ae59fdf3bc2f563ab0a : SUCCESS in 6m 13s\n- osc-upload-image https://zuul.opendev.org/t/openstack/build/e8c1d858a32b41368c186acfdcca8532 : SUCCESS in 6m 51s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/e19f6970786443f2955ae8cbdab342e7 : SUCCESS in 1h 00m 10s","accounts_in_message":[],"_revision_number":1},{"id":"7d2d23e46f97700a8ffeeb2e4444cdc1b734d65a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-02 14:40:12.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"3016fa71d81911a70e2cad810fdca7d62e4bf44d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-02 14:41:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/115c9fd72c084cf2913988a5d4de3153\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cae0f54f6a7e4885a883fb27025dcf7f : SUCCESS in 50s\n- osc-promote-image https://zuul.opendev.org/t/openstack/build/66343df3cf5747cab18c1af11efc2204 : SUCCESS in 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ac1ad1c4e4975c6c4278167273aefb5de90e1ed6","revisions":{"ac1ad1c4e4975c6c4278167273aefb5de90e1ed6":{"kind":"REWORK","_number":1,"created":"2025-04-02 11:41:35.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/35/946135/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/35/946135/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/946135/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/946135/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/946135/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/35/946135/1"}}},"commit":{"parents":[{"commit":"2148a86fc574f35d730dbcb2951af06ede4315b5","subject":"Merge \"Remove use of formatter function\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2148a86fc574f35d730dbcb2951af06ede4315b5"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-04-02 11:36:23.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-04-02 11:39:26.000000000","tz":60},"subject":"Remove use of formatter function","message":"Remove use of formatter function\n\nWe also update tests to use proper SDK fakes so we actually test this.\n\nChange-Id: Ib98348cab613b7139f0faa0b5df90ff44353974f\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ac1ad1c4e4975c6c4278167273aefb5de90e1ed6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ac1ad1c4e4975c6c4278167273aefb5de90e1ed6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}