)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b767f6bd06f8812976160007ba4128aca15f6792","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Parent:     79de1371 (Merge \"identity: Add missing user argument\")"},{"line_number":2,"context_line":"Author:     xfrnk2 \u003cxfrnk2@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2025-05-18 14:44:43 +0900"},{"line_number":4,"context_line":"Commit:     Beomseok Kim \u003cxfrnk2@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-18 05:56:48 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b6855462_87a1c10d","line":2,"updated":"2025-05-19 11:33:18.000000000","message":"If you would like to ensure your name is associated with this change, I would suggest setting your name correctly in Git. You can do this like so:\n\n```\ngit commit --global user.name \"Beomseok Kim\"\n```\n\n(You may have already done this, based on the `Commit` field being correct)\n\nOnce done, you can then reset this field like so:\n\n```\ngit commit --amend --reset-author\n```\n\nWhat you\u0027ve done is fine but I assume you would like credit for your hard work 😊","commit_id":"d7c0021a97f894af3c33232d5a22815b126caeb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b767f6bd06f8812976160007ba4128aca15f6792","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Beomseok Kim \u003cxfrnk2@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-18 05:56:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace assignment of `Mock` objects to methods that are already mocked in test_network_trunk.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace assignment of `Mock` objects to methods that are already mocked"},{"line_number":10,"context_line":"in the setUp function of TestShowNetworkTrunk class in test_network_trunk.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e8121711_a9aab5a3","line":7,"updated":"2025-05-19 11:33:18.000000000","message":"This is a little verbose. How about something simpler?\n\n```\ntests: Simplify mocking in network trunk tests\n```","commit_id":"d7c0021a97f894af3c33232d5a22815b126caeb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98a35fe86bf9f1b9cc0df2a430d439dab95ace93","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Replace assignment of `Mock` objects to methods that are already mocked in test_network_trunk.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace assignment of `Mock` objects to methods that are already mocked"},{"line_number":10,"context_line":"in the setUp function of TestShowNetworkTrunk class in test_network_trunk.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"story: 2011459"},{"line_number":13,"context_line":"task: 52209"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fb295b0e_8a0b3bb4","line":10,"updated":"2025-05-19 11:34:15.000000000","message":"Please ensure these lines are wrapped at \u003c\u003d 72 characters.","commit_id":"d7c0021a97f894af3c33232d5a22815b126caeb2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fb99ed837d46a4223cef0b027aa1ff915e30ce64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9eb30abe_65e97865","updated":"2025-05-21 09:14:53.000000000","message":"Looks like you need to fix the failing unit tests. Could you also mark the comments that you can resolved as such by clicking the Resolved button, please?","commit_id":"10469290e3aa0c244bee4d343c81356b0cac2c31"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7291a598a6d0cc65118680ebc7ea14d8698c3fc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a229fd1_2a397787","in_reply_to":"9eb30abe_65e97865","updated":"2025-05-21 09:16:32.000000000","message":"Also, you can fix the `pep8` failure by either (a) running `tox -e pep8` or (b) installing and enabling `pre-commit` (`pipx install pre-commit` / `sudo dnf install pre-commit` / `sudo apt install pre-commit`, then `pre-commit install` in the root of the repo)","commit_id":"10469290e3aa0c244bee4d343c81356b0cac2c31"}],"openstackclient/tests/unit/network/v2/test_network_trunk.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd7b0c7d6929db8378b498bbe2919fcdfefddb8e","unresolved":true,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def setUp(self):"},{"line_number":414,"context_line":"        super().setUp()"},{"line_number":415,"context_line":"        self.network_client.find_trunk \u003d mock.Mock(return_value\u003dself.new_trunk)"},{"line_number":416,"context_line":"        self.network_client.get_trunk.return_value \u003d self.new_trunk"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        self.projects_mock.get.return_value \u003d self.project"},{"line_number":419,"context_line":"        self.domains_mock.get.return_value \u003d self.domain"}],"source_content_type":"text/x-python","patch_set":2,"id":"70f231a2_150bd12a","line":416,"range":{"start_line":415,"start_character":0,"end_line":416,"end_character":67},"updated":"2025-05-19 11:27:35.000000000","message":"Can you please replace all instances in this file. So\n\n```suggestion\n        self.network_client.find_trunk.return_value \u003d self.new_trunk\n        self.network_client.get_trunk.return_value \u003d self.new_trunk\n```","commit_id":"d7c0021a97f894af3c33232d5a22815b126caeb2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd7b0c7d6929db8378b498bbe2919fcdfefddb8e","unresolved":true,"context_lines":[{"line_number":563,"context_line":"    )"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def setUp(self):"},{"line_number":566,"context_line":"        super().setUp()"},{"line_number":567,"context_line":"        self.network_client.update_trunk \u003d mock.Mock(return_value\u003dself._trunk)"},{"line_number":568,"context_line":"        self.network_client.add_trunk_subports \u003d mock.Mock("},{"line_number":569,"context_line":"            return_value\u003dself._trunk"},{"line_number":570,"context_line":"        )"},{"line_number":571,"context_line":"        self.network_client.find_trunk \u003d mock.Mock(return_value\u003dself._trunk)"},{"line_number":572,"context_line":"        self.network_client.find_port \u003d mock.Mock("},{"line_number":573,"context_line":"            side_effect\u003d[self.sub_port, self.sub_port]"},{"line_number":574,"context_line":"        )"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        self.projects_mock.get.return_value \u003d self.project"},{"line_number":577,"context_line":"        self.domains_mock.get.return_value \u003d self.domain"}],"source_content_type":"text/x-python","patch_set":2,"id":"11c082e7_0a74c3a7","line":574,"range":{"start_line":566,"start_character":23,"end_line":574,"end_character":9},"updated":"2025-05-19 11:27:35.000000000","message":"```suggestion\n        super().setUp()\n        self.network_client.update_trunk.return_value \u003d self._trunk\n        self.network_client.add_trunk_subports.return_value \u003d self._trunk\n        self.network_client.find_trunk.return_value \u003d self._trunk\n        self.network_client.find_port.side_effect \u003d [self.sub_port, self.sub_port]\n```\n\nDitto for any other entries in this file (hint: grep from `mock.Mock`)","commit_id":"d7c0021a97f894af3c33232d5a22815b126caeb2"}]}