)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b0ef36935d05e7344765a603d58d42e8a36bfcc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79e1c69c_ea374eac","updated":"2025-05-21 09:13:31.000000000","message":"I suspect there\u0027s a dependency on the openstacksdk change that needs to be noted also?","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93ef496acad197b4e5cc35b9bc7eeacce2b4c748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32860274_6a7f81dd","updated":"2025-05-21 09:12:58.000000000","message":"Some minor nits inline","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"305a5ce9206b6584aaab7c7ce363a97fbe772e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad26f8f9_61586e76","updated":"2025-05-26 08:39:18.000000000","message":"recheck\nosc-functional-devstack failure is not related","commit_id":"d6e345ae3870213b56069d339c37ca2dec81e195"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bdc7b24aa3af149d026ad7f8ed666ddbba8984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8882ac6b_bc6bc05d","updated":"2025-05-29 14:48:20.000000000","message":"You will need to bump the minimum version of SDK in `requirements.txt` once the dependency merges and is released, but this otherwise looks good to me.","commit_id":"49113c66a899316b67c0a427308078636fde9273"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"999aecfb4147719df571fb4187d348777eff7218","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ea2fd60_6804ee7b","updated":"2025-07-15 13:28:18.000000000","message":"Added the SDK to requirements.txt","commit_id":"1b2dfeacf49e14bb97449f3861a976351153057e"}],"openstackclient/network/v2/security_group.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93ef496acad197b4e5cc35b9bc7eeacce2b4c748","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        shared_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":257,"context_line":"        shared_group.add_argument("},{"line_number":258,"context_line":"            \u0027--share\u0027,"},{"line_number":259,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":260,"context_line":"            help\u003d_(\"List Security-Groups shared between projects\"),"},{"line_number":261,"context_line":"        )"},{"line_number":262,"context_line":"        shared_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"7729f691_5d69ac59","line":259,"updated":"2025-05-21 09:12:58.000000000","message":"If you use a common dest, you can avoid the logic below:\n\n\n```suggestion\n            action\u003d\u0027store_true\u0027,\n            dest\u003d\u0027shared\u0027,\n            default\u003dNone,\n```","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bdc7b24aa3af149d026ad7f8ed666ddbba8984","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        shared_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":257,"context_line":"        shared_group.add_argument("},{"line_number":258,"context_line":"            \u0027--share\u0027,"},{"line_number":259,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":260,"context_line":"            help\u003d_(\"List Security-Groups shared between projects\"),"},{"line_number":261,"context_line":"        )"},{"line_number":262,"context_line":"        shared_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"a295453b_f8472e07","line":259,"in_reply_to":"7729f691_5d69ac59","updated":"2025-05-29 14:48:20.000000000","message":"Done","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93ef496acad197b4e5cc35b9bc7eeacce2b4c748","unresolved":true,"context_lines":[{"line_number":257,"context_line":"        shared_group.add_argument("},{"line_number":258,"context_line":"            \u0027--share\u0027,"},{"line_number":259,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":260,"context_line":"            help\u003d_(\"List Security-Groups shared between projects\"),"},{"line_number":261,"context_line":"        )"},{"line_number":262,"context_line":"        shared_group.add_argument("},{"line_number":263,"context_line":"            \u0027--no-share\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0fc27e96_69ad65ca","line":260,"range":{"start_line":260,"start_character":25,"end_line":260,"end_character":40},"updated":"2025-05-21 09:12:58.000000000","message":"```suggestion\n            help\u003d_(\"List security groups shared between projects\"),\n```","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bdc7b24aa3af149d026ad7f8ed666ddbba8984","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        shared_group.add_argument("},{"line_number":258,"context_line":"            \u0027--share\u0027,"},{"line_number":259,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":260,"context_line":"            help\u003d_(\"List Security-Groups shared between projects\"),"},{"line_number":261,"context_line":"        )"},{"line_number":262,"context_line":"        shared_group.add_argument("},{"line_number":263,"context_line":"            \u0027--no-share\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"347ea76f_07b73adf","line":260,"range":{"start_line":260,"start_character":25,"end_line":260,"end_character":40},"in_reply_to":"0fc27e96_69ad65ca","updated":"2025-05-29 14:48:20.000000000","message":"Done","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93ef496acad197b4e5cc35b9bc7eeacce2b4c748","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        )"},{"line_number":262,"context_line":"        shared_group.add_argument("},{"line_number":263,"context_line":"            \u0027--no-share\u0027,"},{"line_number":264,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":265,"context_line":"            help\u003d_(\"List Security-Groups not shared between projects\"),"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3cc8747a_06a77e89","line":264,"updated":"2025-05-21 09:12:58.000000000","message":"```suggestion\n            action\u003d\u0027store_false\u0027,\n            dest\u003d\u0027shared\u0027,\n            default\u003dNone,\n```","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bdc7b24aa3af149d026ad7f8ed666ddbba8984","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        )"},{"line_number":262,"context_line":"        shared_group.add_argument("},{"line_number":263,"context_line":"            \u0027--no-share\u0027,"},{"line_number":264,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":265,"context_line":"            help\u003d_(\"List Security-Groups not shared between projects\"),"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"24ac2150_26e77b69","line":264,"in_reply_to":"3cc8747a_06a77e89","updated":"2025-05-29 14:48:20.000000000","message":"Done","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93ef496acad197b4e5cc35b9bc7eeacce2b4c748","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        shared_group.add_argument("},{"line_number":263,"context_line":"            \u0027--no-share\u0027,"},{"line_number":264,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":265,"context_line":"            help\u003d_(\"List Security-Groups not shared between projects\"),"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        _tag.add_tag_filtering_option_to_parser("}],"source_content_type":"text/x-python","patch_set":1,"id":"c6e6db47_88eb029c","line":265,"updated":"2025-05-21 09:12:58.000000000","message":"```suggestion\n            help\u003d_(\"List security groups not shared between projects\"),\n```","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bdc7b24aa3af149d026ad7f8ed666ddbba8984","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        shared_group.add_argument("},{"line_number":263,"context_line":"            \u0027--no-share\u0027,"},{"line_number":264,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":265,"context_line":"            help\u003d_(\"List Security-Groups not shared between projects\"),"},{"line_number":266,"context_line":"        )"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        _tag.add_tag_filtering_option_to_parser("}],"source_content_type":"text/x-python","patch_set":1,"id":"dd2e3c60_d98308b2","line":265,"in_reply_to":"c6e6db47_88eb029c","updated":"2025-05-29 14:48:20.000000000","message":"Done","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93ef496acad197b4e5cc35b9bc7eeacce2b4c748","unresolved":true,"context_lines":[{"line_number":292,"context_line":"            ).id"},{"line_number":293,"context_line":"            filters[\u0027project_id\u0027] \u003d project_id"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        if parsed_args.share:"},{"line_number":296,"context_line":"            filters[\u0027shared\u0027] \u003d True"},{"line_number":297,"context_line":"        if parsed_args.no_share:"},{"line_number":298,"context_line":"            filters[\u0027shared\u0027] \u003d False"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        _tag.get_tag_filtering_args(parsed_args, filters)"},{"line_number":301,"context_line":"        data \u003d client.security_groups("}],"source_content_type":"text/x-python","patch_set":1,"id":"31450332_8b90be46","line":298,"range":{"start_line":295,"start_character":0,"end_line":298,"end_character":37},"updated":"2025-05-21 09:12:58.000000000","message":"```suggestion\n        if parsed_args.shared is not None:\n            filters[\u0027shared\u0027] \u003d parsed_args.shared\n```\n\nAlso, shouldn\u0027t the filter be `is_shared`, per [the SDK change](https://review.opendev.org/c/openstack/openstacksdk/+/950305)?","commit_id":"1395003b72a39aa468e13224a21194feea581dec"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8bdc7b24aa3af149d026ad7f8ed666ddbba8984","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            ).id"},{"line_number":293,"context_line":"            filters[\u0027project_id\u0027] \u003d project_id"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        if parsed_args.share:"},{"line_number":296,"context_line":"            filters[\u0027shared\u0027] \u003d True"},{"line_number":297,"context_line":"        if parsed_args.no_share:"},{"line_number":298,"context_line":"            filters[\u0027shared\u0027] \u003d False"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        _tag.get_tag_filtering_args(parsed_args, filters)"},{"line_number":301,"context_line":"        data \u003d client.security_groups("}],"source_content_type":"text/x-python","patch_set":1,"id":"f8d87721_7223350c","line":298,"range":{"start_line":295,"start_character":0,"end_line":298,"end_character":37},"in_reply_to":"31450332_8b90be46","updated":"2025-05-29 14:48:20.000000000","message":"Done","commit_id":"1395003b72a39aa468e13224a21194feea581dec"}]}