)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2d7047bcafaa9a27034cd99bfe97262008648abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ba8655b_8ea32c75","updated":"2025-10-14 17:00:37.000000000","message":"Thanks. Some tweaks requested inline.","commit_id":"e602a4cbecfcf8c6220e2b1b22aaae90fe324571"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2d7047bcafaa9a27034cd99bfe97262008648abb","unresolved":true,"context_lines":[{"line_number":713,"context_line":"                        ignore_missing\u003dFalse,"},{"line_number":714,"context_line":"                    )"},{"line_number":715,"context_line":"                except sdk_exceptions.ResourceNotFound:"},{"line_number":716,"context_line":"                    msg \u003d _(\"Multi Backend support not enabled.\")"},{"line_number":717,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":718,"context_line":"            except Exception as e:"},{"line_number":719,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"529d06e1_4f181db8","line":716,"updated":"2025-10-14 17:00:37.000000000","message":"Can you add a comment explaining why the error means this? I\u0027m guessing based on the assumption that the `find_image` call would have failed if the image was not found, which means the only other thing that could be \"not found\" is the store.\n\nRelated: couldn\u0027t this error mean the store wasn\u0027t a valid store or the user had a typo?","commit_id":"e602a4cbecfcf8c6220e2b1b22aaae90fe324571"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"7c584a106c1a31e9113ba9e6b014e53ae04498e2","unresolved":true,"context_lines":[{"line_number":713,"context_line":"                        ignore_missing\u003dFalse,"},{"line_number":714,"context_line":"                    )"},{"line_number":715,"context_line":"                except sdk_exceptions.ResourceNotFound:"},{"line_number":716,"context_line":"                    msg \u003d _(\"Multi Backend support not enabled.\")"},{"line_number":717,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":718,"context_line":"            except Exception as e:"},{"line_number":719,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"d0adfd64_e8ad7d66","line":716,"in_reply_to":"529d06e1_4f181db8","updated":"2025-10-15 13:40:24.000000000","message":"Honestly I am not yet sure why exactly this message is used.\n\nI presume because glance returns 404 when you ask for a \"store\" in request, but glance is not configured with \"stores\" at all.\nSecond reason why return 404 would be actual UUID is not there at all, but that was kind of ruled out since we got here at all by find_image.\nSo need to check what Glance API returns when it is set in multistore mode, and I use delete call with non-existent store, or store where this particular image is not stored actually.","commit_id":"e602a4cbecfcf8c6220e2b1b22aaae90fe324571"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2d7047bcafaa9a27034cd99bfe97262008648abb","unresolved":true,"context_lines":[{"line_number":714,"context_line":"                    )"},{"line_number":715,"context_line":"                except sdk_exceptions.ResourceNotFound:"},{"line_number":716,"context_line":"                    msg \u003d _(\"Multi Backend support not enabled.\")"},{"line_number":717,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":718,"context_line":"            except Exception as e:"},{"line_number":719,"context_line":"                result +\u003d 1"},{"line_number":720,"context_line":"                msg \u003d _("}],"source_content_type":"text/x-python","patch_set":3,"id":"75860b38_06c748a5","line":717,"updated":"2025-10-14 17:00:37.000000000","message":"Rather than nesting the `try`, can you move this out to a separate block. You\u0027ll have to duplicate the other exception block but I think that\u0027s reasonable.","commit_id":"e602a4cbecfcf8c6220e2b1b22aaae90fe324571"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"7c584a106c1a31e9113ba9e6b014e53ae04498e2","unresolved":true,"context_lines":[{"line_number":714,"context_line":"                    )"},{"line_number":715,"context_line":"                except sdk_exceptions.ResourceNotFound:"},{"line_number":716,"context_line":"                    msg \u003d _(\"Multi Backend support not enabled.\")"},{"line_number":717,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":718,"context_line":"            except Exception as e:"},{"line_number":719,"context_line":"                result +\u003d 1"},{"line_number":720,"context_line":"                msg \u003d _("}],"source_content_type":"text/x-python","patch_set":3,"id":"d6b53694_5e7a1c4d","line":717,"in_reply_to":"75860b38_06c748a5","updated":"2025-10-15 13:40:24.000000000","message":"yeah, can do that.","commit_id":"e602a4cbecfcf8c6220e2b1b22aaae90fe324571"}]}
