)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aaf3ea8ac0d806fc75c7fed4db955f47a7ce9978","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96e51699_3166778c","updated":"2025-11-12 11:51:32.000000000","message":"Repeating myself from IRC:\n\n\u003e \u003cstephenfin\u003e cardoe: I agree that the current position is pretty rubbish. My concern is that by switching to a subset check, we have no incentive to update the tests after we add a new field and we will drift further and further from what\u0027s actually in the output.\n\u003e \u003cstephenfin\u003e *but* I have no clever idea yet (at least one an uncomplicated one that doesn\u0027t involve timestamps and a N month countdown before it starts erroring again) hence the demurring\n\u003e \u003cstephenfin\u003e s/at least one/at least/\n\nI think in the absence of better ideas, we can and should probably do this, however, I believe there are some issues with the existing change and we should also make the same change to other tests (perhaps on a service-by-service basis)","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"dfda052d7c6f2270583171207f32a2e8dfe5aeac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da7ccad2_6bf62015","updated":"2025-10-27 16:29:31.000000000","message":"This should achieve the goal of landing the other patch without multiple releases. That patch failed because of network issues and unrelated issues it seems like.","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cc9d7a039c9a71c8e8643569a2d5b3ceba45e14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d39532b_b1f8f00a","updated":"2025-10-22 10:33:02.000000000","message":"don\u0027t you need to do the same for other resources?\nFor example for ports (https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/unit/network/v2/test_port.py#L155-L183 ) only assertCountEqual asserts used","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"a95093efeefa9bbab94076200bb993293f72f604","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d593257_5c56f5b2","in_reply_to":"7d39532b_b1f8f00a","updated":"2025-10-27 14:00:06.000000000","message":"Maybe. This was to enable https://review.opendev.org/c/openstack/openstacksdk/+/952158 landing.","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"98c48922422271198722510bd35b2e53eebfbea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb8eec24_04ae89ff","in_reply_to":"9d593257_5c56f5b2","updated":"2025-10-27 15:26:11.000000000","message":"ok, thanks, I am fine with it, perhaps as follow-up other tests can be checked","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ea81193cd2ad422b24b5f3bfc7f603fcdf917fdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"595574b7_5689d96d","updated":"2025-12-18 00:16:32.000000000","message":"@stephenfin@redhat.com is this approach good?","commit_id":"bbc14d7fc2d51d2f795281c64f75673fa4c6e06c"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"31d112d173c79e9bdde637014495f5804eaa2750","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"004d082e_78f36a47","updated":"2026-01-07 00:12:31.000000000","message":"What can we do to land this? This is the precursor to adding more fields from neutron so we can use the client to fetch data instead of neutron client and be able to migrate.","commit_id":"bbc14d7fc2d51d2f795281c64f75673fa4c6e06c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2363a2b63dfcdbbb6d8061cbfa950530d56a72c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7b3a8b4f_5f463bb9","in_reply_to":"004d082e_78f36a47","updated":"2026-01-07 09:57:57.000000000","message":"There is still [an open comment](https://review.opendev.org/c/openstack/python-openstackclient/+/963947/comment/db9770db_6496a9de/) on this. In addition, this feels like something that should be done for all tests (or at least all network tests) if we\u0027re going to do it?","commit_id":"bbc14d7fc2d51d2f795281c64f75673fa4c6e06c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"54f4d1f4d9fff8b4ebaa56ca8c6ebe555fce376e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"756f7c75_b3e0c3ed","updated":"2026-02-19 07:32:37.000000000","message":"thanks good aproach","commit_id":"267eb2111418a8fb845d5194e1e418613416282a"}],"openstackclient/tests/unit/network/v2/test_network.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aaf3ea8ac0d806fc75c7fed4db955f47a7ce9978","unresolved":true,"context_lines":[{"line_number":164,"context_line":"            }"},{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":"        self.assertFalse(self.network_client.set_tags.called)"},{"line_number":167,"context_line":"        self.assertTrue(set(self.columns).issubset(set(columns)))"},{"line_number":168,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_create_all_options(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a083a957_c9620396","line":167,"updated":"2025-11-12 11:51:32.000000000","message":"This could probably be a new `assertIsSubset` helper on the base class.","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aaf3ea8ac0d806fc75c7fed4db955f47a7ce9978","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":"        self.assertFalse(self.network_client.set_tags.called)"},{"line_number":167,"context_line":"        self.assertTrue(set(self.columns).issubset(set(columns)))"},{"line_number":168,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_create_all_options(self):"},{"line_number":171,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"db9770db_6496a9de","line":168,"updated":"2025-11-12 11:51:32.000000000","message":"You\u0027ll also need to change these","commit_id":"65110cbcba0c612d880df6805bff8a7ce8c5b897"}]}