)]}'
{"id":"openstack%2Fpython-openstackclient~966438","triplet_id":"openstack%2Fpython-openstackclient~master~I04672d46595e93b19f873a54d5be9363d262370b","project":"openstack/python-openstackclient","branch":"master","topic":"hacking","hashtags":[],"change_id":"I04672d46595e93b19f873a54d5be9363d262370b","subject":"tests: Avoid more unnecessary mocks","status":"MERGED","created":"2025-11-07 14:07:19.000000000","updated":"2025-11-07 17:20:44.000000000","submitted":"2025-11-07 17:18:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"966438-hacking","meta_rev_id":"f2a56ae17077e41a0b1b299317a54347d375a1c7","_number":966438,"virtual_id_number":966438,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-11-07 17:18:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-11-07 15:43:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-11-07 15:43:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-07 15:34:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a1553cd53d66f3478a1ba7538fb51702a2e660ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-11-07 14:07:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a60870d82bcd3b8720e6e553484a61beabad101f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 15:34:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c0cd664ec0714894b31b64e6fdba497d\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/7ca1f6e7681f428b8ee153d97dbbb327 : SUCCESS in 6m 54s (non-voting)\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/48ba33e5642d40c49c99d706767bfcca : SUCCESS in 5m 07s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/4f7e8eddad8d4d4e8a283cf45215f710 : SUCCESS in 7m 17s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/72ee1a1d11c7446faf113bfc2672e01f : SUCCESS in 4m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3a8872961d434ca0bfef09b695386ced : SUCCESS in 5m 29s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/cdf075d316b548c3903a1368076101f8 : SUCCESS in 3m 47s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0e3d47fb503049e1a0be958d90d24dd3 : SUCCESS in 5m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee77347f56714ce88f80cb81a55c314a : SUCCESS in 5m 50s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/7099451011b840ea92b28bbcd4e12644 : FAILURE in 5m 01s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/ac22ac3deab244a19cda21f48ef91c71 : SUCCESS in 47m 40s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/4b2ea46fb0614016ab87e9ef0bb9e472 : SUCCESS in 1h 14m 58s","accounts_in_message":[],"_revision_number":1},{"id":"d577289e9ae23e7e58483fc391943e979850d7ef","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-11-07 15:43:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5385e2f703659e068a07d215201d00f059f13e81","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 15:44:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"762461adf84b0b1b28235a8b47e277bfae9eabd4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 17:18:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/70c0f0b5b00b434e8eb4d7550f214cfa\n\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/aaa56bd8ad5e4645b82aff8c9942ec7e : SUCCESS in 6m 59s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/1ce99b0ff7164fcdac345a41ab71a4c7 : SUCCESS in 8m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7d73e5cc560b4a35968dc3db1411b764 : SUCCESS in 4m 44s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/463e1e64d87d461fb2f666b25534e2cb : SUCCESS in 4m 02s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/91da63be10e24c44920e76fa89477051 : SUCCESS in 8m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f6ac39baa9b94e6e9cf5dc56aa815a77 : SUCCESS in 7m 24s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/eb8aa77f506f42bfb11e355d52c10e2f : SUCCESS in 1h 06m 06s","accounts_in_message":[],"_revision_number":1},{"id":"6763c154550d674cc9e3df9be2bb4bc4a2427151","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 17:18:53.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"f2a56ae17077e41a0b1b299317a54347d375a1c7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 17:20:44.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5ba20af91ed94e70bb2051d4cf8ce05f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a8eeabdc265548c7b1f3ac5bcb15c269 : SUCCESS in 39s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7116449190d9cbc144ede942163ed7678cde2edd","revisions":{"7116449190d9cbc144ede942163ed7678cde2edd":{"kind":"REWORK","_number":1,"created":"2025-11-07 14:07:19.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/38/966438/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/38/966438/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/38/966438/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/38/966438/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/38/966438/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/38/966438/1"}}},"commit":{"parents":[{"commit":"44dfa157e4172616fb4ff75e1b3aa843c105efae","subject":"tests: Remove duplicated fake network client","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/44dfa157e4172616fb4ff75e1b3aa843c105efae"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-07 13:40:36.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-07 14:06:36.000000000","tz":0},"subject":"tests: Avoid more unnecessary mocks","message":"tests: Avoid more unnecessary mocks\n\nChange-Id: I04672d46595e93b19f873a54d5be9363d262370b\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7116449190d9cbc144ede942163ed7678cde2edd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7116449190d9cbc144ede942163ed7678cde2edd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
