)]}'
{"id":"openstack%2Fpython-openstackclient~966439","triplet_id":"openstack%2Fpython-openstackclient~master~Ic0ddc95100811e7b313b519aad7d687a1415020b","project":"openstack/python-openstackclient","branch":"master","topic":"hacking","hashtags":[],"change_id":"Ic0ddc95100811e7b313b519aad7d687a1415020b","subject":"Add new hacking rules","status":"MERGED","created":"2025-11-07 14:07:19.000000000","updated":"2025-11-07 18:18:31.000000000","submitted":"2025-11-07 18:17:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"966439-hacking","meta_rev_id":"731a9c90f0af7788bae292a80166f2ff0ca6c319","_number":966439,"virtual_id_number":966439,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-11-07 18:17:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-11-07 15:46:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-11-07 15:46:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-07 15:22:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8f7cf2b0a80c28ee6348e931953b3bbe7d1c88f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-11-07 14:07:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"057c563c08de37f7631ae774cd308e751b020408","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 15:22:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/17d852a412864538a3b0366e966e78e9\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/a45bd64c231b48b5a6c8dd9901a55d94 : SUCCESS in 2m 24s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/1097d9313d774aa89cc6f80e4ced04aa : SUCCESS in 6m 07s (non-voting)\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/f1a67899acd1455dbd4325ca78efb727 : SUCCESS in 4m 39s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/58d14ab9b69c483380e81b496dd8ec16 : SUCCESS in 7m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/826ee1b04e4b49289b69641760911616 : SUCCESS in 5m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0a611192b0d44d3293d7592f1769043d : SUCCESS in 4m 10s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/79de4a5cd7aa4a3da2678e0b2d676ccb : SUCCESS in 3m 54s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/aff232ec5e1f47b2a676ab9ef0e06441 : SUCCESS in 6m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/693e6f6cbf5e478283d415da3ad40418 : SUCCESS in 7m 08s\n- requirements-check https://zuul.opendev.org/t/openstack/build/a89c1d2f1b634b8181facf54266ff64a : SUCCESS in 2m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2bc6ed0d0c6d4afa8cfe8f94eed825b3 : SUCCESS in 4m 48s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/8eef6711d8ac4d1d920f486ec70351df : FAILURE in 4m 56s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/ac68b5f2c7384458b725aef91af3b0c8 : SUCCESS in 59m 04s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/b468d2f76a3a4fb3a00935fa2801f6da : SUCCESS in 1h 06m 05s","accounts_in_message":[],"_revision_number":1},{"id":"1e603fe0f04288a0a22576012044b17a5277d8aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-11-07 15:45:56.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"ddb3063c51eef9a667d24b3698c051ce16b77f87","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-11-07 15:46:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"74db816f22e8b90dcf0bcc98d2be60d0d1395b32","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 16:57:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/66f0c826c60746aaa35308a0c9718e22\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/5ee305bd6a1245958cd17bb56d92cf93 : SUCCESS in 2m 16s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/28b7e99027064d8085f1bcb561f1be2f : SUCCESS in 6m 05s (non-voting)\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/5ab6c47d9a00490fa52baa28be7bdacb : SUCCESS in 5m 12s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/91656a8d4821442cb66f0bd64017264f : SUCCESS in 7m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e7b1728a7445478aac262fdd43eebe10 : SUCCESS in 4m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/30a47a0d561243c197e2556d2338547c : SUCCESS in 3m 43s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/705b65dad78c48459b4e7648344d9530 : SUCCESS in 3m 32s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/c213f6ebafbc416d85ad49e7bdbc3d43 : SUCCESS in 6m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2fe04ee259b24b9d9e49320a35f17d9c : SUCCESS in 6m 03s\n- requirements-check https://zuul.opendev.org/t/openstack/build/7725c505ceb8431c87e8bd8fc295b831 : SUCCESS in 2m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4a168d70dbe340feab76665fdfa972b5 : SUCCESS in 4m 23s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/b719ed53f52d4d8398bb5a448f08ed48 : FAILURE in 4m 35s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/4625c922fbe64c378ef9e322529d173c : SUCCESS in 1h 01m 53s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/3ec4a1c758864b68b97b4db5011f71e8 : SUCCESS in 1h 09m 49s","accounts_in_message":[],"_revision_number":2},{"id":"85f07827d65c24c6dd3dca55d5f135af85deaf3e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 16:58:29.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1eaf71637179436e00279476d0872866b4d73cfa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 18:17:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e1d953b772da4363b60e24f3f02a757f\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/8cc8035720d543f2a1fa7c98473e5e53 : SUCCESS in 2m 45s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/ce29abaf44ec401e8074ae3ee836fb18 : SUCCESS in 5m 07s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/4f3a0547bc37444c9c7ad4e48c1770dd : SUCCESS in 5m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4db1cad07380470eb41b8933b08c95e2 : SUCCESS in 4m 15s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/0cd72ee72ac64d22af0e66f81a5c0a28 : SUCCESS in 4m 11s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/e31a19c3b2c24edc823723e7a34fc1a1 : SUCCESS in 6m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/80f5066994a548f4b5464e44b1706d2a : SUCCESS in 6m 57s\n- requirements-check https://zuul.opendev.org/t/openstack/build/da45fdb8873e4018a375476d9c023c53 : SUCCESS in 2m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cace3b6666764c29b03249ba22a854bb : SUCCESS in 4m 43s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/1d1edf52dcbd48abbb46d86fd8db173e : SUCCESS in 1h 14m 15s","accounts_in_message":[],"_revision_number":2},{"id":"1035c5201878f104eba387ffaf585f87712a42e9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 18:17:29.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"731a9c90f0af7788bae292a80166f2ff0ca6c319","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-11-07 18:18:31.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a1de54689fc5438488a5c1b2f8879a9f\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01abe54f282b4cce9de5defaecea517c : SUCCESS in 53s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7d74a0896dfa406f81825d2e7503f8d7 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eb7c4c61a9253b99e9e658d27b4f0170c183d6ce","revisions":{"2214e19252c7f80836e7782c177661e03011ee92":{"kind":"REWORK","_number":1,"created":"2025-11-07 14:07:19.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/39/966439/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/39/966439/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/1"}}},"commit":{"parents":[{"commit":"7116449190d9cbc144ede942163ed7678cde2edd","subject":"tests: Avoid more unnecessary mocks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7116449190d9cbc144ede942163ed7678cde2edd"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-07 12:41:29.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-07 14:06:49.000000000","tz":0},"subject":"Add new hacking rules","message":"Add new hacking rules\n\nTo catch some obvious issues.\n\nChange-Id: Ic0ddc95100811e7b313b519aad7d687a1415020b\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2214e19252c7f80836e7782c177661e03011ee92"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2214e19252c7f80836e7782c177661e03011ee92"}]},"branch":"refs/heads/master"},"eb7c4c61a9253b99e9e658d27b4f0170c183d6ce":{"kind":"REWORK","_number":2,"created":"2025-11-07 15:45:56.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/39/966439/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/39/966439/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/39/966439/2"}}},"commit":{"parents":[{"commit":"7116449190d9cbc144ede942163ed7678cde2edd","subject":"tests: Avoid more unnecessary mocks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7116449190d9cbc144ede942163ed7678cde2edd"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-07 12:41:29.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-07 15:45:51.000000000","tz":0},"subject":"Add new hacking rules","message":"Add new hacking rules\n\nTo catch some obvious issues.\n\nChange-Id: Ic0ddc95100811e7b313b519aad7d687a1415020b\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eb7c4c61a9253b99e9e658d27b4f0170c183d6ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eb7c4c61a9253b99e9e658d27b4f0170c183d6ce"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}