)]}'
{"id":"openstack%2Fpython-openstackclient~970816","triplet_id":"openstack%2Fpython-openstackclient~master~I3727fd9238df966b3bc59812c5efcf3398da5c72","project":"openstack/python-openstackclient","branch":"master","topic":"integrate-manilaclient","hashtags":[],"change_id":"I3727fd9238df966b3bc59812c5efcf3398da5c72","subject":"volume: Remove negotiation for v1 API","status":"MERGED","created":"2025-12-12 11:25:04.000000000","updated":"2025-12-12 15:04:53.000000000","submitted":"2025-12-12 15:03:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"970816-integrate-manilaclient","meta_rev_id":"016767f7f68474c4f7ff83ef39a19bd45061b39f","_number":970816,"virtual_id_number":970816,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-12-12 15:03:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-12-12 12:48:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-12-12 12:48:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-12 13:03:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"702c14bb449e9ddfd36f6ad3d292d7c5d461bc79","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-12 11:25:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2734befac446fc602b484e364f75cca2e4223cde","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-12 12:48:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5832e81e5fe23e59407bf701445a499577afddb2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-12 13:03:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1829505ed8c8435bb86e84b9cf241eb0\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/e831f13bf0f247589144fffa3c8b0c10 : FAILURE in 7m 47s (non-voting)\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/e1ed18fe4bd04aec8a935f08eac71093 : SUCCESS in 5m 19s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/634b418e50fb45ed97e740189259fd45 : SUCCESS in 7m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a7aac1dd73794a358b7f3448d7f224cb : SUCCESS in 4m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fe2ebac132754075bc9e4a98671182d9 : SUCCESS in 5m 31s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a5edaf27fd234907a5a3cec917d9a223 : SUCCESS in 3m 40s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/bf5cd3613bd146b49d6db89836ac66e2 : SUCCESS in 7m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/876a622cbf4546c0900d67699dd2ba88 : SUCCESS in 5m 38s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/2d2106ae624a4b979793996673b10518 : FAILURE in 6m 43s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/bc628595b4154f52b8e11231719b1f58 : SUCCESS in 1h 13m 50s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/4aa82fbe1cfb4546a23655469c8c6800 : SUCCESS in 1h 18m 28s","accounts_in_message":[],"_revision_number":1},{"id":"c007f93746e094a0d701b4cad23714545d143484","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-12 13:06:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9167b0041bca8b4163b8ca2b44aa09c7c675b8a7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-12 15:03:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/37c8efb8fcc8412791bd5916bac8ce70\n\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/0681e3d20a8748c18399ccecf1d45a86 : SUCCESS in 3m 14s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/4397b6e9a03f42e7b71ac4082215101d : SUCCESS in 7m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5ea65705812f4eddb084562e831c7a9f : SUCCESS in 5m 04s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/f5f23d4304f84c3dbc2fb9639b4be6b4 : SUCCESS in 3m 39s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fd0f104bde52450ab30f81397728a2f3 : SUCCESS in 5m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b126f44bbbe741bbbb5a52eeda08b5c7 : SUCCESS in 3m 42s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/221130f8683e4f5facf1cb8eccdedd49 : SUCCESS in 1h 13m 31s","accounts_in_message":[],"_revision_number":1},{"id":"1d645f1fae054a1d5975737af0f4d2498a821027","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-12 15:03:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"016767f7f68474c4f7ff83ef39a19bd45061b39f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-12 15:04:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/12ee19b432024a7f8b478ed09ce11e47\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5caff17b4c2040569eae675d9115896a : SUCCESS in 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a7e2f31ecc32ff939799c09d41234c2a991fc87b","revisions":{"a7e2f31ecc32ff939799c09d41234c2a991fc87b":{"kind":"REWORK","_number":1,"created":"2025-12-12 11:25:04.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/16/970816/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/16/970816/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/16/970816/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/16/970816/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/16/970816/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/16/970816/1"}}},"commit":{"parents":[{"commit":"de4e119272a463739d75ac6d2394dea0c8a9c57d","subject":"Merge \"typing: Add types to custom formatters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de4e119272a463739d75ac6d2394dea0c8a9c57d"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-11-28 16:47:52.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-12 10:32:12.000000000","tz":0},"subject":"volume: Remove negotiation for v1 API","message":"volume: Remove negotiation for v1 API\n\nChange Ibe1cd6461d2cb78826467078aa17272f171746aa removed support for the\nv1 volume API. We should have removed this check at the same time.\n\nWe also remove some god-awful monkey patching that references v1\ncinderclient but in practice modified all clients.\n\nChange-Id: I3727fd9238df966b3bc59812c5efcf3398da5c72\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a7e2f31ecc32ff939799c09d41234c2a991fc87b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a7e2f31ecc32ff939799c09d41234c2a991fc87b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
