)]}'
{"id":"openstack%2Fpython-openstackclient~978698","triplet_id":"openstack%2Fpython-openstackclient~stable%2F2026.1~I8b09846ff8fc6ee51ba03531f5b41039282ee1c0","project":"openstack/python-openstackclient","branch":"stable/2026.1","topic":"typing","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2026-03-04 20:23:31.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"I8b09846ff8fc6ee51ba03531f5b41039282ee1c0","subject":"typing: Add class variables to testcases","status":"MERGED","created":"2026-03-03 10:24:40.000000000","updated":"2026-03-04 21:03:45.000000000","submitted":"2026-03-04 21:02:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"978698-typing","meta_rev_id":"d8c3fb2ea6fb68f0fc5c5c06ff89d949ebdef68e","_number":978698,"virtual_id_number":978698,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-03-04 21:02:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-03-03 10:26:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-03-04 20:23:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-03 10:47:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bd0c396bd1ea5cf9b44a8154490eea54f98d273b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-03 10:24:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"238f08024660335552a36e75408ebe6088cc711e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-03 10:25:37.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c5c2afeda7ba1b3ec80308cf191e5425de6ddecd","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-03 10:26:13.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d9ee2a5495f88069c57df90b466ea9de0aea1335","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-03 10:47:44.000000000","message":"Patch Set 2: Verified-1\n\n(6 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/f109e24d86d74265a051348241a4deda\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b8c94da4dc534f25a5551c6889564355 : SUCCESS in 4m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d8a7b31d32db47619ae33ff97cb616f4 : FAILURE in 4m 49s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/67f5a01359e04534b269e017c3563f6c : SUCCESS in 3m 53s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/97b780c28e064a44a31609966f5970f7 : SUCCESS in 5m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e85c4f21771d404697e19876b44d7883 : SUCCESS in 5m 09s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/ca040d1541ef4a089f7f253d3d78ebd0 : FAILURE in 3m 54s (non-voting)\n\nWarning:\n  Comments left for invalid file openstackclient/tests/functional/common/test_help.py\n  Comments left for invalid file openstackclient/tests/functional/image/v1/test_image.py\n  Comments left for invalid file openstackclient/tests/functional/image/v2/test_image.py","accounts_in_message":[],"_revision_number":2},{"id":"ea1fca97978899c303162bc7a0c8164e52629057","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-04 20:23:31.000000000","message":"Patch Set 2: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"238643b73455e408cacc3d8bae71176ce8e2e37b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-04 20:34:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fff0dc690e9548889e8dce3594d66094\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ae27e04b63d1462a92eb8e8cb47f6edc : SUCCESS in 2m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/094556e57eb74120a479153fae53ae4f : SUCCESS in 4m 29s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4df8ef391910444f97fbdb2d12872ffe : SUCCESS in 3m 34s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/54829572b4a74d05a0fa915c8805c11e : SUCCESS in 3m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e788d877cea14b6ead14c0eb105a4b5a : SUCCESS in 6m 13s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/86a5144575b244ce8ef1f949c0787a83 : FAILURE in 4m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"793cc05eb4bb16f7513ffde8a31c02f427b77ced","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-04 20:34:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"937de72887c7c8d0b64844338f327cbc01b7cc43","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-04 21:02:20.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f1cc5d5e951e44adaf5f0ba3dec0bda9\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/84a9bb50fab743b1802851715c174817 : SUCCESS in 4m 24s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c7fb18cc03bd42748e42c05738a56fd0 : SUCCESS in 3m 28s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/8184f232ec154977946f87a308ad1c64 : SUCCESS in 2m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f637cc3b3e3043ea9228b672f435d502 : SUCCESS in 6m 24s","accounts_in_message":[],"_revision_number":2},{"id":"2d89a037a6a52654925640280e2db4b1893cd1bb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-04 21:02:20.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"d8c3fb2ea6fb68f0fc5c5c06ff89d949ebdef68e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-04 21:03:45.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/29874130e1d94d9d8abd60f3e5750bcc\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d4479ead4a3f491fb2ca5660a7404619 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f3e89d4df07dd535bee8be69a4d12a7b4a795842","revisions":{"43e63f417445b9f5e05c4e727105b6c901ef1899":{"kind":"REWORK","_number":1,"created":"2026-03-03 10:24:40.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/98/978698/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/98/978698/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/1"}}},"commit":{"parents":[{"commit":"64cf0c33699fc08e6e09563314d225be597cba9e","subject":"Merge \"trivial: Enable flake8-logging-format (G) rules\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/64cf0c33699fc08e6e09563314d225be597cba9e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-03 09:38:25.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-03 10:24:04.000000000","tz":0},"subject":"typing: Add class variables to testcases","message":"typing: Add class variables to testcases\n\ntesttools was recently bumped to a version that is typed, which means we\nnow see type hints for that library. As a result, we now see issues with\nvariables defined in tests via setUpClass. Note that the issue lies with\nmypy and not testtools, however: mypy doesn\u0027t adding class variables via\nassignment [1].\n\n[1] https://github.com/python/mypy/issues/8723\n\nChange-Id: I8b09846ff8fc6ee51ba03531f5b41039282ee1c0\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n(cherry picked from commit 86b296d40990be715459dd69e6f4940563e6516a)\n(cherry picked from commit 4cf3fbb4beb107fa885de074342b28f81ac0dfbe)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43e63f417445b9f5e05c4e727105b6c901ef1899"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43e63f417445b9f5e05c4e727105b6c901ef1899"}]},"branch":"refs/heads/stable/2026.1"},"f3e89d4df07dd535bee8be69a4d12a7b4a795842":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-03-03 10:25:37.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/98/978698/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/98/978698/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/98/978698/2"}}},"commit":{"parents":[{"commit":"64cf0c33699fc08e6e09563314d225be597cba9e","subject":"Merge \"trivial: Enable flake8-logging-format (G) rules\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/64cf0c33699fc08e6e09563314d225be597cba9e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-03 09:38:25.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-03 10:25:37.000000000","tz":0},"subject":"typing: Add class variables to testcases","message":"typing: Add class variables to testcases\n\ntesttools was recently bumped to a version that is typed, which means we\nnow see type hints for that library. As a result, we now see issues with\nvariables defined in tests via setUpClass. Note that the issue lies with\nmypy and not testtools, however: mypy doesn\u0027t adding class variables via\nassignment [1].\n\n[1] https://github.com/python/mypy/issues/8723\n\nChange-Id: I8b09846ff8fc6ee51ba03531f5b41039282ee1c0\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n(cherry picked from commit aeb0c6828b764e47a90f9f719a33a61bcb438ee7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f3e89d4df07dd535bee8be69a4d12a7b4a795842"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f3e89d4df07dd535bee8be69a4d12a7b4a795842"}]},"branch":"refs/heads/stable/2026.1","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}