)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"7d86ae533e9b3dddc10dd2d00cb64b16b24ea933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ab00a63f_8f32a5ea","updated":"2026-03-13 20:03:12.000000000","message":"Failures are expected due to the depends :)","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e1f2462d_94edf515","updated":"2026-03-18 11:58:35.000000000","message":"Looking good. Some small nits on the tests, and we could do with a release note but this otherwise seems a-okay","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fcaa3e442ffc8d8e608097692832d636d93a50a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ff40f105_18bd481f","updated":"2026-04-08 15:33:10.000000000","message":"I think you lost a lot of your changes from PS7 in PS8 and PS9?\n\nhttps://review.opendev.org/c/openstack/python-openstackclient/+/979367/6..9/openstackclient/tests/unit/identity/v3/test_identity_provider.py","commit_id":"e4d213c6f8312cda7e24f1c7fcc0bf1a8a962057"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"b3aae722f9e24e4cebe657f738e49ab0a7fa2c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"63cd93ac_66634c43","in_reply_to":"ff40f105_18bd481f","updated":"2026-04-08 15:51:47.000000000","message":"Fixed 😅","commit_id":"e4d213c6f8312cda7e24f1c7fcc0bf1a8a962057"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"b9769317163ada7a306dccbb830b69d992714839","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"482affd5_96763c80","updated":"2026-04-08 17:57:06.000000000","message":"recheck unrelated network issue","commit_id":"48d6e1e19e47f1c1585be8680802381eaa8c3016"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"c9039fc9f6a38c9144e2bf0efce022c86853057b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ba61a0af_432f3476","updated":"2026-04-29 19:48:27.000000000","message":"@stephenfin@redhat.com Same pep8 issues from the bot even after rebase :(","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"21a98356f6029b88749a7e5b3040cd2b9b6bcac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a59166e9_3662a672","updated":"2026-04-29 21:02:58.000000000","message":"Just dropping the +2 until the minor tweaks are added","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"21a98356f6029b88749a7e5b3040cd2b9b6bcac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4327df33_ce9c9cf1","in_reply_to":"ba61a0af_432f3476","updated":"2026-04-29 21:02:58.000000000","message":"Okay, so what\u0027s happening here is the SDK can return two potential versions of the identity Proxy class, so you need to tell you which one to use. You can use the `openstack.utils.ensure_service_version` utility for this. There are a few examples of it through the code base already.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"}],"openstackclient/identity/v3/identity_provider.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":true,"context_lines":[{"line_number":129,"context_line":"    def take_action("},{"line_number":130,"context_line":"        self, parsed_args: argparse.Namespace"},{"line_number":131,"context_line":"    ) -\u003e tuple[Sequence[str], Iterable[Any]]:"},{"line_number":132,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":133,"context_line":"        kwargs \u003d {\u0027is_enabled\u0027: parsed_args.enabled}"},{"line_number":134,"context_line":"        if parsed_args.identity_provider_id:"},{"line_number":135,"context_line":"            kwargs[\u0027id\u0027] \u003d parsed_args.identity_provider_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"25917263_fbef9269","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":73},"updated":"2026-04-29 21:00:17.000000000","message":"Update this with:\n\n```suggestion\n        identity_client \u003d sdk_utils.ensure_service_version(\n            self.app.client_manager.sdk_connection.identity, \u00273\u0027\n        )\n```","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"26bb0fdb43428f45ccd51187d1f1e22719c7ed55","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def take_action("},{"line_number":130,"context_line":"        self, parsed_args: argparse.Namespace"},{"line_number":131,"context_line":"    ) -\u003e tuple[Sequence[str], Iterable[Any]]:"},{"line_number":132,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":133,"context_line":"        kwargs \u003d {\u0027is_enabled\u0027: parsed_args.enabled}"},{"line_number":134,"context_line":"        if parsed_args.identity_provider_id:"},{"line_number":135,"context_line":"            kwargs[\u0027id\u0027] \u003d parsed_args.identity_provider_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"7987f279_c686526c","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":73},"in_reply_to":"25917263_fbef9269","updated":"2026-05-04 22:30:22.000000000","message":"Fix applied.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":162,"context_line":"            kwargs[\u0027authorization_ttl\u0027] \u003d auth_ttl"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        idp \u003d identity_client.create_identity_provider(**kwargs)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return _format_identity_provider(idp)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"f3a29755_31923be4","line":164,"in_reply_to":"f71147a4_d50db125","updated":"2026-04-29 21:00:17.000000000","message":"The above change will fix this.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        return parser"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def take_action(self, parsed_args: argparse.Namespace) -\u003e None:"},{"line_number":183,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":184,"context_line":"        result \u003d 0"},{"line_number":185,"context_line":"        for i in parsed_args.identity_provider:"},{"line_number":186,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"cd6e30ea_5dbf2266","line":183,"updated":"2026-04-29 21:00:17.000000000","message":"Update this with:\n\n```suggestion\n        identity_client \u003d sdk_utils.ensure_service_version(\n            self.app.client_manager.sdk_connection.identity, \u00273\u0027\n        )\n```","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"26bb0fdb43428f45ccd51187d1f1e22719c7ed55","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        return parser"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def take_action(self, parsed_args: argparse.Namespace) -\u003e None:"},{"line_number":183,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":184,"context_line":"        result \u003d 0"},{"line_number":185,"context_line":"        for i in parsed_args.identity_provider:"},{"line_number":186,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"e9ddc0a9_bae7d43a","line":183,"in_reply_to":"cd6e30ea_5dbf2266","updated":"2026-05-04 22:30:22.000000000","message":"Fix applied.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        result \u003d 0"},{"line_number":185,"context_line":"        for i in parsed_args.identity_provider:"},{"line_number":186,"context_line":"            try:"},{"line_number":187,"context_line":"                identity_client.delete_identity_provider(i)"},{"line_number":188,"context_line":"            except Exception as e:"},{"line_number":189,"context_line":"                result +\u003d 1"},{"line_number":190,"context_line":"                LOG.error("}],"source_content_type":"text/x-python","patch_set":12,"id":"a62db23d_130d48ec","line":187,"in_reply_to":"3f67be5f_d8960e1a","updated":"2026-04-29 21:00:17.000000000","message":"And this","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":true,"context_lines":[{"line_number":226,"context_line":"    ) -\u003e tuple[tuple[str, ...], Iterable[tuple[Any, ...]]]:"},{"line_number":227,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027domain_id\u0027, \u0027description\u0027)"},{"line_number":228,"context_line":"        column_headers \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Domain ID\u0027, \u0027Description\u0027)"},{"line_number":229,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        kwargs \u003d {}"},{"line_number":232,"context_line":"        if parsed_args.id:"}],"source_content_type":"text/x-python","patch_set":12,"id":"55e7d8c3_eb3c9673","line":229,"updated":"2026-04-29 21:00:17.000000000","message":"Update this with:\n\n```suggestion\n        identity_client \u003d sdk_utils.ensure_service_version(\n            self.app.client_manager.sdk_connection.identity, \u00273\u0027\n        )\n```","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"26bb0fdb43428f45ccd51187d1f1e22719c7ed55","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    ) -\u003e tuple[tuple[str, ...], Iterable[tuple[Any, ...]]]:"},{"line_number":227,"context_line":"        columns \u003d (\u0027id\u0027, \u0027is_enabled\u0027, \u0027domain_id\u0027, \u0027description\u0027)"},{"line_number":228,"context_line":"        column_headers \u003d (\u0027ID\u0027, \u0027Enabled\u0027, \u0027Domain ID\u0027, \u0027Description\u0027)"},{"line_number":229,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        kwargs \u003d {}"},{"line_number":232,"context_line":"        if parsed_args.id:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7eadef35_dedee410","line":229,"in_reply_to":"55e7d8c3_eb3c9673","updated":"2026-05-04 22:30:22.000000000","message":"Fix applied.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        if parsed_args.enabled:"},{"line_number":235,"context_line":"            kwargs[\u0027is_enabled\u0027] \u003d True"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        data \u003d identity_client.identity_providers(**kwargs)"},{"line_number":238,"context_line":"        return ("},{"line_number":239,"context_line":"            column_headers,"},{"line_number":240,"context_line":"            ("}],"source_content_type":"text/x-python","patch_set":12,"id":"21a123ce_8a51f701","line":237,"in_reply_to":"427ee96e_bbd37170","updated":"2026-04-29 21:00:17.000000000","message":"And this.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        return parser"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def take_action(self, parsed_args: argparse.Namespace) -\u003e None:"},{"line_number":309,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        # Always set remote_ids if either is passed in"},{"line_number":312,"context_line":"        if parsed_args.remote_id_file:"}],"source_content_type":"text/x-python","patch_set":12,"id":"cfb283d3_645b1e09","line":309,"updated":"2026-04-29 21:00:17.000000000","message":"Update this with:\n\n```suggestion\n        identity_client \u003d sdk_utils.ensure_service_version(\n            self.app.client_manager.sdk_connection.identity, \u00273\u0027\n        )\n```","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"26bb0fdb43428f45ccd51187d1f1e22719c7ed55","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        return parser"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def take_action(self, parsed_args: argparse.Namespace) -\u003e None:"},{"line_number":309,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        # Always set remote_ids if either is passed in"},{"line_number":312,"context_line":"        if parsed_args.remote_id_file:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ca274b8a_052b83d4","line":309,"in_reply_to":"cfb283d3_645b1e09","updated":"2026-05-04 22:30:22.000000000","message":"Fix applied.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":346,"context_line":"            kwargs[\u0027authorization_ttl\u0027] \u003d auth_ttl"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        identity_client.update_identity_provider("},{"line_number":349,"context_line":"            parsed_args.identity_provider, **kwargs"},{"line_number":350,"context_line":"        )"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"6e6ba3ab_a55a6c0c","line":348,"in_reply_to":"167c7492_e18097f2","updated":"2026-04-29 21:00:17.000000000","message":"And this","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":true,"context_lines":[{"line_number":365,"context_line":"    def take_action("},{"line_number":366,"context_line":"        self, parsed_args: argparse.Namespace"},{"line_number":367,"context_line":"    ) -\u003e tuple[Sequence[str], Iterable[Any]]:"},{"line_number":368,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":369,"context_line":"        idp \u003d identity_client.get_identity_provider("},{"line_number":370,"context_line":"            parsed_args.identity_provider"},{"line_number":371,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"b439aa7e_4ab62d71","line":368,"updated":"2026-04-29 21:00:17.000000000","message":"Update this with:\n\n```suggestion\n        identity_client \u003d sdk_utils.ensure_service_version(\n            self.app.client_manager.sdk_connection.identity, \u00273\u0027\n        )\n```","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"26bb0fdb43428f45ccd51187d1f1e22719c7ed55","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    def take_action("},{"line_number":366,"context_line":"        self, parsed_args: argparse.Namespace"},{"line_number":367,"context_line":"    ) -\u003e tuple[Sequence[str], Iterable[Any]]:"},{"line_number":368,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":369,"context_line":"        idp \u003d identity_client.get_identity_provider("},{"line_number":370,"context_line":"            parsed_args.identity_provider"},{"line_number":371,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"14d5e53b_7b79b796","line":368,"in_reply_to":"b439aa7e_4ab62d71","updated":"2026-05-04 22:30:22.000000000","message":"Fix applied.","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d30972bee3ed3f39f450f0523416e8b22647ca00","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self, parsed_args: argparse.Namespace"},{"line_number":367,"context_line":"    ) -\u003e tuple[Sequence[str], Iterable[Any]]:"},{"line_number":368,"context_line":"        identity_client \u003d self.app.client_manager.sdk_connection.identity"},{"line_number":369,"context_line":"        idp \u003d identity_client.get_identity_provider("},{"line_number":370,"context_line":"            parsed_args.identity_provider"},{"line_number":371,"context_line":"        )"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"4b280dcd_39a972e1","line":369,"in_reply_to":"84042a2e_58c26c63","updated":"2026-04-29 21:00:17.000000000","message":"And this","commit_id":"a20054fd8b7853595e2f1b7243c7255b1e2e57f8"}],"openstackclient/tests/unit/identity/v3/test_identity_provider.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.identity_sdk_client.create_identity_provider.return_value \u003d ("},{"line_number":49,"context_line":"            self.idp"},{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":"        self.formatted_idp_remote_ids \u003d format_columns.ListColumn("},{"line_number":52,"context_line":"            self.idp.remote_ids"},{"line_number":53,"context_line":"        )"},{"line_number":54,"context_line":"        self.identity_sdk_client.find_domain.return_value \u003d self.domain"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.datalist \u003d ("},{"line_number":57,"context_line":"            self.idp.authorization_ttl,"}],"source_content_type":"text/x-python","patch_set":6,"id":"851dd566_5596366b","line":54,"range":{"start_line":50,"start_character":9,"end_line":54,"end_character":71},"updated":"2026-03-18 11:58:35.000000000","message":"nit: Could we inline this definition? IMO it would be clearer.\n\n```suggestion\n        )\n        self.identity_sdk_client.find_domain.return_value \u003d self.domain\n```","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"d67252dc46f19b1276feabd58c8ab7e1b4748758","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.identity_sdk_client.create_identity_provider.return_value \u003d ("},{"line_number":49,"context_line":"            self.idp"},{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":"        self.formatted_idp_remote_ids \u003d format_columns.ListColumn("},{"line_number":52,"context_line":"            self.idp.remote_ids"},{"line_number":53,"context_line":"        )"},{"line_number":54,"context_line":"        self.identity_sdk_client.find_domain.return_value \u003d self.domain"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.datalist \u003d ("},{"line_number":57,"context_line":"            self.idp.authorization_ttl,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b1fcdb5e_0ed228b0","line":54,"range":{"start_line":50,"start_character":9,"end_line":54,"end_character":71},"in_reply_to":"851dd566_5596366b","updated":"2026-03-20 00:06:44.000000000","message":"Fix applied.","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":true,"context_lines":[{"line_number":57,"context_line":"            self.idp.authorization_ttl,"},{"line_number":58,"context_line":"            self.idp.description,"},{"line_number":59,"context_line":"            self.domain.id,"},{"line_number":60,"context_line":"            True,"},{"line_number":61,"context_line":"            self.idp.id,"},{"line_number":62,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":63,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"e3368011_3fa7868f","line":60,"updated":"2026-03-18 11:58:35.000000000","message":"```suggestion\n            self.idp.is_enabled,\n```\n\n?","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"d67252dc46f19b1276feabd58c8ab7e1b4748758","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            self.idp.authorization_ttl,"},{"line_number":58,"context_line":"            self.idp.description,"},{"line_number":59,"context_line":"            self.domain.id,"},{"line_number":60,"context_line":"            True,"},{"line_number":61,"context_line":"            self.idp.id,"},{"line_number":62,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":63,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"654e19c8_0a72dc74","line":60,"in_reply_to":"e3368011_3fa7868f","updated":"2026-03-20 00:06:44.000000000","message":"Fix applied.","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":true,"context_lines":[{"line_number":59,"context_line":"            self.domain.id,"},{"line_number":60,"context_line":"            True,"},{"line_number":61,"context_line":"            self.idp.id,"},{"line_number":62,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":63,"context_line":"        )"},{"line_number":64,"context_line":"        self.cmd \u003d identity_provider.CreateIdentityProvider(self.app, None)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fc611988_2385d623","line":62,"updated":"2026-03-18 11:58:35.000000000","message":"```suggestion\n            format_columns.ListColumn(self.idp.remote_ids),\n```","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"d67252dc46f19b1276feabd58c8ab7e1b4748758","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            self.domain.id,"},{"line_number":60,"context_line":"            True,"},{"line_number":61,"context_line":"            self.idp.id,"},{"line_number":62,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":63,"context_line":"        )"},{"line_number":64,"context_line":"        self.cmd \u003d identity_provider.CreateIdentityProvider(self.app, None)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"141af3ae_15e3ba00","line":62,"in_reply_to":"fc611988_2385d623","updated":"2026-03-20 00:06:44.000000000","message":"Fix applied.","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":true,"context_lines":[{"line_number":238,"context_line":"            self.domain.id,"},{"line_number":239,"context_line":"            False,"},{"line_number":240,"context_line":"            idp_disabled.id,"},{"line_number":241,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":242,"context_line":"        )"},{"line_number":243,"context_line":"        self.assertCountEqual(datalist, data)"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e8731d5f_aaf5b6ea","line":241,"updated":"2026-03-18 11:58:35.000000000","message":"```suggestion\n            format_columns.ListColumn(self.idp.remote_ids),\n```","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"d67252dc46f19b1276feabd58c8ab7e1b4748758","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            self.domain.id,"},{"line_number":239,"context_line":"            False,"},{"line_number":240,"context_line":"            idp_disabled.id,"},{"line_number":241,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":242,"context_line":"        )"},{"line_number":243,"context_line":"        self.assertCountEqual(datalist, data)"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f72c306_94912e2c","line":241,"in_reply_to":"e8731d5f_aaf5b6ea","updated":"2026-03-20 00:06:44.000000000","message":"Fix applied.","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":true,"context_lines":[{"line_number":850,"context_line":"            remote_ids\u003d[\u0027entity1\u0027, \u0027entity2\u0027],"},{"line_number":851,"context_line":"        )"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        self.identity_sdk_client.get_identity_provider.return_value \u003d self.idp"},{"line_number":854,"context_line":"        self.formatted_idp_remote_ids \u003d format_columns.ListColumn("},{"line_number":855,"context_line":"            self.idp.remote_ids"},{"line_number":856,"context_line":"        )"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        self.cmd \u003d identity_provider.ShowIdentityProvider(self.app, None)"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7bc79b7c_78737be9","line":856,"range":{"start_line":853,"start_character":0,"end_line":856,"end_character":9},"updated":"2026-03-18 11:58:35.000000000","message":"As above, could we drop this and inline the reference?\n\n```suggestion\n        self.identity_sdk_client.get_identity_provider.return_value \u003d self.idp\n```","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"d67252dc46f19b1276feabd58c8ab7e1b4748758","unresolved":false,"context_lines":[{"line_number":850,"context_line":"            remote_ids\u003d[\u0027entity1\u0027, \u0027entity2\u0027],"},{"line_number":851,"context_line":"        )"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        self.identity_sdk_client.get_identity_provider.return_value \u003d self.idp"},{"line_number":854,"context_line":"        self.formatted_idp_remote_ids \u003d format_columns.ListColumn("},{"line_number":855,"context_line":"            self.idp.remote_ids"},{"line_number":856,"context_line":"        )"},{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        self.cmd \u003d identity_provider.ShowIdentityProvider(self.app, None)"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"23002760_4adacebd","line":856,"range":{"start_line":853,"start_character":0,"end_line":856,"end_character":9},"in_reply_to":"7bc79b7c_78737be9","updated":"2026-03-20 00:06:44.000000000","message":"Fix applied.","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6364703d74ff64aa2df4258a092a1dc5ed4cca2a","unresolved":true,"context_lines":[{"line_number":887,"context_line":"            self.idp.domain_id,"},{"line_number":888,"context_line":"            True,"},{"line_number":889,"context_line":"            self.idp.id,"},{"line_number":890,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":891,"context_line":"        )"},{"line_number":892,"context_line":"        self.assertCountEqual(datalist, data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c094c660_6284bc6c","line":890,"updated":"2026-03-18 11:58:35.000000000","message":"```suggestion\n            format_columns.ListColumn(self.idp.remote_ids),\n```","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"d67252dc46f19b1276feabd58c8ab7e1b4748758","unresolved":false,"context_lines":[{"line_number":887,"context_line":"            self.idp.domain_id,"},{"line_number":888,"context_line":"            True,"},{"line_number":889,"context_line":"            self.idp.id,"},{"line_number":890,"context_line":"            self.formatted_idp_remote_ids,"},{"line_number":891,"context_line":"        )"},{"line_number":892,"context_line":"        self.assertCountEqual(datalist, data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f1360a94_33c702ef","line":890,"in_reply_to":"c094c660_6284bc6c","updated":"2026-03-20 00:06:44.000000000","message":"Fix applied.","commit_id":"d4872cf9eb1ac5480b353ee43c569f2c0b744fca"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7508cdfde295044f75bf04117390e275398bd2c9","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[testenv:unit-tips]"},{"line_number":41,"context_line":"commands \u003d"},{"line_number":42,"context_line":"  ; python -m pip install -q -U -e {toxinidir}/../cliff#egg\u003dcliff"},{"line_number":43,"context_line":"  ; python -m pip install -q -U -e {toxinidir}/../keystoneauth#egg\u003dkeystoneauth"},{"line_number":44,"context_line":"  ; python -m pip install -q -U -e {toxinidir}/../osc-lib#egg\u003dosc_lib"},{"line_number":45,"context_line":"  python -m pip install -q -U -e {toxinidir}/../openstacksdk#egg\u003dopenstacksdk"},{"line_number":46,"context_line":"  python -m pip freeze"},{"line_number":47,"context_line":"  stestr run {posargs}"}],"source_content_type":"text/x-properties","patch_set":8,"id":"dffe2fef_d49cd034","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":69},"updated":"2026-03-20 10:25:54.000000000","message":"I assume this wasn\u0027t intentional?","commit_id":"8a213d0bd7c5cf6a3e092e211cb1c4ab26656158"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"14dceb66394f2ada514e4c8a1821b01f47d21568","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[testenv:unit-tips]"},{"line_number":41,"context_line":"commands \u003d"},{"line_number":42,"context_line":"  ; python -m pip install -q -U -e {toxinidir}/../cliff#egg\u003dcliff"},{"line_number":43,"context_line":"  ; python -m pip install -q -U -e {toxinidir}/../keystoneauth#egg\u003dkeystoneauth"},{"line_number":44,"context_line":"  ; python -m pip install -q -U -e {toxinidir}/../osc-lib#egg\u003dosc_lib"},{"line_number":45,"context_line":"  python -m pip install -q -U -e {toxinidir}/../openstacksdk#egg\u003dopenstacksdk"},{"line_number":46,"context_line":"  python -m pip freeze"},{"line_number":47,"context_line":"  stestr run {posargs}"}],"source_content_type":"text/x-properties","patch_set":8,"id":"30f60470_ccde35c0","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":69},"in_reply_to":"dffe2fef_d49cd034","updated":"2026-04-01 18:09:05.000000000","message":"Ah yep I forgot to remove that before pushing, fixed 😅","commit_id":"8a213d0bd7c5cf6a3e092e211cb1c4ab26656158"}]}