)]}'
{"id":"openstack%2Fpython-openstackclient~979840","triplet_id":"openstack%2Fpython-openstackclient~master~I8420212be63dbeaff02c97823e1b80441cbc62ca","project":"openstack/python-openstackclient","branch":"master","topic":"hacking","hashtags":[],"change_id":"I8420212be63dbeaff02c97823e1b80441cbc62ca","subject":"hacking: Ensure use of openstackclient.command","status":"MERGED","created":"2026-03-10 13:21:46.000000000","updated":"2026-03-10 16:19:28.000000000","submitted":"2026-03-10 16:17:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"979840-hacking","meta_rev_id":"71f8ad122cf5730a5bc9dd8cfab6f73259212749","_number":979840,"virtual_id_number":979840,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-03-10 16:17:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-03-10 14:13:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-03-10 14:13:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-10 14:52:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cff085769ad7e2f335380f77a09921bab189eb4f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-10 13:21:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c48b42e4835135d25337006ce4dc9ecb956f7fba","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-10 14:13:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"67c9fd83c171a4ea5bab8e0ccd628fbf22d1ddfd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-10 14:52:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/68a132b8cec543da8cbdb0a9fbe5b0da\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/fb48c617d4ac4ab9bdb1b1a5aac1935e : SUCCESS in 7m 18s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/acfb3877505d455f9c748eaa9e6de36c : SUCCESS in 5m 13s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/0f0c6a9d96f84044935824c26b4add6d : SUCCESS in 3m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/77d7efbb5a824780a90d6ae82ab0572c : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/207eff78e8cc4fdda3687dbb5b1f0f24 : SUCCESS in 5m 47s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/630b7f5ebe7f467ea0632bd1c59a2039 : SUCCESS in 4m 27s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/ab63db4ee2a14ee8b5079842f73cc0bc : SUCCESS in 4m 55s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/69d9053967124213ae1ee4d572fe16d8 : FAILURE in 6m 36s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0861d51fb8d1449fb645826f15d84a25 : SUCCESS in 6m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a07346e26cb74b0199a70142d13980d7 : SUCCESS in 4m 54s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/c4b93eac21404bb6ba1209c340fffa03 : FAILURE in 4m 49s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/bf63ff89918b44f09803b7cce52e4838 : SUCCESS in 48m 44s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/dc86e16e93fb4776a427ac72c3777065 : SUCCESS in 1h 14m 19s","accounts_in_message":[],"_revision_number":1},{"id":"b8b1aeed6f1fe101458630ab13e378741464790a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-10 14:52:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a95666b60168cf515b6b1eef527669796cbfac4d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-10 16:17:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/768e6b95f5d84efa97632c24a4f94b23\n\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/7e6502ecb11a4d47973423d2fab33099 : SUCCESS in 4m 41s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/5037ab398b05466d920f7b902f5e1cf2 : SUCCESS in 3m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd8150a0d4954c4fa448765acdb7ebe3 : SUCCESS in 4m 29s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/d2e41aff860b43768fe97f1095d22365 : SUCCESS in 3m 37s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/62f6e0c0c87f4a258f6bf1bd10471821 : SUCCESS in 3m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/53b5f39b7af540ab9b7b0b3cee9e2932 : SUCCESS in 6m 31s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/be3af5f95f4d4efabe79cd57bac389e8 : SUCCESS in 3m 58s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/bee13f5c0d5c4a74b2f9d5d73bf5f1d8 : SUCCESS in 1h 19m 26s","accounts_in_message":[],"_revision_number":1},{"id":"78df8a1aea6aa384811114f2bb1c7e67015563ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-10 16:17:35.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"71f8ad122cf5730a5bc9dd8cfab6f73259212749","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-10 16:19:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9bcdb028aa624682836cd9450f4eef5c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3de289878c5c4baeb0f9614090bc8517 : SUCCESS in 1m 12s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1ebd3fed756245088f90e310c1cd30c6 : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"de81f473059c3fb5014fb10081da409b3664e14b","revisions":{"de81f473059c3fb5014fb10081da409b3664e14b":{"kind":"REWORK","_number":1,"created":"2026-03-10 13:21:46.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/40/979840/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/40/979840/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/979840/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/979840/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/979840/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/40/979840/1"}}},"commit":{"parents":[{"commit":"2a28605ba23840b9c4d408294962ee0c9ea04f7f","subject":"Merge \"Add --cluster option to volume migration\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2a28605ba23840b9c4d408294962ee0c9ea04f7f"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-10 13:17:08.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-03-10 13:20:50.000000000","tz":0},"subject":"hacking: Ensure use of openstackclient.command","message":"hacking: Ensure use of openstackclient.command\n\nThese have the necessary type hints for the clientmanager and\nshould always be used.\n\nChange-Id: I8420212be63dbeaff02c97823e1b80441cbc62ca\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de81f473059c3fb5014fb10081da409b3664e14b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/de81f473059c3fb5014fb10081da409b3664e14b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}