)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d72080b6f2bb4253a0b98e9864ac16dc755d05d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad2aaab0_fe75ae35","updated":"2026-03-20 22:32:39.000000000","message":"Just -W since I\u0027m not sure if this will break anything yet","commit_id":"f264e95e8ffdb09c2c5e6616ddd56060c7240d07"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"dd3fb007d6a1bfec58da8504f345e60e0e1d2c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01063320_a6fc3858","updated":"2026-03-22 20:48:40.000000000","message":"\u003crant\u003e\n\nSo the one confusing (to me) thing about this is regarding \u0027floating ip pools\u0027 - there is a neutron extension with that name but there is no way to query it via OSC. And it only supports \u0027list\u0027, not \u0027create\u0027 or anything else. And the nova code says it\u0027s deprecated. And of course the call doesn\u0027t actually work if you have neutron enabled:\n\n$ openstack floating ip pool list\nFloating ip pool operations are only available for Compute v2 network.\n\nMystery of the universe.\n\nThis is the patch that introduced it in neutron:\n\nhttps://review.opendev.org/c/openstack/neutron/+/555088\n\nSo maybe if we just tweaked things to call neutron it would return something. But it\u0027s deprecated...\n\n\u003cend rant\u003e","commit_id":"dff3750eb5960d03c07f0b643623bc1ab0e299e3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d553d0835ecfc16b728b94ec1676e8d38ce2252c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"872ad5e6_8d0b98c9","updated":"2026-04-10 14:36:14.000000000","message":"I was under the impression we had to keep nova-network support around since a few cloud providers (Rackspace?) are still using it or equivalent APIs? Is that no longer the case? This probably warrants a discussion on openstack-discuss before we merge since it\u0027s quite the change. -2 is just for that.","commit_id":"dff3750eb5960d03c07f0b643623bc1ab0e299e3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5220b5b6b791ee6b5567e5bd6e5bee3ff60d4df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e767565c_6ee0a4d8","in_reply_to":"01063320_a6fc3858","updated":"2026-04-09 21:21:13.000000000","message":"So after looking further I could find no users of the \u0027floatingip_pools\u0027 API using codesearch, even horizon just gets networks with a {\u0027router:external\u0027: True} filter. It was intended to be a way to get the network/subnet mappings. We can keep the API code around in neutron (for now), but this code here is doing nothing.","commit_id":"dff3750eb5960d03c07f0b643623bc1ab0e299e3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"40a9b4c981e8afb09282f4d7934c0c64e3678b95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e74e85e_61134131","in_reply_to":"872ad5e6_8d0b98c9","updated":"2026-04-10 16:33:58.000000000","message":"Ugh, I figured 10+ years with Neutron was enough that nova-network had been completely retired. And looking at Rackspace, it does say they support the nova-network API, but the URL is a 404, so do they really? :-p  I can send something to the ML, would be good to rid of some cruft if we can.","commit_id":"dff3750eb5960d03c07f0b643623bc1ab0e299e3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"99e910640b76f5d74dad654109df8e57fc63d4c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb938b13_c8f33fd9","in_reply_to":"9e74e85e_61134131","updated":"2026-04-10 16:50:39.000000000","message":"I agree. I just don\u0027t want people shouting at me, and OSC and SDK typically do their best to support older versions of OpenStack as long as is viable. A mailing list post would definitely give us the ammo needed to remove this.\n\nAs an aside, we probably also want to call this out in the [docs](https://docs.openstack.org/python-openstackclient/latest/cli/backwards-incompatible.html).","commit_id":"dff3750eb5960d03c07f0b643623bc1ab0e299e3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"10b205ce7c6ec5ee4f1e064be741ccfbd2f279b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"374d46c1_62314a5f","in_reply_to":"cb938b13_c8f33fd9","updated":"2026-04-10 17:32:26.000000000","message":"Ack, will update and add a release note. And they can yell at me...","commit_id":"dff3750eb5960d03c07f0b643623bc1ab0e299e3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a98399bd6788d5bbfd56698b774c2d15f3e2289f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5dc5a3a0_79e74bf1","updated":"2026-04-23 10:40:55.000000000","message":"We haven\u0027t seen anything on the mailing list yet to suggest we need to keep this any longer, which is great news. I\u0027m going to leave the -2 on this for a another few days to give us time to wrap up the PTG and let any laggards pop their heads up, but I plan to start reviewing this before then on the assumption that we can do this","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84f610ffaaa13a6b0edbd5a12e72e804133bc59a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"223cf74e_692302c6","updated":"2026-04-23 11:44:18.000000000","message":"Yeah this looks great. Couple of small nits/potential follow-ups but nothing I\u0027d block on","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d0f34a41a7f8378485cc7924790d2c1a4f76b82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5f06524d_0f7d2c4d","updated":"2026-04-20 21:39:12.000000000","message":"rebased to master after mypy changes","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fee0959e82da57b747136306dcbb71c9fbce8720","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e8a127d2_2addf1e8","updated":"2026-04-27 10:23:41.000000000","message":"It would be good to get a second pair of eyes on this, but I think we can merge this now.","commit_id":"70a4da2355d7b41e7f06bcb3c131bb302d3156bc"}],"openstackclient/network/common.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84f610ffaaa13a6b0edbd5a12e72e804133bc59a","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        raise"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class NetworkDelete(command.Command, metaclass\u003dabc.ABCMeta):"},{"line_number":60,"context_line":"    \"\"\"Network Delete"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    Delete class for commands that support implementation via"}],"source_content_type":"text/x-python","patch_set":5,"id":"db2b1649_451758af","line":59,"updated":"2026-04-23 11:44:18.000000000","message":"I know it will result in some duplicated code, but I\u0027d personally like to get rid of this and fold it into the 4 call sites. Could we do that in a follow-up?","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6fac2ec2a2a46b0b3882726fafbaaf6e15314c30","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        raise"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class NetworkDelete(command.Command, metaclass\u003dabc.ABCMeta):"},{"line_number":60,"context_line":"    \"\"\"Network Delete"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    Delete class for commands that support implementation via"}],"source_content_type":"text/x-python","patch_set":5,"id":"593dc098_b6bfa838","line":59,"in_reply_to":"db2b1649_451758af","updated":"2026-04-24 19:27:38.000000000","message":"Actually I see the subnet code already does this, I\u0027ll just do it in this change","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84f610ffaaa13a6b0edbd5a12e72e804133bc59a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        for r in resources:"},{"line_number":76,"context_line":"            self.r \u003d r"},{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.take_action_delete(parsed_args)"},{"line_number":79,"context_line":"            except Exception as e:"},{"line_number":80,"context_line":"                msg \u003d _("},{"line_number":81,"context_line":"                    \"Failed to delete %(resource)s with name or ID \""}],"source_content_type":"text/x-python","patch_set":5,"id":"e281f609_b2f9abbc","line":78,"updated":"2026-04-23 11:44:18.000000000","message":"Can we rename this to a private function e.g. `_take_action_delete`?","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6fac2ec2a2a46b0b3882726fafbaaf6e15314c30","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        for r in resources:"},{"line_number":76,"context_line":"            self.r \u003d r"},{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.take_action_delete(parsed_args)"},{"line_number":79,"context_line":"            except Exception as e:"},{"line_number":80,"context_line":"                msg \u003d _("},{"line_number":81,"context_line":"                    \"Failed to delete %(resource)s with name or ID \""}],"source_content_type":"text/x-python","patch_set":5,"id":"b9f00083_7e9530aa","line":78,"in_reply_to":"e281f609_b2f9abbc","updated":"2026-04-24 19:27:38.000000000","message":"Done","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"}],"openstackclient/network/v2/security_group_rule.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84f610ffaaa13a6b0edbd5a12e72e804133bc59a","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # Accept but hide the argument for consistency with compute."},{"line_number":285,"context_line":"        # Network will always return all projects for an admin."},{"line_number":286,"context_line":"        parser.add_argument("},{"line_number":287,"context_line":"            \u0027--all-projects\u0027,"},{"line_number":288,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":289,"context_line":"            default\u003dFalse,"},{"line_number":290,"context_line":"            help\u003dargparse.SUPPRESS,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c84506cc_4e8b80ee","line":287,"updated":"2026-04-23 11:44:18.000000000","message":"Could we deprecate this option? A follow-up is fine.","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6fac2ec2a2a46b0b3882726fafbaaf6e15314c30","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        # Accept but hide the argument for consistency with compute."},{"line_number":285,"context_line":"        # Network will always return all projects for an admin."},{"line_number":286,"context_line":"        parser.add_argument("},{"line_number":287,"context_line":"            \u0027--all-projects\u0027,"},{"line_number":288,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":289,"context_line":"            default\u003dFalse,"},{"line_number":290,"context_line":"            help\u003dargparse.SUPPRESS,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ef62b108_9bdd8ce4","line":287,"in_reply_to":"c84506cc_4e8b80ee","updated":"2026-04-24 19:27:38.000000000","message":"I\u0027ll just remove as it\u0027s cruft.","commit_id":"0f2bed9013e1a1fe5e70fd913b73703030e1f185"}]}