)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a5e0585d324dd4afc3e82545fb19884e5325780","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d54eec1_cba66418","updated":"2026-04-22 14:45:15.000000000","message":"Thanks for following up on this 🙏","commit_id":"980075effce825ac266226453d6ea3954a0caad2"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a5e0585d324dd4afc3e82545fb19884e5325780","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    identity_fakes.FakeClientMixin,"},{"line_number":107,"context_line":"    FakeClientMixin,"},{"line_number":108,"context_line":"    utils.TestCommand,"},{"line_number":109,"context_line":"    osc_lib_base.TestCommand,"},{"line_number":110,"context_line":"): ..."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"261cfe35_0613cbbc","line":109,"updated":"2026-04-22 14:45:15.000000000","message":"There is a lot of overlap between `utils.TestCommand` and `osc_lib_base.TestCommand`. I\u0027m not sure if we want to subclass from both as it could get very confusing (multiple competing fixtures, for example). I also don\u0027t know if we want to do this for neutron only.\n\nGiven the significant overlap between the two classes, the ideal end scenario (IMO) would be to remove  `openstackclient.tests.unit.utils.TestCommand` in favour of `osc_lib_utils.TestCommand`. However that\u0027s a much larger refactor that would require some changes in osc-lib (and a new release of same) since it is missing the monkey patching for `sys.stderr`. I don\u0027t expect you to do this, so instead, how about we just move the two assert helpers to `openstackclient.tests.unit.utils.TestCommand` and add a new `TODO` (which we may well never do 😅) that we should eventually remove that class in favour of `osc_lib.test.base.TestCommand`?","commit_id":"980075effce825ac266226453d6ea3954a0caad2"}]}