)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08361e22654385c986b2e6cc77fe89326eb3e21f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d693326d_0d75ca62","updated":"2026-05-07 17:16:57.000000000","message":"just nits, lgtm otherwise","commit_id":"45296c69a08827b5c012cd05dcb7d09095db367d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"df64f200249aa0e47b45a69f0b579fb89b67f445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f7ba92a_45c49153","updated":"2026-05-20 15:25:52.000000000","message":"Should this wait for https://review.opendev.org/c/openstack/neutron/+/982792 ?","commit_id":"02d512c00adcf3e50d3e4f9f837971df42b1e36e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6f9acca989f36c9bf0c08fdb3e5fd8d672b7984a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"50775458_7fcb71c4","in_reply_to":"1f7ba92a_45c49153","updated":"2026-05-21 08:06:37.000000000","message":"Not really. It should be expected to have the Neutron code but if we release this change, we\u0027ll just have a 500 error from the Neutron API. This could also happen if we update the CLI in an older version.","commit_id":"02d512c00adcf3e50d3e4f9f837971df42b1e36e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c46d59ac090b10c1dd872baa3b78f6ac616879fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e6ce895f_2872ac0f","in_reply_to":"50775458_7fcb71c4","updated":"2026-05-21 11:41:58.000000000","message":"This is true, but there\u0027s a non-zero chance that the patch never lands in neutron and this is dead code. Probably best to wait?","commit_id":"02d512c00adcf3e50d3e4f9f837971df42b1e36e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"767a940b29e067548f63d6b47f65400f6880162d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba92e051_2adcd422","updated":"2026-06-03 13:58:51.000000000","message":"The Neutron patch is in the oven (+2+W): https://review.opendev.org/c/openstack/neutron/+/982792","commit_id":"f36e2911e9dfeca299c56616b0247919806ba312"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7c4f38ddda2cd3290e58ea925b57d8902e4fdbb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"266928a4_8cdd892a","updated":"2026-06-03 20:39:14.000000000","message":"recheck osc-functional-devstack-tips","commit_id":"f36e2911e9dfeca299c56616b0247919806ba312"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8b7a91678b3c9df4ffe29fe52d6692777b6c132","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0e43460d_16e28ba2","updated":"2026-06-09 14:25:43.000000000","message":"tiny nit. otherwise lgtm","commit_id":"16cf6b088ab71aefd16f103b5c565f9dde943968"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ba000c07becdb02a225fe513d95bf4837ba8711b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"467ced06_cdf0743d","updated":"2026-06-19 07:04:08.000000000","message":"ping fellow reviewers: all patches are merged now (https://review.opendev.org/q/topic:%22bug/2103521%22)","commit_id":"a95aad0b7cd9332edfd08cc4aaa366150a34a8e2"}],"openstackclient/network/v2/network_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08361e22654385c986b2e6cc77fe89326eb3e21f","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        parser.add_argument("},{"line_number":401,"context_line":"            \u0027agent_id\u0027,"},{"line_number":402,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"},{"line_number":403,"context_line":"            help\u003d_(\"Agent owning the router to update (ID only)\"),"},{"line_number":404,"context_line":"        )"},{"line_number":405,"context_line":"        parser.add_argument("},{"line_number":406,"context_line":"            \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"28cfbf98_fcfe490f","line":403,"range":{"start_line":403,"start_character":20,"end_line":403,"end_character":53},"updated":"2026-05-07 17:16:57.000000000","message":"s/L3 agent to modify\n\nMore matches the wording for SetNetworkAgent class below.","commit_id":"45296c69a08827b5c012cd05dcb7d09095db367d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3840a1c1aee09c298f20b7ad4094a10e060d7b0f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        parser.add_argument("},{"line_number":401,"context_line":"            \u0027agent_id\u0027,"},{"line_number":402,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"},{"line_number":403,"context_line":"            help\u003d_(\"Agent owning the router to update (ID only)\"),"},{"line_number":404,"context_line":"        )"},{"line_number":405,"context_line":"        parser.add_argument("},{"line_number":406,"context_line":"            \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b17183a8_da04330a","line":403,"range":{"start_line":403,"start_character":20,"end_line":403,"end_character":53},"in_reply_to":"28cfbf98_fcfe490f","updated":"2026-05-08 06:45:18.000000000","message":"Done","commit_id":"45296c69a08827b5c012cd05dcb7d09095db367d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08361e22654385c986b2e6cc77fe89326eb3e21f","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            \u0027router\u0027,"},{"line_number":407,"context_line":"            metavar\u003d\u0027\u003crouter\u003e\u0027,"},{"line_number":408,"context_line":"            help\u003d_("},{"line_number":409,"context_line":"                \"Router associated to an agent to update (name or ID)\""},{"line_number":410,"context_line":"            ),"},{"line_number":411,"context_line":"        )"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a624a10_56a11721","line":409,"range":{"start_line":409,"start_character":17,"end_line":409,"end_character":56},"updated":"2026-05-07 17:16:57.000000000","message":"nit: s/Router to update","commit_id":"45296c69a08827b5c012cd05dcb7d09095db367d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3840a1c1aee09c298f20b7ad4094a10e060d7b0f","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            \u0027router\u0027,"},{"line_number":407,"context_line":"            metavar\u003d\u0027\u003crouter\u003e\u0027,"},{"line_number":408,"context_line":"            help\u003d_("},{"line_number":409,"context_line":"                \"Router associated to an agent to update (name or ID)\""},{"line_number":410,"context_line":"            ),"},{"line_number":411,"context_line":"        )"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6ec06ae0_ebfdf271","line":409,"range":{"start_line":409,"start_character":17,"end_line":409,"end_character":56},"in_reply_to":"9a624a10_56a11721","updated":"2026-05-08 06:45:18.000000000","message":"Done","commit_id":"45296c69a08827b5c012cd05dcb7d09095db367d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9837defb5458eef1a558a96f83d202bdf42f9943","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        return parser"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def take_action(self, parsed_args: argparse.Namespace) -\u003e None:"},{"line_number":414,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":415,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":416,"context_line":"        router \u003d client.find_router(parsed_args.router, ignore_missing\u003dFalse)"},{"line_number":417,"context_line":"        if parsed_args.l3:"},{"line_number":418,"context_line":"            client.update_router_in_agent("},{"line_number":419,"context_line":"                agent,"},{"line_number":420,"context_line":"                router,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c9495d18_358f1dd0","line":417,"range":{"start_line":414,"start_character":48,"end_line":417,"end_character":26},"updated":"2026-05-18 14:37:25.000000000","message":"Rather than doing this, is there any attribute on the agent that we can check to see if it\u0027s an L3 agent? We can raise an CommandError if it\u0027s not and the user is attempting to set `--ha-chassis-priority`.","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e1b696aa30cb2bddd0895c6c4e19e2efd3f9339","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        return parser"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def take_action(self, parsed_args: argparse.Namespace) -\u003e None:"},{"line_number":414,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":415,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":416,"context_line":"        router \u003d client.find_router(parsed_args.router, ignore_missing\u003dFalse)"},{"line_number":417,"context_line":"        if parsed_args.l3:"},{"line_number":418,"context_line":"            client.update_router_in_agent("},{"line_number":419,"context_line":"                agent,"},{"line_number":420,"context_line":"                router,"}],"source_content_type":"text/x-python","patch_set":3,"id":"00414e22_b6918f5f","line":417,"range":{"start_line":414,"start_character":48,"end_line":417,"end_character":26},"in_reply_to":"c9495d18_358f1dd0","updated":"2026-05-18 14:59:22.000000000","message":"Right, let me check that.","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"559f3f2e5241921b5aeef2725945f7dfec49cf7d","unresolved":true,"context_lines":[{"line_number":378,"context_line":"            client.remove_router_from_agent(agent, router)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"class SetRouterToAgent(command.Command):"},{"line_number":382,"context_line":"    _description \u003d _(\"Set properties of a router associated to an agent\")"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def get_parser(self, prog_name: str) -\u003e argparse.ArgumentParser:"}],"source_content_type":"text/x-python","patch_set":4,"id":"80cd3a07_b7b0a263","line":381,"updated":"2026-05-20 14:28:20.000000000","message":"nit: How about:\n\n```suggestion\nclass SetNetworkAgentRouter(command.Command):\n```\n\nThe way this is worded suggests you are adding a router to an agent, which is not what we\u0027re doing","commit_id":"fdf3a700d57b02eb25e6afed16d837314ad6e4c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b7ceb6d972be14ba92923baa678d5ad4b0abe5db","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            client.remove_router_from_agent(agent, router)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"class SetRouterToAgent(command.Command):"},{"line_number":382,"context_line":"    _description \u003d _(\"Set properties of a router associated to an agent\")"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def get_parser(self, prog_name: str) -\u003e argparse.ArgumentParser:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ce8c6d8_9478f2d5","line":381,"in_reply_to":"80cd3a07_b7b0a263","updated":"2026-05-20 14:33:41.000000000","message":"Done","commit_id":"fdf3a700d57b02eb25e6afed16d837314ad6e4c5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8b7a91678b3c9df4ffe29fe52d6692777b6c132","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        )"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"# TODO(huanxuan): Use the SDK resource mapped attribute names once the"},{"line_number":432,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":433,"context_line":"class SetNetworkAgent(command.Command):"},{"line_number":434,"context_line":"    _description \u003d _(\"Set network agent properties\")"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d74590f1_671564ca","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":43},"updated":"2026-06-09 14:25:43.000000000","message":"Looks like a rebase snafu. Can you drop this?","commit_id":"16cf6b088ab71aefd16f103b5c565f9dde943968"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3703438b11740795a40c773cce779c69cd85f7e","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        )"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"# TODO(huanxuan): Use the SDK resource mapped attribute names once the"},{"line_number":432,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":433,"context_line":"class SetNetworkAgent(command.Command):"},{"line_number":434,"context_line":"    _description \u003d _(\"Set network agent properties\")"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"017ab8d9_c38d8345","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":43},"in_reply_to":"d74590f1_671564ca","updated":"2026-06-10 06:05:40.000000000","message":"Yes, fixed (incorrectly) the git conflict without actually checking the output","commit_id":"16cf6b088ab71aefd16f103b5c565f9dde943968"}],"openstackclient/tests/unit/network/v2/test_network_agent.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8b7a91678b3c9df4ffe29fe52d6692777b6c132","unresolved":true,"context_lines":[{"line_number":499,"context_line":"        self.assertIsNone(result)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"class TestSetNetworkAgentRouter(TestNetworkAgent):"},{"line_number":503,"context_line":"    _router \u003d network_fakes.create_one_router()"},{"line_number":504,"context_line":"    _agent \u003d network_fakes.create_one_network_agent()"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def setUp(self):"},{"line_number":507,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"b5d9109a_68eb468f","line":504,"range":{"start_line":502,"start_character":50,"end_line":504,"end_character":53},"updated":"2026-06-09 14:25:43.000000000","message":"nit: can you do this inside `setUp`? It\u0027s mutable so this can cause weird issues\n\n(we need to change other users in the code base to do the same: I just haven\u0027t gotten to it yet)","commit_id":"16cf6b088ab71aefd16f103b5c565f9dde943968"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d3703438b11740795a40c773cce779c69cd85f7e","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        self.assertIsNone(result)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"class TestSetNetworkAgentRouter(TestNetworkAgent):"},{"line_number":503,"context_line":"    _router \u003d network_fakes.create_one_router()"},{"line_number":504,"context_line":"    _agent \u003d network_fakes.create_one_network_agent()"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def setUp(self):"},{"line_number":507,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"aaa3a4b4_efcda87d","line":504,"range":{"start_line":502,"start_character":50,"end_line":504,"end_character":53},"in_reply_to":"b5d9109a_68eb468f","updated":"2026-06-10 06:05:40.000000000","message":"Yes, you are right. I should not trust on how Claude implement the test classes, I had some problems before. And adding mutable parameters as class attributes that are testing resources, is an error.\n\nIn any case, it is mimicking how is implemented in this file. But it should be smarter to define a better approach.","commit_id":"16cf6b088ab71aefd16f103b5c565f9dde943968"}],"pyproject.toml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d9d1e9c4868a548b93c44686f3a79a9ae8e6d25c","unresolved":true,"context_lines":[{"line_number":419,"context_line":"network_agent_remove_network \u003d \"openstackclient.network.v2.network_agent:RemoveNetworkFromAgent\""},{"line_number":420,"context_line":"network_agent_remove_router \u003d \"openstackclient.network.v2.network_agent:RemoveRouterFromAgent\""},{"line_number":421,"context_line":"network_agent_set \u003d \"openstackclient.network.v2.network_agent:SetNetworkAgent\""},{"line_number":422,"context_line":"network_agent_set_router \u003d \"openstackclient.network.v2.network_agent:SetRouterToAgent\""},{"line_number":423,"context_line":"network_agent_show \u003d \"openstackclient.network.v2.network_agent:ShowNetworkAgent\""},{"line_number":424,"context_line":"network_auto_allocated_topology_create \u003d \"openstackclient.network.v2.network_auto_allocated_topology:CreateAutoAllocatedTopology\""},{"line_number":425,"context_line":"network_auto_allocated_topology_delete \u003d \"openstackclient.network.v2.network_auto_allocated_topology:DeleteAutoAllocatedTopology\""}],"source_content_type":"text/x-toml","patch_set":3,"id":"aca8cebf_f9893815","line":422,"range":{"start_line":422,"start_character":0,"end_line":422,"end_character":24},"updated":"2026-05-18 13:24:40.000000000","message":"Any reason we can\u0027t do the more typical `network agent router set`?\n\n```suggestion\nnetwork_agent_router_set \u003d \"openstackclient.network.v2.network_agent:SetRouterToAgent\"\n```","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8306b6f8983c50811afb5f947098763d8189ed00","unresolved":true,"context_lines":[{"line_number":419,"context_line":"network_agent_remove_network \u003d \"openstackclient.network.v2.network_agent:RemoveNetworkFromAgent\""},{"line_number":420,"context_line":"network_agent_remove_router \u003d \"openstackclient.network.v2.network_agent:RemoveRouterFromAgent\""},{"line_number":421,"context_line":"network_agent_set \u003d \"openstackclient.network.v2.network_agent:SetNetworkAgent\""},{"line_number":422,"context_line":"network_agent_set_router \u003d \"openstackclient.network.v2.network_agent:SetRouterToAgent\""},{"line_number":423,"context_line":"network_agent_show \u003d \"openstackclient.network.v2.network_agent:ShowNetworkAgent\""},{"line_number":424,"context_line":"network_auto_allocated_topology_create \u003d \"openstackclient.network.v2.network_auto_allocated_topology:CreateAutoAllocatedTopology\""},{"line_number":425,"context_line":"network_auto_allocated_topology_delete \u003d \"openstackclient.network.v2.network_auto_allocated_topology:DeleteAutoAllocatedTopology\""}],"source_content_type":"text/x-toml","patch_set":3,"id":"758a1ad3_8b5875b3","line":422,"range":{"start_line":422,"start_character":0,"end_line":422,"end_character":24},"in_reply_to":"23bb48f7_df12341a","updated":"2026-05-18 14:28:17.000000000","message":"Those are different though: `foo add bar` or `foo remove bar` are actions on `foo` (you\u0027re adding or removing `bar`). In this case you appear to be modifying `bar`, so it should be `foo bar set`, not `foo set bar`. Unless I\u0027ve missed something?","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3e1b696aa30cb2bddd0895c6c4e19e2efd3f9339","unresolved":false,"context_lines":[{"line_number":419,"context_line":"network_agent_remove_network \u003d \"openstackclient.network.v2.network_agent:RemoveNetworkFromAgent\""},{"line_number":420,"context_line":"network_agent_remove_router \u003d \"openstackclient.network.v2.network_agent:RemoveRouterFromAgent\""},{"line_number":421,"context_line":"network_agent_set \u003d \"openstackclient.network.v2.network_agent:SetNetworkAgent\""},{"line_number":422,"context_line":"network_agent_set_router \u003d \"openstackclient.network.v2.network_agent:SetRouterToAgent\""},{"line_number":423,"context_line":"network_agent_show \u003d \"openstackclient.network.v2.network_agent:ShowNetworkAgent\""},{"line_number":424,"context_line":"network_auto_allocated_topology_create \u003d \"openstackclient.network.v2.network_auto_allocated_topology:CreateAutoAllocatedTopology\""},{"line_number":425,"context_line":"network_auto_allocated_topology_delete \u003d \"openstackclient.network.v2.network_auto_allocated_topology:DeleteAutoAllocatedTopology\""}],"source_content_type":"text/x-toml","patch_set":3,"id":"48012dc4_28700f0e","line":422,"range":{"start_line":422,"start_character":0,"end_line":422,"end_character":24},"in_reply_to":"4aec1974_fbc36ce4","updated":"2026-05-18 14:59:22.000000000","message":"I think I\u0027ll go for the `network_agent_router_set` alternative.","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9837defb5458eef1a558a96f83d202bdf42f9943","unresolved":true,"context_lines":[{"line_number":419,"context_line":"network_agent_remove_network \u003d \"openstackclient.network.v2.network_agent:RemoveNetworkFromAgent\""},{"line_number":420,"context_line":"network_agent_remove_router \u003d \"openstackclient.network.v2.network_agent:RemoveRouterFromAgent\""},{"line_number":421,"context_line":"network_agent_set \u003d \"openstackclient.network.v2.network_agent:SetNetworkAgent\""},{"line_number":422,"context_line":"network_agent_set_router \u003d \"openstackclient.network.v2.network_agent:SetRouterToAgent\""},{"line_number":423,"context_line":"network_agent_show \u003d \"openstackclient.network.v2.network_agent:ShowNetworkAgent\""},{"line_number":424,"context_line":"network_auto_allocated_topology_create \u003d \"openstackclient.network.v2.network_auto_allocated_topology:CreateAutoAllocatedTopology\""},{"line_number":425,"context_line":"network_auto_allocated_topology_delete \u003d \"openstackclient.network.v2.network_auto_allocated_topology:DeleteAutoAllocatedTopology\""}],"source_content_type":"text/x-toml","patch_set":3,"id":"4aec1974_fbc36ce4","line":422,"range":{"start_line":422,"start_character":0,"end_line":422,"end_character":24},"in_reply_to":"758a1ad3_8b5875b3","updated":"2026-05-18 14:37:25.000000000","message":"Alternatively, you could just use the existing `network agent set` command and \"namespace\" the new option with a prefix, e.g. `--router-ha-chassis-priority`.","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f2f795aa029d5edd36faae69131d2bf674ec02a5","unresolved":true,"context_lines":[{"line_number":419,"context_line":"network_agent_remove_network \u003d \"openstackclient.network.v2.network_agent:RemoveNetworkFromAgent\""},{"line_number":420,"context_line":"network_agent_remove_router \u003d \"openstackclient.network.v2.network_agent:RemoveRouterFromAgent\""},{"line_number":421,"context_line":"network_agent_set \u003d \"openstackclient.network.v2.network_agent:SetNetworkAgent\""},{"line_number":422,"context_line":"network_agent_set_router \u003d \"openstackclient.network.v2.network_agent:SetRouterToAgent\""},{"line_number":423,"context_line":"network_agent_show \u003d \"openstackclient.network.v2.network_agent:ShowNetworkAgent\""},{"line_number":424,"context_line":"network_auto_allocated_topology_create \u003d \"openstackclient.network.v2.network_auto_allocated_topology:CreateAutoAllocatedTopology\""},{"line_number":425,"context_line":"network_auto_allocated_topology_delete \u003d \"openstackclient.network.v2.network_auto_allocated_topology:DeleteAutoAllocatedTopology\""}],"source_content_type":"text/x-toml","patch_set":3,"id":"23bb48f7_df12341a","line":422,"range":{"start_line":422,"start_character":0,"end_line":422,"end_character":24},"in_reply_to":"aca8cebf_f9893815","updated":"2026-05-18 13:55:06.000000000","message":"This is following the current convention we have for this command: `network_agent_add_router`, `network_agent_remove_router`.\n\nWe have similar command definitions: `router_add_gateway`, `router_add_port`, `router_add_subnet`\n\nActually we should update the previous command `SetNetworkAgent` to be `network_agent_set_network`","commit_id":"e698e251017dc7cd908d36461389f62732c6921a"}]}