)]}'
{"id":"openstack%2Fpython-openstackclient~994423","triplet_id":"openstack%2Fpython-openstackclient~master~I8c23b789facdde7cbbcd7631a28156463fc12f8d","project":"openstack/python-openstackclient","branch":"master","topic":"typing","hashtags":[],"change_id":"I8c23b789facdde7cbbcd7631a28156463fc12f8d","subject":"network: Replace new use of keystoneclient","status":"MERGED","created":"2026-06-23 10:58:46.000000000","updated":"2026-06-23 14:54:12.000000000","submitted":"2026-06-23 14:53:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"994423-typing","meta_rev_id":"2e297dab7f14fa6cd28b0895e937ae6fb0a39f13","_number":994423,"virtual_id_number":994423,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-06-23 14:53:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-06-23 13:22:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-06-23 13:22:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-23 12:30:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7d297398fdcb54235e9f366e56efb23e9c4fb049","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-06-23 10:58:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"263ef1028290de0b8c11e7b4c92d2fe12253df0c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-23 12:30:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1b2701d864074e31badcde469cefb40a\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/7597667a6ec54dd696fb1eef43b01731 : SUCCESS in 5m 48s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/734b7ba18d3d429886f2da73f8692b99 : SUCCESS in 4m 54s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/44d2833e71d4462f9a7e5c7dadd5f442 : SUCCESS in 7m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1c1fcd5593e14fddb5a0cf31a782e17e : SUCCESS in 5m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fb1dd204aff84f01a1b97d3d96ee13d0 : SUCCESS in 4m 32s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/93224baafc214737a2f2ed9ff6402694 : SUCCESS in 4m 10s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/e63498138f2b454ba2577e305abd1321 : SUCCESS in 4m 12s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/cdbc95a443964631b7a9dcafe9e5c523 : SUCCESS in 6m 36s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f8479d864aab452aa7d72aca6994ae79 : SUCCESS in 8m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/40df7eab383d437a850e64db25c837e0 : SUCCESS in 9m 19s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/72dd14f29a114505ae7321802eb6b3f1 : FAILURE in 5m 46s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/33133a00b5964e9ead57d86635caa636 : SUCCESS in 1h 16m 38s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/7aea11d9d45147a0929a25e3910bbb63 : SUCCESS in 1h 22m 45s","accounts_in_message":[],"_revision_number":1},{"id":"d916a376bc86e0ddeae72629d5ad8befbf35320b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-06-23 13:22:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"69decab383c69b956bf96046c5376e6a1e10cd6f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-23 13:23:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"694d9975df8bf732210f7cdb976085718053215a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-23 14:53:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8855669fae0c49fdb2311d6ef7eb21c7\n\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/713c79a9e59243d6a277c82d160a68cb : SUCCESS in 5m 12s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/988a7958de8e4f95b3a1a1e660c678de : SUCCESS in 5m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cda327ffcad94f8d932767a6e04bf91e : SUCCESS in 3m 48s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/35b85ab346cd45539bef2d78952192e4 : SUCCESS in 3m 24s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/92f64e21031e497a8bd55431d02d2f6d : SUCCESS in 4m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b43c8f0a8ed4b1fa6077c365cebf758 : SUCCESS in 7m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e994fb733d114f8a876ddd36dde7721a : SUCCESS in 5m 49s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/38cf29b2b18e44059563d04a0a7018af : SUCCESS in 1h 28m 01s","accounts_in_message":[],"_revision_number":1},{"id":"e9fad885df515f731fa48725d3d029a3d24e01a3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-23 14:53:14.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"2e297dab7f14fa6cd28b0895e937ae6fb0a39f13","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-23 14:54:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3df8d5a095024a3bac28462b7fa286cb\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa5895897212478e9fad226b26b80797 : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5a53f2cc01e7a3494cc44bd3efbbc11ddd8b66db","revisions":{"5a53f2cc01e7a3494cc44bd3efbbc11ddd8b66db":{"kind":"REWORK","_number":1,"created":"2026-06-23 10:58:46.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/23/994423/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/994423/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/994423/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/994423/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/994423/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/994423/1"}}},"commit":{"parents":[{"commit":"bad01d3d6795f376897c8fbb31bfb4414624cd05","subject":"typing: Add missing hints to network.v2.dynamic_routing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bad01d3d6795f376897c8fbb31bfb4414624cd05"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-06-23 10:53:07.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-06-23 10:55:25.000000000","tz":60},"subject":"network: Replace new use of keystoneclient","message":"network: Replace new use of keystoneclient\n\nChange Id9014aef47af42ac813cacaaccc61346a0282897 removed all use of\nkeystoneclient from openstackclient.network, but these users slipped in\nin the interim. Replace them.\n\nChange-Id: I8c23b789facdde7cbbcd7631a28156463fc12f8d\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5a53f2cc01e7a3494cc44bd3efbbc11ddd8b66db"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5a53f2cc01e7a3494cc44bd3efbbc11ddd8b66db"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
