)]}'
{"id":"openstack%2Fpython-openstackclient~995106","triplet_id":"openstack%2Fpython-openstackclient~master~Icab0efce27d3676a8350b911ab738344e5e60735","project":"openstack/python-openstackclient","branch":"master","topic":"migrate_stadium_osc","hashtags":[],"change_id":"Icab0efce27d3676a8350b911ab738344e5e60735","subject":"network: Address review comments on VPNaaS addition","status":"MERGED","created":"2026-06-26 16:13:35.000000000","updated":"2026-06-27 01:53:55.000000000","submitted":"2026-06-27 01:53:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"995106-migrate_stadium_osc","meta_rev_id":"9aea869280d3b69154996d10edb195bac1a47e6c","_number":995106,"virtual_id_number":995106,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-06-27 01:53:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-06-27 00:34:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-06-27 00:34:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-26 17:55:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8aac34051d75027cf34aee3f459586c206980041","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-06-26 16:13:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c329f006ba6852f86cb74670d33c2ccb92133f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-26 17:55:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fa1fd20b73724bcaa938b8f28263712b\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/a33bb57b18e94f61b57bfd4c4027c79f : SUCCESS in 6m 37s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/adccefe2cc1a4cb4a048670a629db199 : SUCCESS in 7m 09s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/4b655ae4b3894099ac9e4828e290b49e : SUCCESS in 8m 37s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/80c19309b864490184e922d693940397 : SUCCESS in 4m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05d5cc5bc577424290d2964b99753966 : SUCCESS in 6m 05s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/09d4b5af42f94b388b11c6e93781f4b1 : SUCCESS in 2m 18s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/6d23b8220ca94accb63f7b3e661c5e0c : SUCCESS in 2m 48s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/17b38c14ef5d4efb997a3de23c6c9e87 : SUCCESS in 6m 17s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/402f8503563a4b9b819afe654dc7f726 : SUCCESS in 5m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ea28029d2de4892a21dc4e9826b763a : SUCCESS in 8m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b64949dcdfc849e2abbc93ea456a0016 : SUCCESS in 11m 08s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/c94f6b81b7b84be7bd9f2e41f8765a41 : FAILURE in 6m 07s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/698ac6d5202c403588daec455a44a090 : SUCCESS in 1h 25m 13s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/b044735ef46b4b47ae1a0141b0c10a5f : SUCCESS in 1h 22m 15s","accounts_in_message":[],"_revision_number":1},{"id":"56f8125b7ecf5e55bb173f64f3e87e5cccf4333a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-06-27 00:34:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3cdf3cf14433d9f715d2647ee5c894e7786bad92","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-27 00:35:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"73755a432092cc92ca188e5c96f3b19e1e9ba275","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-27 01:53:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0a9ef063ec0740d8bf13bbefd6912e2d\n\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/e32559be84684c8cb9f990d4ffda1d6d : SUCCESS in 4m 11s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/9df6bd69ef0647819633fc0ce307ef0d : SUCCESS in 7m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0bb13fe76ddd4583bfdf4ebfbcf1a8f3 : SUCCESS in 5m 33s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ac7ecffbf68b406ebe74a7eaa19cec57 : SUCCESS in 3m 40s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/6486242c3b9b4f33b67480936af59a2d : SUCCESS in 2m 40s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/5489560d2229475dbb8c2c4a487e078b : SUCCESS in 6m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/32f2f784517a483d85740d5e80f3a7bb : SUCCESS in 3m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2cd05e3f1c3749d9a42f08d94a703988 : SUCCESS in 8m 26s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/e15d984d7a674b969b3a04f17686a70f : SUCCESS in 1h 01m 19s","accounts_in_message":[],"_revision_number":1},{"id":"9aea869280d3b69154996d10edb195bac1a47e6c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-27 01:53:55.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0a14239d31849b4ae67328c3f9f1019d4397121b","revisions":{"0a14239d31849b4ae67328c3f9f1019d4397121b":{"kind":"REWORK","_number":1,"created":"2026-06-26 16:13:35.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/06/995106/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/06/995106/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/995106/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/995106/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/995106/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/06/995106/1"}}},"commit":{"parents":[{"commit":"f475f4e7a195100ba11dd4442cc288e06d95c7af","subject":"network: Replace new use of keystoneclient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f475f4e7a195100ba11dd4442cc288e06d95c7af"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-06-26 14:31:12.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-06-26 16:09:41.000000000","tz":60},"subject":"network: Address review comments on VPNaaS addition","message":"network: Address review comments on VPNaaS addition\n\n- Fold single-caller methods to their call site\n- Replace str2dict_type with existing utility\n\nChange-Id: Icab0efce27d3676a8350b911ab738344e5e60735\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0a14239d31849b4ae67328c3f9f1019d4397121b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0a14239d31849b4ae67328c3f9f1019d4397121b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}