)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3a079992bc41c1b427d88e6fc2e5a061b4e3db6","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Volume-related options still require Cinder and now fail with a clear error"},{"line_number":23,"context_line":"when the endpoint is missing."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #2160039"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Assisted-by: Cursor Composer 2.5"},{"line_number":28,"context_line":"Change-Id: I79e2efe3e79727c7055ca47c0eca05833be6eb1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff499390_de1faea1","line":25,"updated":"2026-07-13 18:41:40.000000000","message":"ya that defintly a valid bug server create in particalare shoudld not depend on cinder or techincally neutron\n\n\nthe minimal set of service to boot a vm is glance keytons nova and placment\nrealsiticly neutron and cidner are the next most used compents but if your\n\nusing the ironic virt dirver then you dont have to have neutron for networking or if you use pci passhtouhg so osc shoudl not force a tight coupling if the serivce can work with a reduced set.","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"091dc3cc576671b403adcc297f460c50bb8fca7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77df0658_02b45d88","updated":"2026-07-13 17:59:30.000000000","message":"The nova-alt-configurations job is currently broken due to the bug this will fix:\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dnova-alt-configurations\u0026project\u003dopenstack/nova\n\nThanks for working on it.","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9444b07efe5616edd1ec70f7647b85c4614ea1f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7b40c16_5741a6fe","updated":"2026-07-09 15:01:40.000000000","message":"recheck - unrelated dhcp agent scheduler issue","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"}],"openstackclient/common/availability_zone.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3a079992bc41c1b427d88e6fc2e5a061b4e3db6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    def _get_volume_availability_zones("},{"line_number":206,"context_line":"        self, parsed_args: argparse.Namespace"},{"line_number":207,"context_line":"    ) -\u003e list[dict[str, str]]:"},{"line_number":208,"context_line":"        if not self.app.client_manager.is_volume_endpoint_enabled():"},{"line_number":209,"context_line":"            if parsed_args.volume:"},{"line_number":210,"context_line":"                message \u003d _("},{"line_number":211,"context_line":"                    \"Block Storage API is not available in the current cloud\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9278cbcc_a83fb710","line":208,"updated":"2026-07-13 18:41:40.000000000","message":"https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/clientmanager.py#L171\n\nit might be worth considring if we shoudl cache that\nto avoid calling is_service_available many times\n\nhttps://opendev.org/openstack/osc-lib/src/branch/master/osc_lib/clientmanager.py#L245\n\nalthough that might not be required.\n\nit would be nice in interactive mode but in non interactive mode i dont knwo that it will buy us much","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3a079992bc41c1b427d88e6fc2e5a061b4e3db6","unresolved":true,"context_lines":[{"line_number":1149,"context_line":"    if parsed_args.volume or parsed_args.snapshot:"},{"line_number":1150,"context_line":"        return True"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    for mapping in parsed_args.block_device_mapping:"},{"line_number":1153,"context_line":"        if mapping[\u0027source_type\u0027] in (\u0027volume\u0027, \u0027snapshot\u0027):"},{"line_number":1154,"context_line":"            return True"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    return False"},{"line_number":1157,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae5ea2a_77a47c1a","line":1154,"range":{"start_line":1152,"start_character":2,"end_line":1154,"end_character":23},"updated":"2026-07-13 18:41:40.000000000","message":"i guess we are ignoring the boot form nova created volume form image flow\n\nbecause in that case the cidner depency is server side so that valid i guess.","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3a079992bc41c1b427d88e6fc2e5a061b4e3db6","unresolved":true,"context_lines":[{"line_number":1620,"context_line":""},{"line_number":1621,"context_line":"        volume_client \u003d None"},{"line_number":1622,"context_line":"        if _server_create_needs_volume_client(parsed_args):"},{"line_number":1623,"context_line":"            volume_client \u003d _get_required_volume_client(self.app)"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        # Lookup parsed_args.image"},{"line_number":1626,"context_line":"        image \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"17351a8b_d9e643f7","line":1623,"range":{"start_line":1623,"start_character":28,"end_line":1623,"end_character":55},"updated":"2026-07-13 18:41:40.000000000","message":"i would be tempeteed to inline _server_create_needs_volume_client into _get_required_volume_client and remove the if.\n\nim nto sure it really hels to extract _server_create_needs_volume_client\nwhen its only used once","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3a079992bc41c1b427d88e6fc2e5a061b4e3db6","unresolved":true,"context_lines":[{"line_number":1685,"context_line":"                )"},{"line_number":1686,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"        volume \u003d None"},{"line_number":1689,"context_line":"        if parsed_args.volume:"},{"line_number":1690,"context_line":"            # --volume and --boot-from-volume are mutually exclusive."},{"line_number":1691,"context_line":"            if parsed_args.boot_from_volume:"},{"line_number":1692,"context_line":"                msg \u003d _(\u0027--volume is not allowed with --boot-from-volume\u0027)"},{"line_number":1693,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"            assert volume_client is not None  # narrow type"},{"line_number":1696,"context_line":"            volume \u003d volume_client.find_volume("},{"line_number":1697,"context_line":"                parsed_args.volume,"},{"line_number":1698,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":1699,"context_line":"            ).id"},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"        snapshot \u003d None"},{"line_number":1702,"context_line":"        if parsed_args.snapshot:"},{"line_number":1703,"context_line":"            # --snapshot and --boot-from-volume are mutually exclusive."},{"line_number":1704,"context_line":"            if parsed_args.boot_from_volume:"},{"line_number":1705,"context_line":"                msg \u003d _(\u0027--snapshot is not allowed with --boot-from-volume\u0027)"},{"line_number":1706,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":1707,"context_line":""},{"line_number":1708,"context_line":"            assert volume_client is not None  # narrow type"},{"line_number":1709,"context_line":"            snapshot \u003d volume_client.find_snapshot("},{"line_number":1710,"context_line":"                parsed_args.snapshot,"},{"line_number":1711,"context_line":"                ignore_missing\u003dFalse,"},{"line_number":1712,"context_line":"            ).id"},{"line_number":1713,"context_line":""},{"line_number":1714,"context_line":"        flavor \u003d compute_client.find_flavor("},{"line_number":1715,"context_line":"            parsed_args.flavor, ignore_missing\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"f51d17af_76734657","line":1712,"range":{"start_line":1688,"start_character":2,"end_line":1712,"end_character":16},"updated":"2026-07-13 18:41:40.000000000","message":"while the assert are correct from a typing point of view i also feel like\n\nthere is now some duplciation of parmater checking with \n_server_create_needs_volume_client","commit_id":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"}]}