)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c40926dd35c017c176736b9fc58697da1fe8ac6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cbe1eff7_ea407c20","updated":"2026-07-20 20:48:15.000000000","message":"Thanks for working on this","commit_id":"d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c40926dd35c017c176736b9fc58697da1fe8ac6b","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        \u0027--vnic-type\u0027,"},{"line_number":397,"context_line":"        metavar\u003d\u0027\u003cvnic-type\u003e\u0027,"},{"line_number":398,"context_line":"        choices\u003d("},{"line_number":399,"context_line":"            \u0027accelerator-direct\u0027,"},{"line_number":400,"context_line":"            \u0027direct\u0027,"},{"line_number":401,"context_line":"            \u0027direct-physical\u0027,"},{"line_number":402,"context_line":"            \u0027macvtap\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"88ef022b_d7f90fe4","line":399,"updated":"2026-07-20 20:48:15.000000000","message":"Can you also update the api-ref in neutron-lib so it has this value? [0]\n\nActually looking at that there are other inconsistencies - smart-nic is not here and vdpa is not there.\n\n[0] neutron-lib/api-ref/source/v2/parameters.yaml","commit_id":"d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fed77bb13887566c9766838bb6c89047d2f682c3","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        \u0027--vnic-type\u0027,"},{"line_number":397,"context_line":"        metavar\u003d\u0027\u003cvnic-type\u003e\u0027,"},{"line_number":398,"context_line":"        choices\u003d("},{"line_number":399,"context_line":"            \u0027accelerator-direct\u0027,"},{"line_number":400,"context_line":"            \u0027direct\u0027,"},{"line_number":401,"context_line":"            \u0027direct-physical\u0027,"},{"line_number":402,"context_line":"            \u0027macvtap\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"06ecea07_a97c725e","line":399,"in_reply_to":"506253d7_b08f6fda","updated":"2026-07-28 12:10:01.000000000","message":"\u0027smart-nic\u0027, is for the off path DPU feature right\n\n https://specs.openstack.org/openstack/nova-specs/specs/yoga/implemented/integration-with-off-path-network-backends.html#desired-outcome-overview\n \nand yes vdpa has bee a viald type for quit a whiel as well\nhttps://specs.openstack.org/openstack/nova-specs/specs/wallaby/implemented/libvirt-vdpa-support.html\n\nthe canonical place to check the valid vnic types is https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings.py#L133-L136\n\nnot the api ref but that shoudl prbaly be adressed seperatly.","commit_id":"d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e421c33e8a972688cc1f354be66aa7a5d20ab59e","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        \u0027--vnic-type\u0027,"},{"line_number":397,"context_line":"        metavar\u003d\u0027\u003cvnic-type\u003e\u0027,"},{"line_number":398,"context_line":"        choices\u003d("},{"line_number":399,"context_line":"            \u0027accelerator-direct\u0027,"},{"line_number":400,"context_line":"            \u0027direct\u0027,"},{"line_number":401,"context_line":"            \u0027direct-physical\u0027,"},{"line_number":402,"context_line":"            \u0027macvtap\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"506253d7_b08f6fda","line":399,"in_reply_to":"88ef022b_d7f90fe4","updated":"2026-07-20 21:47:34.000000000","message":"Sure, thanks for pointing that out. I have added the other missing VNIC_TYPES and proposed the api-ref update at https://review.opendev.org/c/openstack/neutron-lib/+/998069","commit_id":"d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7f58d42f0c1ee9498df37a9eb668c492c64b6e89","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        metavar\u003d\u0027\u003cvnic-type\u003e\u0027,"},{"line_number":398,"context_line":"        choices\u003d("},{"line_number":399,"context_line":"            \u0027accelerator-direct\u0027,"},{"line_number":400,"context_line":"            \u0027accelerator-direct-physical\u0027,"},{"line_number":401,"context_line":"            \u0027direct\u0027,"},{"line_number":402,"context_line":"            \u0027direct-physical\u0027,"},{"line_number":403,"context_line":"            \u0027macvtap\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c0a1cb30_02b1b77f","line":400,"range":{"start_line":400,"start_character":13,"end_line":400,"end_character":40},"updated":"2026-07-20 21:59:09.000000000","message":"Just not sure about this one, even though it is defined I don\u0027t see a user.","commit_id":"d84716fb9c2d9968078e53a598747bb7c9b540f0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fed77bb13887566c9766838bb6c89047d2f682c3","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        metavar\u003d\u0027\u003cvnic-type\u003e\u0027,"},{"line_number":398,"context_line":"        choices\u003d("},{"line_number":399,"context_line":"            \u0027accelerator-direct\u0027,"},{"line_number":400,"context_line":"            \u0027accelerator-direct-physical\u0027,"},{"line_number":401,"context_line":"            \u0027direct\u0027,"},{"line_number":402,"context_line":"            \u0027direct-physical\u0027,"},{"line_number":403,"context_line":"            \u0027macvtap\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6cda5c59_6bd724e4","line":400,"range":{"start_line":400,"start_character":13,"end_line":400,"end_character":40},"in_reply_to":"c0a1cb30_02b1b77f","updated":"2026-07-28 12:10:01.000000000","message":"we initally chosoe not to enable it due to how the cyborg driver works\n\nwe can allwo it but you correct that no ml2 driver currently support binding it\n\nthere are some concerns in general with allowing PFs to be directly assigned as neutron does not enfoce they are only used ofn flat netowrk or use heracal prot bidning ot trunk the switch port to a vlan or other neutron netowrk\n\nso whne it came to suporting this we just enabled accelerator-direct initally","commit_id":"d84716fb9c2d9968078e53a598747bb7c9b540f0"}]}