)]}'
{"id":"openstack%2Fpython-openstackclient~998057","triplet_id":"openstack%2Fpython-openstackclient~master~I052f77b911057a88f21adc0107196a3156a80ca1","project":"openstack/python-openstackclient","branch":"master","topic":"bug/2161369","attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2026-07-20 21:59:09.000000000","reason":"\u003cGERRIT_ACCOUNT_1131\u003e replied on the change","reason_account":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}}},"removed_from_attention_set":{"16688":{"account":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"last_update":"2026-07-24 15:02:46.000000000","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change","reason_account":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"}},"1131":{"account":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"last_update":"2026-07-20 21:59:09.000000000","reason":"\u003cGERRIT_ACCOUNT_1131\u003e replied on the change","reason_account":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}}},"hashtags":[],"change_id":"I052f77b911057a88f21adc0107196a3156a80ca1","subject":"Add missing vnic-type choices to --vnic-type","status":"NEW","created":"2026-07-20 19:42:10.000000000","updated":"2026-07-28 12:10:01.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":6,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"fed77bb13887566c9766838bb6c89047d2f682c3","_number":998057,"virtual_id_number":998057,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-07-20 23:09:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"all":[{"value":2,"date":"2026-07-24 15:02:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":2,"date":"2026-07-28 12:10:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2026-07-21 17:29:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-20 20:48:15.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2026-07-20 20:52:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-21 17:29:06.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2026-07-28 12:10:01.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"24ade28c73641be591c98ad15f255d5ac07b305d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2026-07-20 19:42:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c40926dd35c017c176736b9fc58697da1fe8ac6b","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2026-07-20 20:48:15.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"704e2beec6b21be8f0b947d3819d5462430eb4ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-20 20:52:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cb794f3852bb40c890471a1ac36e4cf3\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/184f0aca00db44918d2fbd935e38f60c : SUCCESS in 5m 58s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/52c2da2db7be4f8a924886376517a180 : SUCCESS in 4m 36s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/b615879c302f446e892ca91fac9c9f3e : SUCCESS in 7m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/78a0e2b5755a4ba5b50462743435d815 : SUCCESS in 6m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/133d57be975048beb704d61700ad42fb : SUCCESS in 4m 28s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/9d5c80fb26324b7f9697ccc880c8a1f6 : SUCCESS in 5m 06s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/526d05cdb42748b483c9cd482c6690b5 : SUCCESS in 3m 41s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/faa2bd6233964207b9f0e8674119732d : SUCCESS in 6m 25s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/8f0478cc97564e6bbf04f754530b7981 : SUCCESS in 6m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25497584c4f944d38c4d066e56d82fc5 : SUCCESS in 5m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1f688a4b0ac64648bdf21805ea5f7249 : SUCCESS in 6m 18s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/9cdf6fc7d75a42e484de689857d948d8 : FAILURE in 4m 52s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/0be85530e3744f2dab0f9071d9866da5 : SUCCESS in 1h 07m 41s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9ceb2f662297499cbe9e43ba30af816d : SUCCESS in 49m 40s","accounts_in_message":[],"_revision_number":1},{"id":"d95b45cfaba70c9f288feef9f4971aaf0767651b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2026-07-20 21:46:01.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e421c33e8a972688cc1f354be66aa7a5d20ab59e","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2026-07-20 21:47:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7f58d42f0c1ee9498df37a9eb668c492c64b6e89","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2026-07-20 21:59:09.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c528342b3aa2971b06ce66be607d09b79a43b7b6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-20 23:09:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9880de1a9c9d4e0c9d14476b461c03bf\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/89f13e923edc415e8e030ba9917efd14 : SUCCESS in 4m 20s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/04550771ff1d4175b3f18d4dd1801a30 : SUCCESS in 2m 42s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/26771bce3a8b441493f3cb160e91be68 : SUCCESS in 4m 46s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e65ffb94b194473b917d35027d3df9b7 : SUCCESS in 7m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/24f6c2c226fc410b8d7532d251d12878 : SUCCESS in 4m 37s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2edf388b10bc4ea4a12dba083c383aec : SUCCESS in 4m 42s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/4050e2aea1f04c5ab427031d6eeeab7d : SUCCESS in 5m 01s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/86d5c6d3674e4960a5cb66a9155857d3 : SUCCESS in 4m 37s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/8005153c8618488693f3043172e6a01a : SUCCESS in 6m 41s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f8489a2d02a44b18b5da71ac73a2abce : SUCCESS in 5m 52s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a6a9ee7c01604fd1a27271ecfc548bb9 : SUCCESS in 7m 25s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/e5b1b8f585ba482ebbb02842c64f15f3 : FAILURE in 3m 51s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/7a7a1f386a7042a6a902bd01c50186e6 : SUCCESS in 1h 10m 19s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/576ddac4749e46e0a900577561775a41 : SUCCESS in 1h 17m 58s","accounts_in_message":[],"_revision_number":2},{"id":"61378c3d0ab584b43a09f2404fbc7660cfb2e08b","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2026-07-21 17:29:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ab2e44e28b72c2a8cc7f8e7b18989e45f6f9f410","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2026-07-24 15:02:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fed77bb13887566c9766838bb6c89047d2f682c3","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2026-07-28 12:10:01.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d84716fb9c2d9968078e53a598747bb7c9b540f0","revisions":{"d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde":{"kind":"REWORK","_number":1,"created":"2026-07-20 19:42:10.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/57/998057/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/998057/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/1"}}},"commit":{"parents":[{"commit":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8","subject":"Make block-storage endpoint optional for select commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2026-07-20 19:41:27.000000000","tz":-420},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2026-07-20 19:41:27.000000000","tz":-420},"subject":"Add accelerator-direct to --vnic-type choices","message":"Add accelerator-direct to --vnic-type choices\n\nThe accelerator-direct vnic-type was added in neutron-lib for the\nsmartNIC SR-IOV support (Xena cycle) but was never added to the\nCLI\u0027s --vnic-type choices. This forces users to use curl to create\nports with this vnic-type.\n\nAdd accelerator-direct to the choices tuple and help text.\n\nCloses-Bug: #2161369\nAssisted-by: Claude claude-opus-4-6 2.1.215\nChange-Id: I052f77b911057a88f21adc0107196a3156a80ca1\nSigned-off-by: melanie witt \u003cmelwittt@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d4cd0463c21d2cc621e7ec1aac3b3cd9bf3bacde"}]},"branch":"refs/heads/master"},"d84716fb9c2d9968078e53a598747bb7c9b540f0":{"kind":"REWORK","_number":2,"created":"2026-07-20 21:46:01.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/57/998057/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/998057/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/998057/2"}}},"commit":{"parents":[{"commit":"9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8","subject":"Make block-storage endpoint optional for select commands","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9726a4d7994eaee55c6e1673cb02ee7d9dc4f8d8"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2026-07-20 19:41:27.000000000","tz":-420},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2026-07-20 21:42:11.000000000","tz":-420},"subject":"Add missing vnic-type choices to --vnic-type","message":"Add missing vnic-type choices to --vnic-type\n\nThe --vnic-type choices list was missing several vnic types that\nexist in neutron-lib\u0027s VNIC_TYPES: accelerator-direct (added in\nXena for smartNIC SR-IOV), accelerator-direct-physical, and\nsmart-nic. This forced users to use curl to create ports with\nthese vnic types.\n\nAdd all missing types to the choices tuple and help text so the\nCLI matches neutron-lib.\n\nCloses-Bug: #2161369\nAssisted-by: Claude claude-opus-4-6 2.1.215\nChange-Id: I052f77b911057a88f21adc0107196a3156a80ca1\nSigned-off-by: melanie witt \u003cmelwittt@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d84716fb9c2d9968078e53a598747bb7c9b540f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d84716fb9c2d9968078e53a598747bb7c9b540f0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}