)]}'
{"id":"openstack%2Fpython-pankoclient~495763","triplet_id":"openstack%2Fpython-pankoclient~master~If758f5c281cb61ae9426780b99796131f716ef27","project":"openstack/python-pankoclient","branch":"master","topic":"bug/1711997","hashtags":[],"change_id":"If758f5c281cb61ae9426780b99796131f716ef27","subject":"Fix operator option when listing event with filter","status":"ABANDONED","created":"2017-08-21 08:27:10.000000000","updated":"2017-09-15 15:40:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ad028621b5a9019ed0d6b9d9f6ad8a94348f6241","_number":495763,"virtual_id_number":495763,"owner":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},{"value":1,"date":"2017-09-13 01:21:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-09-13 01:28:44.000000000","_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"all":[{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-09-15 00:57:57.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-23 00:18:01.000000000","updated_by":{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},"reviewer":{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},"state":"REVIEWER"},{"updated":"2017-08-28 01:49:02.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2017-09-13 01:21:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1aee4e676d488d5689e6e9969b9dbc50075b9f96","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-21 08:27:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e2b2d66c366e3cb525a055d9e7c8d9c5f974ade","author":{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},"date":"2017-08-21 08:30:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3df771c4ae3c562b63e6802c21c9e6e34c32d312","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-21 08:32:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a9606fa16bb060616b1c6887ddb26b39ea414490","author":{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},"date":"2017-08-21 08:34:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c77218e45caa2bbe58f7c2b96c93b5c38d99bc4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-21 08:42:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-pankoclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/495763/2/check/gate-python-pankoclient-docs-ubuntu-xenial/7490c6f//doc/build/html/ : SUCCESS in 3m 03s\n- gate-python-pankoclient-pep8-ubuntu-xenial http://logs.openstack.org/63/495763/2/check/gate-python-pankoclient-pep8-ubuntu-xenial/cb3daf3/ : SUCCESS in 4m 57s\n- gate-python-pankoclient-python27-ubuntu-xenial http://logs.openstack.org/63/495763/2/check/gate-python-pankoclient-python27-ubuntu-xenial/17c4056/ : SUCCESS in 3m 04s\n- gate-python-pankoclient-python35 http://logs.openstack.org/63/495763/2/check/gate-python-pankoclient-python35/ea8fb90/ : SUCCESS in 3m 45s\n- check-osc-plugins http://logs.openstack.org/63/495763/2/check/check-osc-plugins/6df7348/ : SUCCESS in 6m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"95fb348f59629fde21d375f6e1c34f6d085ab59e","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-22 01:08:50.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"2eeea44da461c8cb7246b982a0f94f1024a59168","author":{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},"date":"2017-08-22 01:09:49.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ff4c1e2209a6d7558043c829892b8aa7f72bcb7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-22 01:16:25.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-pankoclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/495763/3/check/gate-python-pankoclient-docs-ubuntu-xenial/4ba99a8//doc/build/html/ : SUCCESS in 2m 30s\n- gate-python-pankoclient-pep8-ubuntu-xenial http://logs.openstack.org/63/495763/3/check/gate-python-pankoclient-pep8-ubuntu-xenial/fde33d7/ : SUCCESS in 2m 48s\n- gate-python-pankoclient-python27-ubuntu-xenial http://logs.openstack.org/63/495763/3/check/gate-python-pankoclient-python27-ubuntu-xenial/465666f/ : SUCCESS in 3m 15s\n- gate-python-pankoclient-python35 http://logs.openstack.org/63/495763/3/check/gate-python-pankoclient-python35/0f5de84/ : SUCCESS in 2m 55s\n- check-osc-plugins http://logs.openstack.org/63/495763/3/check/check-osc-plugins/532921c/ : SUCCESS in 5m 10s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"2c507e4e5c90037f30fc67fb8b00ae55ce07720a","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-22 09:12:18.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a0e3398a8de272a45a5bb48bc5c1d4e7e7824974","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-22 09:20:04.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-pankoclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/495763/4/check/gate-python-pankoclient-docs-ubuntu-xenial/6eb7adc//doc/build/html/ : SUCCESS in 4m 15s\n- gate-python-pankoclient-pep8-ubuntu-xenial http://logs.openstack.org/63/495763/4/check/gate-python-pankoclient-pep8-ubuntu-xenial/922b84b/ : SUCCESS in 3m 29s\n- gate-python-pankoclient-python27-ubuntu-xenial http://logs.openstack.org/63/495763/4/check/gate-python-pankoclient-python27-ubuntu-xenial/8dd3a09/ : SUCCESS in 3m 04s\n- gate-python-pankoclient-python35 http://logs.openstack.org/63/495763/4/check/gate-python-pankoclient-python35/9adc029/ : SUCCESS in 3m 29s\n- check-osc-plugins http://logs.openstack.org/63/495763/4/check/check-osc-plugins/e7e861e/ : SUCCESS in 5m 20s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"48eb2ce0ffd8725f79e18b5580523b30758a2580","author":{"_account_id":25698,"name":"Tzu-Chia Wang","email":"tcwang@itri.org.tw","username":"kerwinwang"},"date":"2017-08-23 00:18:01.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"34242aaf40dfece1bdf8842c6da1b5e961960e47","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2017-08-28 01:49:02.000000000","message":"Patch Set 4: Code-Review-1\n\n:( yes, i see the issue. \n\ni think we should fix this more cleanly. specifically, we should not be converting filter values into a dict[1]. we should just leave it and translate it as appropriate.\n\n[1] https://github.com/openstack/python-pankoclient/blob/5cf6011c0e41a9e4d04013b95935bc9604ea077a/pankoclient/v2/events_cli.py#L59","accounts_in_message":[],"_revision_number":4},{"id":"7e1254fbc340aec74e09a20f198c5e48ae73e6e8","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-28 02:10:16.000000000","message":"Patch Set 4:\n\nSure, this should solve the problem as well. But I think the fundemental\nproblem resides on the panko api. What is the point to specify operator\nwhen the field is (start|end)_timestamp? It must be (\u0027\u003e\u003d\u0027 | \u0027\u003c\u003d\u0027).\n\n  /v2/events?q.field\u003dstart_timestamp\u0026q.op\u003dge\u0026q.value\u003d2017-08-28\n\nSo I\u0027m thinking is it possible that we also change how panko-api behaves.\nLike this: if the field is (start|end)_timestamp, op should be ignored.\n\nAnd btw, it would be better if we simply change the url format to be like\none of gnocchi:\n\n  /v1/metric/\u003cuuid\u003e/measures?start\u003d2017-08-28\n\nBut I know it is almost impossible change that now. It is yet a good idea\nin my opinion. ^^","accounts_in_message":[],"_revision_number":4},{"id":"2c25bdf180f3dae59f2fc93657b4ee91c1dcc138","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-28 02:40:36.000000000","message":"Patch Set 4:\n\nNow I\u0027m looking into pankoclient/v2/events_cli.py. And I\u0027m wondering\nwhat you mean by cleanly. Could you explain it in detail?\n\nAnd since the original code in utils.py explicitly assign url with\n\u0027q.op\u003deq\u0027 . The code won\u0027t work if that doesn\u0027t get modified.","accounts_in_message":[],"_revision_number":4},{"id":"1ba1f1a64fda9c6752ea018f05708e75440ea7d1","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2017-08-28 12:12:49.000000000","message":"Patch Set 4:\n\n\u003e Sure, this should solve the problem as well. But I think the\n \u003e fundemental\n \u003e problem resides on the panko api. What is the point to specify\n \u003e operator\n \u003e when the field is (start|end)_timestamp? It must be (\u0027\u003e\u003d\u0027 | \u0027\u003c\u003d\u0027).\n \u003e \n \u003e /v2/events?q.field\u003dstart_timestamp\u0026q.op\u003dge\u0026q.value\u003d2017-08-28\n \u003e \n \u003e So I\u0027m thinking is it possible that we also change how panko-api\n \u003e behaves.\n \u003e Like this: if the field is (start|end)_timestamp, op should be\n \u003e ignored.\n \u003e \n \u003e And btw, it would be better if we simply change the url format to\n \u003e be like\n \u003e one of gnocchi:\n \u003e \n \u003e /v1/metric/\u003cuuid\u003e/measures?start\u003d2017-08-28\n \u003e \n \u003e But I know it is almost impossible change that now. It is yet a\n \u003e good idea\n \u003e in my opinion. ^^\n\nyou\u0027re right, you could change it in api as well. this is the original patch[1]. it seems like it was to support sqlalchemy but if you possibly do this mapping in panko, it will also solve it.\n\n[1] https://github.com/openstack/panko/commit/a6314e99e83645baf529544eb0bdee5c4acebfb6","accounts_in_message":[],"_revision_number":4},{"id":"dc38c5969800fd9207e8af6d1ef0583a03cd60a4","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2017-08-28 12:14:09.000000000","message":"Patch Set 4:\n\n\u003e Now I\u0027m looking into pankoclient/v2/events_cli.py. And I\u0027m\n \u003e wondering\n \u003e what you mean by cleanly. Could you explain it in detail?\n \u003e \n \u003e And since the original code in utils.py explicitly assign url with\n \u003e \u0027q.op\u003deq\u0027 . The code won\u0027t work if that doesn\u0027t get modified.\n\ni think my suggestion is that https://github.com/openstack/python-pankoclient/blob/master/pankoclient/v2/events_cli.py#L59 code should not be cast to dict or else you can never support \u0027ge\u0027 and \u0027le\u0027","accounts_in_message":[],"_revision_number":4},{"id":"9a430b8a3489ed4111c0ba6d384ab566906ce053","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-28 12:19:50.000000000","message":"Patch Set 4:\n\nso @gordon,\nwhat do you think we should do right now? Close this review and try to fix by changing panko-api? Or we still have to fix this \u0027forced to use eq operator\u0027 thing?","accounts_in_message":[],"_revision_number":4},{"id":"c006a9663a70dfd5affd9112f8cb551a0a478d1b","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2017-08-28 14:33:15.000000000","message":"Patch Set 4:\n\n\u003e so @gordon,\n \u003e what do you think we should do right now? Close this review and try\n \u003e to fix by changing panko-api? Or we still have to fix this \u0027forced\n \u003e to use eq operator\u0027 thing?\n\nhmm... i think we will have to fix client regardless so maybe start here. i would suggest supporting \u0027ge\u0027 and \u0027le\u0027 by avoiding that dict() cast. what do you think?","accounts_in_message":[],"_revision_number":4},{"id":"93e01e729abadf9b23c6353b8c42834489bdd380","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-29 00:20:01.000000000","message":"Patch Set 4:\n\n@gordon\nIf openstack client is used, basically it is not possible (at least now) to specify operator now since the format of filter must be:\n\n  openstack event list --format \u003ckey\u003e\u003d\u003cvalue\u003e\n\nSo I doubt if we can do anything with that. And btw I temporarily make code be:\n\n  def take_action(self, parsed_args):\n      ac \u003d self.app.client_manager.event\n      print(\u0027-------- \u0027 + str(parsed_args.filter))\n      filters \u003d dict(parsed_args.filter) if parsed_args.filter else None\n      print(\u0027-------- \u0027 + str(filters))\n\n\nThe output was:\n\n  -------- [(u\u0027start_timestamp\u0027, u\u002720170829\u0027)]\n  -------- {u\u0027start_timestamp\u0027: u\u002720170829\u0027}\n\nIt looks like it won\u0027t help and it doesn\u0027t matter if we keep \u0027dict()\u0027 or not.\nAt least in my understanding.","accounts_in_message":[],"_revision_number":4},{"id":"43f9733b12bc34529f086ee72ed57848632e4c3b","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2017-08-29 04:08:20.000000000","message":"Patch Set 4:\n\ni don\u0027t understand how openstackclient controls the input format? that doesn\u0027t seem right. although i see now that there is more to code that is forcing KEY\u003dVALUE format[1]. it\u0027s unfortunate.\n\ni\u0027d prefer we fix this in API so it\u0027s similar to gnocchi as you mentioned but i am open to your opinion.\n\n[1] https://github.com/openstack/python-pankoclient/blob/2a116079e7817aa45ecad8f9cd7f4bc7142b2ebb/pankoclient/v2/events_cli.py#L29-L34","accounts_in_message":[],"_revision_number":4},{"id":"73250fd43bb1e4671a13fc9a4f19ac455339f5b7","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-29 08:15:42.000000000","message":"Patch Set 4:\n\nI think that keeping the filter format: \u0027\u003ckey\u003e \u003d \u003cvalue\u003e\u0027 is fine, since I don\u0027t come up a case we would use to specify operator. Maybe I missed something.\n\nThe syntax of gnocch is:\n\n  gnocchi measures show \u003cid\u003e --start \u003ctime1\u003e --stop \u003ctime2\u003e\n\nI don\u0027t think we should completely copy this, but simplify the syntax of panko like this:\n\n  openstack event list --filter start\u003d\u003ctime1\u003e --filter stop\u003d\u003ctime2\u003e\n\nBut I don\u0027t know if changing the field name is allowed or is a simple task (maybe changes of document are required). Keeping the name is also fine in my opinion: (but it is much lengthier)\n\n  openstack event list --filter start_timestamp\u003d\u003ctime1\u003e --filter end_timestamp\u003d\u003ctime2\u003e\n\nSo I think we can temporarily leave this here, try to fix on the api side, and if that works out, we close this review.\n\nBtw, there is another problem: the format \u0027--filter \u003cKEY1\u003dVALUE1;KEY2\u003dVALUE2..\u003e\u0027 is actually not working.[1] Either\n\n  openstack event list --filter k1\u003dv1;k2\u003dv2 ,\n  openstack event list --filter \u0027k1\u003dv1;k2\u003dv2\u0027 or\n  openstack event list --filter k1\u003dv1\\;k2\u003dv2\n\nwon\u0027t work. So I\u0027m using \u0027--filter \u003c1\u003e --filter \u003c2\u003e --filter \u003c3\u003e ...\u0027 now and it works.\nMaybe we should modify that in another review as well.  \n\n[1] https://github.com/openstack/python-pankoclient/blob/master/pankoclient/v2/events_cli.py#L39","accounts_in_message":[],"_revision_number":4},{"id":"3c68cc40d7d2a791ddb5449565920e94aa361955","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-29 08:41:30.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"1d10e825944dc647dbf52151483fb222c107adc7","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-29 09:01:50.000000000","message":"Patch Set 4:\n\nTo supplement my last reply:\n\n1. the need of specifying operator.\n   I mean that I myself haven\u0027t been in a case where I need to filter a field using \u003e or \u003c operator. But I guess there will be someone that does. The current format doesn\u0027t provide that function, and if we want it to work, there would be quite some works to be done. Until we modify the format, panko restful api can be used if one needs that filtering function.\n\n\n2. filtering start and end timestamp\n   we can treat timestamp as a special paramater rather than a trait filter. I means:\n\n     ?start\u003d2017-08-28\n\n   rather than\n\n     ?q.field\u003dstart_timestamp\u0026q.op\u003dge\u0026q.value\u003d2017-08-28\n\nsince they are actually specially handled compared to other traits. In sqlalchemy backend, the column \u0027generated\u0027 is used rather than values in the trait tables being used when filtering other traits.\n\nHowever, changing the api may break lots of things, and I have no idea if it is what we currently want.","accounts_in_message":[],"_revision_number":4},{"id":"d7fdabdb780b87fe1c4acf5c11696ec2c540069e","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-08-31 03:32:46.000000000","message":"Patch Set 4:\n\nrelated review in panko: https://review.openstack.org/499435","accounts_in_message":[],"_revision_number":4},{"id":"1802747f224dec8ee5a81d2f2c48890c0d84a9b3","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-09-13 00:14:27.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"bf46291bead81178168ab07005d54f0492a2c8b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-13 01:21:46.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-pankoclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/495763/5/check/gate-python-pankoclient-docs-ubuntu-xenial/fcfebc3//doc/build/html/ : SUCCESS in 2m 43s\n- gate-python-pankoclient-pep8-ubuntu-xenial http://logs.openstack.org/63/495763/5/check/gate-python-pankoclient-pep8-ubuntu-xenial/aa27fda/ : SUCCESS in 3m 15s\n- gate-python-pankoclient-python27-ubuntu-xenial http://logs.openstack.org/63/495763/5/check/gate-python-pankoclient-python27-ubuntu-xenial/ec70981/ : SUCCESS in 3m 14s\n- gate-python-pankoclient-python35 http://logs.openstack.org/63/495763/5/check/gate-python-pankoclient-python35/7241818/ : SUCCESS in 4m 57s\n- check-osc-plugins http://logs.openstack.org/63/495763/5/check/check-osc-plugins/509fc5a/ : SUCCESS in 5m 49s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"a4483b03971d90a1bf69e3ea1d4bd670e6e8acd9","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-09-13 01:28:44.000000000","message":"Patch Set 5:\n\nSince the current solution in panko api part is not satisfying, merge this fix could temporarily fix the problem. However, I still think the panko api need a revision on the filter part.","accounts_in_message":[],"_revision_number":5},{"id":"ad0fa502d418c93e4b3c84baeac47d746bfbb678","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-09-15 00:57:57.000000000","message":"Patch Set 5: Workflow-1","accounts_in_message":[],"_revision_number":5},{"id":"726362ac539457257d647187c662c40ac16935ea","author":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"date":"2017-09-15 15:40:23.000000000","message":"Abandoned\n\nthe issue has been solved by https://review.openstack.org/#/c/499435","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"18d525efba9b8ca40f1f66936ebe6ed16ae364c1","revisions":{"85c81a70b27132ac95965918953e4336b1217746":{"kind":"REWORK","_number":1,"created":"2017-08-21 08:27:10.000000000","uploader":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"ref":"refs/changes/63/495763/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/63/495763/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/1"}}},"commit":{"parents":[{"commit":"815a8c94519a527e2041c82afd2311d92cab8879","subject":"Merge \"Docs: switch to openstackdocstheme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/815a8c94519a527e2041c82afd2311d92cab8879"}]}],"author":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:17:12.000000000","tz":480},"committer":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:27:07.000000000","tz":480},"subject":"Fix operator option when listing event with filter","message":"Fix operator option when listing event with filter\n\nCloses-Bug: #1711997\n\nProblems:\n\n  Listing event using filter such as \u0027start_timestamp\u0027:\n\n    $ openstack event list --filter start_timestamp\u003d\u00272017-08-15 00:00:00\u0027\n\n  raises exception:\n\n    Operator eq is not supported. Only `ge\u0027 operator is available for field\n    start_timestamp (HTTP 400) (Request-ID: ...\n\nRelated code:\n\n  pankoclient/utils.py. Around line 32:\n\n    url \u003d \"q.field\u003d%s\u0026q.op\u003deq\u0026q.value\u003d%s\" % (k, v)\n\n  The code sends query with operator \u0027eq\u0027 no matter what the field is.\n\nFixing:\n\n  Make this part of code that when some specific filter field is given, the\n  operator in the url query would be the one that matches.\n\nTest:\n\n  The problem happens when using openstack CLI. I could not find test code\n  related to it inside the tests folder. If anyone knows how to write a\n  test, please contact me, thanks.\n\nChange-Id: If758f5c281cb61ae9426780b99796131f716ef27\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/85c81a70b27132ac95965918953e4336b1217746"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/85c81a70b27132ac95965918953e4336b1217746"}]},"branch":"refs/heads/master"},"b5058db828e2a3e1bda2eeb991d7a5b3c9fce1e8":{"kind":"REWORK","_number":2,"created":"2017-08-21 08:32:54.000000000","uploader":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"ref":"refs/changes/63/495763/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/63/495763/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/2"}}},"commit":{"parents":[{"commit":"815a8c94519a527e2041c82afd2311d92cab8879","subject":"Merge \"Docs: switch to openstackdocstheme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/815a8c94519a527e2041c82afd2311d92cab8879"}]}],"author":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:17:12.000000000","tz":480},"committer":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:32:06.000000000","tz":480},"subject":"Fix operator option when listing event with filter","message":"Fix operator option when listing event with filter\n\nCloses-Bug: #1711997\n\nProblems:\n\n  Listing event using filter such as \u0027start_timestamp\u0027:\n\n    $ openstack event list --filter start_timestamp\u003d\u00272017-08-15 00:00:00\u0027\n\n  raises exception:\n\n    Operator eq is not supported. Only `ge\u0027 operator is available for field\n    start_timestamp (HTTP 400) (Request-ID: ...\n\nRelated code:\n\n  pankoclient/utils.py. Around line 32:\n\n    url \u003d \"q.field\u003d%s\u0026q.op\u003deq\u0026q.value\u003d%s\" % (k, v)\n\n  The code sends query with operator \u0027eq\u0027 no matter what the field is.\n\nFixing:\n\n  Make this part of code that when some specific filter field is given, the\n  operator in the url query would be the one that matches.\n\nTest:\n\n  The problem happens when using openstack CLI. I could not find test code\n  related to it inside the tests folder. If anyone knows how to write a\n  test, please contact me, thanks.\n\nPatch:\n\n  1. fixed newline format.\n\nChange-Id: If758f5c281cb61ae9426780b99796131f716ef27\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/b5058db828e2a3e1bda2eeb991d7a5b3c9fce1e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/b5058db828e2a3e1bda2eeb991d7a5b3c9fce1e8"}]},"branch":"refs/heads/master"},"a27ec6c07246b6209c1cda879cf69363879e95c9":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-08-22 01:08:50.000000000","uploader":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"ref":"refs/changes/63/495763/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/63/495763/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/3"}}},"commit":{"parents":[{"commit":"815a8c94519a527e2041c82afd2311d92cab8879","subject":"Merge \"Docs: switch to openstackdocstheme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/815a8c94519a527e2041c82afd2311d92cab8879"}]}],"author":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:17:12.000000000","tz":480},"committer":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-22 01:07:59.000000000","tz":480},"subject":"Fix operator option when listing event with filter","message":"Fix operator option when listing event with filter\n\nProblems:\n\n  Listing event using filter such as \u0027start_timestamp\u0027:\n\n    $ openstack event list --filter start_timestamp\u003d\u00272017-08-15 00:00:00\u0027\n\n  raises exception:\n\n    Operator eq is not supported. Only `ge\u0027 operator is available for field\n    start_timestamp (HTTP 400) (Request-ID: ...\n\nRelated code:\n\n  pankoclient/utils.py. Around line 32:\n\n    url \u003d \"q.field\u003d%s\u0026q.op\u003deq\u0026q.value\u003d%s\" % (k, v)\n\n  The code sends query with operator \u0027eq\u0027 no matter what the field is.\n\nFixing:\n\n  Make this part of code that when some specific filter field is given, the\n  operator in the url query would be the one that matches.\n\nTest:\n\n  The problem happens when using openstack CLI. I could not find test code\n  related to it inside the tests folder. If anyone knows how to write a\n  test, please contact me, thanks.\n\nPatch:\n\n  1. fixed newline format.\n\nCloses-Bug: #1711997\nChange-Id: If758f5c281cb61ae9426780b99796131f716ef27\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/a27ec6c07246b6209c1cda879cf69363879e95c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/a27ec6c07246b6209c1cda879cf69363879e95c9"}]},"branch":"refs/heads/master"},"01264c33786d1db45a005b79cad7ae876a333350":{"kind":"REWORK","_number":4,"created":"2017-08-22 09:12:18.000000000","uploader":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"ref":"refs/changes/63/495763/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/63/495763/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/4"}}},"commit":{"parents":[{"commit":"815a8c94519a527e2041c82afd2311d92cab8879","subject":"Merge \"Docs: switch to openstackdocstheme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/815a8c94519a527e2041c82afd2311d92cab8879"}]}],"author":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:17:12.000000000","tz":480},"committer":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-22 09:09:54.000000000","tz":480},"subject":"Fix operator option when listing event with filter","message":"Fix operator option when listing event with filter\n\nProblems:\n\n  Listing event using filter such as \u0027start_timestamp\u0027:\n\n    $ openstack event list --filter start_timestamp\u003d\u00272017-08-15 00:00:00\u0027\n\n  raises exception:\n\n    Operator eq is not supported. Only `ge\u0027 operator is available for field\n    start_timestamp (HTTP 400) (Request-ID: ...\n\nRelated code:\n\n  pankoclient/utils.py. Around line 32:\n\n    url \u003d \"q.field\u003d%s\u0026q.op\u003deq\u0026q.value\u003d%s\" % (k, v)\n\n  The code sends query with operator \u0027eq\u0027 no matter what the field is.\n\nFixing:\n\n  Make this part of code that when some specific filter field is given, the\n  operator in the url query would be the one that matches.\n\nTest:\n\n  The problem happens when using openstack CLI. I could not find test code\n  related to it inside the tests folder. If anyone knows how to write a\n  test, please contact me, thanks.\n\nPatch:\n\n  1. fix newline format.\n  2. fix accidental indent which was wrong\n\nCloses-Bug: #1711997\nChange-Id: If758f5c281cb61ae9426780b99796131f716ef27\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/01264c33786d1db45a005b79cad7ae876a333350"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/01264c33786d1db45a005b79cad7ae876a333350"}]},"branch":"refs/heads/master"},"18d525efba9b8ca40f1f66936ebe6ed16ae364c1":{"kind":"REWORK","_number":5,"created":"2017-09-13 00:14:27.000000000","uploader":{"_account_id":26679,"name":"SU, HAO-CHEN","email":"g0010726@gmail.com","username":"astacksu"},"ref":"refs/changes/63/495763/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/63/495763/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/63/495763/5"}}},"commit":{"parents":[{"commit":"815a8c94519a527e2041c82afd2311d92cab8879","subject":"Merge \"Docs: switch to openstackdocstheme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/815a8c94519a527e2041c82afd2311d92cab8879"}]}],"author":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-08-21 08:17:12.000000000","tz":480},"committer":{"name":"astacksu","email":"g0010726@gmail.com","date":"2017-09-13 00:13:52.000000000","tz":480},"subject":"Fix operator option when listing event with filter","message":"Fix operator option when listing event with filter\n\nProblems:\n\n  Listing event using filter such as \u0027start_timestamp\u0027:\n\n    $ openstack event list --filter start_timestamp\u003d\u00272017-08-15 00:00:00\u0027\n\n  raises exception:\n\n    Operator eq is not supported. Only `ge\u0027 operator is available for field\n    start_timestamp (HTTP 400) (Request-ID: ...\n\nRelated code:\n\n  pankoclient/utils.py. Around line 32:\n\n    url \u003d \"q.field\u003d%s\u0026q.op\u003deq\u0026q.value\u003d%s\" % (k, v)\n\n  The code sends query with operator \u0027eq\u0027 no matter what the field is.\n\nFixing:\n\n  Make this part of code that when some specific filter field is given, the\n  operator in the url query would be the one that matches.\n\nTest:\n\n  The problem happens when using openstack CLI. I could not find test code\n  related to it inside the tests folder. If anyone knows how to write a\n  test, please contact me, thanks.\n\nPatch:\n\n  1. fix newline format.\n  2. fix accidental indent which was wrong\n\nCloses-Bug: #1711997\nChange-Id: If758f5c281cb61ae9426780b99796131f716ef27\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/18d525efba9b8ca40f1f66936ebe6ed16ae364c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/18d525efba9b8ca40f1f66936ebe6ed16ae364c1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}