)]}'
{"id":"openstack%2Fpython-pankoclient~566252","triplet_id":"openstack%2Fpython-pankoclient~master~Ibd8fc7d15c666f285fe81e7009ff3000433ded84","project":"openstack/python-pankoclient","branch":"master","topic":"fix-osc-plugin","hashtags":[],"change_id":"Ibd8fc7d15c666f285fe81e7009ff3000433ded84","subject":"Fix OSC plugin and SessionClient","status":"ABANDONED","created":"2018-05-04 09:17:54.000000000","updated":"2018-05-18 08:29:32.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bfcce0f04d14342cafee628264fe47dc126e16c1","_number":566252,"virtual_id_number":566252,"owner":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-05-15 06:03:08.000000000","_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":1,"date":"2018-05-04 10:47:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"value":-1,"date":"2018-05-15 02:13:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2018-05-18 07:49:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-04 10:47:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-05-15 02:13:38.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2018-05-18 07:49:39.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"}],"messages":[{"id":"3e98272e83ce8025898a9f1ccc1d8a57ba5e419a","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2018-05-04 09:17:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78772b4fcd3dfb2c6bd304fadde6584409ff93cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-04 09:31:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/52/566252/1/check/openstack-tox-pep8/0e42d06/ : SUCCESS in 4m 21s\n- openstack-tox-py27 http://logs.openstack.org/52/566252/1/check/openstack-tox-py27/3c34cc3/ : FAILURE in 4m 36s\n- openstack-tox-py35 http://logs.openstack.org/52/566252/1/check/openstack-tox-py35/1f11e96/ : FAILURE in 4m 55s\n- build-openstack-sphinx-docs http://logs.openstack.org/52/566252/1/check/build-openstack-sphinx-docs/238775c/html/ : SUCCESS in 4m 43s\n- openstackclient-check-plugins http://logs.openstack.org/52/566252/1/check/openstackclient-check-plugins/31a3382/ : SUCCESS in 7m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3c4448cbb37f29d605eb37b7b880afa8af184b53","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2018-05-04 10:33:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d65613034f5115b10156896ce3c7b592da93dbd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-04 10:47:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/52/566252/2/check/openstack-tox-pep8/6610457/ : SUCCESS in 3m 13s\n- openstack-tox-py27 http://logs.openstack.org/52/566252/2/check/openstack-tox-py27/27e1864/ : SUCCESS in 3m 39s\n- openstack-tox-py35 http://logs.openstack.org/52/566252/2/check/openstack-tox-py35/d3e06d2/ : SUCCESS in 4m 47s\n- build-openstack-sphinx-docs http://logs.openstack.org/52/566252/2/check/build-openstack-sphinx-docs/cd9e0bf/html/ : SUCCESS in 4m 00s\n- openstackclient-check-plugins http://logs.openstack.org/52/566252/2/check/openstackclient-check-plugins/1411cf4/ : SUCCESS in 5m 56s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4484226f58a5f6f6a9170dc7b648318878b9c16b","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2018-05-15 02:13:38.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0d0168b8e19ebb6550da88f369089c439f564ad8","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2018-05-15 06:03:08.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nGordon,","accounts_in_message":[],"_revision_number":2},{"id":"a68bbd70dfa1760c613e10c8a081e2cfba74acb7","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2018-05-18 07:49:39.000000000","message":"Patch Set 2: Code-Review-1\n\nThis have already been proposed here:\nhttps://review.openstack.org/#/c/552981/1\nhttps://review.openstack.org/#/c/552930/1","accounts_in_message":[],"_revision_number":2},{"id":"2b7d63b84ce6f924e707bb6f27ed8a4c7c8e0a6a","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2018-05-18 08:29:32.000000000","message":"Abandoned\n\nthere are patches to this regard already","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cb452900fa868a468adf0d4470608427c1cc3d08","revisions":{"e0b7b506be69dc18646189c87ffd395460ca5de4":{"kind":"REWORK","_number":1,"created":"2018-05-04 09:17:54.000000000","uploader":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"ref":"refs/changes/52/566252/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/52/566252/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/1"}}},"commit":{"parents":[{"commit":"346ade1e35c5382ce284a9ffd5c8ccea69597e69","subject":"Merge \"Update reno for stable/queens\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/346ade1e35c5382ce284a9ffd5c8ccea69597e69"}]}],"author":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2018-05-04 09:13:53.000000000","tz":0},"committer":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2018-05-04 09:17:52.000000000","tz":0},"subject":"Fix OSC plugin and SessionClient","message":"Fix OSC plugin and SessionClient\n\n- all the code throughout pankoclient depends on HTTP methods\n  returning both response and its parsed body, but SessionClient\n  was returning response only;\n- OSC plugin was not working, passing already unsupported arguments\n  to SessionClient\n- fixed error handling, sometime the error message does not have\n  \u0027faultsring\u0027 element (e.g. if the error is returned from WebServer\n  directly).\n\nChange-Id: Ibd8fc7d15c666f285fe81e7009ff3000433ded84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/e0b7b506be69dc18646189c87ffd395460ca5de4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/e0b7b506be69dc18646189c87ffd395460ca5de4"}]},"branch":"refs/heads/master"},"cb452900fa868a468adf0d4470608427c1cc3d08":{"kind":"REWORK","_number":2,"created":"2018-05-04 10:33:13.000000000","uploader":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"ref":"refs/changes/52/566252/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-pankoclient","ref":"refs/changes/52/566252/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-pankoclient refs/changes/52/566252/2"}}},"commit":{"parents":[{"commit":"346ade1e35c5382ce284a9ffd5c8ccea69597e69","subject":"Merge \"Update reno for stable/queens\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/346ade1e35c5382ce284a9ffd5c8ccea69597e69"}]}],"author":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2018-05-04 09:13:53.000000000","tz":0},"committer":{"name":"Pavlo Shchelokovskyy","email":"shchelokovskyy@gmail.com","date":"2018-05-04 10:33:02.000000000","tz":0},"subject":"Fix OSC plugin and SessionClient","message":"Fix OSC plugin and SessionClient\n\n- all the code throughout pankoclient depends on HTTP methods\n  returning both response and its parsed body, but SessionClient\n  was returning response only;\n- OSC plugin was not working, passing already unsupported arguments\n  to SessionClient\n- fixed error handling, sometime the error message does not have\n  \u0027faultsring\u0027 element (e.g. if the error is returned from WebServer\n  directly).\n\nChange-Id: Ibd8fc7d15c666f285fe81e7009ff3000433ded84\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/cb452900fa868a468adf0d4470608427c1cc3d08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-pankoclient/commit/cb452900fa868a468adf0d4470608427c1cc3d08"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}