)]}'
{"qinlingclient/tests/unit/osc/v1/fakes.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c67961602ac332333082430f26b737a482518530","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 AWCloud Software Co., Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a48552d1","line":1,"updated":"2018-08-10 03:16:23.000000000","message":"Although most of the resource definitions in this file are \u0027fake\u0027, I prefer to rename this file to \u0027base.py\u0027, because seems it is needed by almost all of the test files.","commit_id":"9c7aa8c740aa582b953be159bb7d8ddd14975290"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5fb1abef36ec2e97aa542a8bcce842e3ba5dade6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 AWCloud Software Co., Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eb38f2a0","line":1,"in_reply_to":"3f79a3b5_398c037e","updated":"2018-08-10 11:35:02.000000000","message":"It\u0027s just the \u0027fakes\u0027 makes me uncomfortable, but that\u0027s not a \u0027strong opinion\u0027, we could definitely merge this one.","commit_id":"9c7aa8c740aa582b953be159bb7d8ddd14975290"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"1d50d1658558ee1b26e1fc8e0e564c5c642bc39e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 AWCloud Software Co., Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_398c037e","line":1,"in_reply_to":"3f79a3b5_a48552d1","updated":"2018-08-10 10:37:36.000000000","message":"Please be noted that the idea is from the unit tests in python-openstackclient, for example see [1] and [2]. I don\u0027t have strong opinion here though. So just let me know if you want to change the filename to something that differs from openstackclient, then I\u0027ll update this.\n\n[1] https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/unit/compute/v2/fakes.py\n[2] https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/unit/network/v2/fakes.py","commit_id":"9c7aa8c740aa582b953be159bb7d8ddd14975290"}],"qinlingclient/tests/unit/osc/v1/test_runtime.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"c67961602ac332333082430f26b737a482518530","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.client.runtimes.list.assert_called_once_with()"},{"line_number":61,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":62,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_runtime_list_with_filter(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4440fea5","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":46},"updated":"2018-08-10 03:16:23.000000000","message":"The params of assertXXX() method should follow this pattern: (expected, actual)","commit_id":"9c7aa8c740aa582b953be159bb7d8ddd14975290"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"1d50d1658558ee1b26e1fc8e0e564c5c642bc39e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.client.runtimes.list.assert_called_once_with()"},{"line_number":61,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":62,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_runtime_list_with_filter(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_99c997ad","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":46},"in_reply_to":"3f79a3b5_4440fea5","updated":"2018-08-10 10:37:36.000000000","message":"Yes, and self.columns is predefined, it is the expected result. The variable \u0027columns\u0027 here is the return value from take_action(), thus it is the actual result.","commit_id":"9c7aa8c740aa582b953be159bb7d8ddd14975290"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"5fb1abef36ec2e97aa542a8bcce842e3ba5dade6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        self.client.runtimes.list.assert_called_once_with()"},{"line_number":61,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":62,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_runtime_list_with_filter(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cbce56b3","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":46},"in_reply_to":"3f79a3b5_99c997ad","updated":"2018-08-10 11:35:02.000000000","message":"You are right :-)","commit_id":"9c7aa8c740aa582b953be159bb7d8ddd14975290"}]}