)]}'
{"saharaclient/api/node_group_templates.py":[{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"438ceb83d8982e91dfde2d6359e575fb847cbc75","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if volumes_per_node:"},{"line_number":51,"context_line":"            data.update({\"volumes_per_node\": volumes_per_node,"},{"line_number":52,"context_line":"                         \"volumes_size\": volumes_size})"},{"line_number":53,"context_line":"            if volumes_availability_zone:"},{"line_number":54,"context_line":"                data.update({\"volumes_availability_zone\":"},{"line_number":55,"context_line":"                             volumes_availability_zone})"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_cb262aba","line":53,"updated":"2014-10-14 07:11:28.000000000","message":"I think that such logic masks user expectations when using CLI. I mean that a check that volumes_availability_zone parameter has effect only volumes_per_node not 0 should be handled on validation layer of sahara-api.","commit_id":"b43dc219b14daf64b4b0c35d9428b89fb9beda4d"},{"author":{"_account_id":8411,"name":"Andrew Lazarev","email":"alazarev@mirantis.com","username":"alazarev"},"change_message_id":"f7c696f6edc26f5e68d3cce76a5ae3ef2b01b674","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if volumes_per_node:"},{"line_number":51,"context_line":"            data.update({\"volumes_per_node\": volumes_per_node,"},{"line_number":52,"context_line":"                         \"volumes_size\": volumes_size})"},{"line_number":53,"context_line":"            if volumes_availability_zone:"},{"line_number":54,"context_line":"                data.update({\"volumes_availability_zone\":"},{"line_number":55,"context_line":"                             volumes_availability_zone})"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_b9002e35","line":53,"in_reply_to":"baa201ad_c1a1a9aa","updated":"2014-10-15 13:33:20.000000000","message":"Python client should be user friendly. No sense in passing parameters that don\u0027t have sense.","commit_id":"b43dc219b14daf64b4b0c35d9428b89fb9beda4d"},{"author":{"_account_id":7125,"name":"Alexander Ignatov","email":"aignatov@mirantis.com","username":"aignatov"},"change_message_id":"0aa125f953d9fba77f3382b9fb0749d15468c23d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if volumes_per_node:"},{"line_number":51,"context_line":"            data.update({\"volumes_per_node\": volumes_per_node,"},{"line_number":52,"context_line":"                         \"volumes_size\": volumes_size})"},{"line_number":53,"context_line":"            if volumes_availability_zone:"},{"line_number":54,"context_line":"                data.update({\"volumes_availability_zone\":"},{"line_number":55,"context_line":"                             volumes_availability_zone})"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_fd6d2533","line":53,"in_reply_to":"baa201ad_c1a1a9aa","updated":"2014-10-16 11:13:03.000000000","message":"Yes, I meant de-indentation. Agree with you and Andrew in his comment that this is not problematic, so I didn\u0027t put -1 along with my comment :)","commit_id":"b43dc219b14daf64b4b0c35d9428b89fb9beda4d"},{"author":{"_account_id":12561,"name":"Adrien Vergé","email":"adrienverge@gmail.com","username":"adrien.verge"},"change_message_id":"3281082373de39ad78ec703bbe4abe8cf772436d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if volumes_per_node:"},{"line_number":51,"context_line":"            data.update({\"volumes_per_node\": volumes_per_node,"},{"line_number":52,"context_line":"                         \"volumes_size\": volumes_size})"},{"line_number":53,"context_line":"            if volumes_availability_zone:"},{"line_number":54,"context_line":"                data.update({\"volumes_availability_zone\":"},{"line_number":55,"context_line":"                             volumes_availability_zone})"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c1a1a9aa","line":53,"in_reply_to":"baa201ad_cb262aba","updated":"2014-10-14 08:47:25.000000000","message":"You mean you would like to de-indent lines 53-55?\n\nI agree that it masks \u0027volumes_availability_zone\u0027 when \u0027volumes_per_node\u0027 is 0, but I don\u0027t think it\u0027s problematic. Actually, this is the same as for \u0027volumes_size\u0027 (which is passed only when \u0027volumes_per_node\u0027 is not 0).","commit_id":"b43dc219b14daf64b4b0c35d9428b89fb9beda4d"}]}