)]}'
{"saharaclient/api/client.py":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"201834187fef8c7286894ebc8d3c70d266410b12","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if not url:"},{"line_number":90,"context_line":"                # This is support of \u0027data_processing\u0027 service spelling"},{"line_number":91,"context_line":"                # which was used for releases before Kilo"},{"line_number":92,"context_line":"                service_type \u003d service_type.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        kwargs.setdefault(\u0027interface\u0027, endpoint_type)"},{"line_number":95,"context_line":"        kwargs.setdefault(\u0027endpoint_override\u0027, sahara_url)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_76a28e4c","line":92,"updated":"2015-03-01 15:08:11.000000000","message":"+1, and why not handle this in the except EndpointNotFound branch?","commit_id":"a60f18d9e2272c319990a459fa19201c90a2864e"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"b7730b11b21e03a629c83255f553e8b70250a4c3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if not url:"},{"line_number":90,"context_line":"                # This is support of \u0027data_processing\u0027 service spelling"},{"line_number":91,"context_line":"                # which was used for releases before Kilo"},{"line_number":92,"context_line":"                service_type \u003d service_type.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        kwargs.setdefault(\u0027interface\u0027, endpoint_type)"},{"line_number":95,"context_line":"        kwargs.setdefault(\u0027endpoint_override\u0027, sahara_url)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_90d69826","line":92,"updated":"2015-02-26 09:07:44.000000000","message":"I think need to get url with new service_type","commit_id":"a60f18d9e2272c319990a459fa19201c90a2864e"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"9309e83ff5ef9eee688a4d2c2e5d8cfc84c808d1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            if not url:"},{"line_number":90,"context_line":"                # This is support of \u0027data_processing\u0027 service spelling"},{"line_number":91,"context_line":"                # which was used for releases before Kilo"},{"line_number":92,"context_line":"                service_type \u003d service_type.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        kwargs.setdefault(\u0027interface\u0027, endpoint_type)"},{"line_number":95,"context_line":"        kwargs.setdefault(\u0027endpoint_override\u0027, sahara_url)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_11e8957b","line":92,"in_reply_to":"ba7be1f8_90d69826","updated":"2015-02-27 21:00:50.000000000","message":"+1, looks like there is a retry missing","commit_id":"a60f18d9e2272c319990a459fa19201c90a2864e"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"88f39f5f11826d7d7083b8b249a1769bdfb0da43","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class Client(object):"},{"line_number":47,"context_line":"    def __init__(self, username\u003dNone, api_key\u003dNone, project_id\u003dNone,"},{"line_number":48,"context_line":"                 project_name\u003dNone, auth_url\u003dNone, sahara_url\u003dNone,"},{"line_number":49,"context_line":"                 endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027data-processing\u0027,"},{"line_number":50,"context_line":"                 input_auth_token\u003dNone, session\u003dNone, auth\u003dNone,"},{"line_number":51,"context_line":"                 insecure\u003dFalse, cacert\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a75e904_4fb6258c","line":48,"updated":"2015-03-21 05:40:34.000000000","message":"There\u0027s an option --bypass, which can pass the sahara_url to use. As you can see from the old code Line 57. Is this option still supported after this commit?","commit_id":"4a6d7b786026b7f045ada06c42fd23eb41085dc3"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3ea3bf56a623c3be5b6fa43a3f6cdc79a06774a4","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class Client(object):"},{"line_number":47,"context_line":"    def __init__(self, username\u003dNone, api_key\u003dNone, project_id\u003dNone,"},{"line_number":48,"context_line":"                 project_name\u003dNone, auth_url\u003dNone, sahara_url\u003dNone,"},{"line_number":49,"context_line":"                 endpoint_type\u003d\u0027publicURL\u0027, service_type\u003d\u0027data-processing\u0027,"},{"line_number":50,"context_line":"                 input_auth_token\u003dNone, session\u003dNone, auth\u003dNone,"},{"line_number":51,"context_line":"                 insecure\u003dFalse, cacert\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_4531a1a1","line":48,"in_reply_to":"7a75e904_4fb6258c","updated":"2015-03-23 01:37:11.000000000","message":"yes, sahara_url is converted into endpoint_override on line 81.","commit_id":"4a6d7b786026b7f045ada06c42fd23eb41085dc3"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"88f39f5f11826d7d7083b8b249a1769bdfb0da43","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            verify \u003d True"},{"line_number":70,"context_line":"            if insecure:"},{"line_number":71,"context_line":"                verify \u003d False"},{"line_number":72,"context_line":"            elif cacert:"},{"line_number":73,"context_line":"                verify \u003d cacert"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            session \u003d keystone_session.Session(verify\u003dverify)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a75e904_0feeed8b","line":72,"updated":"2015-03-21 05:40:34.000000000","message":"This seems meaningless, verify is True anyway.","commit_id":"4a6d7b786026b7f045ada06c42fd23eb41085dc3"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3ea3bf56a623c3be5b6fa43a3f6cdc79a06774a4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            verify \u003d True"},{"line_number":70,"context_line":"            if insecure:"},{"line_number":71,"context_line":"                verify \u003d False"},{"line_number":72,"context_line":"            elif cacert:"},{"line_number":73,"context_line":"                verify \u003d cacert"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            session \u003d keystone_session.Session(verify\u003dverify)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_a51fb508","line":72,"in_reply_to":"7a75e904_0feeed8b","updated":"2015-03-23 01:37:11.000000000","message":"In this case we are testing for the presentce of cacert. This is generally a string path to a certificate to use.","commit_id":"4a6d7b786026b7f045ada06c42fd23eb41085dc3"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"88f39f5f11826d7d7083b8b249a1769bdfb0da43","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _get_keystone_auth(self, username\u003dNone, api_key\u003dNone, auth_url\u003dNone,"},{"line_number":109,"context_line":"                           project_id\u003dNone, project_name\u003dNone):"},{"line_number":110,"context_line":"        if not auth_url:"},{"line_number":111,"context_line":"            raise RuntimeError(\"No auth url specified\")"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if \u0027v2.0\u0027 in auth_url:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a75e904_6feda18b","line":110,"updated":"2015-03-21 05:40:34.000000000","message":"So, why not remove the default value?","commit_id":"4a6d7b786026b7f045ada06c42fd23eb41085dc3"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3ea3bf56a623c3be5b6fa43a3f6cdc79a06774a4","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _get_keystone_auth(self, username\u003dNone, api_key\u003dNone, auth_url\u003dNone,"},{"line_number":109,"context_line":"                           project_id\u003dNone, project_name\u003dNone):"},{"line_number":110,"context_line":"        if not auth_url:"},{"line_number":111,"context_line":"            raise RuntimeError(\"No auth url specified\")"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if \u0027v2.0\u0027 in auth_url:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_65b4ddf2","line":110,"in_reply_to":"7a75e904_6feda18b","updated":"2015-03-23 01:37:11.000000000","message":"Just to keep from making unrelated changes. This code existed previously to prevent people from ommiting the auth_url. It doesn\u0027t really buy us anything either way as we always pass all those variables but we\u0027d still need to check that None/empty string wasn\u0027t passed","commit_id":"4a6d7b786026b7f045ada06c42fd23eb41085dc3"}]}