)]}'
{"saharaclient/api/shell.py":[{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"adcb76769e03718e61c363ea1aa18ee6d588421a","unresolved":false,"context_lines":[{"line_number":830,"context_line":"#"},{"line_number":831,"context_line":"# Job Types"},{"line_number":832,"context_line":"# ~~~~~~~~~"},{"line_number":833,"context_line":"# job-types-list [--type] [--plugin [--version]]"},{"line_number":834,"context_line":"#"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"def _print_plugin_field(job_type):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_6941f338","line":833,"updated":"2015-03-05 05:46:05.000000000","message":"--version or --plugin-version?","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"8878c34246b99bd644388bbf0eef993c6b788117","unresolved":false,"context_lines":[{"line_number":830,"context_line":"#"},{"line_number":831,"context_line":"# Job Types"},{"line_number":832,"context_line":"# ~~~~~~~~~"},{"line_number":833,"context_line":"# job-types-list [--type] [--plugin [--version]]"},{"line_number":834,"context_line":"#"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"def _print_plugin_field(job_type):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_346f22ff","line":833,"updated":"2015-03-05 20:07:44.000000000","message":"Note, this should be job-type-list to be consistent with the other operators.","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"d9b6945b68f406c0854c0334600471f88770cd5d","unresolved":false,"context_lines":[{"line_number":830,"context_line":"#"},{"line_number":831,"context_line":"# Job Types"},{"line_number":832,"context_line":"# ~~~~~~~~~"},{"line_number":833,"context_line":"# job-types-list [--type] [--plugin [--version]]"},{"line_number":834,"context_line":"#"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"def _print_plugin_field(job_type):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_fec48e41","line":833,"in_reply_to":"9a80dd14_6941f338","updated":"2015-03-05 17:51:32.000000000","message":"should be --plugin-version, --version is intercepted by the shell","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"8878c34246b99bd644388bbf0eef993c6b788117","unresolved":false,"context_lines":[{"line_number":857,"context_line":"           default\u003dNone,"},{"line_number":858,"context_line":"           help\u003d\u0027Report only on job types supported by this version \u0027"},{"line_number":859,"context_line":"           \u0027of a specified plugin. Only valid with --plugin.\u0027)"},{"line_number":860,"context_line":"def do_job_types_list(cs, args):"},{"line_number":861,"context_line":"    \"\"\"Show supported job types.\"\"\""},{"line_number":862,"context_line":"    search_opts \u003d {}"},{"line_number":863,"context_line":"    if args.type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d47de6b2","line":860,"updated":"2015-03-05 20:07:44.000000000","message":"should be job_type_list","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":12707,"name":"Jacob Bin Wang","email":"wangbin@awcloud.com","username":"Jacob"},"change_message_id":"adcb76769e03718e61c363ea1aa18ee6d588421a","unresolved":false,"context_lines":[{"line_number":868,"context_line":"            search_opts[\"version\"] \u003d args.plugin_version"},{"line_number":869,"context_line":"    elif args.plugin_version:"},{"line_number":870,"context_line":"        raise exceptions.CommandError("},{"line_number":871,"context_line":"            \u0027The --plugin-version option is only valid when \u0027"},{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7e77e7d4","line":871,"updated":"2015-03-05 05:46:05.000000000","message":"translation is needed here","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"86190d5c1265e7d1e89a3fe3297f1dd065180c2f","unresolved":false,"context_lines":[{"line_number":868,"context_line":"            search_opts[\"version\"] \u003d args.plugin_version"},{"line_number":869,"context_line":"    elif args.plugin_version:"},{"line_number":870,"context_line":"        raise exceptions.CommandError("},{"line_number":871,"context_line":"            \u0027The --plugin-version option is only valid when \u0027"},{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_154f9cbe","line":871,"in_reply_to":"9a80dd14_7e77e7d4","updated":"2015-03-05 10:31:31.000000000","message":"Client doesn\u0027t support translations for now","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"4a048fb4f254b1ee5fbcd1421d651fc08d9c47bd","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1427a765","line":875,"updated":"2015-03-05 07:26:01.000000000","message":"I think should add separate column for versions","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"86190d5c1265e7d1e89a3fe3297f1dd065180c2f","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b5d5f0ba","line":875,"in_reply_to":"9a80dd14_1427a765","updated":"2015-03-05 10:31:31.000000000","message":"+1","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"d25de6dc4ae8fec78c922e7cfcf8a3f9e3e5785a","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f493cff7","line":875,"in_reply_to":"9a80dd14_796fd8c5","updated":"2015-03-05 18:27:42.000000000","message":"Agree that this seems ugly.","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"c81ca4e4903554a1ec2ec13de0ef62a1eaafad2d","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b9c4f092","line":875,"in_reply_to":"9a80dd14_796fd8c5","updated":"2015-03-05 17:55:18.000000000","message":"Or, we could put this whole thing on it\u0027s head I suppose.\n\nPlugin   version    jobtype, jobtype, jobtype, ....\n\nPlugin   version    jobtype, jobtype, jobtype","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"d9b6945b68f406c0854c0334600471f88770cd5d","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f91d8867","line":875,"in_reply_to":"9a80dd14_b5d5f0ba","updated":"2015-03-05 17:51:32.000000000","message":"I don\u0027t know how to do this.  We have a job supported by multiple versions of multiple plugins.\n\nSo, I listed \"plugin(version, version, ...).  Sample output is in the spec, too hard to paste here.\n\nThe only way to have plugin with a separate column for version is to repeat the job type .  Looks bad to me.\n\nJava     hdp        2.0.6\nJava     hdp        1.3.2\nJava     vanilla   1.2.1\n\nOr, we have to do something complicated like a variable number of columns, a plugin/versions column pair for each plugin\n\nJava    hdp    1.3.2, 2.0.6   vanilla  1.2.1","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"d25de6dc4ae8fec78c922e7cfcf8a3f9e3e5785a","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_74a0bf43","line":875,"in_reply_to":"9a80dd14_b9c4f092","updated":"2015-03-05 18:27:42.000000000","message":"-1 to \"putting the whole thing on it\u0027s head\"  Seems too upside-down for my taste.","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"44bb445240fa4bd5f4f2c1fb4a31f35c2de71b72","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_796fd8c5","line":875,"in_reply_to":"9a80dd14_f91d8867","updated":"2015-03-05 17:53:03.000000000","message":"Formatting didn\u0027t work.  Again:\n\nThe only way to have plugin with a separate column for version is to repeat the job type . Looks bad to me.\n\nJava hdp 2.0.6\n\nJava hdp 1.3.2 \n\nJava vanilla 1.2.1","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"d25de6dc4ae8fec78c922e7cfcf8a3f9e3e5785a","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            \u0027--plugin is specified\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    job_types \u003d cs.job_types.list(search_opts)"},{"line_number":875,"context_line":"    columns \u003d (\u0027name\u0027, \u0027plugin(versions)\u0027)"},{"line_number":876,"context_line":"    utils.print_list(job_types, columns,"},{"line_number":877,"context_line":"                     {\u0027plugin(versions)\u0027: _print_plugin_field})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_54673b25","line":875,"in_reply_to":"9a80dd14_f91d8867","updated":"2015-03-05 18:27:42.000000000","message":"I kind of liked the plugin(version, version, ...) form","commit_id":"30544803bd95d1131b9e223af8cc04376396709a"}]}
