)]}'
{"saharaclient/osc/v1/node_group_templates.py":[{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"105b9924c1852b86a02300a51eaa869f04e68201","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        parser.add_argument("},{"line_number":444,"context_line":"            \u0027--volumes-size\u0027,"},{"line_number":445,"context_line":"            type\u003dint,"},{"line_number":446,"context_line":"            metavar\u003d\"\u003cvolumes-per-node\u003e\","},{"line_number":447,"context_line":"            help\u003d\u0027Size of volumes attached to node (GB). \u0027"},{"line_number":448,"context_line":"                 \u0027This parameter will be taken into account only \u0027"},{"line_number":449,"context_line":"                 \u0027if volumes-per-node is set and non-zero\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_55d429ea","line":446,"range":{"start_line":446,"start_character":22,"end_line":446,"end_character":38},"updated":"2015-10-01 10:46:12.000000000","message":"volumes_size?","commit_id":"fdb53bfa05c23bcf55cd3c31554b6673c26307cf"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"42ec138ef210e3412faa59a7f9313a39ee931633","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        parser.add_argument("},{"line_number":444,"context_line":"            \u0027--volumes-size\u0027,"},{"line_number":445,"context_line":"            type\u003dint,"},{"line_number":446,"context_line":"            metavar\u003d\"\u003cvolumes-per-node\u003e\","},{"line_number":447,"context_line":"            help\u003d\u0027Size of volumes attached to node (GB). \u0027"},{"line_number":448,"context_line":"                 \u0027This parameter will be taken into account only \u0027"},{"line_number":449,"context_line":"                 \u0027if volumes-per-node is set and non-zero\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_e080184c","line":446,"range":{"start_line":446,"start_character":22,"end_line":446,"end_character":38},"in_reply_to":"9a1a9d01_55d429ea","updated":"2015-10-01 12:52:57.000000000","message":"Done","commit_id":"fdb53bfa05c23bcf55cd3c31554b6673c26307cf"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"ad010a822fee49f7a323d1b86761a8d9c6e45b70","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from saharaclient.osc.v1 import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"NGT_FIELDS \u003d [\u0027id\u0027, \u0027name\u0027, \u0027plugin_name\u0027, \u0027hadoo_version\u0027, \u0027node_processes\u0027,"},{"line_number":28,"context_line":"              \u0027description\u0027, \u0027auto_security_group\u0027, \u0027security_groups\u0027,"},{"line_number":29,"context_line":"              \u0027availability_zone\u0027, \u0027flavor_id\u0027, \u0027floating_ip_pool\u0027,"},{"line_number":30,"context_line":"              \u0027volumes_per_node\u0027, \u0027volumes_size\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_bd81e0fd","line":27,"updated":"2015-10-05 16:50:23.000000000","message":"typo, \"hadoop_version\"","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"11ddd95e93d7107811b5675f5b9058eaffbae9bf","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from saharaclient.osc.v1 import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"NGT_FIELDS \u003d [\u0027id\u0027, \u0027name\u0027, \u0027plugin_name\u0027, \u0027hadoo_version\u0027, \u0027node_processes\u0027,"},{"line_number":28,"context_line":"              \u0027description\u0027, \u0027auto_security_group\u0027, \u0027security_groups\u0027,"},{"line_number":29,"context_line":"              \u0027availability_zone\u0027, \u0027flavor_id\u0027, \u0027floating_ip_pool\u0027,"},{"line_number":30,"context_line":"              \u0027volumes_per_node\u0027, \u0027volumes_size\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_2431300c","line":27,"in_reply_to":"7a2fa921_bd81e0fd","updated":"2015-10-05 20:40:40.000000000","message":"+1","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"95f99fecb9d8e836761ce2a14ce7769f9d03703c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from saharaclient.osc.v1 import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"NGT_FIELDS \u003d [\u0027id\u0027, \u0027name\u0027, \u0027plugin_name\u0027, \u0027hadoo_version\u0027, \u0027node_processes\u0027,"},{"line_number":28,"context_line":"              \u0027description\u0027, \u0027auto_security_group\u0027, \u0027security_groups\u0027,"},{"line_number":29,"context_line":"              \u0027availability_zone\u0027, \u0027flavor_id\u0027, \u0027floating_ip_pool\u0027,"},{"line_number":30,"context_line":"              \u0027volumes_per_node\u0027, \u0027volumes_size\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_89e9291d","line":27,"in_reply_to":"7a2fa921_bd81e0fd","updated":"2015-10-06 09:13:27.000000000","message":"Done","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"903d909b469121642621aefc12d03513b5093ffa","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def get_parser(self, prog_name):"},{"line_number":53,"context_line":"        parser \u003d super(CreateNodeGroupTemplate, self).get_parser(prog_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--name\u0027,"},{"line_number":57,"context_line":"            metavar\u003d\"\u003cname\u003e\","},{"line_number":58,"context_line":"            help\u003d\"Name of the node group template [REQUIRED]\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_7d8908ca","line":55,"updated":"2015-10-05 16:56:48.000000000","message":"Is parser here some variety of argparse.ArgumentParser?  Shouldn\u0027t required things have \"required\u003dTrue\" set on them?\n\nI could be wrong ...","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"bdb3aa86a9b26ea64f425184d0fa6898b4373c21","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def get_parser(self, prog_name):"},{"line_number":53,"context_line":"        parser \u003d super(CreateNodeGroupTemplate, self).get_parser(prog_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--name\u0027,"},{"line_number":57,"context_line":"            metavar\u003d\"\u003cname\u003e\","},{"line_number":58,"context_line":"            help\u003d\"Name of the node group template [REQUIRED]\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_838fc822","line":55,"in_reply_to":"7a2fa921_7d8908ca","updated":"2015-10-06 08:46:22.000000000","message":"You are right, but there is a problem - we can\u0027t mark any one of them as required. name, plugin, version and processes should be set if --json isn\u0027t provided. But if it is, everything else doesn\u0027t really matter. I believe it could be handled with mutually exclusive groups somehow, but they will only make it more complex. So, I guess the only thing to think about is how to let users know which parameters and in which case should be necessarily provided","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"8347a88b69b72eaba77b21c0d0ea9a0f99990ccc","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    \u0027template from file %s: %s\u0027 % (parsed_args.json, e))"},{"line_number":201,"context_line":"            data \u003d client.node_group_templates.create(**template).to_dict()"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            if (not parsed_args.name or not parsed_args.plugin or"},{"line_number":204,"context_line":"                    not parsed_args.version or not parsed_args or"},{"line_number":205,"context_line":"                    not parsed_args.processes):"},{"line_number":206,"context_line":"                raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_8013575c","line":203,"updated":"2015-10-05 17:00:48.000000000","message":"related question, if we can force required through the parser then this check is unnecessary, correct?","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":7710,"name":"Sergey Reshetnyak","email":"sreshetniak@mirantis.com","username":"sreshetniak"},"change_message_id":"ee9d11a412d7057a4944472f009df4ed256dd382","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateNodeGroupTemplate\")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_parser(self, prog_name):"},{"line_number":53,"context_line":"        parser \u003d super(CreateNodeGroupTemplate, self).get_parser(prog_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_08bb9728","line":52,"updated":"2015-10-07 12:33:58.000000000","message":"shares  argument missed","commit_id":"5e3a66d1ddb9b0c12f7273e933e79620da98fe4e"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":146,"context_line":"            default\u003dFalse,"},{"line_number":147,"context_line":"            help\u003d\u0027If enabled, instance and attached volumes will be created on\u0027"},{"line_number":148,"context_line":"                 \u0027 the same physical host. This parameter will be taken into \u0027"},{"line_number":149,"context_line":"                 \u0027account only if volumes-per-node is set and non-zero\u0027,"},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_b9031bb8","line":148,"range":{"start_line":148,"start_character":18,"end_line":148,"end_character":19},"updated":"2015-10-13 19:43:24.000000000","message":"different parent of handling last space : )","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"472303908419546071c79ac67fb61246b011b69d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":146,"context_line":"            default\u003dFalse,"},{"line_number":147,"context_line":"            help\u003d\u0027If enabled, instance and attached volumes will be created on\u0027"},{"line_number":148,"context_line":"                 \u0027 the same physical host. This parameter will be taken into \u0027"},{"line_number":149,"context_line":"                 \u0027account only if volumes-per-node is set and non-zero\u0027,"},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_5c5c1f4b","line":148,"range":{"start_line":148,"start_character":18,"end_line":148,"end_character":19},"in_reply_to":"5a2ca52d_b9031bb8","updated":"2015-10-14 09:14:31.000000000","message":"yep","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027--shares\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":191,"context_line":"            help\u003d\u0027JSON representation of the manila shares\u0027"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        parser.add_argument("},{"line_number":194,"context_line":"            \u0027--configs\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_795ee3ea","line":191,"updated":"2015-10-13 19:43:24.000000000","message":"Should we mention we shares will be taken into account? I meant when JSON is not provided","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"472303908419546071c79ac67fb61246b011b69d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027--shares\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":191,"context_line":"            help\u003d\u0027JSON representation of the manila shares\u0027"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        parser.add_argument("},{"line_number":194,"context_line":"            \u0027--configs\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_bc60d336","line":191,"in_reply_to":"5a2ca52d_795ee3ea","updated":"2015-10-14 09:14:31.000000000","message":"I guess it makes sense to mention that everything else will NOT be taken into account if --json is provided :)","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            help\u003d\u0027JSON representation of the manila shares\u0027"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        parser.add_argument("},{"line_number":194,"context_line":"            \u0027--configs\u0027,"},{"line_number":195,"context_line":"            metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":196,"context_line":"            help\u003d\u0027JSON representation of the node group template configs\u0027"},{"line_number":197,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_39586bfa","line":194,"updated":"2015-10-13 19:43:24.000000000","message":"ditto","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    def get_parser(self, prog_name):"},{"line_number":278,"context_line":"        parser \u003d super(ListNodeGroupTemplates, self).get_parser(prog_name)"},{"line_number":279,"context_line":"        parser.add_argument("},{"line_number":280,"context_line":"            \u0027--long\u0027,"},{"line_number":281,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":282,"context_line":"            default\u003dFalse,"},{"line_number":283,"context_line":"            help\u003d\u0027List additional fields in output\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_59b9a7e8","line":280,"range":{"start_line":280,"start_character":15,"end_line":280,"end_character":19},"updated":"2015-10-13 19:43:24.000000000","message":"Probably confusing argument name.","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"472303908419546071c79ac67fb61246b011b69d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    def get_parser(self, prog_name):"},{"line_number":278,"context_line":"        parser \u003d super(ListNodeGroupTemplates, self).get_parser(prog_name)"},{"line_number":279,"context_line":"        parser.add_argument("},{"line_number":280,"context_line":"            \u0027--long\u0027,"},{"line_number":281,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":282,"context_line":"            default\u003dFalse,"},{"line_number":283,"context_line":"            help\u003d\u0027List additional fields in output\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_3ccfe380","line":280,"range":{"start_line":280,"start_character":15,"end_line":280,"end_character":19},"in_reply_to":"5a2ca52d_59b9a7e8","updated":"2015-10-14 09:14:31.000000000","message":"This agrument is used all over the openstackclient. As our CLI is part of it we should correspond to its structure.","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        parser \u003d super(DeleteNodeGroupTemplate, self).get_parser(prog_name)"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \"node_group_template\","},{"line_number":381,"context_line":"            metavar\u003d\"\u003cnode_group_template\u003e\","},{"line_number":382,"context_line":"            nargs\u003d\"+\","},{"line_number":383,"context_line":"            help\u003d\"Name(s) or id(s) of the node group template(s) to delete\","},{"line_number":384,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_d91db7be","line":381,"range":{"start_line":381,"start_character":22,"end_line":381,"end_character":42},"updated":"2015-10-13 19:43:24.000000000","message":"Here we use node_group_template as metavar, but below we have node-group-template. Is it right?","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"472303908419546071c79ac67fb61246b011b69d","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        parser \u003d super(DeleteNodeGroupTemplate, self).get_parser(prog_name)"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \"node_group_template\","},{"line_number":381,"context_line":"            metavar\u003d\"\u003cnode_group_template\u003e\","},{"line_number":382,"context_line":"            nargs\u003d\"+\","},{"line_number":383,"context_line":"            help\u003d\"Name(s) or id(s) of the node group template(s) to delete\","},{"line_number":384,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_fc496bd1","line":381,"range":{"start_line":381,"start_character":22,"end_line":381,"end_character":42},"in_reply_to":"5a2ca52d_d91db7be","updated":"2015-10-14 09:14:31.000000000","message":"metavar is just a representation in help message, but yes it can be unified","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"},{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        parser.add_argument("},{"line_number":406,"context_line":"            \u0027node_group_template\u0027,"},{"line_number":407,"context_line":"            metavar\u003d\"\u003cnode-group-template\u003e\","},{"line_number":408,"context_line":"            help\u003d\"Name or ID of the node group template\","},{"line_number":409,"context_line":"        )"},{"line_number":410,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_f96d1333","line":407,"updated":"2015-10-13 19:43:24.000000000","message":"See comment above","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"}],"saharaclient/osc/v1/utils.py":[{"author":{"_account_id":12038,"name":"Vitaly Gridnev","email":"gridnevvvit@gmail.com","username":"vgridnev"},"change_message_id":"315a06e0917b93ac60e412f6bb2d5418b835a600","unresolved":false,"context_lines":[{"line_number":41,"context_line":"def prepare_column_headers(columns):"},{"line_number":42,"context_line":"    return [c.replace("},{"line_number":43,"context_line":"        \u0027hadoop_version\u0027, \u0027version\u0027).replace("},{"line_number":44,"context_line":"        \u0027_\u0027, \u0027 \u0027).capitalize() for c in columns]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_by_name_substring(data, name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_59bbe772","line":44,"updated":"2015-10-13 19:43:24.000000000","message":"Maybe I am wrong, but why we using this hardcoded values in common utils?","commit_id":"bb1b2b3e5b6403b14e304bb8afaf7f6b8855a2a1"}],"saharaclient/tests/unit/osc/v1/test_node_group_templates.py":[{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"11ddd95e93d7107811b5675f5b9058eaffbae9bf","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Check that columns are correct"},{"line_number":178,"context_line":"        expected_columns \u003d [\u0027Name\u0027, \u0027Id\u0027, \u0027Plugin name\u0027, \u0027Hadoop version\u0027]"},{"line_number":179,"context_line":"        self.assertEqual(expected_columns, columns)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # Check that data is correct"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_274db272","line":178,"updated":"2015-10-05 20:40:40.000000000","message":"I think we should show just \"Version\" in places and avoid using \"Hadoop version\"","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":8091,"name":"Trevor McKay","email":"tmckay@redhat.com","username":"tmckay"},"change_message_id":"79010854df0808bf79e3d4cf4c062f3b6961a3f8","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Check that columns are correct"},{"line_number":178,"context_line":"        expected_columns \u003d [\u0027Name\u0027, \u0027Id\u0027, \u0027Plugin name\u0027, \u0027Hadoop version\u0027]"},{"line_number":179,"context_line":"        self.assertEqual(expected_columns, columns)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # Check that data is correct"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_eaaf817b","line":178,"in_reply_to":"7a2fa921_274db272","updated":"2015-10-05 21:17:26.000000000","message":"+1. I believe that is one of the things to address in api V2, but it makes sense not to perpetuate it in the client (especially if we know it is going to change anyway)","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":12039,"name":"Andrey Pavlov","email":"apavlov@mirantis.com","username":"apavlov"},"change_message_id":"95f99fecb9d8e836761ce2a14ce7769f9d03703c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Check that columns are correct"},{"line_number":178,"context_line":"        expected_columns \u003d [\u0027Name\u0027, \u0027Id\u0027, \u0027Plugin name\u0027, \u0027Hadoop version\u0027]"},{"line_number":179,"context_line":"        self.assertEqual(expected_columns, columns)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # Check that data is correct"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_e9b69d3c","line":178,"in_reply_to":"7a2fa921_274db272","updated":"2015-10-06 09:13:27.000000000","message":"Done","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"11ddd95e93d7107811b5675f5b9058eaffbae9bf","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Check that columns are correct"},{"line_number":195,"context_line":"        expected_columns \u003d [\u0027Name\u0027, \u0027Id\u0027, \u0027Plugin name\u0027, \u0027Hadoop version\u0027,"},{"line_number":196,"context_line":"                            \u0027Node processes\u0027, \u0027Description\u0027]"},{"line_number":197,"context_line":"        self.assertEqual(expected_columns, columns)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_075c3624","line":194,"updated":"2015-10-05 20:40:40.000000000","message":"ditto","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"11ddd95e93d7107811b5675f5b9058eaffbae9bf","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # Check that columns are correct"},{"line_number":215,"context_line":"        expected_columns \u003d [\u0027Name\u0027, \u0027Id\u0027, \u0027Plugin name\u0027, \u0027Hadoop version\u0027]"},{"line_number":216,"context_line":"        self.assertEqual(expected_columns, columns)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Check that data is correct"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_c73e3eb8","line":215,"updated":"2015-10-05 20:40:40.000000000","message":"ditto","commit_id":"f38706c965c3d69d93ddc759918deb217966a2d9"}]}